Commit Graph

48 Commits

Author SHA1 Message Date
Ingo Schommer
df56eb540a MINOR Don't throw deprecation notice on DataObjectSet and FieldSet if there's still over 500 (!) references to them in core, as it basically means that everybody has to suppress PHP NOTICE errors for months, impacting core code quality 2011-10-04 13:23:13 +02:00
Will Rossiter
1732a17114 Merged new-orm into datagrid 2011-09-26 16:47:54 +13:00
Will Rossiter
2c17cb2f80 MINOR: spelling fix. 2011-09-19 17:27:26 +02:00
Ingo Schommer
ce8e72cf0e MINOR Removing executable flag from all files (thanks miiihi) 2011-09-18 22:04:02 +02:00
ajshort
def001566c API CHANGE: Renamed FieldSet to FieldList.
API CHANGE: Renamed HiddenFieldSet to HiddenFieldList.
2011-05-06 08:51:02 +10:00
ajshort
f0676c7d56 API CHANGE: Updated FieldSet to use ArrayList rather then DataObjectSet.
MINOR: Updated FieldSetTest since position information is no longer available on iterated objects.
2011-05-06 08:30:54 +10:00
Sam Minnee
2b991629b8 API CHANGE: In FieldSet::removeByName(), only match on field Title() if field Name() isn't set. 2011-05-01 15:25:14 +12:00
Sean Harvey
ec661a9886 ENHANCEMENT #6228 FieldSet::addFieldsToTab() now allows inserting before a field name for consistency with addFieldToTab()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 02:31:49 +00:00
Ingo Schommer
68fcd8c94f MINOR Reverted r105264, breaks CompositeFieldTest, FieldSetTest, TranslatableTest (from r105274)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112474 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:28:12 +00:00
Ingo Schommer
de0bf3f7cd BUGFIX: addFieldToTab segfaulting under PHP 5.2 (from r105264)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112445 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:29:18 +00:00
Ingo Schommer
28f80b8da5 BUGFIX #5121 Fixed cache flushing for FieldSet when removing fields - thanks paradigmincarnate! (from r100417)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:51:35 +00:00
Ingo Schommer
6460d09570 MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 00:11:41 +00:00
Sam Minnee
6e23d7ebbb API CHANGE: Inserting $HiddenFields into a form template will show the input tags of all the hidden fields.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90871 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 01:54:37 +00:00
Sean Harvey
bb5eff8bed BUGFIX Ensure that any white space is stripped in FieldSet::dataFieldByName() and FieldSet::fieldByName()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77650 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-22 10:18:15 +00:00
Sean Harvey
c4071d3521 MINOR Code formatting fix in FieldSet
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77649 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-22 10:11:03 +00:00
Sean Harvey
2a66b5a8e1 API CHANGE Removed @deprecated 2.3 method FieldSet::insertBeforeRecursive(): Please use FieldSet::insertBefore() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77401 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-20 07:53:30 +00:00
Sean Harvey
56fbe55a47 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75580 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-04-28 23:55:53 +00:00
Sean Harvey
76b5adc979 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-04-28 23:52:15 +00:00
Andrew O'Neil
60f75c5ca4 Merged changes from 2.3 branch
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71172 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-01 23:49:53 +00:00
Ingo Schommer
085346f0e0 MINOR Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@69704 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-05 06:19:48 +00:00
Ingo Schommer
d26f08b481 MINOR merged branches/2.3 into trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@67465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-12-04 22:38:32 +00:00
Sam Minnee
2984355f43 Merged branches/2.3 into trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66395 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-22 03:33:00 +00:00
Ingo Schommer
5df97fba10 ENHANCEMENT Added CompositeField->fieldPosition()
ENHANCEMENT Supporting recursion into nested sets in FieldSet->insertAfter()/TabSet->insertAfter()/CompositeField->insertAfter()
API CHANGE Deprecated CompositeField->insertBeforeRecursive(), use CompositeField->insertBefore()
ENHANCEMENT Renamed CompositeField->beforeInsert() to CompositeField->onBeforeInsert() to avoid confusion with insertBefore()
ENHANCEMENT Added CompositeFieldTest
ENHANCEMENT Added unit tests for FieldSet->insertBefore()/insertAfter()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-11 02:35:54 +00:00
Andrew O'Neil
68aaa32e86 BUGFIX Fix disappearing fields when a field without a name was being pushed onto a FieldSet (eg a CompositeField)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64263 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 01:30:14 +00:00
Ingo Schommer
8cc5625708 ENHANCEMENT Ability to add title constructor arguments to Tab and TabSet classes to resolve i18n issues with untranslated or unreferencable Tabs (see #2359)
ENHANCEMENT Support for $field_labels in relation tabs created by DataObject->addScaffoldRelationFields()
ENHANCEMENT Type checking and user errors for Tab and TabSet constructor arguments
ENHANCEMENT Supporting titles in FieldSet->findOrMakeTab()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64073 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 16:00:50 +00:00
Ingo Schommer
18855687fc BUGFIX Making less assumptions about object structure in FieldSet->addFieldToTab() error messages
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64007 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:15:39 +00:00
Sam Minnee
fce3767389 API CHANGE: Added support for dot syntax to FieldSet::fieldByName()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63922 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 00:32:10 +00:00
Sam Minnee
cf5b6342df BUGFIX: Fix FieldSet::replaceField() so that it doesn't clobber tabs
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:37:12 +00:00
Ingo Schommer
21859d3d97 ENHANCEMENT Added FieldSet->hasTabSet() incl. unit test
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 18:29:43 +00:00
Ingo Schommer
8f3b3fedaa MINOR Documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 15:55:39 +00:00
Saophalkun Ponlu
6b6209019c comment Debug.traceback that occur when the field is a tab
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-17 22:31:01 +00:00
Sam Minnee
6e5b511c46 BUGFIX: Allow creation of a tab and a field of the same name; bug cause by the duplicate field merging code introduced recently.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62320 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 04:42:24 +00:00
Sam Minnee
62414fdfa6 FEATURE: #1403 - addFieldToTab(), push(), insertBefore(), etc will allow duplicates - the old field is replaced with the new.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62211 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-11 00:02:49 +00:00
Sean Harvey
3ae2a7e605 MINOR PHPdoc for FieldSet->replaceField()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61161 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:11:07 +00:00
Sean Harvey
d69c3d6a1a ENHANCEMENT Added FieldSet->removeFieldsFromTab() which does exactly what removeFieldFromTab() does, but with an array of field names
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:03:50 +00:00
Hayden Smith
130ecfe5aa Merged [47044]: Introduces modifications to Sapphire's form handling that allows it to ignore fields marked as Disabled when saving the contents of a form's fields to a DataObject.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60469 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 02:58:48 +00:00
Ingo Schommer
8d0166e298 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60265 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-10 23:29:30 +00:00
Ingo Schommer
8fd1a33d84 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60227 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 05:57:44 +00:00
Ingo Schommer
016cff2093 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60209 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 04:38:44 +00:00
Ingo Schommer
aeab0115a0 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@59927 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-06 03:43:48 +00:00
Ingo Schommer
60860cc1b9 MINOR Unified @package PHPdoc (added where missing, removed duplicates)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@56212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-15 13:33:53 +00:00
Sean Harvey
f2bfbc652e MINOR function php doc comments, and code formatting
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@56141 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-12 08:54:03 +00:00
Sam Minnee
14da70e64e Merged revisions 53204 via svnmerge from
http://svn.silverstripe.com/open/modules/sapphire/branches/2.2.2

........
  r53204 | sharvey | 2008-04-22 15:55:34 +1200 (Tue, 22 Apr 2008) | 1 line
  
  MINOR: PHP notice fix - undefined variable
........


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@53529 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-04-26 06:54:47 +00:00
Ingo Schommer
0d49845a73 ENHANCEMENT HiddenFields() now returns FieldSet rather than concatenated HTML string
BUGFIX renamed genExtraFields() to getExtraFields(), now returns a FieldSet rather than adding to $this->fields automatically (allows for external control and inspection)
BUGFIX adding fields from getExtraFields() in Fields()
ENHANCEMENT changed visibility of getExtraFields to public
BUGFIX removed $action->unsetthis() in unsetActionByName
ENHANCEMENT remove $securityTokenAdded flag (unnecessary state, can be determined by inspecting fieldset)
ENHANCEMENT documentation, coding conventions, removed debug code

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@51131 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-03-16 22:15:04 +00:00
Sam Minnee
b1d2e3906b API Documentation updates
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@47766 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-01-09 04:18:36 +00:00
Normann Lou
26b8f7dffe switch externals to trunk.
Inform-merge: from the changeset:
r32477: Merge 2.0-inform from trunk previously
r32478: Merge 2.0-inform from trunk previously
r32481: merge 2.0infom with lastes chunk 
r32483: merge 2.0infom with lastes chunk 
r33526: Final styling of all forms and combined communication form add/alter javascript for height adjustment of First / Second block 
r33580: styling for combined form communication in myinfom pages 
r33706: styling of combined form (communication) in Email 
r33881: made compatible to $extraClass 
r33885: added defaultVal
r33887: fixed typo 
r34728: modified SmallFieldHolder?()
r34729: added "validationError"-class 
r34914: WIP3866: Factfinder: Hide "self emplyed" block 
r34964: Change current plan upto TraumaInsurance? 
r35038: disabled friggin field focus 
r35230: #1032 Fixed hash-link insertion 
r35887: conditionally setting parameters in sourceID() - to avoid empty overrides
r35892: Saving value in SQL-compatible format (YYYY-MM-DD instead of DD/MM/YYYY), with fallback for non-sql values (just passed through without conversion) 
r35928: Removed "create a" from PageType?-dropdown, sorting alphabetically, falling back to $singular_name
r35990: branched off for membertablefield
r35994: fix for membertablefield
r36024: added array-condition needed for DMYDateField 
r36083: fix bug for compositeField -> dropDatalessField
r36394: removed debug code 
r36826: change wrong indent format 
r36828: WIP 4262: Logging out of My Inform goes to blank page
r36858: Fixed error caused in r12472 while merging to Session-class
r37132: Merged partial changesets from branches/2.0-nzct, only adding childID to detailform when not in add-mode 
r40815: add an unsubscribe record when a member subscribe a newslettertype 
r41113: fix the bug described in http://support.silverstripe.com/info/ticket/31: CRM not showing search results
r43226: fixed search (partial merge from trunk) 
r43268: merged createNewPassword() from trunk, was referencing a non-existinent global function randomString()


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@45473 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-11-23 01:10:19 +00:00
Ingo Schommer
970a453cb8 bfojcapell: Added function insertBeforeRecursive (see www.silverstripe.com/google-summer-of-code-forum/show/3005). This function is only called in Translatable.php at this moment, so if finally insertBefore gets a recursive behaviour then the call can be renamed and insertBeforeRecursive deleted.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42113 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:06:52 +00:00
Hayden Smith
4a5d9b03f8 Moved Sapphire module to open source path
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@39001 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-07-19 10:40:28 +00:00