Commit Graph

8975 Commits

Author SHA1 Message Date
Sean Harvey
e1ebb4a8eb MINOR Fixing broken test for PostgreSQL 2012-06-12 14:54:19 +12:00
Sean Harvey
0a2e877625 MINOR Remove PostgreSQLDatabase boolean workaround in
DataObject::__construct()

The database adapter uses smallint instead of the boolean datatype,
which works around the issue instead of converting the value.
2012-06-12 14:21:59 +12:00
Sean Harvey
59e68f16da MINOR Remove MSSQLDatabase date/datetime workarounds from DataObject::__construct()
These are being handled by the MSSQLDatabase class in the mssql module
instead, which keeps the workarounds separated from the framework core.
2012-06-12 12:25:15 +12:00
Ingo Schommer
d95e9a06b3 Merge pull request #518 from ajshort/jsfixes
BUGFIX: Fixed incorrect variables breaking form submission.
2012-06-11 06:33:27 -07:00
Andrew Short
34eb1b39dd BUGFIX: Fixed incorrect variables breaking form submission. 2012-06-11 23:31:02 +10:00
Sam Minnee
1aefc0aa94 BUGFIX: Ensure that extensio arugments are passed when temporarily instantiating for setting up statics. 2012-06-11 22:56:11 +12:00
Sam Minnee
c41ff29d70 MINOR: Don't rely on singleton() inappropriately in FormScaffolderTest 2012-06-11 22:46:42 +12:00
Sam Minnee
114ebb6953 API CHANGE: Don't have any instance caching in singleton(), rely on Injector for this. 2012-06-11 22:41:12 +12:00
Sam Minnee
f65a7c6b21 API CHANGE: Remove dodgy DataObject::destroy() behaviour, opting instead for using PHP5.3's garbage collector. 2012-06-11 22:41:12 +12:00
Naomi Guyer
e96ca5fb9a ENHANCEMENT: Change media insertion to use button and apply design
Conflicts:

	css/UploadField.css
	scss/UploadField.scss
2012-06-11 10:54:48 +02:00
Ingo Schommer
9009d43f63 MINOR Moved "insert x" dialog styling from generic UploadField.scss to CMS-specific _style.scss 2012-06-11 10:51:47 +02:00
Ingo Schommer
f0f6f1abec Merge pull request #517 from clarkepaul/sapphire
---

Ticket #7446 Minor css spacing fixs: padding on grid filter, filter
panel, page actions box-shadow to remove
2012-06-11 10:33:08 +02:00
Paul Clarke
3ada9a9327 ENHANCEMENT Basic css spacing issues
Ticket #7446 Minor css spacing fixs: padding on grid filter, filter
panel, page actions box-shadow to remove
2012-06-11 16:02:33 +12:00
Sean Harvey
3f68e6f82f BUGFIX Ensure that a single string value (as opposed to an array of
values) is accepted by implode() in CheckboxSetField by casting it
as an array.
2012-06-11 13:41:02 +12:00
Ingo Schommer
86bdd167cc MINOR oEmbed documentation 2012-06-08 18:40:34 +02:00
Ingo Schommer
c0b3512fd4 ENHANCEMENT Oembed.enabled config property 2012-06-08 18:40:34 +02:00
Ingo Schommer
f7ac4e34e7 MINOR Cache oEmbed results for a week (rather than an hour) by default, to avoid synchronous querying of potentially slow and unreliable external services upon page rendering 2012-06-08 18:40:34 +02:00
Ingo Schommer
2ecd8a0cc4 MINOR Hiding "insert media" tabs when editing an image (wrong selector) 2012-06-08 18:40:34 +02:00
Ingo Schommer
210e32d631 MINOR Labeling in HtmlEditorField 2012-06-08 18:40:33 +02:00
Naomi Guyer
7523f98e04 BUGFIXES: File Uploads
* Add arrows back to edit-all toggle button
* Don't show dimensions if the item being inserted doesn't have them.
* Set pop-up windows to be a percentage of the window height for better
use of space
* Fix broken fieldholdersmall styling within files edit
* Add placeholder if no preview
*Take out minFileSize so upload will work on Android phones
2012-06-08 18:40:33 +02:00
Ingo Schommer
05cbb36ab5 Merge branch '7023-tutorials' 2012-06-08 00:45:51 +02:00
Andy Adiwidjaja
71b3fe5760 ENHANCEMENT Updated tutorial documentation (thanks to Cam Findlay and Andy Adiwidjaja) 2012-06-08 00:37:16 +02:00
Ingo Schommer
617fe3c0ac Merge pull request #508 from sminnee/fix-change-password
Fix JS bug that was preventing passwords from being changed
2012-06-07 03:39:40 -07:00
Ingo Schommer
013abcbe8b Merge pull request #506 from halkyon/sapphire
---

In the example, if you have an enum of Enum("Something,Don\t know") in your `DataObject::$db` array, then dev/build will *always* say this field has changed, because `MySQLDatabase::showFields()` returns the escaped string specification of the field with  instead of \.

This converts the field spec so that  is escaped to \ correctly so the change detection in `Database` is correct.
2012-06-07 12:35:10 +02:00
Will Rossiter
f3b91618fb Merge pull request #509 from Zauberfisch/patch-2
MINOR: fixed opera vendor prefix for @mixin hide-text-overflow
2012-06-07 00:37:55 -07:00
Sam Minnee
267f41bdf4 ENHANCEMENT: Point userhelp link at a new userhelp instance. (#7430) 2012-06-07 13:46:47 +12:00
Ingo Schommer
d4baf2d19d BUGFIX Stability improvements on CMS layout logic
- Changed application order
- Fixed layout trigger after preview toggle
- Replaced button row dimension approximation with double application of jQuery.layout() - once before sizing the action panel height to set correct width on container, then again for the height
2012-06-06 21:05:36 +02:00
Ingo Schommer
803aa6bfc5 MINOR Only applying box-shadow on inactive tabs 2012-06-06 21:05:35 +02:00
Ingo Schommer
415a680802 BUGFIX CMS Breadcrumbs and tabs as inline blocks which can span multiple lines, rather than being cropped off (fixes #6882) 2012-06-06 21:05:33 +02:00
Zauberfisch
eac70b6b5b MINOR: fixed opera vendor prefix for @mixin hide-text-overflow 2012-06-06 15:30:19 +02:00
Ingo Schommer
22de5c6597 MINOR Performance improvement and removal of duplicate code in jQuery.ondemand 2012-06-06 11:50:17 +02:00
Ingo Schommer
b3164eb2a9 MINOR Disabled jQuery.entwine inspector in dev mode, as it causes side effects due to document.write() before other scripts are loaded 2012-06-06 11:49:32 +02:00
Ingo Schommer
91b6bd62b1 MINOR Fixed a small but important docs error in cms-architecture.md 2012-06-06 08:28:48 +02:00
Sam Minnee
da915a4889 BUGFIX: Fix JS bug that was preventing passwords from being changed in 'hidden by default' ConfirmedPasswordField instances. 2012-06-06 17:53:16 +12:00
Sean Harvey
13be7cb2b9 BUGFIX Ensure that enum values with a single quote are escaped correctly for PHP coming out of MySQL ('' to \'), otherwise dev/build shows these as changed all the time. 2012-06-06 10:39:00 +12:00
Ingo Schommer
b4fb174809 MINOR Fixed PjaxResponseNegotiatorTest 2012-06-05 14:22:00 +02:00
Ingo Schommer
12f2e1e176 Merge branch 'pjax-multiple' 2012-06-05 14:01:18 +02:00
Ingo Schommer
e643559b17 MINOR Warning about HTML5 compat in CSSContentParser 2012-06-05 11:38:27 +02:00
Sam Minnee
5499079c1c BUGFIX: Fixed ORM bugs introduced in ec55468932 2012-06-05 11:07:19 +12:00
Sam Minnée
64aa2ad170 Merge pull request #502 from unclecheese/patch-2
If a DataObject has a many_many to a SiteTree subclass...
2012-06-04 15:38:58 -07:00
Sam Minnée
f8921f7c9f Merge pull request #500 from nyeholt/injector_strong_create
RECOMMIT This is a recommit of a previously merged, but reverted, commit...
2012-06-04 15:32:19 -07:00
Sam Minnée
90378b0998 Merge pull request #504 from schmengler/namespace-fixes-rc1
BUGFIX: Handling of classes with namespaces in database
2012-06-04 15:31:26 -07:00
Sam Minnée
2d9686274c Merge pull request #503 from nyeholt/injector_updates
Changes to use injector for creating some classes to ensure injection of dependencies
2012-06-04 15:30:45 -07:00
Fabian Schmengler
ec55468932 BUGFIX: Handling of classes with namespaces in database
MySQLDatabase::enumValuesForField() - Added stripslashes because backslashes are escaped in the type description

DataObject::requireTable() - Added double quotes to column names in automatically generated indexes for many_many relationships

DataObject::write() - Escaped class name for DB query

DataQuery::getFinalisedQuery() - Escaped class names for DB query
2012-06-04 20:22:37 +02:00
Marcus Nyeholt
82a1e7d282 MINOR Use injector for creating Member_GroupSet object
MINOR Use injector for creating many many list objects

MINOR Use injector for creating objects from within the DataList

MINOR Use Injector::inst() for creating objects; cannot rely on this->injector being present due to many classes being created with 'new', so use inst() directly

MINOR Remove injector autoset property for now; automatically setting it breaks a few test cases that don't know about it for now, and it's not needed just yet
2012-06-05 01:33:44 +10:00
unclecheese
119739de68 If a DataObject has a many_many to a SiteTree subclass, and that subclass has no database fields defined, and $this->name is "ID", this function will errantly return "SiteTreeSubClass.ID", which can never exist in a search query, since there is no such table as SiteTreeSubClass. The problem is that DataObject::hasOwnTableDatabaseField() is a little eager when passed an argument of "ID." It doesn't check to see if the object has its own table first. 2012-06-04 12:27:58 -03:00
Ingo Schommer
f794e98d7e BUGFIX Moved localised JS messages in correct module (fixes #7393) 2012-06-04 11:52:31 +02:00
Ingo Schommer
acfc658b4e BUGFIX Fail silently in _t() legacy mode when using sprintf(), to avoid outdated translations breaking with a fatal error (e.g. CMSMain.ACCESS changed from two to one usage of {title}, which isn't changed yet in most languages). Slight performance overhead, but acceptable since its legacy usage only 2012-06-04 11:40:55 +02:00
Ingo Schommer
69d3497497 MINOR Fixed node deselection when changing areas (e.g. "pages" to "edit page") 2012-06-04 11:05:05 +02:00
Ingo Schommer
9e21fb8a4a API CHANGE Moved SapphireSoapServer and SOAPModelAccess into its own module at https://github.com/silverstripe/silverstripe-soapserver (fixes #7282) 2012-06-04 10:22:48 +02:00