Sean Harvey
79baa1b092
BUGFIX Fixed undefined variable $matches in SSViewer::parseTemplateContent()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68026 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:47 +13:00
Sean Harvey
22b1b81843
BUGFIX SSViewer::set_source_file_comments(false) wasn't working because of lack of checking if enabled.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68024 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:47 +13:00
Ingo Schommer
d530706093
ENHANCEMENT Documented and improved DataObjectSet->PaginationSummary(). Removed DataObjectSet->paginationSummaryDots
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67984 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:47 +13:00
Saophalkun Ponlu
06efa9e0c8
Changed ... to html entiries …
...
PaginationSummary return all pages by default
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67877 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:47 +13:00
Saophalkun Ponlu
d5abb2bd87
Added PaginationSummary function that enable DataObjectSet to display a portion of page list
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67793 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:47 +13:00
Sam Minnee
f1c1eb218e
BUGFIX: Added check ot i18n::include_by_class() to prevent repeated calls.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67777 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:47 +13:00
Ingo Schommer
d9b3abf8ac
MINOR Documented ClassInfo::subclassesFor() and added unit tests
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67689 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:47 +13:00
Sean Harvey
b2c88c2f5b
MINOR Updated phpDoc for Requirements::customCSS() and Requirements_Backend::customCSS()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67682 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:46 +13:00
Sean Harvey
e4c0b3779d
BUGFIX Method not found error. Requirements::customCSS() should be calling self::backend()->customCSS() not custom()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67678 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:46 +13:00
Sean Harvey
b9e1fc0692
MINOR Added phpDoc to Requirements::customCSS() and Requirements_Backend::customCSS() to be clear about what should be included
...
MINOR Code formatting cleanup
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67676 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:46 +13:00
Sam Minnee
0b0908f8a3
BUGFIX: SSDatetime can handle being given a NZ date in dd/mm/yyyy format
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:45 +13:00
Ingo Schommer
0cacc25a12
BUGFIX Fixed i18n::get_owner_module() to detect template paths in themes (array notation) correctly (see #3022 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67520 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:45 +13:00
Ingo Schommer
6425dd7237
ENHANCEMENT Added SSViewer::get_source_file_comments()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:45 +13:00
Sean Harvey
c96d891c2c
MINOR Removed whitespace after ?> end PHP tag
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:45 +13:00
Sam Minnee
681c05d088
API CHANGE: Added SSViewer::set_source_file_comments() to allow disabling of comments in SSViewer output
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67426 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Ingo Schommer
2381e480c3
ENHANCEMENT Allowing custom methods in DataObjectSet->column()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67345 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Sean Harvey
90fb060b58
BUGFIX Since ModelAsController->handleRequest() expects a URLSegment, we make the ErrorPage Link() return a relative URLSegment in ErrorPage->publish()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67304 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Sean Harvey
9cf909e6ca
MINOR Declared Director::direct() and Director::test() as static functions to avoid confusion
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67301 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Sean Harvey
dd0dbddb4b
MINOR Code formatting improvements for Director->test()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67300 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Sean Harvey
7c03f7364b
BUGFIX Changed Director::test($this->URLSegment) to Director::test($this->Link()) in ErrorPage->publish() to be more robust
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67299 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Ingo Schommer
1b1b1a1d78
MINOR Re-enabled calls to updateCMSFields() accidentally disabled in r67294
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67295 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Ingo Schommer
3b50d5de00
ENHANCEMENT Added SITETREE_GRANT_ACCESS permission code to SiteTree to control editability of the "Access" tab (incl. unit tests)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67294 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Sam Minnee
ba0c2380e9
BUGFIX: dev/build should function even when new classes are referenced in _config.php
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67271 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Josh Kosmala
d839201092
BUGFIX: Filter on the baseclassid in Hierachy, not the class id, in case the class doesnt have a table (aoneil)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67268 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Sam Minnee
e802eaa1d9
ENHANCEMENT: Make it easier to create pageless subclasses of Page_Controller
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67242 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Ingo Schommer
958ad1c4e0
MINOR Merged r66794 from trunk (related to #3192 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67213 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Andrew O'Neil
c305bf3e1e
BUGFIX: Fixed incorrect permission checking when the current member isn't being used
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67199 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Andrew O'Neil
2132e8e301
Merged r67152 from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67194 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Ingo Schommer
4469283166
BUGFIX Checking for "$this instanceof VirtualPage" instead of "$this->class == 'VirtualPage' to support subclassing in VirtualPage->onBeforeWrite()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67150 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Ingo Schommer
933ade1692
BUGFIX Checking for existence of $this->record in VirtualPage_Controller->init()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67140 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Andrew O'Neil
a037a24148
BUGFIX: Fix publishing of error pages
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67137 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Sean Harvey
88d7a32017
BUGFIX Put the order of save and publish buttons back to normal (so save and publish are next to eachother)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67078 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
b1846439a7
MINOR removed debug code
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67075 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
78406d7c1f
ENHANCEMENT Moving "save" and "delete" cms actions from CMSMain->EditForm() into SiteTree->getCMSActions() to make them decoratable (e.g. disallow delete action) and easier to cover with unit tests. Leaving fallback "save" and "delete" actions in CMSMain in case no actions are defined (necessary e.g. for Group class in SecurityAdmin)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Sam Minnee
7671dc644b
BUGFIX: Fixed Enum::scaffoldSearchForm() to always include an (All) option
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67045 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Sam Minnee
c7a4afee52
BUGFIX: Fixing tests
...
ENHANCEMENT: Add <%-- --%> comments
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66946 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
3d5600c597
MINOR merged from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66944 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
3673a604c6
MINOR merged r66670 from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66942 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sam Minnee
7cce6782bc
BUGFIX #3115 ajshort: Fixed backslashes in temp folder location in manifest builder
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66918 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sam Minnee
1aeaed7fc4
Better checking of tabstrip stuff
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66889 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sam Minnee
331a427796
BUGFIX: Better generation of PastMember cookie when you have stale login info
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66888 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sean Harvey
4a145c4e1b
MINOR Code formatting conventions in HTTPRequest->param()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Ingo Schommer
322fa2a547
BUGFIX Returning a boolean instead of Permission IDs in specific SiteTree->canEdit() case
...
BUGFIX Passing through $member param from SiteTree->canPublish() to SiteTree->canEdit()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66740 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Will Rossiter
18178c3e79
BUGFIX: fixed typo in filesystem
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Ingo Schommer
524a003d24
MINOR merged r66672 from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Ingo Schommer
93dd7600df
ENHANCEMENT Renamed tab "Meta-data" to "Metadata" for better readability (see #3142 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66654 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sam Minnee
be6e67a20f
DataObject::relObject() throws an exception rather than an error so that it can be caught
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66645 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sean Harvey
7874d09771
MINOR Removed redundant code
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66640 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sean Harvey
0d450e6c3a
BUGFIX Fixed flaw logic checking for $member variable, since it's always set the alternative for choosing Member::currentUser() would never work.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66638 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sean Harvey
a2d5a9ac75
MINOR Code formatting of !isset($member) on SiteTree->canAddChildren() for consistency with other can*() methods
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66637 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00