Sean Harvey
744791219e
MINOR #6256 Removed PHP version < 5.1.3 functionality workaround from Object::create() and Object::strong_create()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115055 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-15 04:27:43 +00:00
Sean Harvey
127d682ba7
BUGFIX #6219 Director::direct() validation fails for doubly nested file fields (thanks ajshort!)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114921 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-14 00:15:30 +00:00
Sean Harvey
f48d685a82
ENHANCEMENT Allow setting secure session cookies when using SSL. Recent change r114567 made this impossible. (thanks simon_w!)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114900 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-13 22:30:49 +00:00
Will Rossiter
81bd4c102e
MINOR: restored SiteConfig functions
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114822 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 05:45:04 +00:00
Will Rossiter
815e9efd94
APICHANGE: removed page comments from core. Please see the github.com account for page comments functionality
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 05:43:08 +00:00
Will Rossiter
21f84c9513
APICHANGE: changed BaseHref to AbsoluteBaseURL for consistency. FEATURE: added BaseURL for getting non absolute value. PATCH via muzdowski ( #6158 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114815 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 02:01:13 +00:00
Will Rossiter
ac851e6f82
FEATURE: added get_theme_folder() to return the full path to the themes folder
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114814 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 01:34:47 +00:00
Will Rossiter
2f56a8bcad
ENHANCEMENT: added onBeforeVersionedPublish() hook. PATCH via muzdowski ( #6016 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 01:28:46 +00:00
Ingo Schommer
ae2311bcd6
BUGFIX Removed switch in MySQLDatabase->query() to directly echo queries with 'showqueries' parameter when request is called via ajax
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-09 23:26:22 +00:00
Ingo Schommer
1222b4d146
ENHANCEMENT 'bypassStaticCache' cookie set in Versioned is limited to httpOnly flag (no access by JS) to improve clientside security
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-06 00:29:20 +00:00
Ingo Schommer
562eeee790
ENHANCEMENT Session::start() forces PHPSESSID cookies to be httpOnly (no access by JS) to improve clientside security
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-06 00:28:27 +00:00
Sam Minnee
6de3e90527
FIX: Revert last commit (from r114464)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:45:20 +00:00
Sam Minnee
aaf56e190f
FIX: Revert last commit (from r114463)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:44:37 +00:00
Sam Minnee
8638221adb
MINOR: Added exception handling if ClassName is null in search results (from r114454)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:44:20 +00:00
Sam Minnee
1fc8bef1ce
BUGFIX Including template /lang folders in i18n::include_by_locale() (implementation started in r113919) (from r114208)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:43:38 +00:00
Sam Minnee
312c7aec07
BUGFIX #6201 Use of set_include_path() did not always include sapphire paths in some environments (from r113976)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:40:28 +00:00
Sam Minnee
edc7a46d21
MINOR Fixed spaces with tabs in Core (from r113924)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:37:31 +00:00
Sam Minnee
567c0b4939
MINOR Fixed spaces with tabs for Core::getTempFolder() (from r113923)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:37:15 +00:00
Sam Minnee
b7777cd67d
BUGFIX ErrorPage::requireDefaultRecords() case where no assets directory causes an fopen() error. Ensure assets directory is created before attempting to write error page files (from r113590)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:36:05 +00:00
Sam Minnee
770281b65c
BUGFIX Clear static marking caches on Hierarchy->flushCache() (from r113277)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:26:40 +00:00
Sam Minnee
c63b00f92a
MINOR Using SecurityToken in ViewableData->getSecurityID() (from r113274)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:24:37 +00:00
Sam Minnee
c3fa7406ab
MINOR Documentation (from r113241)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114522 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:18:58 +00:00
Ingo Schommer
3e8704c882
BUGFIX Escaping $locale values in Translatable->augmentSQL() in addition to the i18n::validate_locale() input validation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114515 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 05:23:37 +00:00
Ingo Schommer
396f297acb
API CHANGE Using i18n::validate_locale() in various Translatable methods to ensure the locale exists (as defined through i18n::$allowed_locales)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-03 00:28:24 +00:00
Ingo Schommer
17ac4753fd
BUGFIX Check for valid locale in i18n::set_locale()/set_default_locale()/include_locale_file()/include_by_locale() (as defined in i18n::$allowed_locales). Implicitly sanitizes the data for usage in controllers.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114469 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-03 00:27:41 +00:00
Ingo Schommer
640b504ebe
BUGFIX Don't allow HTML formatting in RequestHandler->httpError() by sending "Content-Type: text/plain" response headers.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-02 08:03:17 +00:00
Ingo Schommer
07b6d1870a
MINOR Checking for class_exists() before SapphireTest::is_running_tests() to avoid including the whole testing framework, and triggering PHPUnit to run a performance-intensive directory traversal for coverage file blacklists
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114332 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-30 05:13:09 +00:00
Ingo Schommer
7be01d3d10
BUGFIX Fixed saving of files in IE6/IE7 in SS_HTTPRequest::send_file() by adding custom "Cache-Control" HTTP headers
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114136 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:50 +00:00
Ingo Schommer
196cabb2f0
MINOR: unique indexes on versioned tables now changed to 'index'
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114134 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:49 +00:00
Ingo Schommer
f1bf0d0fc4
BUGFIX Aborting marking in Hierarchy->markPartialTree() before loading nodes, if the expected node count would exceed the totals (regardless of the in-memory marking state)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114133 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:48 +00:00
Ingo Schommer
b15019a95f
ENHANCEMENT Added SS_HTTPResponse->setStatusDescription() as equivalent to setStatusCode(). Added documentation.
...
BUGFIX Strip newlines and carriage returns from SS_HTTPResponse->getStatusDescription() (fixes #6222 , thanks mattclegg)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114082 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 19:38:15 +00:00
Ingo Schommer
3725ab77a0
BUGFIX Removed double quoting of $where parameter in Translatable::get_existing_content_languages() ( fixes #6203 , thanks cloph)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114080 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 19:21:44 +00:00
Ingo Schommer
6ccd6d61bd
MINOR Documentation for Aggregate caching
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114077 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 05:43:59 +00:00
Saophalkun Ponlu
efda708708
MINOR: Make sure that Translatable creates a translated parent of SiteTree only when the parent is not translated
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113955 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-19 02:49:41 +00:00
Geoff Munn
7d96dcd02b
MINOR: dev/build message fixed to explain changes more clearly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113931 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-18 23:29:30 +00:00
Ingo Schommer
ab92919b27
ENHANCEMENT Allowing i18nTextCollector to discover entities in templates stored in themes/ directory (thanks nlou)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113918 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-18 19:00:13 +00:00
Ingo Schommer
854cbe79c8
API CHANGE Don't partially URI encode strings in SiteTree->RelativeLink(), rely on XML casting in templates instead ( fixes #6125 , thanks paradigmincarnate)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-13 02:54:13 +00:00
Geoff Munn
4215b2f434
ENHANCEMENT: full text search indexes now identified more clearly in dev/build
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113657 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-11 19:06:18 +00:00
Geoff Munn
92c7419767
BUGFIX: unique versioned indexes are now converted to standard indexes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113299 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-01 02:58:43 +00:00
Sam Minnee
4665369e31
BUGFIX Renamed MySQLQuery::__destroy() renamed to __destruct() so that it is called properly after the object is destroyed (from r112288)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112950 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:59 +00:00
Sam Minnee
75101d329f
MINOR Reverted regression in r112272 (from r112278)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112949 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:46 +00:00
Sam Minnee
2699eb3b5b
ENHANCEMENT MySQLDatabase::renameField() no longer checks that the field exists in fieldList(). alterField() does no such check, so it should be consistent. Removing this should provide a small performance improvement as well (from r112272)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112948 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:32 +00:00
Sam Minnee
bb183add33
BUGFIX #3910 Setting timezone parameter to MySQLDatabase::__construct() should use $this->query() to be consistent (from r111889)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:40 +00:00
Sam Minnee
e2cb7001ce
ENHANCEMENT MySQLDatabase::getVersion() now uses mysql_get_server_info() which has been supported since PHP 4. This gives us a better version than say "5.1", instead we now get something like "5.1.51" (from r111868)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112933 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:03 +00:00
Sam Minnee
429434811f
MINOR Revert r111850 to MySQLDatabase::getVersion as version comparisons need to happen, and this will strip out non-numeric characters e.g. "ubuntu1" or "lenny4" which are prefixed on some Linux distros (from r111852)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112932 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:02:42 +00:00
Sam Minnee
4af7d7aa34
MINOR dev/build now shows database name and version next to "Building database ..." text (from r111851)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112931 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:02:02 +00:00
Sam Minnee
849bca4a3d
ENHANCEMENT Make use of mysql_get_server_info() when calling MSSQLDatabase::getVersion(), if there's a problem getting info this way, falls back to using query for VERSION() details (from r111850)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112930 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:01:50 +00:00
Sam Minnee
5e0b978263
BUGFIX #6055 ErrorPage should always create static error page files when dev/build is called if they don't exist (from r111842)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112927 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:00:35 +00:00
Sam Minnee
8d5b417619
MINOR Fixed documentation in Datetime ( fixes #6062 , thanks nicolaas) (from r111787)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112921 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:53:11 +00:00
Sam Minnee
d328c7cc53
BUGFIX DB::connect() should not rely on $_SESSION existing, so we check isset() to supress any warnings of undefined indexes
...
MINOR Code formatting tidy of DB::connect() function (from r111772)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112920 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:52:59 +00:00