Ingo Schommer
18855687fc
BUGFIX Making less assumptions about object structure in FieldSet->addFieldToTab() error messages
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64007 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:15:39 +00:00
Ingo Schommer
950560e188
MINOR Fixed PHP notice in CLITestReporter
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64006 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:14:31 +00:00
Ingo Schommer
eb5cd150d8
BUGFIX YamlFixture->saveIntoDatabase(): In order to support reflexive relations which need a valid object ID, the record is written twice: first after populating all non-relational fields, then again after populating all relations (has_one, has_many, many_many). Fixes a bug where FileTest was testing onBeforeWrite() behaviour
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64005 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:14:03 +00:00
Ingo Schommer
320c30ba5d
BUGFIX Writing record from yml before parsing relations in YamlFixture->saveIntoDatabase() to avoid missing lookups for reflexive relations on the same object
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64004 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:07:34 +00:00
Ingo Schommer
06d78ee993
ENHANCEMENT Don't like relations without $api_access in RestfulServer, added RestfulServer->getAllowedRelations()
...
ENHANCEMENT Added DataFormatter->setCustomRelations()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64003 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:47:25 +00:00
Ingo Schommer
4134f92dad
BUGFIX Moved RecordController and CollectionController to external module (see r63905)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64002 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:41:22 +00:00
Ingo Schommer
2fbed5b2e1
BUGFIX Adjusted FormTest->testLoadDataFromObject() to new assumptions about changed behaviour on loadDataFrom() from $loadBlanks to $clearMissingFields - which means that form fields are cleared regardless if they have blank values in the passed object or not
...
ENHANCEMENT Added FormTest->loadDataFromClearMissingFields()
ENHANCEMENT Made FormTest fixtures more expressive
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64001 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:40:13 +00:00
Ingo Schommer
5f50fee5e9
BUGFIX Making sure that DataObject->has*Field() methods always return an array, in order not to fail any array_key_exists() checks
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64000 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:39:24 +00:00
Ingo Schommer
b1b909103e
BUGFIX Fixing DataObject->hasField() to find fields in inherited database tables by using hasDatabaseField().
...
BUGFIX Fixing DataObject->hasField() to detect dynamic getters by using hasMethod("get$fieldName")
ENHANCEMENT Re-enabled two test cases in DataObjectSet as a result of the above fixes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63999 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:38:46 +00:00
Ingo Schommer
67f144e1a5
BUGFIX Fixed Form->loadDataFrom() to properly populate FormField->setValue() when an object is passed as the first parameter (needed e.g. for CheckboxSetField->setValue()) - see mailinglist discussion at http://groups.google.com/group/silverstripe-dev/browse_thread/thread/717bada8ccafdd70
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63998 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:37:46 +00:00
Ingo Schommer
62e4870c7b
API CHANGE Deprecated GhostPage
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63997 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:36:04 +00:00
Ingo Schommer
b6ffe7b939
ENHANCEMENT Added unit test CheckboxSetFieldTest?->testLoadDataFromObject()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63996 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:32:47 +00:00
Ingo Schommer
de1218e8db
ENHANCEMENT Using fixtures in CheckboxSetFieldTest?, restructured from hard-to-debug manymany-join on self to a Article<->Tag relation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63995 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:29:48 +00:00
Sean Harvey
4da7a70cdd
BUGFIX: Allow use of ClassInfo methods in _config.php when manifest is being rebuilt
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63981 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 05:29:34 +00:00
Sean Harvey
d794b11910
BUGFIX Added missing slash in TableListField_Item->Link()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63945 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 02:20:35 +00:00
Sam Minnee
866853f31a
BUGFIX: Improved RedirectorPage's handling of invalid configuration options to prevent infinite loops and segfaults
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 01:46:17 +00:00
Sam Minnee
679f694c67
Improved backtrace generation in test reporter, to limit the amount of unnecessary waffle.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63938 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 01:45:36 +00:00
Sam Minnee
25a812c12f
MINOR: Reformatting
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 01:45:12 +00:00
Sam Minnee
db0644c985
BUGFIX: Improved detection of CLI colour support
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63927 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 00:49:53 +00:00
Sam Minnee
fce3767389
API CHANGE: Added support for dot syntax to FieldSet::fieldByName()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63922 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 00:32:10 +00:00
Josh Kosmala
3d4d4d0c42
BUGFIX: Fix broken breadcrumbs
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63920 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 00:28:36 +00:00
Andrew O'Neil
f96dceecc9
BUGFIX: #2588 Fix issue with IIS not stripping GET variables from the URL (mackeyn)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63915 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 23:04:55 +00:00
Andrew O'Neil
e5f3982058
BGFIX: #2587 Fix HTTPS detection on IIS (mackeyn)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63912 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 22:53:20 +00:00
Sam Minnee
571e8d2b2c
BUGFIX: Prevent misconfigured redirector pages from breaking static publishing
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 22:35:22 +00:00
Andrew O'Neil
bd1b9e4f73
BGFIX: #2527 - Fix mysql version detection on hosts with custom mysql version names (HakTom)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63904 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 22:05:56 +00:00
Andrew O'Neil
015385c526
MINOR: Add warning for deprecated function.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63898 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 21:33:43 +00:00
Hayden Smith
3f6a86738b
Added PHP doc for the ValidationException thrown by DataObject::write
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63892 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 20:50:28 +00:00
Hayden Smith
fc2c16efdf
DataObject::write now throws a ValidationException rather than calling user_error if the call to DataObject::validate fails. This allows the validation exception to be caught and handled by tests or other controllers.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63891 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 20:42:09 +00:00
Hayden Smith
d8dd8097e1
BUGFIX: Validation result was ignoring the $valid flag passed as the first argument.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63890 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 20:40:11 +00:00
Hayden Smith
aa9a337c5c
Added missing TableListField_printable.ss template.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63883 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 19:23:02 +00:00
Hayden Smith
f0af7dd9a5
Corrected reverted merge. ComplexTableField::setPopupSize is now present.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63882 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 19:22:07 +00:00
Ingo Schommer
0337512cf2
MINOR Updated entities from translate.silverstripe.com
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63873 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 15:17:47 +00:00
Ingo Schommer
feb7ea5229
MINOR Updated language master table
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63864 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 14:05:39 +00:00
Ingo Schommer
9d31e43de3
BUGFIX Properly merging different dictionaries for javascript i18n implementation (see #2916 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63857 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 12:17:00 +00:00
Ingo Schommer
8c75af3927
MINOR Reverted manual setting of i18n fallback strings in r63839, fixed original problem (wrong entity name)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63856 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 12:14:41 +00:00
Sean Harvey
22572f3b8e
BUGFIX Added missing default english text to i18n call in TableField and TableListField javascript
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63839 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 04:18:13 +00:00
Sam Minnee
7efd56e0dd
Updated Member's getCMSFields() to consistently work with fields in a tab
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63837 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 04:17:52 +00:00
Sam Minnee
7741fdb155
BUGFIX: Don't let Director::test() clobber current stage
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63825 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:37:33 +00:00
Sam Minnee
cf5b6342df
BUGFIX: Fix FieldSet::replaceField() so that it doesn't clobber tabs
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:37:12 +00:00
Sam Minnee
09cb773f5c
BUGFIX: SiteTree::onAfterPublish() will still pass an object to the handlers on the first publish
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63823 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:36:38 +00:00
Sam Minnee
b79c0661a4
MINOR: Fix to SiteTreeTest's data fixtures
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63822 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:36:12 +00:00
Hayden Smith
f2474a0ae2
Moved error_reporting setting from main.php to Core.php
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:35:28 +00:00
Sam Minnee
1b1751457e
Removed relational CTFs reliance on DataObject->ClassName
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:35:27 +00:00
Sam Minnee
51447b89ab
BUGFIX: Fixed pagination in TableListField after hsmith's changes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:32:33 +00:00
Sean Harvey
332da65edb
MINOR Tidied up argument list for Object::create() in ComplexTableField->AddForm()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63815 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:40:10 +00:00
Sean Harvey
9f0718f6df
BUGFIX: Fixed array_key_exists check in DataObject->setField that was failing when DataObject->record was not yet initialised by DataObject->setField.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:25:26 +00:00
Ingo Schommer
431afe234f
BUGFIX PHP Notice in InlineFormAction_Readonly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63809 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:03:05 +00:00
Hayden Smith
634ed7b70c
Merged from branches/nzct-trunk. Use 'svn log -c <changeset> -g' for full commit message. Merge includes stability fixes and minor refactor of TableListField and ComplexTableField.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:00:12 +00:00
Sean Harvey
f2abae719e
BUGFIX Member->getCMSFields() should use scaffoldCMSFields() instead of scaffoldFormFields() - currently it is operating in the wrong context.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63797 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 00:50:03 +00:00
Hayden Smith
2d9fcee4de
BUGFIX: Fixed paths to CSV fixtures for case-sensitive file systems.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63769 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 21:20:24 +00:00