Sean Harvey
b325fea709
MINOR Fixing "No current controller available" error when TestSession::__destruct() is called
2012-05-24 16:41:29 +12:00
Sam Minnée
c5616f8724
Merge pull request #487 from nyeholt/injector_bugfixes
...
Change singleton and strong_create to use dependency injector, with additional fixes to existing classes to behave correctly
2012-05-23 18:46:48 -07:00
Marcus Nyeholt
82495f5a7e
BUGFIX Versioned's constructor doesn't provide suitable defaults. Previously a bug/feature in singleton, where it would pass null,true as params to strong_create, which would then get passed through as params to Versioned's constructor, meant that the code still executed fine (as was set to something that wasn't an array, so the null and true were instead taken as args). The fact that the usage of singleton(Versioned) never really used the classes code, purely for value lookup, meant that this never propagated errors. I've now switched singleton() to use the injector for retrieving values, which means these dud values are no longer passed through
...
CHANGE Given that Config::inst is an implementation of the singleton pattern itself, I've removed the extra call to singleton(). A side effect of this is that it gets around a possibly nasty circular reference with the dependency injector (which relies on the config object); in future, this dependency structure should really be structured from the DI directly.
MINOR Change singleton and strong_create to use dependency injector
BUGFIX: Provide default constructor values for classes (fixes issues when used in 'singleton' scenario during dev/build in particular)
MINOR Clear out injector state when resetting db schema during tests (a follow on from changing singleton() calls to use the injector underneath)
2012-05-23 21:10:04 +10:00
Sean Harvey
77c2365b87
MINOR Replacing deprecated static function calls to Director with
...
current Controller instance replacements.
2012-05-23 21:50:02 +12:00
Sean Harvey
aaf91154a2
BUGFIX If there is *any* error connecting to MySQL, expose this to the installer.
2012-05-19 11:29:25 +12:00
Sean Harvey
b65dff0fbe
BUGFIX Allowing actions related to coverage tests
2012-05-18 16:05:05 +12:00
Ingo Schommer
eeef41e91f
SECURITY Fixed remote code execution vuln in install.php due to inserting unescaped user data into mysite/_config.php. Not critical because install.php is required to be removed on a SilverStripe installation anyway ( fixes #7205 )
2012-05-16 14:59:42 +02:00
Sean Harvey
e095950a50
BUGFIX Installer checks: warn if finfo class not available, re-instating hash check, and remove duplicate iconv check.
2012-05-14 14:18:49 +12:00
Sean Harvey
20a51d6572
MINOR Ensure finfo class exists in installer checks, we need it for MIME
...
type detection of files.
2012-05-12 10:17:53 +12:00
Sean Harvey
01f8e38eee
MINOR Using correct URL for tutorial in installer
2012-05-11 14:51:23 +12:00
Sean Harvey
b1e17578c7
API CHANGE Removed assertType() and assertEmpty() workarounds. Use assertInstanceOf()
...
instead of assertType(), assertEmpty() is available in PHPUnit 3.5+.
PHPUnit 3.4 is no longer supported, so please upgrade your version to
work.
MINOR Removed FullTestSuite which was a workaround for PHPUnit but not
used.
2012-05-09 23:05:39 +12:00
Ingo Schommer
1671b9c65c
BUGFIX Checking for mbstring PHP extension support in installer, as it has been a documented installation requirement for a while. Removing method_exists() checks from mbstring usage in core for the same reasons
2012-05-09 10:25:31 +02:00
Sean Harvey
5bce3425b4
Merge pull request #401 from chillu/is-absolute-url
...
Director::is_absolute_url() security fixes
2012-05-07 18:47:03 -07:00
Sean Harvey
4e18cc581b
BUGFIX Ensure MySQLi is used consistently in MySQLDatabaseConfigurationHelper, not old mysql functions
2012-05-05 11:22:28 +12:00
Ingo Schommer
1f7f8b8aee
BUGFIX Don't' set 'Referer' header in FunctionalTest->get()/post() if its explicitly passed to the method
2012-05-04 11:49:30 +02:00
Ingo Schommer
e929753992
MINOR Using correct $locale format in installer (regression from last commit)
2012-05-03 00:00:51 +02:00
Ingo Schommer
0068b6d5b6
BUGFIX Showing only actually available languages for selection during install ( fixes #7260 )
2012-05-02 23:35:20 +02:00
Andrew O'Neil
fa60f9e8b2
ENHANCEMENT: Implement blowfish encryption and use it by default. ( #7111 )
2012-05-02 13:51:29 +12:00
Sean Harvey
3ccaa1f864
MINOR Supress any error connecting to the database so the installer
...
doesn't show it in the page header
2012-04-30 11:15:21 +12:00
Sean Harvey
32d4ec837c
Merge pull request #374 from oddnoc/installer-email-password-feedback
...
BUGFIX: Start a PHP session in installer.
2012-04-27 21:49:38 -07:00
Sean Harvey
b03cf04dbd
BUGFIX Updating MySQLDatabaseConfigurationHelper to check for MySQLi
...
instead of mysql_connect and other old function usage, as we've moved to
MySQLi in MySQLDatabase.php now
2012-04-28 12:13:58 +12:00
Fred Condo
b8228271e6
BUGFIX: Start a PHP session in installer.
...
This fixes blank username and password on home/successfullyinstalled
2012-04-27 16:51:47 -07:00
Fred Condo
df6a249bf0
BUGFIX: Change requirement rubrics to remove confusion
...
Resolves #7199
Change all the rubrics to be nouns or questions, rather than a statement of
the desired setting. If the setting is correct, we get a nice green OK; if
not, it was confusing for the rubric to state the opposite of the failure
mode, which is described in the long message.
2012-04-26 15:04:07 -07:00
Sean Harvey
bda849afeb
BUGFIX Check for SimpleXML support in PHP at the installation step
2012-04-22 22:43:06 +12:00
Sean Harvey
cc339c37c4
BUGFIX Ensure the SS3 installer checks for CType support in PHP, as language YAML parser uses this in framework.
2012-04-22 17:45:56 +12:00
Sean Harvey
c55e0b8b95
MINOR Fixing up PHP versions to be consistent with
...
33ae83640b
2012-04-20 15:08:01 +12:00
Sam Minnee
33ae83640b
MINOR: Lowered 5.3.10 recommendation to 5.3.4
2012-04-20 14:45:57 +12:00
Sean Harvey
16e950cb6a
MINOR Tidy up of code formatting in TestRunner
...
MINOR Fixing up old ObjectStaticTest and merging into ConfigTest
2012-04-18 23:29:54 +12:00
Sean Harvey
4c6be2931b
BUGFIX Removing use of deprecated Object static functions like
...
get_static(), set_static(), uninherited() etc. Replace with equivalent
Config system get(), update()
2012-04-18 23:10:57 +12:00
Mateusz Uzdowski
e262a29193
ENHANCEMENT: move code introspection functions to the silverstripe-codeviz module
2012-04-17 14:45:26 +12:00
Sean Harvey
69c066cb2c
Merge pull request #332 from mateusz/strict
...
BUGFIX: fix up some E_STRICT errors
2012-04-16 16:59:29 -07:00
Mateusz Uzdowski
59663f9289
BUGFIX: fix up some E_STRICT errors
2012-04-17 11:51:55 +12:00
Will Rossiter
7a4392ca03
Merge pull request #324 from halkyon/installer_fixes
...
MINOR: Fix install not loading because of Zend/Translate.php dependency in i18n.php
2012-04-16 16:34:53 -07:00
Sean Harvey
5f73643e3f
BUGFIX Hardcoding locales in installer, because we can't include i18n
...
properly, and including core/Core.php is too much.
2012-04-17 11:02:18 +12:00
Sean Harvey
ad2a21cc92
API CHANGE getSysTempDir() is now deprecated, use sys_get_temp_dir()
...
instead!
2012-04-17 10:53:41 +12:00
Sean Harvey
dc0031cf26
BUGFIX Fixed broken installer trying to include i18n thirdparty Zend
...
libs, which depends on Core.php being included first because include
paths are setup there first. This has the effect of removing redundant
code in the installer like temp path discovery, as Core takes care of
that for us.
2012-04-17 10:53:40 +12:00
Sean Harvey
d0984ec897
MINOR Line break after sentence of message
2012-04-17 10:53:40 +12:00
Sean Harvey
bbf04ee7ea
MINOR Removed function_exists() checks which aren't necessary for PHP 5.2+
2012-04-16 13:15:41 +12:00
Sean Harvey
ebe75fefab
MINOR Update locations to server requirements page
2012-04-15 16:29:14 +12:00
Sean Harvey
515a2ccfcc
MINOR Updating old URLs in installer, show message about creating admin
...
account
2012-04-15 16:01:06 +12:00
Sean Harvey
e71b8d6215
MINOR Installer cleanups, removing references to old "command line
...
installation" which is no longer supported.
MINOR Removed stray semi-colon when showing version in installer
template.
2012-04-15 15:05:20 +12:00
Sean Harvey
6405c44bc2
MINOR Enable the highest level of error_reporting() in install, to be
...
consistent with Core.php
2012-04-15 10:50:20 +12:00
Simon Welsh
f07258f3cf
MINOR Update @package values to match renaming sapphire
2012-04-15 10:50:19 +12:00
Simon Welsh
3a6341a251
API-CHANGE sapphire folder can now be renamed.
2012-04-15 10:50:19 +12:00
Simon Welsh
f8082e4814
MINOR Add newline to end of files without one
2012-04-15 10:50:19 +12:00
Sean Harvey
f57a763524
MINOR Ensure incomplete tests also have a backtrace
2012-04-15 00:26:17 +12:00
Sean Harvey
ce097a7b54
ENHANCEMENT If there are no test failures, but incomplete tests, mark
...
summary of test run as "ok but incomplete" in yellow for CliTestReporter
2012-04-15 00:07:15 +12:00
Sean Harvey
edaed5ef7e
BUGFIX If SS_Backtrace::get_rendered_backtrace() has $plainText argument
...
to TRUE, ensure there is no HTML in the output.
2012-04-15 00:05:49 +12:00
Sean Harvey
fc18b2c788
ENHANCEMENT TestReporter now reports incomplete tests properly
2012-04-14 23:11:54 +12:00
Will Rossiter
907568b182
ENHANCEMENT: move hard coded template HTML for composite field and field group out to separate template files.
2012-04-14 17:36:08 +12:00
