tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
11,339 Commits 31 Branches 527 Tags 162 MiB
72a7f0e672
Commit Graph

11339 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ingo Schommer
5119d9aa72 FIX Only allow one concurrent ajax in TreeDropdownField 
Prevents situations where a previous action might finish out of line
and override later choices, such as first expanding the (full) tree panel,
then limiting the tree through searching.
 2013-04-08 19:42:17 +12:00
Ingo Schommer
da87614d8f FIX Skip autofocus on TreeDropdownField 
To avoid (visually) unsetting the selected value if the drop down
is the first form field on the page (see LeftAndMain.EditForm.js)
 2013-04-08 19:42:17 +12:00
Will Rossiter
8e82ef186d Merge pull request #1337 from adrexia/patch-1 
BUG: update deprecated 'live' jquery to 'on'
 2013-04-08 00:41:02 -07:00
Ingo Schommer
f296439a24 NEW Hints for scaffolded date/time fields 2013-04-08 19:38:50 +12:00
Will Rossiter
d04ead65b8 Merge pull request #1340 from chillu/pulls/theme-enabled 
API Replaced SSViewer.custom_theme with SSViewer.theme_enabled
 2013-04-08 00:27:56 -07:00
Ingo Schommer
7121fc3f85 FIX Config isolation in Director::test() 2013-04-07 23:59:10 +02:00
Ingo Schommer
828ac7fe4f API Replaced SSViewer.custom_theme with SSViewer.theme_enabled 
Since we can't influence the setting of configuration values,
we also can't set/unset the 'custom_theme' value based on which
theme is set. This means the 'custom_theme' value goes stale,
and we can't rely on it e.g. in FilesystemPublisher.

The 'theme_enabled' toggle is a cleaner solution to the same problem,
since the 'custom_theme' was really just a way to remember the original
theme, while still disabling it. The toggle makes this more explicit,
but also requires users of the 'theme' setting to check for it.
 2013-04-07 23:59:10 +02:00
Ingo Schommer
5c7ceee902 Merge pull request #1723 from NicoHaase/master 
[API] Fixed version for RegenerateCachedImagesTask (former FlushGeneratedImagesTask)
 2013-04-07 09:35:02 -07:00
Ingo Schommer
fb17f43878 Merge pull request #1733 from wilr/open6270 
FIX: nested SelectionGroups should only hide first level
 2013-04-07 05:36:05 -07:00
Will Rossiter
7881f60298 FIX: nested SelectionGroups should only hide first level 2013-04-07 15:13:50 +12:00
Nico Haase
8908a6bcd7 This is a fixed version for RegenerateCachedImagesTask (former FlushGeneratedImagesTask) such that it regenerates images instead of silently removing them and breaking existing pages 
The pull request also contains some enhancements and fixes to the corresponding testcases.

Fixes #318
 2013-04-06 15:56:27 +02:00
Ingo Schommer
700453b7dc Merge pull request #1731 from wilr/open5551 
FIX: Decimal field change detection.
 2013-04-06 04:32:27 -07:00
Ingo Schommer
e2b42ca4c2 Fixed Versioned hook regression 
Introduced by 5238e9cf48
 2013-04-06 12:24:57 +02:00
Ingo Schommer
667711609b Merge pull request #1725 from s-m/templater-parser-files-sync 
Sync template-parser files
 2013-04-06 03:22:17 -07:00
Will Rossiter
e619329dc3 FIX: Decimal field change detection. 2013-04-06 23:20:28 +13:00
Ingo Schommer
5c82efd61d Merge pull request #1729 from ajshort/no-rule-match-404 
API: Return a 404 error when no director rule is matched
 2013-04-06 03:09:48 -07:00
Ingo Schommer
ff2977eee3 Merge pull request #1730 from wilr/open5489 
API: add onBeforeRollback() and onAfterRollback() hooks.
 2013-04-06 03:08:02 -07:00
Will Rossiter
5238e9cf48 API: add onBeforeRollback() and onAfterRollback() hooks. 2013-04-06 22:59:33 +13:00
Andrew Short
1fc780ce2b API: Return a 404 error when no director rule is matched 2013-04-06 18:19:03 +11:00
Simon Welsh
7871e5a85e Merge pull request #1727 from wilr/open6079 
FIX: remove_extension should work on parameterized extensions
 2013-04-05 23:30:30 -07:00
Will Rossiter
1427a0637b FIX: remove_extension should work on parameterized extensions 2013-04-06 19:29:03 +13:00
Simon Welsh
77514204ee Merge pull request #1728 from wilr/open6445 
FIX: Ensure FieldList::push() doesn't eliminate key
 2013-04-05 23:25:52 -07:00
Will Rossiter
69722222b4 FIX: Ensure FieldList::push() doesn't eliminate key 2013-04-06 19:16:59 +13:00
Will Rossiter
b25eda83c4 Remove reference to /images/flush. 
Now a BuildTask. See /dev/tasks
 2013-04-06 18:13:18 +13:00
s-m
14de34cb9b Sync template-parser files 
The template-parser files were not in sync, there were some lines added
in SSTemplateParser.php from 3334eafcb1
and 0a9f3b75a9 , I readded those parts
into the SSTemplateParser-include-file and recreated the
SSTemplateParser.php to get to a synced state...
 2013-04-05 19:12:54 +02:00
Ingo Schommer
1dda9ae45f Fixed extra_requirements docs 2013-04-05 15:35:30 +02:00
Ingo Schommer
91477617e6 Fixed HiddenField->SmallFieldHolder() declaration 2013-04-05 14:03:13 +02:00
Ingo Schommer
2266638475 Note on usage of HTTP::send_files() for large files (see trac/5125) 2013-04-05 14:03:13 +02:00
Ingo Schommer
d042b380c0 Merge pull request #1722 from lewellyn/patch-1 
Provide guidance for cross-repo issue referencing
 2013-04-05 05:00:24 -07:00
Matt Lewandowsky
d613ba0593 Provide guidance for cross-repo issue referencing 2013-04-05 04:57:09 -07:00
Ingo Schommer
b3db70fcbd HiddenField->SmallFieldHolder() (fixes trac/4608) 2013-04-05 13:45:48 +02:00
Ingo Schommer
bc6f18849f Merge pull request #1719 from wilr/open5793 
API: Move LimitWordCount() to Varchar
 2013-04-05 03:03:09 -07:00
Ingo Schommer
4d36b97543 Check for $bounceAddress before using (fixes #3359) 2013-04-05 11:46:15 +02:00
Will Rossiter
05d4dd863d Update controller.md 2013-04-05 22:17:11 +13:00
Ingo Schommer
97819b3f21 Correct encoding in MemberLoginForm->forgotPassword() URLs (fixes #6126) 2013-04-05 11:15:34 +02:00
Ingo Schommer
35b6887568 Detection of <FormField>_Readonly classes (fixes #1473) 
Consistent behavior with _Disabled classes
 2013-04-05 11:15:09 +02:00
Will Rossiter
ddb017a6ff API: Move LimitWordCount() to Varchar 2013-04-05 21:58:03 +13:00
Ingo Schommer
cfafa19cc3 FIX Disallow group removal when member is edited in groups view 
It would invalidate this view. Only allow group editing
for new members added to this group (with a group default),
and for members edited through the "root" view.
 2013-04-05 00:51:24 +02:00
Sean Harvey
65cb182c98 BUG Don't sort when deleting records in ManyManyList::removeAll() 
This breaks databases like MSSQL which don't allow an ORDER BY with
a subquery at the same time. DELETE queries don't need to be ordered,
so we can safely remove the default.
 2013-04-05 11:50:25 +13:00
Ingo Schommer
a0f0e9bce3 Update translation.md 2013-04-04 17:44:40 +03:00
Ingo Schommer
9a52dae207 Removed LOLCAT locale from installer (fixes #1457) 2013-04-04 11:18:40 +02:00
Ingo Schommer
ed19bbc3ba Removed LOLCAT locale - sadly not supported by our translation infrastructure (fixes #1457) 
It breaks the CMS when selected. If there's interest in maintaining it, we can re-add.
 2013-04-04 11:03:37 +02:00
Ingo Schommer
0242686a7a Requirements acces to files with query strings (fixes #7735) 
Originally authored by florian.thoma, tests added
by Ingo Schommer. Also removed query params from
file paths before calling mtime() on it.

See https://github.com/silverstripe/sapphire/pull/1023
 2013-04-03 16:39:59 +02:00
Andrew Short
ceb7e3c8a8 Merge pull request #1352 from chillu/pulls/postgres-fixes 
Postgres fixes
 2013-04-03 03:50:08 -07:00
Ingo Schommer
6d5925708e FIX Empty fields on SQLQuery->aggregate() with alias 
Breaks Postgres otherwise, because it produces a
"SELECT *, <field> ... " statement without putting all
fields into the GROUP BY.
 2013-04-03 12:22:12 +02:00
Ingo Schommer
2bc273e2a8 Consistently quote DataObject::$default_sort 
Strictly speaking, no longer required since we auto-quote simple
field names in DataQuery now, but since the majority of sorts in core is
already quoted we should stay consistent.
 2013-04-03 12:11:53 +02:00
Ingo Schommer
5a8a067ae8 FIX Consistently quote orderby in DataQuery->ensureSelectContainsOrderbyColumns() 
Otherwise aggregate queries through DataQuery->column() fail unless the
passed in field is specifically quoted already. This fixes ManyManyListTest->testRemoveAll()
 2013-04-03 12:11:53 +02:00
Ingo Schommer
fb5ef0293e Clearer docs on where SQL strings are expected to be escaped already 
Also quoted some phpdoc examples, to avoid them failing by default on
stricter DB drivers like Postgres
 2013-04-03 12:11:53 +02:00
Ingo Schommer
e9d55fcaf9 Correctly quote SQL in SQLQueryTest (fixes Postgresql) 2013-04-03 12:11:52 +02:00
Ingo Schommer
ff3b63f2a9 FIX Remove unnecessary DISTINCT from ManyManyList->removeAll() 
Breaks Postgres if the innermost query has an ORDER BY statement as well
 2013-04-03 12:11:50 +02:00