Nico Haase
5fbb3da661
Enhanced tests for regeneration of images and a bugfix for images that were cached in multiple steps
2013-04-24 10:27:20 +02:00
Ingo Schommer
9eab893e7c
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
model/Image.php
2013-04-12 01:14:55 +02:00
Ingo Schommer
59dc0085d8
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
docs/en/reference/urlvariabletools.md
tests/forms/CheckboxFieldTest.php
2013-04-12 01:13:32 +02:00
Ingo Schommer
933fbf8ea4
l10n key to make "yes" and "no" translatable (see #1749 )
2013-04-12 01:11:24 +02:00
g4b0
c8e8b5147d
API: used call_user_func_array in order to have an arbitrary number of parameter for getFormattedImage ( fixes #1752 )
2013-04-11 16:51:36 +02:00
Ingo Schommer
0343a77d30
Merge remote-tracking branch 'origin/3.1'
2013-04-11 11:42:04 +02:00
Ingo Schommer
9856fcef21
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
javascript/DateField.js
model/DataQuery.php
model/Versioned.php
tests/forms/RequirementsTest.php
tests/model/DataObjectLazyLoadingTest.php
view/Requirements.php
2013-04-09 14:45:35 +02:00
Ingo Schommer
e26090a840
Avoid double encoding Date->Formati18n()
...
See https://github.com/silverstripe/sapphire/pull/1314
Thanks to @ivoba
2013-04-09 11:04:45 +02:00
Sam Minnée
a6929f11b2
Merge pull request #1185 from chillu/pulls/augment-lazy-versioned
...
Versioned lazy loading fixes (backport from 3.1)
2013-04-08 16:04:50 -07:00
Ingo Schommer
01f46d039f
NEW Enforce max node counts to avoid excessive resource usage
...
Rendering potentially 1000s of nodes can exceed the CPU and memory constraints
of a normal PHP process, as well as the rendering capabilities of browsers.
Set a hard maximum for the renderable nodes, deferring to a "show as list" action
in the main CMS tree. For TreeDropdownField, we don't have the list fallback option,
so ask the user to search for the node title instead.
Also makes both the "node_threshold_total" and "node_threshold_leaf" values configurable
2013-04-09 10:24:18 +12:00
Sam Minnée
88d77db9e0
Merge pull request #1318 from tractorcow/3.1-api-image-resampling-compatible
...
API Better detection and prevention of image resampling
2013-04-08 15:18:55 -07:00
Ingo Schommer
f296439a24
NEW Hints for scaffolded date/time fields
2013-04-08 19:38:50 +12:00
Nico Haase
8908a6bcd7
This is a fixed version for RegenerateCachedImagesTask (former FlushGeneratedImagesTask) such that it regenerates images instead of silently removing them and breaking existing pages
...
The pull request also contains some enhancements and fixes to the corresponding testcases.
Fixes #318
2013-04-06 15:56:27 +02:00
Ingo Schommer
700453b7dc
Merge pull request #1731 from wilr/open5551
...
FIX: Decimal field change detection.
2013-04-06 04:32:27 -07:00
Ingo Schommer
e2b42ca4c2
Fixed Versioned hook regression
...
Introduced by 5238e9cf48
2013-04-06 12:24:57 +02:00
Will Rossiter
e619329dc3
FIX: Decimal field change detection.
2013-04-06 23:20:28 +13:00
Will Rossiter
5238e9cf48
API: add onBeforeRollback() and onAfterRollback() hooks.
2013-04-06 22:59:33 +13:00
Will Rossiter
ddb017a6ff
API: Move LimitWordCount() to Varchar
2013-04-05 21:58:03 +13:00
Sean Harvey
65cb182c98
BUG Don't sort when deleting records in ManyManyList::removeAll()
...
This breaks databases like MSSQL which don't allow an ORDER BY with
a subquery at the same time. DELETE queries don't need to be ordered,
so we can safely remove the default.
2013-04-05 11:50:25 +13:00
Ingo Schommer
6d5925708e
FIX Empty fields on SQLQuery->aggregate() with alias
...
Breaks Postgres otherwise, because it produces a
"SELECT *, <field> ... " statement without putting all
fields into the GROUP BY.
2013-04-03 12:22:12 +02:00
Ingo Schommer
5a8a067ae8
FIX Consistently quote orderby in DataQuery->ensureSelectContainsOrderbyColumns()
...
Otherwise aggregate queries through DataQuery->column() fail unless the
passed in field is specifically quoted already. This fixes ManyManyListTest->testRemoveAll()
2013-04-03 12:11:53 +02:00
Ingo Schommer
fb5ef0293e
Clearer docs on where SQL strings are expected to be escaped already
...
Also quoted some phpdoc examples, to avoid them failing by default on
stricter DB drivers like Postgres
2013-04-03 12:11:53 +02:00
Ingo Schommer
ff3b63f2a9
FIX Remove unnecessary DISTINCT from ManyManyList->removeAll()
...
Breaks Postgres if the innermost query has an ORDER BY statement as well
2013-04-03 12:11:50 +02:00
Joseph Madden
df4d7428fa
FIX Saving of custom meta tags ( fixes #8288 )
...
This should allow custom meta tags to be saved in the admin panel.
Also, if you use html5 video or audio the source sub tag
would have been stripped two these are all the tags that may be empty
and are valid.
2013-04-02 12:02:56 +02:00
Ingo Schommer
f0d92f7bcc
Merge pull request #1094 from silverstripe-big-o/pulls/3.1-versioned-relfield
...
BUGFIX Versioned_Version->relField()
2013-04-02 02:49:27 -07:00
Ingo Schommer
ef3d974821
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
docs/en/misc/contributing/issues.md
2013-04-02 02:05:58 +02:00
Andrew Short
5ec85d06f6
API: Don't allow dots in URL segments
2013-03-30 19:47:17 +11:00
Ingo Schommer
afb8465d05
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
.travis.yml
2013-03-29 17:37:19 +01:00
Ingo Schommer
373da53826
Removed unused DataExtension::$extendable_statics
...
Oversight from cleanup in 876f4c5
2013-03-27 16:09:17 +01:00
Ingo Schommer
538bf01860
Merge remote-tracking branch 'origin/3.1'
2013-03-27 12:12:16 +01:00
Ingo Schommer
b0d3f7f3a2
Merge remote-tracking branch 'origin/3.1'
...
Conflicts:
api/RSSFeed.php
dev/SapphireTest.php
tests/control/RequestHandlingTest.php
2013-03-26 10:46:41 +01:00
Ingo Schommer
880702fc74
Fixed static config access in Currency and i18n ( fixes #8341 )
2013-03-26 10:13:51 +01:00
Simon Welsh
f175d0bf66
Merge pull request #1275 from Zauberfisch/hierarchy
...
API: Hierarchy class cleanup
2013-03-25 13:03:04 -07:00
Zauberfisch
215628a1ea
API: re factored Hierarchy class to use new ::get() syntax
...
API: removed broken & unused method Hierarchy->partialTreeAsUL()
2013-03-25 19:55:19 +00:00
Ingo Schommer
3334eafcb1
API Marked statics private, use Config API instead ( #8317 )
...
See "Static configuration properties are now immutable, you must use Config API." in the 3.1 change log for details.
2013-03-24 17:20:53 +01:00
Damian Mooyman
dd6aaaf484
ENHANCEMENT Additional image generation functions now self-determine if a modification to the underlying image backend is necessary before generating additional image files.
2013-03-21 12:15:28 +13:00
Ingo Schommer
61dbafc4e5
Merge pull request #1292 from tractorcow/3.1-validationexception-fixes
...
BUG Issue with ValidationException having blank ValidationResult
2013-03-20 03:55:42 -07:00
Ingo Schommer
4f95a07936
Removed deprecated NegationFilter tests, rewrote ExactMatchMultiFilter tests
2013-03-19 12:58:14 +01:00
Andrew Short
94f209eb74
Merge branch '3.1'
2013-03-19 22:36:47 +11:00
Andrew Short
b8a51c3792
Merge branch '3.0' into 3.1
2013-03-19 22:27:09 +11:00
Ingo Schommer
dd6f33ab37
FIX Respect tree node limits, fix search result node display
...
- Renamed $minNodeCount to more accurate $nodeCountThreshold
- The $minNodeCount attribute wasn't properly respected
during actual querying, so SilverStripe would always traverse
the entire tree (and load all objects into memory),
before then marking nodes as "unexpanded", which prevents
them from actually being rendered.
- Fixes nodes on search results to be expanded by default
- Fixes nodes on search results to correctly ajax-expand
2013-03-19 00:05:14 +01:00
Simon Welsh
5087b25a65
Allow setting the MySQL database port
2013-03-19 10:50:20 +13:00
Andrew Short
bc941c18b6
Merge branch '3.1'
2013-03-15 21:58:37 +11:00
Damian Mooyman
cd27bf71fb
BUG Enforced requirement that ValidationException::getResult() is expected to consistently produce a valid ValidationResult object.
2013-03-15 13:56:43 +13:00
Hamish Friedlander
743a186c32
API Make SSViewer#process return HTMLText not string
...
This means that you dont have to worry about casting it
as HTMLText again when using the result in a template or other context
However in some situations code might be assuming it can
check with is_string, in which case you now need to use instanceof HTMLText
2013-03-14 12:49:03 +13:00
Hamish Friedlander
cd41a536b9
NEW Let shortcodes be disabled in HTMLText & HTMLVarchar
2013-03-14 12:49:03 +13:00
Hamish Friedlander
53128c5d2f
Make ShortcodeParser use HTMLValue for HTML parsing
2013-03-14 12:49:03 +13:00
Hamish Friedlander
168f071499
API Make HTMLValue replace-able via DI
...
Extracted common code out to SS_HTMLValue and made abstract, then
put HTML 4 specific code in SS_HTML4Value. Its now possible to
replace HTMLValue with one designed for HTML 5 or XHTML
Requires a code change from new SS_HTMLValue to
Injector::inst()->create(HTMLValue)
2013-03-14 12:49:02 +13:00
Robert Curry
b9dc2dc650
Define getIDList on UnsavedRelationList
...
This is to fix a bug that caused CheckboxSetFields to throw an error
when trying to call this function when editing a new DataObject. This
occurred when using the advancedworkflow module.
Thanks to simonwelsh for the majority of the work on this fix.
2013-03-08 12:34:52 +13:00
Ingo Schommer
d57caa6477
Merge pull request #1247 from ajshort/mml-remove-filtered
...
BUG: Fix ManyManyList->removeAll() when filters are applied to the query
2013-03-04 00:55:45 -08:00