Tom Rix
6f9177ef43
MINOR fixed validation on CurrencyField. Will no longer parse non-numeric characters out of input. Added test coverage.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@97057 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-01-18 00:56:29 +00:00
Sam Minnee
2996cb39e3
MINOR: Fixed deep-nested-URLs test to work on sites in subfolders
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@96836 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-01-13 01:13:18 +00:00
Andrew Short
0c13c7a091
BUGFIX: Fixed nested URLs operation for pages more than 4 levels deep.
...
From: Andrew Short <andrewjshort@gmail.com>
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95902 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-18 05:19:28 +00:00
Sean Harvey
d8b67c4a2e
MINOR Removed whitespace from DirectorTest
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95881 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-18 03:58:36 +00:00
Sean Harvey
f2d264ce3a
ENHANCEMENT #3049 Array notation on DataObjectSet is now possible
...
MINOR Added unit tests for array notation to DataObjectSetTest
MINOR Removed commented out tests from DataObjectSet
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95876 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-18 03:35:26 +00:00
Sean Harvey
ba2066b8dd
BUGFIX Fixed undefined $this->Parent in SiteTree::getCMSFields() (from r95422)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95638 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:49:39 +00:00
Sean Harvey
bf19a704a4
BUGFIX: LessThanFilter uses SearchFilter::getDbFormattedValue, just like GreaterThanFilter (from r95388)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95637 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:49:33 +00:00
Sean Harvey
48211b4931
BUGFIX: pass $allowHTML through to the parent class (from r95339)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:49:28 +00:00
Sean Harvey
848a254da7
BUGFIX If running a BuildTask via AJAX, e.g. Filesystem::sync() is run from AssetAdmin, don't show the message "Running [task] ..." (from r95169)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95635 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:49:23 +00:00
Sean Harvey
0d1f39ff88
BUGFIX: Fix fatal error when exporting a csv from a tablefield with a custom query (from r95108)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95634 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:49:14 +00:00
Sean Harvey
b52e49dee7
BUGFIX ComplexTableField - fixed sprintf() not enough arguments when the referrer has a % character in it, the referrer is now an argument instead of being hardcoded in the string (from r95093)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95633 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:48:06 +00:00
Sean Harvey
3a982497aa
MINOR make widgetarea/editor more suitable for generic use (from r95086)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95632 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:44:20 +00:00
Sean Harvey
b1bf03ffd1
BUGFIX #4848 FileIFrameField visual problem where the preview image is hidden if the TreeDropdownField gets too long for selecting a file (from r95084)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95631 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:44:13 +00:00
Sean Harvey
2ac60298cc
MINOR: remove director rule for removed Image_Uploader in r77012 (from r95052)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95630 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:44:07 +00:00
Sean Harvey
c57ec36ea9
FEATURE: added several tests for PermissionCheckboxSetField, PermissionRole and Group (from r94887)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95629 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:43:59 +00:00
Sean Harvey
bb14045626
BUGFIX Fixed ModelAsController::findOldPage() failing on MSSQLDatabase using "sqlsrv" driver (from r94885)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:43:54 +00:00
Sean Harvey
d459e17288
BUGFIX: adding onAfterDelete hooks to remove the no longer necessary permissions (from r94859)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95627 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:43:47 +00:00
Sean Harvey
d8017fe459
MINOR: added comment (from r94856)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95626 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:43:40 +00:00
Sean Harvey
ca45cbe7e2
BUGFIX: orphaned permissions and subsite administrator groups were causing trouble - now with the JOIN the first global administrator group is picked up when ussing the override login. (from r94835)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95625 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:43:35 +00:00
Sean Harvey
14c66fb2f8
BUGFIX: removing permissions before re-applying them (previously it just removed the components on the relation which resulted in permissions having GroupID set to 0) (from r94810)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95624 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:43:20 +00:00
Sean Harvey
5be077cd83
BUGFIX: fixed typing error (from r94721)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95623 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:43:02 +00:00
Sean Harvey
439ca0e466
MINOR: test support for superglobals in testrequest (from r94711)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95622 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:56 +00:00
Sean Harvey
775945d197
MINOR: test support for superglobals in testrequest (from r94710)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95621 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:50 +00:00
Sean Harvey
e64443b50d
MINOR: added cookies to Director::test() (from r94684)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95620 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:43 +00:00
Sean Harvey
8b0a41d60d
MINOR: Added db-fixture creation for cucumber-based testing (from r94528)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95619 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:35 +00:00
Sean Harvey
d1e5f7dc91
ENHANCEMENT: Improved layout of altercation message when called via CLI. Patch via simon_w #4373 (from r94515)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:21 +00:00
Sean Harvey
f663e4f949
BUGFIX: Fix fileiframefields dying when an image is attached and a folder is expanded via ajax (from r94461)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95617 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:15 +00:00
Sean Harvey
4aa35e8a1a
BUGFIX: fixed closing action on profiler popup (from r94443)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:00 +00:00
Sean Harvey
3aa391afdf
MINOR: removed duplicate writes for performance (from r94438)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95615 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:41:44 +00:00
Sean Harvey
395f87f545
BUGFIX: include customHeadScripts in clear rule. (from r94437)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95614 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:41:38 +00:00
Sean Harvey
27d7a48bed
MINOR: Don't use test manifest for dev/startsession and dev/endsession (from r93528) (from r94431) (from r94432)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:41:14 +00:00
Sean Harvey
c0db452069
APICHANGE: Group::addByGroupName() now creates the group if one does not already exist (from r83010) (from r94430)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:41:08 +00:00
Sean Harvey
96fdef27bd
MINOR: Added small fixture YML that just lets you log in, for bootstrapping browser automation tests. (from r94429)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:59 +00:00
Sean Harvey
b79c2149d9
ENHANCEMENT Allow passing in an Exception object to SS_Log::log() in addition to an array describing the error context (line number, file, trace etc) (from r94423)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95609 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:52 +00:00
Sean Harvey
99c4609806
MINOR Fixed misspelled acronym for "Cross-site request forgery" (from r94420)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:46 +00:00
Sean Harvey
3665c59fff
MINOR Documentation updates to SS_Log (from r94418)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:40 +00:00
Sean Harvey
ec20c7a425
BUGFIX Fixed undefined function error ip2country() in Geoip::ipcountry_check() (from r94416)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95606 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:34 +00:00
Sean Harvey
63ce0bd4ec
ENHANCEMENT Added FunctionalTest::findAttribute() as a helper for getting an attribute from a SimpleXMLElement object by it's name (from r94381)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:27 +00:00
Sean Harvey
92439f2a1d
BUGFIX: match returns null on not-found, querying raw.length resulted in an error. Now it's possible to add links to the page again. (from r94378)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:20 +00:00
Sean Harvey
298ef035ed
BUGFIX: Make sure findAnAdministrator gets a global administrator when subsites is installed. (from r94369)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:05 +00:00
Sean Harvey
69cda024ab
MINOR Added tests methods for Member::can*() methods to MemberTest
...
MINOR Added test Extension classes for testing decorated can*() methods (from r94359)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:39:57 +00:00
Sean Harvey
35628832d6
BUGFIX #4686 Fixed $member non-object error, and decorated checks from not working in Member::canView(), Member::canEdit() and Member::canDelete()
...
MINOR Added additional tests to MemberTest (from r94358)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95601 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:39:39 +00:00
Sean Harvey
eb25344862
BUGFIX #4566 Time::Nice() and Time::Nice24() return bad results if there is no value (from r94353)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:39:23 +00:00
Sean Harvey
afb06e4a80
MINOR #4973 Automatically generate URLSegment for default records on SiteTree and ErrorPage instead of explicitly setting them (from r94352)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:39:09 +00:00
Sean Harvey
e615db96d7
BUGFIX: Don't throw a notice-level error if you access a setting that hasn't been set yet. (from r94349)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:38:56 +00:00
Sean Harvey
424ad27d08
MINOR: Tweak to test name display on the test runner (from r94336)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:38:42 +00:00
Sean Harvey
1548eab100
BUGFIX: convert ImageFormAction form prototype syntax to jQuery syntax, merged from r94304 (from r94332)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:38:28 +00:00
Sean Harvey
c817f45bb7
BUGFIX: allow checkboxes to catch clicks (ticket #4737 ) (from r93069) (from r94323)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95595 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:38:15 +00:00
Sean Harvey
f7dfa4d2bc
BUGFIX Fixed undefined calls to URL() in SimpleImageField, replacing them with getURL() instead (from r94301)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:37:58 +00:00
Sean Harvey
bf9358ee46
FEATURE Added DataObjectSet::emptyItems() to remove all the items from the set - this is useful for when you are augmenting CMS and front end fields via updateCMSFields() and updateFrontEndFields() on a DataObjectDecorator (from r94297)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:37:50 +00:00