Sean Harvey
38f3f23614
Merge pull request #314 from silverstripe-scienceninjas/bugfixes/php-peg
...
Bugfixes/php peg
2012-04-13 16:55:58 -07:00
Ingo Schommer
3572b31a94
MINOR Default app title when SiteConfig object is not present ( fixes #7114 )
2012-04-13 16:21:30 +02:00
Ingo Schommer
2db0be6cc0
Merge pull request #313 from halkyon/sapphire
...
---
Re-enable E_STRICT after it was temporarily turned off.
Additionally, this fixes "class SS_Log not found" errors by explicitly requiring the required debugging classes in Core.php bootstrap code, because `SS_ClassLoader::registerAutoloader()` cant always guarantee that at the time the strict error was issued the Debug/Log classes were loaded yet.
This should be pulled *after* this issue is fixed: http://open.silverstripe.org/ticket/7135 which allieviates the problem of changing every `getCMSFields` method when upgrading because of the parameter differences.
2012-04-13 15:56:57 +02:00
Ingo Schommer
8ba9c3ca6b
API CHANGE Removed $params argument to DataObject->getCMSFields(), please use FormScaffolder directly ( fixes #7135 )
2012-04-13 15:46:47 +02:00
Ingo Schommer
0f8a6999a1
MINOR Passing rendered form to renderWith() call, underlying logic changed (see #7136 )
2012-04-13 15:35:46 +02:00
Ingo Schommer
6e872c34d4
Merge pull request #311 from silverstripe-scienceninjas/sapphire
...
---
Fixes http://open.silverstripe.org/ticket/7136
2012-04-13 15:32:13 +02:00
Ingo Schommer
1e2d8160f8
MINOR HTML5 for BlankPage.ss default template
2012-04-13 15:32:05 +02:00
Will Rossiter
1701de8c6f
Merge pull request #315 from silverstripe-big-o/breadcrumbs-tabs-overflow-Trac6882
...
ENHANCEMENT: Breadcrumbs tabs overflow. Fixes 6882.
2012-04-12 22:52:19 -07:00
Jeremy Bridson
20aeb76979
BUGFIX:fixed overflow issues in cms-content-header with back button / breadcrumbs / tabs
2012-04-13 16:08:05 +12:00
Jeremy Bridson
6a7668fefb
ENHANCEMENT:Trac 6882 - created include template for back button and altered the templates accordingly
2012-04-13 16:06:15 +12:00
Hamish Friedlander
fc5592ef17
MINOR: PHP-PEG is now triple licensed under BSD, MPL and GPL by request
2012-04-13 15:33:12 +12:00
Hamish Friedlander
7ae9f8af84
BUGFIX: match_function had been partially refactored to take $value as an argument rather than from the instance variable, but that hadnt been completed, causing problems with E_STRICT. This completes that refactoring.
2012-04-13 15:33:12 +12:00
Sean Harvey
6d9732435d
Merge pull request #312 from robert-h-curry/7131-php-version-requirement
...
ENHANCEMENT: Change PHP version requirements. Part of #7131 .
2012-04-12 18:33:25 -07:00
Sean Harvey
6db8f85450
API CHANGE Enable E_STRICT, but include DebugView, Log classes as these are not always guaranteed to be loaded by ClassLoader at the time a strict error is issued.
2012-04-13 13:23:26 +12:00
Robert Curry
8b0dafb30d
ENHANCEMENT: Change PHP version requirements. Part of #7131 .
2012-04-13 13:12:48 +12:00
Hamish Friedlander
521742aaf8
ENHANCEMENT: Split arguments passed to SSViewer into underlay and overlay arguments to control precedence. Also fixes breakage of SecurityAdmin
2012-04-13 12:15:34 +12:00
Sean Harvey
aa14a5191e
MINOR Temporarily disabled E_STRICT until we can solve Debug issues with
...
SS error handler
2012-04-13 12:03:01 +12:00
Ingo Schommer
e2df1f4c5f
MINOR Removed $('.cms-content').loadForm(), its very similar to loadPanel() - accepts callbacks, but that's not specific to forms. Listen to 'afterstatechange' rather than 'loadform' events
2012-04-12 23:53:14 +02:00
Ingo Schommer
b025b95ede
ENHANCEMENT Lazy-loading image and link dialogs for HtmlEditorField, to avoid unnecessary processing overhead on initial CMS load (also means they'll never get loaded if not required, e.g. in ReportAdmin)
2012-04-12 23:53:12 +02:00
Ingo Schommer
c73b80049a
MINOR Removed usage of deprecated Object::uninherited_static() in core, improves CMS loading speed in live mode by ~3.5%
2012-04-12 18:26:56 +02:00
Ingo Schommer
0fd7ce6a1e
MINOR Added PJAX and ajax redirect documentation to cms-archirecture reference guide
2012-04-12 12:53:19 +02:00
Ingo Schommer
5cfbac63a2
MINOR Fixed PJAX panel loading when .cms-content is a split panel with tree and form view (regression caused by 452a507cc9
)
2012-04-12 12:29:20 +02:00
Ingo Schommer
5070cb3a8b
Merge pull request #308 from mateusz/sapphire
...
---
Ref: http://open.silverstripe.org/ticket/6175
Can you review this please and let me know if this is helpful?
Ive attempted to clean up the multitude of the caches on the DataObject, and make them at least more consistent and more visible - although I didnt try to merge them or refactor the code to eliminate them.
Have also explicitly deprecated setComponent - it manipulates "componentCache" which to my eye is no longer used anywhere, and can cause some hidden surprises for people out there. Fixed related CsvBulkLoader problem which was still using setComponent.
Removed $cache_buildSQL_query and $_cache_custom_database_fields, which were not used.
Fixed DataObject::reset to clean all global caches, and DataObject::flushCache to flush the component cache. Both now are doing what it says on the box.
The problem reported in ticket 6175 can now be fixed by doing $this->flushCache(); after the setting the has_one and writing.
Comments welcome :)
2012-04-12 11:34:16 +02:00
Simon Welsh
b4e155258f
API-CHANGE Move tinymce plugins in thirdparty
2012-04-12 20:47:57 +12:00
Sam Minnee
9fdcf345e4
MINOR: Updated PHP requirement in docs ( #7129 )
2012-04-12 18:22:44 +12:00
Sam Minnée
977e9f3576
Merge pull request #306 from silverstripe-big-o/report-fixes
...
API-CHANGE: new GridFieldFooter component
2012-04-11 22:30:10 -07:00
Mateusz Uzdowski
ae5bd7d65e
ENHANCEMENT: refer to cache statics explicitly via DataObject (os6175)
...
Unify the usage across the class. Since the intention is to have a
single site-wide cache, calling via DataObject seems to be a better
option - self could theoretically end up calling a redefined field from
a subclass.
2012-04-12 17:04:24 +12:00
Mateusz Uzdowski
5186a0cea3
BUGFIX: remove unnecessary setComponent call - no longer used (os6175)
2012-04-12 17:04:24 +12:00
Mateusz Uzdowski
aedadebae6
BUGFIX: adjust the cache flush and reset functions to cover all caches (os6175)
2012-04-12 17:04:22 +12:00
Mateusz Uzdowski
8ea2460e50
BUGFIX: make internal DataObject caches more consistent (os6175)
2012-04-12 17:03:18 +12:00
Mateusz Uzdowski
621b2e1888
APICHANGE: deprecate DataObject::setComponent, no longer does anything.
2012-04-12 17:02:09 +12:00
Sam Minnée
66ee494fc2
Merge pull request #307 from halkyon/date_changes
...
MINOR Testing extended dates (very far in the past and future) in DateTest
2012-04-11 21:57:26 -07:00
Sean Harvey
b52c6b4f2b
MINOR Testing extended dates (very far in the past and future) in
...
DateTest
2012-04-12 16:38:35 +12:00
Mateusz Uzdowski
360e9df54e
MINOR: fix typo
2012-04-12 16:22:36 +12:00
Julian Seidenberg
e9dc610448
API-CHANGE: new GridFieldFooter component
2012-04-12 16:13:47 +12:00
Sam Minnée
21f7eb19e4
Merge pull request #305 from halkyon/e_strict_fixes
...
php-peg E_STRICT fixes
2012-04-11 20:15:53 -07:00
Sean Harvey
0dd4d4386e
BUGFIX php-peg E_STRICT fixes
2012-04-12 14:58:21 +12:00
Sam Minnee
77c95b3434
MINOR: Hamish is all class. ;-)
2012-04-12 13:19:48 +12:00
Sam Minnée
d766100335
Merge pull request #304 from halkyon/e_strict_fixes
...
Enable E_STRICT by default for development, fix all E_STRICT errors affected by tests.
2012-04-11 17:54:18 -07:00
Sam Minnee
aa659a2326
MINOR: Fixed classname displayed in Hierarchy::markChildren() error. ( #4406 )
2012-04-12 12:38:07 +12:00
Sean Harvey
2b8e14fdff
API CHANGE Fixing CompositeField/SelectionGroup
...
performReadonlyTransformation and performDisabledTransformation to be
consistent and conform with parent FormField. $trans argument is no longer allowed, just uses
DisabledTransformation or ReadonlyTransformation instead.
2012-04-12 12:24:06 +12:00
Sean Harvey
852ffcf492
MINOR MemberDatetimeOptionsetField::validate() now passes in $validator argument instead of getting it from the form, which is how other FormFields work like CompositeField
2012-04-12 12:23:18 +12:00
Sean Harvey
3c70ea4922
MINOR Fixing broken test MemberDatetimeOptionsetFieldTest, passing in null for $validator argument
2012-04-12 12:20:18 +12:00
Sam Minnée
1189322b41
Merge pull request #302 from robert-h-curry/7113-nested-controls-breaking-last
...
BUGFIX: Issue #7113 : Recalculate itemIteratorCount when popping viewer state.
2012-04-11 17:19:46 -07:00
Sean Harvey
865cde0c39
BUGFIX FormField::name_to_label() is now declared as static as it was never used as an instance method
...
API CHANGE FormField::validate() $validator argument is now required for FormField classes
2012-04-12 12:18:55 +12:00
Sean Harvey
8369cded32
MINOR Code formatting in EmailField
2012-04-12 12:17:30 +12:00
Sean Harvey
1e61b76ca8
MINOR ConfirmedPasswordField::validate() now passes in $validator
...
argument instead of getting it from the form, which is how other
FormFields work like CompositeField
2012-04-12 12:14:42 +12:00
Sean Harvey
859f7add20
MINOR TableField_Item::Fields() now conforms to parent
...
TableListField_Item::Fields() for E_STRICT compliance
2012-04-12 12:13:22 +12:00
Sean Harvey
42988ecb18
BUGFIX Argument hinting of FormField instance for TabSet::push() to
...
comply with parent CompositeField::push() for E_STRICT compliance
2012-04-12 12:11:53 +12:00
Sean Harvey
9cf1686786
MINOR Code formatting fixes for CurrencyField
2012-04-12 12:11:22 +12:00