Commit Graph

8053 Commits

Author SHA1 Message Date
Ingo Schommer
6517f4496b Merge pull request #273 from ajoneil/sapphire
---

This allows DataList::create(SiteTree) as equivalent to Object::create(DataList, SiteTree), without
having to have a create() function on DataList.

Required for E_STRICT compliance, as child classes cant override create() if they change the arguments.

DBField::create() is also renamed to DBField::create_field(), as this does not just call the constructor, which all other cases of create() do.

Conflicts:
	tests/model/DateTest.php
	tests/model/DatetimeTest.php
2012-04-04 16:48:16 +02:00
Ingo Schommer
ac6f9e9987 MINOR Normalize trailing slashes in X-ControllerURL handling to avoid double requests caused by SS_HTTPRequest modifying the original URL (removing trailing slash etc) 2012-04-04 16:47:14 +02:00
Ingo Schommer
c2b741642e MINOR Moved X-ControllerURL handling into global ajax response handlers to avoid code duplication 2012-04-04 16:47:13 +02:00
Ingo Schommer
0414e42bbc MINOR Keep X-ControllerURL canonical by not re-constructing with question mark if there's no GET string (caused duplicate HTML5 pushState requests) 2012-04-04 16:47:13 +02:00
Ingo Schommer
af80ab5ab7 Merge pull request #282 from halkyon/php52_references
Removed checks for versions less than PHP 5.3
2012-04-04 07:47:04 -07:00
Sean Harvey
076f1a83f4 BUGFIX Fixed GridField edit link appearing 9999px off screen, should not be visible as the icon replaces the link text. 2012-04-04 16:00:56 +12:00
Sean Harvey
707777812f Merge pull request #287 from unclecheese/patch-1
Using deprecated StringField::Upper() and StringField::Lower(). Calling ...
2012-04-03 15:15:03 -07:00
unclecheese
59706d5bf5 Using deprecated StringField::Upper() and StringField::Lower(). Calling $MyEnumField.Upper on the template returns an unresolvable deprecation error. 2012-04-03 15:58:17 -03:00
Ingo Schommer
58d6f15b7e Merge pull request #285 from halkyon/debugview_changes
Adjusted wording in DebugView for E_DEPRECATED and E_USER_DEPRECATED error levels
2012-04-03 03:02:56 -07:00
Will Rossiter
1996089b8b Merge pull request #286 from drzax/forms
ENHANCEMENT: Heading level updatable on heading form fields.
2012-04-02 23:22:23 -07:00
Simon Elvery
429ff64d7c Merge branch 'master' of https://github.com/silverstripe/sapphire.git into forms 2012-04-03 15:06:23 +10:00
Simon Elvery
68db977ef1 MINOR: Provide a setter for heading level on HeaderField object. 2012-04-03 15:05:21 +10:00
Sean Harvey
f8a6db8d31 MINOR Temporarily reverted X-ControllerURL push state, as the header doesn't get set
correctly in LeftAndMain::handleRequest() correctly. This fixes saving
pages until X-ControllerURL has been corrected.
2012-04-03 11:29:44 +12:00
Sean Harvey
349019e780 MINOR Adjusted wording based on E_DEPRECATED and E_USER_DEPRECATED error levels. 2012-04-03 10:28:07 +12:00
Sean Harvey
68aaae8cc0 MINOR Update docs and version checking for PHP 5.3+ 2012-04-03 09:54:55 +12:00
Sean Harvey
58e912d4d7 MINOR Removed check for PHP versions less than 5.2 in Cookie 2012-04-03 09:54:55 +12:00
Sean Harvey
db65704639 MINOR Removed PHP 5.2 check in DateTest 2012-04-03 09:54:55 +12:00
Sean Harvey
a2979f0551 BUGFIX Ensure that origLayoutClasses is always an array when considered
empty, as join() will be called later and causes a JS error on an empty
string.
2012-04-02 14:29:02 +12:00
Sean Harvey
89267419d4 BUGFIX When inserting an image in HtmlEditorField, don't append "px" as
the width and height attributes only accept a number without a unit
2012-04-02 14:10:20 +12:00
Stig Lindqvist
8913bf7b05 Merge pull request #281 from halkyon/json_changes
Use built-in json functions in PHP instead of third-party Services_JSON library
2012-03-30 17:36:08 -07:00
Sean Harvey
c52f75e319 MINOR Add notes on upgrading for Convert::json2array() changes 2012-03-31 13:35:01 +13:00
Sean Harvey
dbc4be3e94 API CHANGE Removed Services_JSON library, as we use the built-in json functions instead. 2012-03-31 13:20:19 +13:00
Sean Harvey
8ae474b182 API CHANGE Remove use of Services_JSON and replace with json_encode() and json_decode()
API CHANGE Convert::json2array() will convert nested JSON structures to array as well for easier traversal, instead of array with nested objects.
2012-03-31 13:17:36 +13:00
Will Rossiter
18a1cc1db3 MINOR: update docs to fix issues raised via comments. MINOR: remove section on comments. 2012-03-31 09:03:54 +13:00
Ingo Schommer
7c1b40d4a7 MINOR Added 'updateCMSFields' hook to File (fixes #7091) 2012-03-30 16:55:44 +02:00
Ingo Schommer
6c91aa0ec5 BUGFIX Force referer via "BackURL" POST data in CMS to work around IE problems with sending the base URL as the referer instead of the actual one (#7002) 2012-03-30 16:51:43 +02:00
Ingo Schommer
1091c7b944 BUGFIX Don't replace pushState() if emulated, as it will re-load the new URL via ajax, effectively duplicating every request in IE (#7002) 2012-03-30 16:51:43 +02:00
Ingo Schommer
83adffd7cd MINOR Fixed var names in LeftAndMain.js 2012-03-30 16:51:42 +02:00
Ingo Schommer
e6aa9ae017 BUGFIX Fixed History.js library handling of relative URLs combined with a base URL (was causing infinite loops, e.g. /admin/#/admin/admin/admin/security) (#7002) 2012-03-30 16:51:42 +02:00
Ingo Schommer
f34e58f573 ENHANCEMENT Enabled History.pushState() support in IE via onhashchange fallbacks (#7002) 2012-03-30 16:51:42 +02:00
Ingo Schommer
3f4aba5545 MINOR Avoid breaking IE on CMS ajax responses which don't contain CSS class names (splitting on NULL) (#7002) 2012-03-30 16:51:42 +02:00
Ingo Schommer
c518a19ec2 BUGFIX Replaced logic for checking external URLs in CMS Menu with more stable jQuery Mobile codebase (fixes problems on IE not loading menu entries via ajax) (#7002) 2012-03-30 16:51:42 +02:00
Sam Minnee
58433d38ce BUGFIX: Tidied up relObject() behaviour on DataLists to restore broken SearchContext functionality. 2012-03-30 15:59:57 +13:00
Ingo Schommer
c56176c5d5 MINOR Updated 'from-source' installation to use new 'simple' theme (which also fixes the problem of checking out 'blackcandy' sub themes via git into overlapping repository paths) 2012-03-28 22:55:44 +02:00
Ingo Schommer
d0d23dc591 Merge pull request #271 from halkyon/group_changes
BUGFIX Nested Group records should be removed, along with the parent.
2012-03-28 02:52:52 -07:00
Sean Harvey
bd95bcaf61 BUGFIX Nested Group records should be removed, along with the parent. 2012-03-28 22:49:58 +13:00
Ingo Schommer
f0ee711f52 Merge pull request #275 from halkyon/e_strict_support
First round of fixes for E_STRICT compliance
2012-03-28 02:42:26 -07:00
Sean Harvey
e097f6e1a8 MINOR Fixes to method arguments in core classes for E_STRICT support.
API CHANGE Remove abstract static function and just use static functions
in Authenticator (PHP 5.3+ doesn't support abstract static functions)
2012-03-28 22:41:42 +13:00
Ingo Schommer
f81ad47239 Merge pull request #272 from halkyon/date_fixes
DateField::setValue() with dmyfields sets erroneous date in valueObj
2012-03-28 02:38:03 -07:00
Ingo Schommer
2ecfbc49f5 Merge pull request #276 from halkyon/e_deprecated_fixes
E_DEPRECATED fixes - split() replaced with preg_split()
2012-03-28 02:31:04 -07:00
Sean Harvey
e0dc3aaf21 Merge pull request #278 from silverstripe-scienceninjas/install-and-php5-ini-settings
BUGFIX The SilverStripe installer throwing warning on settings that was okey
2012-03-28 02:20:27 -07:00
Stig Lindqvist
1a81c3de27 BUGFIX The SilverStripe installer throwing warning on settings that was legit. 2012-03-28 17:56:57 +13:00
Sean Harvey
86b805d03c Merge pull request #241 from oddnoc/date-default-timezone-for-tests
Set UTC timezone for SapphireTest
2012-03-27 13:35:39 -07:00
Fred Condo
5954774530 BUGFIX: Use UTC consistently across all tests for date/time calculations
This ensures that tests will not pass or fail based on whether the test
machine is on NZ time.

This partially reverts df050eda5d, which has
already been merged. Instead of finding tests that use date calculations, we
are now setting the default time zone in SapphireTest so it will apply to the
whole test suite and any future tests.

Adjust expected values in certain tests for UTC, where the expected values had
previously been expressed in NZ time.

When creating a temp DB for test fixtures, create the DB connection with
timezone UTC.
2012-03-27 10:29:07 -07:00
Fred Condo
82bb12b5d3 MINOR: Explicitly declare $adapter in DbDatetimeTest 2012-03-27 10:28:10 -07:00
Ingo Schommer
cbb0259dd7 Merge branch 'integration-merge27march' 2012-03-27 18:07:21 +02:00
Ingo Schommer
66093f71ac MINOR Fixed one-off button height inconsistencies (fixes #6980) 2012-03-27 17:07:52 +02:00
Ingo Schommer
6d423fe9ee MINOR Moved AssetUploadField iframe margins into iframe body itself to avoid width conflicts, override default .cms overflow behaviour to ensure the iframe content as a whole stays scrollable (fixes #7003) 2012-03-27 17:07:52 +02:00
Ingo Schommer
3ef3a6df99 MINOR Shrinking GridField button column to fit, rather than hardcoding a width for it that depends on the amount and styling of buttons in the table 2012-03-27 17:07:52 +02:00
Ingo Schommer
efc30fd39e MINOR Removed setRightTitle() special case (and too specific styling) from Group->getCMSFields(), implemented title attribute for chosen.js drop downs instead (to be styled with more friendly title popovers) 2012-03-27 17:07:50 +02:00