Sean Harvey
9e7abebd4c
MINOR comment changes to allow better readability of comments of what we're testing
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61482 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-25 08:27:16 +00:00
Sean Harvey
5c3379a612
MINOR Additions to FieldSetTest to test removeByName() and removeFieldsFromTab()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61481 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-25 08:15:22 +00:00
Sam Minnee
5fb17f1eca
Improved File tests
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61462 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-25 01:42:27 +00:00
Sam Minnee
63224005f5
Fixed coverage reporting on test runner
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61461 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-25 01:41:58 +00:00
Will Rossiter
489ee9aba5
FEATURE: xml2array now works with recursion so it will actually work with most xml files. Unit tests to comei
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-24 23:39:32 +00:00
Sean Harvey
bb0dd22164
ENHANCEMENT RequiredFields->php() uses quotes around title of field, falling back to the name of the field if title isn't available
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 04:16:33 +00:00
Sean Harvey
5fd0464b68
ENHANCEMENT Added LowerCase() to DBField to return the raw2xml converted value as lower case for any type of field if applicable
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61415 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 03:36:00 +00:00
Sam Minnee
65604f4ab6
Fixed saving of TableField and added tests
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61411 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 03:33:43 +00:00
Sam Minnee
fb822a0924
Better error message if you have forgotten to set fixture_file
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61410 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 03:33:25 +00:00
Sean Harvey
8f51649160
BUGFIX SetHeight() was calling SetWidth using getFormattedImage()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61395 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 03:05:28 +00:00
Sean Harvey
5893ac0a03
ENHANCEMENT Added SetHeight() to the Image class, so we can call it from the templates
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61394 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 03:03:57 +00:00
Sean Harvey
c05ea7f653
ENHANCEMENT Added SetSize() to the Image class so we can use it in the templates
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61392 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 03:03:20 +00:00
Sam Minnee
8505039954
Undeprecated a critical feature of TableField, and reimplemented in the Group's permission field. Cleaned up its implementation to be more in line with TableListField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61370 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 00:47:36 +00:00
Sam Minnee
73be80c2e5
Fixed display of Permission dropdown in SecurityAdmin
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61351 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-21 23:45:21 +00:00
Will Rossiter
288433e962
Fixed bug with manifest generation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61344 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-21 23:30:16 +00:00
Will Rossiter
e085ee19d7
BUGFIX: fixed ManyMany relation for same object
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61292 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-21 05:30:49 +00:00
Romain Louis
5689ec0caa
MINOR setRelationAutoSetting function adding
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61217 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 22:47:46 +00:00
Sean Harvey
121b3436f0
BUGFIX Reverted change r61158 which stopped scrollbars working
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61202 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 20:56:59 +00:00
Sam Minnee
0e1289bdf2
Merged branches/kiwiselect into trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61184 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 06:31:12 +00:00
Sean Harvey
7912aa3b4a
MINOR Fixed PHP notice in CheckboxSetField when transforming to readonly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61164 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:16:30 +00:00
Sean Harvey
09af15d382
BUGFIX sourceFilter should be a string, not an array
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61162 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:13:53 +00:00
Sean Harvey
3ae2a7e605
MINOR PHPdoc for FieldSet->replaceField()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61161 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:11:07 +00:00
Sean Harvey
700cb7c68b
MINOR PHP notice fix for FileIFrameField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61160 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:10:15 +00:00
Sean Harvey
d69c3d6a1a
ENHANCEMENT Added FieldSet->removeFieldsFromTab() which does exactly what removeFieldFromTab() does, but with an array of field names
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:03:50 +00:00
Sean Harvey
2b49d18350
BUGFIX HtmlEditorField_Toolbar->LinkForm() for editing a link inside an HtmlEditorField instance was showing page titles using the "Title"
...
field, changed to "MenuTitle" to be consistent with the main CMS site tree and to avoid confusion
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61155 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:57:55 +00:00
Sean Harvey
1f846970c3
ENHANCEMENT Director::forceSSL() redirects are now 301 instead of 302 redirects, which is better for SEO
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:54:24 +00:00
Sean Harvey
41c9d5692e
ENHANCEMENT ErrorPage:: should also list ShowInSearch as 0, since it is not required to be searched
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61153 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:48:44 +00:00
Sam Minnee
c4b358e26e
Work to decouple the ManifestBuilder from the database, so that you can run manifest builder tests without an active database existing
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61152 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:47:48 +00:00
Sean Harvey
29ccb18fac
BUGFIX ComplexTableField_popup.css "overflow: auto" should only be applied to the container HTML element instead of HTML and BODY which can
...
introduce double scrolling and thus poor usability
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61151 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:44:24 +00:00
Sean Harvey
7f6be42004
ENHANCEMENT Added getter method for CompositeField->children
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61149 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:41:55 +00:00
Sean Harvey
dc5607d8f0
ENHANCEMENT If title not passed into TextareaField constructor, it defaults to the name value
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61147 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:36:45 +00:00
Saophalkun Ponlu
cad9147916
Fixed bug with CsvBulkLoader
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61136 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:01:41 +00:00
Saophalkun Ponlu
f6754178d9
uncommmented processRecord that process each record because it was mistakenly commented previously
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61135 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 03:55:23 +00:00
Saophalkun Ponlu
727a1f52fc
change the return type of processAll of CsvBulkLoader from DataObjectSet to int, the number of affected row
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61122 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 02:38:45 +00:00
Saophalkun Ponlu
802b93be2e
modified csv import function documention. It returns number of affected records.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61120 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 02:29:37 +00:00
Sam Minnee
ed07c0acf2
Made some methods on SearchFilter public so that SearchFilters can be co-opted for other purposes. Really, moving the magic to a DataQuery object would be better
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:09:28 +00:00
Sam Minnee
ec9a40ee50
Fixed bug in TableListField sort links
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61065 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:07:28 +00:00
Sam Minnee
292140897a
Allow querystrings in arguments passed to Controller::join_links()
...
Fix FormField::Link() to allow querystrings in the form's action
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61064 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:06:43 +00:00
Sam Minnee
23d6fb8952
Turn off default caching
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61063 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:05:52 +00:00
Sean Harvey
aca28b981b
MINOR Added FieldSetTest to the test library
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60949 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 05:13:46 +00:00
Saophalkun Ponlu
505fef0791
Removed double quoute from the from fields as it means field terminator
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 04:23:24 +00:00
Will Rossiter
900baba303
BUGFIX: #1458 - GEOIP now does not return any error if it cannot look up the ip address (as it uses a shell command this is not enabled on many WAMP systems)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60920 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 03:13:40 +00:00
Sam Minnee
8d62fbf1aa
Fixed bug in Member::mapInCMSGroups()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60912 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:51:55 +00:00
Sam Minnee
53cc576dab
Reverted Folder::CanEdit() to its original behaviour; that of returning a many-many join. Note that this conflicts with DataObject::CanEdit() now.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60911 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:51:35 +00:00
Sam Minnee
3fe588bbf5
Added ComplexTableField::getCustomFieldsFor() that you can overload in subclasses of ComplexTableField to create alternative pop-up forms
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60910 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:50:39 +00:00
Sam Minnee
2d0233f2b1
Added table references to many-many join used by scaffolder, to remove 'ambiguous column' bugs
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:49:44 +00:00
Saophalkun Ponlu
ffb5d82bc2
replaced <br /> with newline for CSV export
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:41:38 +00:00
Sam Minnee
75ae9859ae
API CHANGE: Added Validator::set_javascript_validation_handler() and ->setJavscriptValidatorHandler(), to choose a different way of dealing with javascript validation. Currently 'none' and 'prototype' are the only legal options, but 'jquery' would be an obvious thing to implement.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60894 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:07:37 +00:00
Sam Minnee
b4c593e63d
Added warnings for parts of Member that require the newsletter module. Note that this code should really be moved to the newsletter module at some stage.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60885 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-17 22:24:57 +00:00
Sam Minnee
76797cc5e1
Made all sapphire/thirdparty classes _manifest_exclude'd
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60874 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-17 01:08:10 +00:00