Commit Graph

554 Commits

Author SHA1 Message Date
Ingo Schommer
6517f4496b Merge pull request #273 from ajoneil/sapphire
---

This allows DataList::create(SiteTree) as equivalent to Object::create(DataList, SiteTree), without
having to have a create() function on DataList.

Required for E_STRICT compliance, as child classes cant override create() if they change the arguments.

DBField::create() is also renamed to DBField::create_field(), as this does not just call the constructor, which all other cases of create() do.

Conflicts:
	tests/model/DateTest.php
	tests/model/DatetimeTest.php
2012-04-04 16:48:16 +02:00
Ingo Schommer
ac6f9e9987 MINOR Normalize trailing slashes in X-ControllerURL handling to avoid double requests caused by SS_HTTPRequest modifying the original URL (removing trailing slash etc) 2012-04-04 16:47:14 +02:00
Ingo Schommer
c2b741642e MINOR Moved X-ControllerURL handling into global ajax response handlers to avoid code duplication 2012-04-04 16:47:13 +02:00
Ingo Schommer
0414e42bbc MINOR Keep X-ControllerURL canonical by not re-constructing with question mark if there's no GET string (caused duplicate HTML5 pushState requests) 2012-04-04 16:47:13 +02:00
Sean Harvey
f8a6db8d31 MINOR Temporarily reverted X-ControllerURL push state, as the header doesn't get set
correctly in LeftAndMain::handleRequest() correctly. This fixes saving
pages until X-ControllerURL has been corrected.
2012-04-03 11:29:44 +12:00
Sean Harvey
a2979f0551 BUGFIX Ensure that origLayoutClasses is always an array when considered
empty, as join() will be called later and causes a JS error on an empty
string.
2012-04-02 14:29:02 +12:00
Ingo Schommer
6c91aa0ec5 BUGFIX Force referer via "BackURL" POST data in CMS to work around IE problems with sending the base URL as the referer instead of the actual one (#7002) 2012-03-30 16:51:43 +02:00
Ingo Schommer
1091c7b944 BUGFIX Don't replace pushState() if emulated, as it will re-load the new URL via ajax, effectively duplicating every request in IE (#7002) 2012-03-30 16:51:43 +02:00
Ingo Schommer
83adffd7cd MINOR Fixed var names in LeftAndMain.js 2012-03-30 16:51:42 +02:00
Ingo Schommer
e6aa9ae017 BUGFIX Fixed History.js library handling of relative URLs combined with a base URL (was causing infinite loops, e.g. /admin/#/admin/admin/admin/security) (#7002) 2012-03-30 16:51:42 +02:00
Ingo Schommer
f34e58f573 ENHANCEMENT Enabled History.pushState() support in IE via onhashchange fallbacks (#7002) 2012-03-30 16:51:42 +02:00
Ingo Schommer
3f4aba5545 MINOR Avoid breaking IE on CMS ajax responses which don't contain CSS class names (splitting on NULL) (#7002) 2012-03-30 16:51:42 +02:00
Ingo Schommer
c518a19ec2 BUGFIX Replaced logic for checking external URLs in CMS Menu with more stable jQuery Mobile codebase (fixes problems on IE not loading menu entries via ajax) (#7002) 2012-03-30 16:51:42 +02:00
Ingo Schommer
f0ee711f52 Merge pull request #275 from halkyon/e_strict_support
First round of fixes for E_STRICT compliance
2012-03-28 02:42:26 -07:00
Sean Harvey
e097f6e1a8 MINOR Fixes to method arguments in core classes for E_STRICT support.
API CHANGE Remove abstract static function and just use static functions
in Authenticator (PHP 5.3+ doesn't support abstract static functions)
2012-03-28 22:41:42 +13:00
Ingo Schommer
2ecfbc49f5 Merge pull request #276 from halkyon/e_deprecated_fixes
E_DEPRECATED fixes - split() replaced with preg_split()
2012-03-28 02:31:04 -07:00
Ingo Schommer
cbb0259dd7 Merge branch 'integration-merge27march' 2012-03-27 18:07:21 +02:00
Ingo Schommer
66093f71ac MINOR Fixed one-off button height inconsistencies (fixes #6980) 2012-03-27 17:07:52 +02:00
Ingo Schommer
3ef3a6df99 MINOR Shrinking GridField button column to fit, rather than hardcoding a width for it that depends on the amount and styling of buttons in the table 2012-03-27 17:07:52 +02:00
Ingo Schommer
efc30fd39e MINOR Removed setRightTitle() special case (and too specific styling) from Group->getCMSFields(), implemented title attribute for chosen.js drop downs instead (to be styled with more friendly title popovers) 2012-03-27 17:07:50 +02:00
Normann Lou
7a27832297 BUGFIX fix the field generated by choser with 0 width in an iFrame popup 2012-03-27 17:06:58 +02:00
Normann Lou
a95b11d004 MINOR Updated chosen.js from 0.9.7 to 0.9.8 while still maintaining local fixes 2012-03-27 17:02:19 +02:00
Normann Lou
66f537dc3a BUGFIX: when apply a bugfix patch, there is one missing variable missing, add it. 2012-03-27 17:02:19 +02:00
jbridson
236f2673e1 MINOR:changed the heading 'add pages' to add page trac #7026 2012-03-27 17:02:19 +02:00
jbridson
31d4629cdb BUGFIX:removed the float from the li (checkboxes) in members permissions... fixed layout issues Trac #6958 2012-03-27 17:02:18 +02:00
jbridson
83be1a8b43 BUGFIX:removed unnecessary horizontal line from new members page and replaced cms-help-toggle text with ?icon Trac #6956 2012-03-27 17:02:18 +02:00
jbridson
97aa2c8ba6 BUGFIX:adjusted padding so that content aligns properly on the add page panel Trac #6990 2012-03-27 17:02:18 +02:00
jbridson
6fb95e098d BUGFIX:fixed padding issues with navigation tabs across the CMS 2012-03-27 17:02:18 +02:00
Ingo Schommer
87fbb720a1 MINOR Fixing 1px gap between nav tree and page header 2012-03-27 17:02:18 +02:00
jbridson
064a36e140 BUGFIX:fixed alignment of create and delete buttons across the CMS - Trac #6955 2012-03-27 17:02:17 +02:00
jbridson
43d8c08b28 ENHANCEMENT:added cursor:pointer to arrows in the pages tree (Trac #6930) 2012-03-27 17:02:17 +02:00
jbridson
62ef8a269f ENHANCEMENT:replaced text "Toggle Formatting Help" with a ? icon on edit profile Popup - Trac #6904 2012-03-27 17:02:17 +02:00
jbridson
1a66ecd6ac BUGFIX:fixed styling issues on edit profile dialog popup - Trac #6819 2012-03-27 17:02:14 +02:00
jbridson
304b89f802 MINOR:replaced back button icon with correct icon. 2012-03-27 15:38:36 +02:00
Normann Lou
4c1cb59116 MINOR: fix the bug that ModelAdmin search filter doesn't work when arriving from another section of the CMS. 2012-03-27 15:37:32 +02:00
Sean Harvey
cf014dc56d MINOR Replaced use of deprecated split() with preg_split() and fixed use of "&new Class()" which is deprecated in PHP 5.3
ENHANCEMENT E_DEPRECATED and E_USER_DEPRECATED are now handled as notice level errors in Debug.
2012-03-27 23:16:52 +13:00
Will Rossiter
c3cae289d3 MINOR: added default flag to SCSS to allow variables to be overridden 2012-03-27 21:35:43 +13:00
Will Rossiter
e9f650a04e MINOR: tighten up tree spacing 2012-03-27 21:35:43 +13:00
Andrew O'Neil
de2832e65f ENHANCEMENT: Allow Object::create() to be called with late static binding.
This allows DataList::create('SiteTree') as equivalent to Object::create('DataList', 'SiteTree'), without
having to have a create() function on DataList. Required for E_STRICT compliance.
2012-03-27 17:57:42 +13:00
Ingo Schommer
06a4e1aad6 Merge pull request #268 from sminnee/raise-js-errors
BUGFIX: Show a correct growl message when ajax returns a JS error rather than HTTP error.
2012-03-26 06:27:41 -07:00
Sean Harvey
fd7f2eb469 ENHANCEMENT Use of Object::create('GridField') for Roles grid in
SecurityAdmin, to be consistent with Members and Groups grid
instantiation.
MINOR Removing comments referring to CTF
2012-03-26 14:51:40 +13:00
Sean Harvey
fca60b786c ENHANCEMENT Addition of ModelAdmin::getExportFields() which allows ModelAdmin classes to customise which fields should be exported. Defaults to the summary fields from the model class definition. 2012-03-25 20:01:43 +13:00
Sam Minnee
f5f655bd7a BUGFIX: Show a correct growl message when ajax returns a JS error rather than HTTP error. 2012-03-24 16:35:18 +13:00
Will Rossiter
06dd79f34c MINOR: remove console.log 2012-03-24 14:22:29 +13:00
Will Rossiter
39742f53e5 BUGFIX: #7036 refresh CMS panel when adding a new file 2012-03-24 14:20:46 +13:00
Sam Minnée
3ef64af761 Merge pull request #260 from simonwelsh/assettablefield
MINOR Remove unused AssetTableField js file
2012-03-23 18:08:12 -07:00
Sam Minnée
1b24437fde Merge pull request #262 from halkyon/security_import
ENHANCEMENT Adding missing MemberImportForm to SecurityAdmin, and styling fixes.
2012-03-23 17:39:46 -07:00
Sean Harvey
ffdf548575 ENHANCEMENT Adding missing MemberImportForm to SecurityAdmin, putting each importer into
Users and Groups tab for context instead of Import tab, and fixing
styling to be close to how it was in SS 2.4.
2012-03-24 13:20:19 +13:00
Simon Welsh
673dd7d992 MINOR Remove unused AssetTableField js file 2012-03-24 12:36:59 +13:00
Will Rossiter
71f37b993c BUGFIX: #6840 Fix navigation highlights on LeftAndMain 2012-03-24 11:57:29 +13:00