tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
4,523 Commits 31 Branches 527 Tags 162 MiB
622fda969f
Commit Graph

4523 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ingo Schommer
c82f0335f0 API CHANGE Don't reflect changes in File and Folder property setters on filesystem before write() is called, to ensure that validate() applies in all cases. This fixes a problem where File->setName() would circumvent restrictions in File::$allowed_extensions (fixes #5693) 
API CHANGE Removed File->resetFilename(), use File->updateFilesystem() to update the filesystem, and File->getRelativePath() to just update the "Filename" property without any filesystem changes (emulating the old $renamePhysicalFile method argument in resetFilename())
API CHANGE Removed File->autosetFilename(), please set the "Filename" property via File->getRelativePath()
MINOR Added unit tests to FileTest and FolderTest (some of them copied from FileTest, to test Folder behaviour separately)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107273 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:34 +13:00
Ingo Schommer
52efe7f3f9 MINOR Changed ImageTest to use fixture files located in assets/ folder, the filesystem API doesn't support Folder objects with "sapphire/..." paths, which leads to inconsistent results 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107272 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:34 +13:00
Ingo Schommer
8d82c3c7b7 MINOR Making FileTest->setUp()/tearDown() more resilient against in-test file/folder renames 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107271 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:34 +13:00
Ingo Schommer
62dd270fba MINOR More identifiable file naming in FileTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107270 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:34 +13:00
Ingo Schommer
2a5a00ced4 MINOR Using File::get_file_extension() instead of substr() magic in File->setName() 
MINOR Using exceptions instead of user_error() in File->setName()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107269 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:34 +13:00
Ingo Schommer
a00dc63124 API CHANGE Deprecated File->getLinkedURL() 
MINOR Avoiding duplication by using existing getFullPath() in File->getAbsoluteURL()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107268 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:34 +13:00
Ingo Schommer
3781ecc784 MINOR Made File::get_file_extension() more readable, and added unit test 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107267 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:34 +13:00
Ingo Schommer
80ce0b5f4f MINOR Removed File->setField(), doesn't have any overloaded functionality 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107266 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Ingo Schommer
7e65d3c5af MINOR Documentation in File and Folder class 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107265 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
d5ae174e95 MINOR: updated generator tag URL 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107214 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Andreas Piening
58e7936004 MINOR: force exclusive connection 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107175 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
f7f237f119 ENHANCEMENT: abstracted protocol detection out to Director::protocol() #5450 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107094 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
12aedc0e30 ENHANCEMENT: in referencing a file in combine_files() it should fall back to standard requirement tags if combining has been disabled eg dev mode 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107091 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
c6364e5548 BUGFIX: prevented HTTPRequest->shift() throwing notices when shifting multiple elements. APICHANGE: SS_HTTPRequest->shift($multiple) no longer returns an array of size $multiple spaced with nulls, it returns an array up to the size of $multiple. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107090 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
b834248ddc BUGFIX: fixed notice level errors getting through 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107089 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
879e8b456d ENHANCEMENT: added setDisabled() to set DropdownField::$disabled 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107086 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Ingo Schommer
d283b4a1c1 API CHANGE Deprecated AutocompleteTextField, use third-party solutions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107054 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Andreas Piening
7be9ca0c7e MINOR: return false rather than error out in case SS_Query:: is not a resource 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107030 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Andreas Piening
b5ad10bff1 MINOR: mysql_fetch_row() expects resource, this will fatal if query was e.g. UPDATE when iterating a result because MySQLQuery::nextRecord() is used by Iterator::valid() and MySQLQuery:: is bool in this case 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106938 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Ingo Schommer
34ec202c0d ENHANCEMENT Added TestRunner::$coverage_filter_dirs to exclude certain directories from PHPUnit test coverage reports 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106877 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
7dfb8dd43d MINOR Making $Email available in Security_passwordsent.ss template (fixes #5737) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106876 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
4eb8a346a8 BUGFIX Making status description in Debug::friendlyError() compatible to HTTP 1.1 spec (removing any markup and newlines) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106867 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
42ee289493 MINOR Added FileTest->testValidateExtension() (related to #5693) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106805 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
aefecf2965 MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106804 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
422d654dae BUGFIX Re-enabling theme in ErrorPage->doPublish() (it's usually disabled in the publication context through LeftAndMain->init()) 
MINOR Reverted r88633, it breaks <base> tag in static HTML for ErrorPage->doPublish()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106777 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Sean Harvey
b999ca4c72 BUGFIX Stricter checking that a relation exists on ComplexTableField::saveComplexTableField() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106755 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
3dc526c00f ENHANCEMENT Calling Image->deleteFormattedImages() in Image->onBeforeWrite() (#5423) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106705 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
862c5a8602 MINOR Fixed hardcoded error message in PasswordValidator (fixes #5734) 
MINOR Added PasswordValidatorTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106687 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
7b90d5e94d BUGFIX Fixed ImageField->EditFileForm() to list subclasses of Image in tree dropdown (fixes #5708, thanks keeny) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106671 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
8cfe7aa11b BUGFIX Prevent DateField->performReadonlyTransformation() from segfaulting on PHP 5.2 due to broken __toString() casting (fixes #5713, thanks charden) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106666 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Luke Hudson
44698d0a38 MINOR: Provide a default message for FIELDISREQUIRED 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106568 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Luke Hudson
8079bfd417 MINOR: Correct typo in comments 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106313 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Ingo Schommer
25b65b71cf BUGFIX Checking for the same combined filename in Requirements::combine_files() to avoid irrelevant error messages 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106225 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Will Rossiter
c38dc3b1b4 APICHANGE: moved Group::addToGroupByName to $member->addToGroupByCode. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106217 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Will Rossiter
93040d6781 BUGFIX: updated tests for Text 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106205 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Will Rossiter
41ec792cb4 ENHANCEMENT: added prefix and suffix support to ContextSummary 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106200 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Ingo Schommer
a50d4fbc10 MINOR Fixed memory limit setting in SapphireTest (regression from r106128) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106190 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Sam Minnee
c3670e8981 MINOR: Better checking of safe_mode in MemoryLimitTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106187 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Sam Minnee
899e41efd5 MINOR: Don't run memory limit tests in safe mode, 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106156 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Will Rossiter
b7d073d910 BUGFIX: if running in cli do not output html tags when rebuilding the db 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106154 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
2f9dddc0ea MINOR: Preserve memory_limit between tests (for better PHP5.1 behaviour) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106128 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
493fb1be55 BUGFIX: Replaced Versioned's unique index definition with an array syntax. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106120 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
bb8ad14651 MINOR: Added test for Database::hasTable(). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106119 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Will Rossiter
917a0545ce ENHANCEMENT: added setRows() and setColumns() to customize the size of the textarea field outside of the controller 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106118 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Ingo Schommer
d7efcc4aaf MINOR Removed db/build legacy wording in DevelopmentAdmin (fixes #5676) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106083 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
afdf8afaf4 BUGFIX: Fixed SiteTree::IsModifiedOnStage() for an edge-case that was identified when deleteFromStage() stopped manipulating the current record. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106082 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
5fbc19f5be BUGFIX: Don't let deleteFromStage() kill the ID of the original record. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106080 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
3f6005fd6a BUGFIX: Add a unique index to SiteTree_versions.RecordID+Version. Fix saving methods to support this. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106079 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
e1753a35e5 BUGFIX: Throw an exception if you try an delete an unsaved or already-deleted record 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106078 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sean Harvey
7cc9709123 BUGFIX MySQLDatabaseConfigurationHelper::getVersion() will fallback to trying to get the version using a query if mysql_get_server_info() returns nothing 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106071 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:29 +13:00