Sam Minnee
729bcc95db
BUGFIX: Don't clear form messages unless forTemplate() is actually called.
...
BUGFIX: Clear session-stored form data as well as form error message.
2013-01-08 17:45:17 +13:00
Sam Minnee
abbee41b78
NEW: Add ReadonlyField::setIncludeHiddenField()
...
The new config setter restores the 2.4 behaviour of including <input type="hidden"> with a field. Although as a default, this option has security flaws; it is useful in a few circumstances and, if nothing else, is handy to make upgrading sites easier.
2013-01-08 17:45:17 +13:00
Sean Harvey
b63e55a77a
Merge pull request #993 from halkyon/htaccess_fix
...
Fixing .htaccess to ignore rewriting PHP files directly
2013-01-06 17:24:49 -08:00
Sean Harvey
baaa270ceb
Merge pull request #1032 from halkyon/datalist_filter_docs
...
Improve class naming and docs for DataList::applyFilterContext()
2013-01-06 17:23:43 -08:00
Sean Harvey
2140a621fb
Merge pull request #1067 from halkyon/shorthand_ternary_op
...
Remove unncessary variable from TreeDropdownField
2013-01-06 17:20:54 -08:00
Sean Harvey
68eb367d27
Remove unncessary variable from TreeDropdownField
2013-01-07 14:14:54 +13:00
Ingo Schommer
44c41085b9
Copying request params before Core.php exec in PHPUnit bootstrap
...
Same behaviour as with 3.0 bootstrap.php and the
2.4 cli-script.php (which it is based on).
This allows to use GET switches which are evaluated in _config.php
files, e.g. db=<db-alias> settings for running tests
with various DBs without changing the underlying PHP config.
2013-01-06 22:34:29 +01:00
Ingo Schommer
a0a317886b
Merge pull request #1077 from sunnysideup/patch-5
...
upgrading 'Setting up an environment for contributing to SilverStripe'
2013-01-06 13:08:06 -08:00
Nicolaas
9dcace9b32
upgrading 'Setting up an environment for contributing to SilverStripe' to heading 1
...
we do this to make it clearer that you can do the basic install OR a 'DEV' install - after that we list the advanced usage cases.
2013-01-05 11:26:21 +13:00
Ingo Schommer
5d9819be53
Clearer docs on using composer for contributions
2013-01-04 12:21:07 +01:00
Ingo Schommer
d872202ae5
Support for X-Reload header
...
Backported from 3.1. Required to get subsite's
"copy page to subsite" form submission working.
2013-01-03 20:43:51 +01:00
Ingo Schommer
06f05d0e7a
Merge pull request #1075 from g4b0/8088-GroupedDropdownField-xhtml-strict-2
...
BUG:removed null FormField value. fixes #8088
2013-01-02 09:02:47 -08:00
g4b0
63dbb1c6c9
BUG:removed null FormField value. fixes #8088
2013-01-02 15:47:06 +01:00
Ingo Schommer
9dafc83f29
Fixed DateField phpdocs
2013-01-02 13:45:15 +01:00
Nicolaas
a32451f72e
adding extension hook in GridFieldDetailForm.php
...
This hook is useful so that you can add additional fields / actions in a gridfield form that are not available in other settings (e.g. additional actions: previous / next / save and publish / unpublish / etc
2012-12-27 19:22:54 +13:00
Justin Martin
f431b35b88
BUG: Confirmed Password Field now copies attributes to child fields.
2012-12-27 09:25:15 +13:00
Nicolaas
3fca288873
Update forms/TextareaField.php
...
small edit to description of the field (usage). Removed reference to cols and rows parameters.
2012-12-26 22:29:36 +13:00
Simon Elvery
775567d427
Allow <button type='submit'> for the benifit of IE<=7
2012-12-21 16:19:43 +01:00
g4b0
e53280c650
BUG SQLQuery::aggregate() with limit, groupBy and orderBy ( fixes #8148 )
2012-12-21 15:20:59 +01:00
Ingo Schommer
8ec3641e60
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
admin/javascript/LeftAndMain.FieldHelp.js
lang/en.yml
model/URLSegmentFilter.php
2012-12-21 15:04:17 +01:00
Ingo Schommer
3fd1769142
Added docs about which branch to choose
2012-12-21 14:26:51 +01:00
Ingo Schommer
f0f83b26a8
BUG Graceful handling of sprintf with too few params in i18n::_t()
...
Originally discovered as a problem with the 'GridFieldDetailForm.Saved' in nl.yml
2012-12-21 11:46:39 +01:00
Ingo Schommer
661a4a2492
Removed direct sprintf() usage from _t() calls
...
Parameterized strings are easier to understand,
and more fail-proof, don't fatal out when not enough sprintf() args
2012-12-21 11:46:38 +01:00
Ingo Schommer
7a6ce01567
BUG Skip pagination on UnsavedRelationList in GFPaginator
2012-12-20 20:16:53 +01:00
Ingo Schommer
c054ab49a2
Merge pull request #1053 from unclecheese/patch-11
...
Fix edge case in which uninitialized buttons are being destroyed.
2012-12-20 11:08:47 -08:00
Ingo Schommer
6bcffd66ad
Merge pull request #1063 from drzax/log-file-formatter-fix
...
BUGFIX Ensure has length before using string index access.
2012-12-20 10:19:03 -08:00
Ingo Schommer
d918c26782
Allow recursive includes in i18nTextCollector ( fixes #8133 )
2012-12-20 12:46:57 +01:00
Ingo Schommer
9ffd25225e
Don't complain about pre-replaced YAML fixture relations
2012-12-20 12:46:56 +01:00
Nathan J. Brauer
d487a42456
API Default to Upload::$uploads_dir in UploadField
2012-12-20 10:25:52 +01:00
Sean Harvey
aa3b358469
Adding test for SortColumn to SQLQueryTest
...
Mostly for the benefit of MSSQLDatabase which is having problems
with subselects and alias functions.
2012-12-20 15:52:46 +13:00
Simon Welsh
e20f15df55
Remove /e option due to preg_replace_callback use
2012-12-20 15:35:40 +13:00
Simon Elvery
1a4eaaaf04
BUGFIX Ensure has length before using string index access.
2012-12-20 12:27:09 +10:00
Sam Minnée
0ab513ac5d
Merge pull request #1060 from simonwelsh/55-fixes
...
Use preg_replace_callback over preg_replace with e modifier
2012-12-19 18:13:20 -08:00
Simon Welsh
c56a80d6ce
Use preg_replace_callback over preg_replace with e modifier
2012-12-20 13:40:42 +13:00
Ingo Schommer
e4cb25b831
Merge pull request #1058 from chillu/pulls/remove-testsession
...
API Remove dev/tests/startsession etc, use new "testsession" module
2012-12-19 11:42:56 -08:00
Ingo Schommer
86940aa684
Made hyphen escaping clearer in FileNameFilter and URLSegmentFilter
...
Does not actually change behaviour, but ensures that the hyphen
is not interpreted as a range identifier should it be placed
between two characters which PCRE regards as "rangeable".
2012-12-19 17:30:28 +01:00
Kirk Mayo
561e629c16
NEW Show the allowed extensions as a toggle tip as per trac 7993
...
NEW Added a behat test for showing extension trac 7993
2012-12-19 17:00:39 +01:00
Ingo Schommer
2e1a5081fa
API Remove dev/tests/startsession etc, use new "testsession" module
...
Removed commands: startsession, endsession, sessionloadyml, setdb, emptydb.
See https://github.com/silverstripe-labs/silverstripe-testsession
2012-12-19 16:05:37 +01:00
Adam Judd
3a555d2bcb
Set 'active' correctly for accordion widget
...
The accordion widget was previously being passed true and false, where as it either expects true or the integer of the panel to show.
This fix sets it as either false or 0.
2012-12-18 23:22:37 -08:00
Stig Lindqvist
22efd3848e
BUG Calling DataObject::relField() on a object with an empty relation list
...
This causes a 'Fatal error: Call to a member function hasMethod() on a non-object'.
This can happen when displaying a field in a gridfield on a belongs_to relationship.
2012-12-19 16:47:07 +13:00
unclecheese
07fb756327
Fix edge case in which uninitialized buttons are being destroyed.
...
In certain cases, the button may not yet be initialized or may no longer have button properties at the time of removal from the DOM. Without this check, an uncaught exception is thrown.
2012-12-18 09:41:54 -05:00
Ingo Schommer
9b3aebd310
Allow HTML in FormField->setDescription()
2012-12-18 15:02:23 +01:00
Loz Calver
4388433583
BUG: Right click on LeftAndMain menu caused CMS preview window to open
...
The onclick event for LeftAndMain menu links didn't check if the click
was left or right, meaning that right click events could trigger the
function for loading split view mode in some browser/os combinations.
2012-12-18 10:44:12 +00:00
uniun
6aba24b3e9
BUG removeRequiredField() should use array_splice() instead of unset()
...
Function unset() preserves numeric keys and method removeRequiredField() will give a PHP notice about nonexistent array key and loop won't iterate throughout all elements in array on second method call (and all subsequent).
So it's better to use foreach loop and array_splice() function (it doesn't preserve numeric keys).
2012-12-18 11:57:11 +02:00
Ingo Schommer
f72a024af5
Updated changelog notes
2012-12-18 10:40:05 +01:00
Mateusz Uzdowski
d5a1c3d99a
BUG SS has problems handling + in URLs. Filter them out.
...
+ has a special meaning in the URLs so overall it's a good idea to
strip them out. Otherwise they would need to appear in their ugly url
encoded form "%2B".
Refer: http://open.silverstripe.org/ticket/7929
2012-12-18 09:44:47 +01:00
Sam Minnée
e4198de115
Merge pull request #1047 from simonwelsh/ns_class_parse
...
FIX Handle namespaced classes in Object::parse_class_spec()
2012-12-17 23:55:50 -08:00
Sam Minnée
9460e8704c
Merge pull request #1043 from tractorcow/3.1-deleted-pages-fixes
...
Fix for issue #7975 - Issue with retrieving deleted pages
2012-12-17 19:50:27 -08:00
Simon Welsh
94be5c6d87
FIX Handle namespaced classes in Object::parse_class_spec()
2012-12-18 15:00:45 +13:00
Ingo Schommer
618a3d0314
Requirements acces to files with query strings ( fixes #7735 )
...
Originally authored by florian.thoma, tests added
by Ingo Schommer. Also removed query params from
file paths before calling mtime() on it.
See https://github.com/silverstripe/sapphire/pull/1023
2012-12-18 01:01:19 +01:00