tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
16,369 Commits 31 Branches 527 Tags 162 MiB
5f7f1ea150
Commit Graph

16369 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Daniel Hensby
6e78b9f8d2
Merge pull request #7406 from NightJar/patch-2 
Fix ArrayList sort error with old (supported) PHP

PHP 5.3 at least (the reported and tested against version) requires arguments to `call_user_func_array` to be passed by reference. There exists a note as a comment in the code, but was unfortunately overlooked in a previous commit to fix case sensitive sorting 4998b80#diff-6ba746c3d31fd6b4c4a99d7efe35eb21L442

To solve this issue we simply first assign the constant to a variable, so we can then pass that by reference. This has no functional impact, however fixes an issue for users locked in to old PHP versions which we still list as supported (https://docs.silverstripe.org/en/3/getting_started/server_requirements/#web-server-software-requirements).
 2017-09-28 15:46:38 +01:00
Dylan Wagstaff
ebe1de8d8b
Fix ArrayList sort error with old (supported) PHP 
PHP 5.3 at least (the reported and tested against version) requires arguments to `call_user_func_array` to be passed by reference. There exists a note as a comment in the code, but was unfortunately overlooked in a previous commit to fix case sensitive sorting 4998b80445 (diff-6ba746c3d31fd6b4c4a99d7efe35eb21L442)

To solve this issue we simply first assign the constant to a variable, so we can then pass that by reference. This has no functional impact, however fixes an issue for users locked in to old PHP versions which we still list as supported (https://docs.silverstripe.org/en/3/getting_started/server_requirements/#web-server-software-requirements).
 2017-09-28 15:29:54 +01:00
Daniel Hensby
1209b2ae13
Added 3.5.5-beta2 changelog 2017-09-20 13:41:04 +00:00
Daniel Hensby
72702dbd50 Merge pull request #43 from silverstripe-security/pulls/3.5/member-enumeration-timing-attack 
[SS-2017-005] User enumeration via timing attack mitigated
 2017-09-20 11:39:39 +01:00
Daniel Hensby
6b198336a8 Merge pull request #44 from silverstripe-security/patch/3.5/authenticator-fix 
FIX Authenticators are more resilient to incomplete configuration
 2017-09-20 11:38:38 +01:00
Daniel Hensby
f0262a8fd9
[SS-2017-005] User enumeration via timing attack mitigated 2017-09-20 11:33:22 +01:00
Daniel Hensby
1f256cf2d2
Added 3.5.5-beta1 changelog 2017-09-19 15:25:41 +00:00
Matthias Schelling
eacfe280c1
TreeDropdownField: replace onadd by onmatch 
Makes TreeDropdownField work in situations where it's moved around in the DOM (e.g. when inside a drag'n'drop container)
 2017-09-15 12:02:18 +01:00
Daniel Hensby
091d99f599
FIX Authenticators are more resilient to incomplete configuration 2017-09-12 15:57:03 +01:00
Damian Mooyman
c0003bca3d Merge pull request #7319 from open-sausages/pulls/3.5/no-combining-requirements 
Fix add combinedFiles to clear logic - ss3
 2017-08-29 13:47:52 +12:00
Christopher Joe
7b200a2a64 Fix add combinedFiles to clear logic 2017-08-29 12:57:41 +12:00
Daniel Hensby
9d2503c3da Merge pull request #7274 from PapaBearNZ/patch-1 
Fix Truncate Error Issue when using views in a Unittest.
 2017-08-25 11:51:36 +01:00
Damian Mooyman
7ad081a20b Merge pull request #7288 from dhensby/pulls/3.5/write-no-change-edit 
FIX Don't update LastEdited on skipped writes
 2017-08-17 15:09:03 +12:00
Daniel Hensby
eb80a5f9e8
FIX LastEdited no longer updated on skipped writes 2017-08-16 23:39:22 +01:00
Daniel Hensby
1ae07ac2a3
TEST Prove LastEdited is updated when no changes are made 2017-08-16 22:26:47 +01:00
James Pluck
b04a1ab41c Fix Truncate Error Issue when using views in a Unittest. 
When using a view in a SilverStripe project, whenever the tear down scripts for the Unittests are run the following error occurs:

Couldn't run query:
TRUNCATE "ActivityPoints_view"
Table 'ss_tmpdb2391727.ActivityPoints_view' doesn't exist

This was due to the MySQLSchemaManager::tableList() function assuming that all records in the TABLES were actual tables containing data.

This small tweak fixes the issue by modifying the SQL to filter out views from the list before truncating.
 2017-08-14 15:22:19 +12:00
Damian Mooyman
69451790d6 Merge pull request #7224 from dhensby/pulls/3.5/spyc-composer 
Move spyc dependency to composer
 2017-08-02 16:19:00 +12:00
Daniel Hensby
6494bc820c
Move spyc dependency to composer 2017-07-28 13:35:30 +01:00
Damian Mooyman
9b378d8c08 Merge pull request #7213 from dhensby/pulls/3.5/fix-small-htmlfield 
FIX Avoid JS errors for HTMLEditorFields in small holders
 2017-07-28 13:25:31 +12:00
Daniel Hensby
2e34730d3d Merge pull request #7211 from kinglozzer/migrate-legacy-hashes-config 
Fix: Use Config API for MemberAuthenticator::$migrate_legacy_hashes (fixes #7208)
 2017-07-26 11:21:51 +01:00
Daniel Hensby
31c5eebda0
FIX Avoid JS errors for HTMLEditorFields in small holders 2017-07-26 11:20:00 +01:00
Loz Calver
82c0632f46
Fix: Use Config API for MemberAuthenticator::$migrate_legacy_hashes (fixes #7208) 2017-07-26 09:54:29 +01:00
Daniel Hensby
ba8c149b78
Stay on travis precise dist for now 2017-07-25 16:02:02 +01:00
Chris Joe
3e8b636dc9 Merge pull request #6942 from open-sausages/pulls/3.4/fix-gridfield-state 
BUG Ensure GridState_Component is added to GridField config
 2017-07-21 10:54:07 +12:00
Klemen Dolinsek
3dd3036792 BUG Ensure GridState_Component is added to GridField config even if we set config with GridField::setConfig 
Fixes #6886
 2017-07-21 10:32:13 +12:00
Loz Calver
0c6851e597 Merge pull request #7190 from silverstripe/revert-7035-3.5 
Revert "TreeDropDown performance boost."
 2017-07-19 15:37:28 +01:00
Daniel Hensby
7b6aad8a65 Revert "TreeDropDown performance boost." 2017-07-19 12:44:43 +01:00
Daniel Hensby
292aaf6530
FIX Cache IDs grouped by site first 2017-07-19 11:29:01 +01:00
Damian Mooyman
d053c9aaac Merge pull request #7186 from dhensby/pulls/3.5/cache-prefix 
FIX Add unique prefix to cache stores to prevent cache leak
 2017-07-19 11:54:49 +12:00
Daniel Hensby
b77274c1a3
FIX Add unique prefix to cache stores to prevent cache leak 2017-07-18 23:43:08 +01:00
Daniel Hensby
fa8f0cc955 Merge pull request #7141 from bummzack/fix-7132-utf8 
Fix OS X issue with some string methods.
 2017-07-18 11:59:16 +01:00
Roman Schmid
a6db16b229 Fix OS X issue with Convert::html2raw, HTMLText::FirstSentence, HTMLText::Summary and Text::FirstSentence. 
Use unicode modifier for regular expressions that deal with whitespace.
Added unit-tests to ensure no invalud utf-8 gets generated by these methods.
 2017-07-10 09:49:55 +02:00
Daniel Hensby
f769d9a13f Merge pull request #7059 from mfendeksilverstripe/3.5 
Html editor selection is now properly stored while the dialog is open
 2017-07-05 15:03:18 +01:00
Daniel Hensby
3a7261ac6e Merge pull request #7093 from dhensby/pulls/3.5/lam-getchildasul-call 
FIX add missing $rootCall param from LeftAndMain
 2017-07-02 00:28:48 +01:00
Daniel Hensby
79a7b1016e
FIX add missing $rootCall param from LeftAndMain 2017-06-29 11:24:09 +01:00
Damian Mooyman
2b8eb202db Merge pull request #6687 from hailwood/patch-6 
Do not default to locale if hasEmptyDefault is true
 2017-06-28 12:12:16 +12:00
Mojmir Fendek
b2d362beb9 Html editor selection is now properly stored while the dialog is open. 2017-06-26 12:55:05 +12:00
Daniel Hensby
9888cbc406 Merge pull request #7035 from mfendeksilverstripe/3.5 
TreeDropDown performance boost.
 2017-06-21 13:19:09 +01:00
Daniel Hensby
d666eea148 Merge pull request #7041 from creative-commoners/pulls/3.5/fix-gridfield-filter-header-colour 
FIX Text colour in GridField filter headers for dropdown fields (SS 3.5)
 2017-06-20 15:21:19 +01:00
Robbie Averill
e2116a70ef FIX Text colour in GridField filter headers for dropdown fields 2017-06-20 16:21:59 +12:00
Mojmir Fendek
5b6a39e71a TreeDropDown performance boost. 2017-06-19 15:10:23 +12:00
Daniel Hensby
99a364a24c Merge pull request #7024 from kinglozzer/hasmanylist-ambiguity 
FIX: Ensure HasManyList foreign ID filter includes table name (fixes #7023)
 2017-06-15 20:58:50 +01:00
Loz Calver
d1ed92ad26 Merge pull request #7022 from sanderha/fix-gd-rotate-png-transparency 
keep PNG transparancy on GDBackend::rotatePixelByPixel
 2017-06-15 14:38:10 +01:00
Sander Hagenaars
b61c3ac8c3
keep PNG transparancy on GDBackend::rotatePixelByPixel 2017-06-15 13:59:29 +01:00
Loz Calver
2afe018dc7
FIX: Ensure HasManyList foreign ID filter includes table name (fixes #7023) 2017-06-15 12:06:30 +01:00
Loz Calver
4f4fb62dfa Merge pull request #7015 from bcairns/3.5 
Fix changetracker checkbox bugs
 2017-06-13 09:13:37 +01:00
Brian Cairns
53c84d93da Fix changetracker checkbox bugs 
1) Use quoted name attribute selector, to work with CheckboxsetField bracketed[] field names
2) Initialize unchecked boxes original values to 0 instead of undefined, as this is the value onchange() expects for unchecked boxes (see line 67)
 2017-06-12 16:16:55 -06:00
Damian Mooyman
9c2f4e3c44 Merge pull request #7012 from dhensby/pulls/3.5/member-null 
FIX Order of conditionals for getting default admin
 2017-06-13 09:58:22 +12:00
Daniel Hensby
a5c84b12ab
FIX Order of conditionals for getting default admin 2017-06-12 11:54:05 +01:00
Damian Mooyman
7cf7a7094c Merge pull request #7000 from kinglozzer/uploadfield-size-ini 
FIX: Upload_Validator failed to fetch max size from PHP ini values (fixes #6999)
 2017-06-07 15:48:27 +12:00