tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-07-05 10:59:35 +02:00
Code Issues Projects Releases Wiki Activity
6,379 Commits 29 Branches 517 Tags 147 MiB
5f59b3a3c9
Commit Graph

574 Commits

Author SHA1 Message Date
Sam Minnee
67b5116702 BUGFIX: Allow execution of a test without a current controller. (from r111044) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112882 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:36:12 +00:00
Sam Minnee
cb283acb9b MINOR: added phpdoc to the new PHPUnitWrapper classes. (from r111042) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112880 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:35:14 +00:00
Sam Minnee
3006b6ac36 ENHANCEMENT: refactored runTests, using the new phpunit wrapper classes. (from r111041) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112878 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:33:51 +00:00
Sam Minnee
ce92190465 API-CHANGE: remove include which is not required. (from r111040) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112872 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:07:15 +00:00
Sam Minnee
eeb9e36e7a ENHANCEMENT: Created a phpunit wrapper class to ensure that Sapphire's test framework is capable of running unit tests, coverage report and retrieve clover-statistics for PHPUnit 3.4 and PHPUnit 3.5 (from r111039) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112871 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:06:55 +00:00
Sam Minnee
d8a8635374 API CHANGE Member->canEdit() returns false if the editing member has lower permissions than the edited member, for example if a member with CMS_ACCESS_SecurityAdmin permissions tries to edit an ADMIN (fixes #5651) (from r110856) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112861 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 02:46:26 +00:00
Sam Minnee
9107cf950b ENHANCEMENT: added the ability to toggle the use draft site setting (from r110757) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112844 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:32:17 +00:00
Sam Minnee
e5dd8c13d3 ENHANCEMENT: disable basic auth by default, tests run on the assumption it is disabled. (from r110211) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112838 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:29:39 +00:00
Sam Minnee
2c7d88aade MINOR: repair installer for sqlite (from r109787) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112830 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:26:27 +00:00
Sam Minnee
99fde26091 MINOR CSSContentParser::__construct() now gives a better error if the content could not be parsed. This will mostly happen if tidy isn't present. (from r109274) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112821 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:23:00 +00:00
Sam Minnee
f929d2ee6d MINOR phpDoc updates for SS_LogFileWriter and SS_LogEmailWriter (from r109165) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112819 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:21:32 +00:00
Sam Minnee
f20e83eeaf MINOR: Fix links etc, and remove www. from SS urls (from r109105) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112783 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:56:25 +00:00
Sam Minnee
cda6638281 ENHANCEMENT: Added -v / --verbose option to dev/tests/*, to make it output every single test name before it starts that test. (from r109104) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112782 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:56:02 +00:00
Sam Minnee
0d6cb295c4 Added dev/tests/emptydb to clear out test session databases. (from r109099) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112777 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:54:31 +00:00
Sam Minnee
b2c7c944de BUGFIX SapphireTest::create_temp_db() should restore the SS error handler from the PHPUnit one temporarily in case there's any errors building (from r108509) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112755 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:42:53 +00:00
Sam Minnee
d28d7510af MINOR Fixed failing tests because of locale not being set to the default in SapphireTest::setUp() (from r108500) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112754 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:37:55 +00:00
Sam Minnee
c52dfd1e03 BUGFIX Database password input in installer should be password, so that the password is obfuscated when input (from r108432) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112746 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:33:12 +00:00
Sam Minnee
229bea6dd4 MINOR: Add trailing slash to image tag (thanks to mattclegg) (from r108376) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112722 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:51:05 +00:00
Sam Minnee
aa4503845f MINOR Documentation in CSVBulkLoader (from r108048) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112712 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:42:12 +00:00
Sam Minnee
a707f925ad BUGFIX: Don't allow reinstalling without first making the user manually delete mysite/_config.php (from r108026) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112710 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:41:32 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:55:22 +00:00
Ingo Schommer
f63751893b BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957) 
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest) (from r107415)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112588 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:43:30 +00:00
Ingo Schommer
47762cdf5b ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:23:02 +00:00
Ingo Schommer
f7e61e0d11 ENHANCEMENT Added TestRunner::$coverage_filter_dirs to exclude certain directories from PHPUnit test coverage reports (from r106877) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112542 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:07:08 +00:00
Ingo Schommer
9b177ec458 BUGFIX Making status description in Debug::friendlyError() compatible to HTTP 1.1 spec (removing any markup and newlines) (from r106867) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112540 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:06:31 +00:00
Ingo Schommer
5fe548f7b5 MINOR Fixed memory limit setting in SapphireTest (regression from r106128) (from r106190) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112525 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:59:10 +00:00
Ingo Schommer
3c18a9f1f6 MINOR: Preserve memory_limit between tests (for better PHP5.1 behaviour) (from r106128) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112521 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:58:02 +00:00
Ingo Schommer
7eaca248e2 MINOR Removed db/build legacy wording in DevelopmentAdmin (fixes #5676) (from r106083) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112517 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:56:21 +00:00
Ingo Schommer
b839ab2b9f BUGFIX MySQLDatabaseConfigurationHelper::getVersion() will fallback to trying to get the version using a query if mysql_get_server_info() returns nothing (from r106071) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112512 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:54:18 +00:00
Ingo Schommer
74036f9642 ENHANCEMENT Added MySQLDatabaseConfigurationHelper::getDatabaseVersion() which abstracts the version number away from the version check the installer requires (from r105712) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112501 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:50:06 +00:00
Ingo Schommer
cf4a722cc8 MINOR Show better message if couldn't find MySQL version in MySQLDatabaseConfigurationHelper (from r105516) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112499 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:49:35 +00:00
Ingo Schommer
e44ba25714 ENHANCEMENT Added CSSContentParser->getByXpath() (from r105126) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112440 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:26:24 +00:00
Ingo Schommer
163b358bdf BUGFIX Fixed correct input ID in install.js due to change in r105029 (from r105030) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112437 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:23:00 +00:00
Ingo Schommer
55f1df0f6d BUGFIX Fixed inconsistent styling of reinstall actions at the bottom of the installer, and if using IIS, warn that this will overwrite the web.config file, not .htaccess (from r105029) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112436 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:22:44 +00:00
Ingo Schommer
86cae58d4c BUGFIX: TestSession::submitForm throws proper error if form not found (from r104972) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112413 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:18:22 +00:00
Ingo Schommer
d135ae6837 MINOR Reverted r104923, as current database releases of mssql and sqlite3 modules don't support this yet (from r104924) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112406 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:17:25 +00:00
Ingo Schommer
84b74a6d23 API CHANGE Added interface method DatabaseConfigurationHelper::requireDatabaseVersion(), all database helpers that implement DatabaseConfigurationHelper must now have this method, which as of now is MySQL, PostgreSQL, SQL Server and SQLite (from r104923) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112405 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:17:08 +00:00
Ingo Schommer
8ea659be69 ENHANCEMENT Added MySQLDatabaseConfigurationHelper::requireDatabaseVersion() to check whether the connected instance is using version 5.0+ (from r104706) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112375 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:10:10 +00:00
Ingo Schommer
0e99090bc7 MINOR Tweaks to positioning of help text in installer (from r104704) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112373 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:04:53 +00:00
Ingo Schommer
bfb7dab1fb FEATURE: Add dev/tests/sessionloadyml to load a yml fixture into an existing test session (from r104231) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112340 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 00:01:23 +00:00
Ingo Schommer
d50097e905 FEATURE: Add dev/build/defaults to call requireDefaultRecords (from r104093) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112334 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-14 23:57:02 +00:00
Sam Minnee
35378e577e BUGFIX CSSContentParser now reports better errors by using simplexml_load_string() instead of SimpleXMLElement directly (from r103552) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112147 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 03:57:07 +00:00
Sam Minnee
2948bc1c64 MINOR: Misc merges from branches/2.4 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112142 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 03:53:12 +00:00
Sam Minnee
7fc63deda0 MINOR: use red font instead of gray when displaying error (from r101729) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112029 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:03:46 +00:00
Sam Minnee
d25e326ba0 MINOR Removed fullstop where it wasn't needed (from r101688) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112023 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:00:24 +00:00
Sam Minnee
c4e8624794 MINOR Tidied up the layout of the Themes area of the installer slightly - now consistent helptext as other areas (from r101687) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112022 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:59:55 +00:00
Sam Minnee
d3129b8964 MINOR Updated CMS Admin Account text to be more precise (from r101686) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112021 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:59:23 +00:00
Sam Minnee
d07297aa46 MINOR Altered wording in installer for localised interface (from r101683) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112019 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:58:55 +00:00
Sam Minnee
5aa012335a ENHANCEMENT: tidied up installer process to streamline process. Moved requirements to top and button to bottom and added visual seperation of the individual steps (from r101661) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112015 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:57:05 +00:00
Sam Minnee
bac6a9d240 ENHANCEMENT: refactored requirements section to hide successful tests (from r101381) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111998 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:45:50 +00:00
Sam Minnee
f2bbb4c605 ENHANCEMENT Added links to installation introduction text for sources of help and suggested web hosts (from r101378) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111996 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:44:01 +00:00
Sam Minnee
252321f3c7 MINOR Made reinstall message more precise by adding web.config to the files that will get overwritten (from r101341) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111994 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:43:00 +00:00
Sam Minnee
9137539ae6 ENHNACEMENT Installer no longer asks for firstname and surname for default CMS admin account, this can be changed later on and doesn't need to be entered for installation (from r101314) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111993 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:42:36 +00:00
Sam Minnee
875197b934 MINOR Moved "theme" section further down in the installer, its much less likely to be changed than the database connection and admin account fields. (from r101282) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111991 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:40:21 +00:00
Sam Minnee
cfae8d5c24 MINOR Fixed regression in install.js option selection (see r101173) (from r101251) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111976 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:57:06 +00:00
Sam Minnee
46be185c65 ENHANCEMENT Improved wording and styling in installer. Added links to server requirements, themes download, tutorial. Decreased vertical space before the "install" button to make it more obvious. (from r101246) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111975 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:56:46 +00:00
Sam Minnee
2f45137028 BUGFIX Don't run click() on all inputs, but input:radio only (from r101173) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111971 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:54:07 +00:00
Sam Minnee
25cddf944c BUGFIX: Pass correct class to allowPrimaryKeyEditing in yaml fixture (from r101171) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111969 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:52:55 +00:00
Sam Minnee
477709f0da MINOR: Fix output format of buildbot test runs to not include colour control codes. (from r101172) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111968 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:52:19 +00:00
Sam Minnee
f8a5282055 BUGFIX #5216 Installer has issues with click handlers applied to the entire li, be more specific and apply it to the label and input instead (from r101167) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111966 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:49:35 +00:00
Sean Harvey
5658cd68a2 FEATURE #5694 New log writer SS_SysLogWriter for logging SilverStripe errors to the system log (thanks rorschach!) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111674 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 22:04:20 +00:00
Sam Minnee
55c5d1cab7 API CHANGE: Allow on_db_reset() methods on DataObjects as well as DataObjectDecortators (from r101119) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111593 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:51:08 +00:00
Sam Minnee
deb88d1143 BUGFIX #5202 Installer now properly populates database configuration inputs from request after user clicks "Re-check requirements" (from r101087) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111584 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:45:44 +00:00
Sam Minnee
555762299d ENHANCEMENT Allowing SQLite selection in installer 
ENHANCEMENT Moved all Javascript containedin  install.php and config-form.html to install.js, and using jQuery to simplify logic
ENHANCEMENT Allow installer to attach custom form fields based on the install driver (as defined in _register_database.php) (from r101054)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111576 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:43:12 +00:00
Sam Minnee
848faf2a6b MINOR tests can now require default records on classes (from r101025) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111566 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:31:58 +00:00
Sam Minnee
390d9b45dd MINOR Updated required version to 5.1 in php5-required template (from r100988) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111559 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:29:26 +00:00
Sam Minnee
387d34f625 MINOR Removed whitespace from "Development servers" textarea for installer (from r100978) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111553 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:27:44 +00:00
Sam Minnee
11b1367c8c MINOR Fixed "disabled" styling for database options in config-form.html (showed all as green when "use _ss_environment" was ticked (from r100965) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111549 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:26:54 +00:00
Sam Minnee
7285bbe140 ENHANCEMENT Added help text for "locale" setting in installer 
MINOR Changed <div> hierarchy in config-form.html to allow right-aligned help texts which horizontically align with their respective field sets on the left. (from r100940)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111546 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:24:33 +00:00
Sam Minnee
e41c7eeede BUGFIX Allow DatabaseAdmin to run dev/build in live mode when not Security::is_database_ready(), and avoid broken login due to broken db queries (selecting unknown columns before dev/build) (see #4957) (from r100924) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111543 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:21:45 +00:00
Sam Minnee
614a8091f3 ENHANCEMENT Added DatabaseAdapterRegistry::unregister() to remove a database from the registry (from r100908) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111539 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:17:01 +00:00
Sam Minnee
1c6e0c3102 MINOR Changed the way DatabaseAdapterRegistry accepts databases (from r100898) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111536 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:16:16 +00:00
Andreas Piening
76dcb97a6f BUGFIX #5176 Javascript error in IE for the installer - use "this" instead of e.target which doesn't work (from r100866) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108831 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-08-03 03:51:37 +00:00
Andreas Piening
3c795141ef MINOR Supress notice if $_REQUEST['url'] doesn't exist in Debug::showError() (from r100832) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108807 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-08-03 01:07:51 +00:00
Andreas Piening
0df70af13d MINOR: removed sqlite msg (from r100801) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108805 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-08-03 01:06:41 +00:00
Ingo Schommer
5c965330c3 ENHANCEMENT you can now choose your site locale at install time (from r100769) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105645 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:58:00 +00:00
Ingo Schommer
480c25a6ee BUGFIX allow selection of database adpater (from r100727) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105630 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:25:29 +00:00
Ingo Schommer
ae9cae661c BUGFIX misspelled variable (from r100726) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105629 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:25:12 +00:00
Ingo Schommer
e4dfc243b4 BUGFIX Fixed SapphireTest->loginWithPermission() and MemberAuthenticatorTest to use existing Members based on their unique_identifier_field (if existing) to accommodate recent Member->onBeforeWrite() changes (see r100705) (from r100723) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105628 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:24:53 +00:00
Ingo Schommer
ee0be99f00 MINOR remove the sqlite databases from the installer list. (from r100697) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105627 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:24:30 +00:00
Ingo Schommer
e19b13a48a ENHANCEMENT show all database systems we support, along with messages if the user cannot use them. Also allow 3rd parties to register their own database classes to appear in this list. (from r100696) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105626 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:24:14 +00:00
Ingo Schommer
14d1e8eb70 MINOR Added note about other databases (from r100669) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105618 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:21:48 +00:00
Ingo Schommer
67c7b7a026 MINOR When the installer is using the environment for configuration, disable the development servers textarea as it's automatically configured from environment (from r100622) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105609 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:19:10 +00:00
Ingo Schommer
a65037650f BUGFIX #4572 Fixed Windows failure on SS_Cli::supports_colour() because posix functions are not supported (from r100560) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105604 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:18:00 +00:00
Ingo Schommer
0f2a698f15 MINOR Wording change in installer for database details not correct (from r100552) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105603 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:17:48 +00:00
Ingo Schommer
dd8d0c1259 MINOR Fixed undefined variable $error in MySQLDatabaseConfigurationHelper (from r100550) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105602 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:17:35 +00:00
Ingo Schommer
53ed23d8b6 BUGFIX If fixture file is NULL don't cause the test framework to break down because of it (from r100548) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105601 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 04:17:21 +00:00
Ingo Schommer
a5608657cc MINOR Use "email" instead of username for validation of admin account during install (from r100418) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105566 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:52:01 +00:00
Ingo Schommer
65b3bec774 BUGFIX #5136 Ensure $coverage argument to TestRunner::runTests() has a strict check before running coverage tests, as sometimes an SS_HTTPRequest object can be passed into this argument (from r100415) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105563 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:51:11 +00:00
Ingo Schommer
8f8a3b2f6e BUGFIX YamlFixture::writeDataObject() - some databases need special allowance to edit the primary key column - do so by using DB::getConn()->allowPrimaryKeyEditing() (from r100393) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105558 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:49:22 +00:00
Ingo Schommer
cf5afb4018 MINOR Updated installer to use "CMS / Framework" instead of just "CMS" 
MINOR Updated copyright year to current year (from r100387)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105556 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:45:51 +00:00
Ingo Schommer
ba4ad49422 BUGFIX: Fix TestRunner coverage pattern to work as documented (Fixes QA scripts too) (from r100116) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105550 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:43:11 +00:00
Ingo Schommer
3a19dc08a3 ENHANCEMENT you can now do coverage tests of single/multiple tests, or entire modules (from r99954) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105544 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:22:44 +00:00
Ingo Schommer
593a87b2f2 ENHANCEMENT #4043 Allow setting the from address for debug information in SS_LogEmailWriter - thanks Hamish! (from r99845) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105536 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:15:26 +00:00
Ingo Schommer
4d2cc5dbe8 ENHANCEMENT #5024 Installer now checks that the user has entered a username and password correctly for the default admin, an additional button for re-checking requirements is now found at the bottom of the admin configuration section 
ENHANCEMENT Error messages for database AND admin configuration are now in the same place at the top of the installer (from r99841)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105535 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:14:47 +00:00
Ingo Schommer
e4eca9c7c8 MINOR Fixed phpdoc documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103415 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-23 03:26:32 +00:00
Ingo Schommer
271584e43b MINOR Fixed phpdoc documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103390 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-23 01:04:16 +00:00
Ingo Schommer
6460d09570 MINOR Fixed phpdoc documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103385 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-23 00:11:41 +00:00
Ingo Schommer
4703aa6e81 MINOR Fixed SapphireTest->logInWithPermission() spelling (from r99491) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102866 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 04:41:30 +00:00
Ingo Schommer
7452c4c584 API CHANGE: Let any DataObjectDecorator define an on_db_reset() method that is called by tests, like in Versioned. (from r97734) (from r99051) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102827 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:53:44 +00:00
Ingo Schommer
39149529c1 BUGFIX Development server list should be retained when user submits installer form and gets redirected back (from r99005) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102820 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:51:03 +00:00
Ingo Schommer
5dcf53c239 BUGFIX: testing framework needs to be reset to a clean state after each test: now also nested urls and redirection state will be reverted (from r98944) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102815 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:49:06 +00:00
Ingo Schommer
afb7b5eda5 REVERT: reverse merging the change, it breaks some tests. (from r98873) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102810 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:47:19 +00:00
Ingo Schommer
03201e6201 MINOR Fixed clearing issue in installer that was recently removed (from r98872) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102809 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:46:56 +00:00
Ingo Schommer
dcd5ef9c77 BUGFIX: restore the original nested_urls state after running the test, so we can enable and disable nested URLs within the tests safely. (from r98860) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102806 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:46:23 +00:00
Ingo Schommer
e89e377cb6 MINOR Removed return of connection and changed variables to conincide with r98795 (from r98800) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102804 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:44:38 +00:00
Ingo Schommer
c1dc70b88d MINOR Removed whitespace in textarea value that caused an empty string in the development servers list in installer (regression from recent change) (from r98792) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102799 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:33:12 +00:00
Ingo Schommer
618328ace7 API CHANGE Installer now uses a database configuration helper class which isolates the logic of checking the database away from the installer, this interface can be used by other databases like MSSQL and PostgreSQL. The installer now looks for a specific file inside each database module, provided it's configured in install.php MySQL is provided by default, as it lives in sapphire (from r98786) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102798 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:32:30 +00:00
Ingo Schommer
6bd64ad703 MINOR Styling on installer (from r98781) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102797 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:31:42 +00:00
Ingo Schommer
081b05b411 BUGFIX Checkbox for overriding the install from environment now checks for the file existance properly (from r98688) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102792 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:30:13 +00:00
Ingo Schommer
74a21c6a12 MINOR Reverted broken variables in installer for checking environment (from r98679) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102791 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:29:59 +00:00
Ingo Schommer
2ba7b18e50 BUGFIX Fixed initial state of "use environment" checkbox in installer (from r98678) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102779 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:23:12 +00:00
Ingo Schommer
de112bba6e ENHANCEMENT Added checkbox to switch off using the environment during install if it's available (from r98677) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102778 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:22:54 +00:00
Ingo Schommer
53d5a04655 MINOR Install template cleanup (from r98670) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102776 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:22:21 +00:00
Ingo Schommer
c7528a3b75 MINOR Styling for help text in the installer (from r98668) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102775 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:22:06 +00:00
Ingo Schommer
e6c94e574a MINOR Styling fixes for installer (from r98667) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102774 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:21:52 +00:00
Ingo Schommer
8a1e52ca87 MINOR Tidy up of install template (from r98666) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102773 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:21:39 +00:00
Ingo Schommer
55708cbfa1 MINOR Changed config-form to HTML 4.01 and validated the page minus a few issues with the form field placement (from r98662) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102772 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:21:26 +00:00
Ingo Schommer
00f5f0687a ENHANCEMENT #3903 Initial changes to installer to support selection of different database drivers (from r98659) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102771 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:21:11 +00:00
Ingo Schommer
55c4c90652 MINOR disable form fields if they are set from _ss_environment. See #5054 (from r98643) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102769 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 02:20:44 +00:00
Ingo Schommer
d7f2925dc8 APICHANGE: Refactor Versioned so a single state is kept for stage, archived date, or any module specific reading modes (from r98161) (from r98224) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102633 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 03:16:57 +00:00
Ingo Schommer
91918ccfe1 MINOR Allow creating fixture records without any columns by checking the fields exist first before doing a foreach() in YamlFixture::writeDataObject() (from r98055) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102592 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 02:08:08 +00:00
Ingo Schommer
a138531808 ENHANCEMENT: Removed dev/reset, instead encouraging the use of dev/tests/startsession for tests. 
ENHANCEMENT: Let people use dev/tests/startsession without a fixture, instead calling requireDefaultRecords (from r98080)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102575 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:55:09 +00:00
Ingo Schommer
8ce43e46ff MINOR Partially reverted accidental commit from r97920 (unconditionally requiring ADMIN login via BasicAuth in DevelopmentAdmin) (from r98079) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102574 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:53:42 +00:00
Ingo Schommer
7c84bb984e MINOR: Preserve theme settings in tests (from r97920) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102555 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:44:45 +00:00
Ingo Schommer
29ea7e0b98 BUGFIX Use BASE_PATH and BASE_URL instead of data from $_SERVER. 
API CHANGE: Determine default BASE_PATH/BASE_URL from the __FILE__ content, so that the script that initiated the Sapphire process doesn't matter.  This means that index.php doesn't need to manipulate those variables. (from r97731)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102528 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 23:15:04 +00:00
Ingo Schommer
40899c3bfb BUGFIX: Don't rely on the current working directory for any file access; use BASE_PATH. (from r97728) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102527 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 23:14:36 +00:00
Ingo Schommer
43ff00ebd6 BUGFIX Enforcing creation of temp database in SapphireTest->setUp() to avoid writing to production databases. This check should only kick in for single test case runs, as the temp database connection should be set in a dev/tests/all run after the first db-related test anyway. (see #5034) (from r99342) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102462 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 08:28:06 +00:00
Ingo Schommer
a09263e572 BUGFIX: Another bugfix for r97583 (from r97593) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102458 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 05:39:48 +00:00
Ingo Schommer
b4e9564213 BUGFIX: Fix display of exception backtrace in CLI view. (from r97038) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102428 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 03:36:27 +00:00
Ingo Schommer
9e9ec33dd3 MINOR: Fixed bugs with test execution. (from r96829) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102404 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 03:24:29 +00:00
Ingo Schommer
9fc3256025 BUGFIX: Don't let Versioned archive tables clutter the global state when testing. 
BUGFIX: Don't let mocked datetimes clutter the global state when testing. (from r96640) (from r96648) (from r96774)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102403 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 03:21:30 +00:00
Ingo Schommer
7c14bd233a MINOR: Give all test ADMIN privileges by default (from r92208) (from r96747) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102374 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 02:36:14 +00:00
Ingo Schommer
e19d18d3c9 BUGFIX: Fixed bug that was caused by r97583 (from r97589) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102358 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 02:14:33 +00:00
Ingo Schommer
e921b376bc API CHANGE: Don't generate TestOnly DataObjects in the database immediately; instead let test developers specify them in SapphireTest::$extraDataObjects. 
API CHANGE: Added SapphireTest::resetDBSchema() (from r90054) (from r96734)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102356 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 02:03:16 +00:00
Ingo Schommer
19c03a0bd9 MINOR: Flush get_one cache after rebuilding database schema. (from r89966) (from r96730) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102352 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 01:54:33 +00:00
Ingo Schommer
093da7592a API CHANGE: Renamed SapphireTest::set_up_once/tear_down_once to setUpOnce/tearDownOnce, and made them instance methods. 
API CHANGE: Added SapphireTest::$illegalExtensions and SapphireTest::$requiredExtensions for making tests depending on particular extension sets (from r89958) (from r96727)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102350 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 01:52:39 +00:00
Ingo Schommer
2fc2d72501 BUGFIX Fixed DataObject->fieldLabels() to respect flag 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@98748 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-02-11 02:18:54 +00:00
Andrew Short
82df67ac81 MINOR: Moved the YamlFixture class into the dev directory. 
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@97399 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-01-21 22:59:17 +00:00
Sean Harvey
848a254da7 BUGFIX If running a BuildTask via AJAX, e.g. Filesystem::sync() is run from AssetAdmin, don't show the message "Running [task] ..." (from r95169) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95635 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:49:23 +00:00
Sean Harvey
e64443b50d MINOR: added cookies to Director::test() (from r94684) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95620 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:42:43 +00:00
Sean Harvey
b79c2149d9 ENHANCEMENT Allow passing in an Exception object to SS_Log::log() in addition to an array describing the error context (line number, file, trace etc) (from r94423) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95609 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:40:52 +00:00
Sean Harvey
3665c59fff MINOR Documentation updates to SS_Log (from r94418) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95607 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:40:40 +00:00
Sean Harvey
63ce0bd4ec ENHANCEMENT Added FunctionalTest::findAttribute() as a helper for getting an attribute from a SimpleXMLElement object by it's name (from r94381) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95605 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:40:27 +00:00
Sean Harvey
424ad27d08 MINOR: Tweak to test name display on the test runner (from r94336) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95597 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:38:42 +00:00
Sam Minnee
35c6b15edc MINOR: Don't use test manifest for dev/startsession and dev/endsession (from r93528) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@94431 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-06 02:48:32 +00:00
Ingo Schommer
ef28a27b25 ENHANCEMENT Added BulkLoader->deleteExistingRecords(), removed unnecessary parameters from BulkLoader->load() 
ENHANCEMENT Decreased memory usage in BulkLoader->load() when deleting all records before importing
MINOR Re-enabled CsvBulkloaderTest cases, were disabled by accident

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@94250 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-02 09:40:28 +00:00
Ingo Schommer
261f8f897a BUGFIX Added Hierarchy::reset() to manually clear marked/expanded states triggered through Hierarchy->markExpanded() etc. This caused side effects when running e.g. CMSMainSearchFormTest and HierarchyTest alongside each other. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93987 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-11-30 02:24:46 +00:00
Ingo Schommer
ba344f2531 ENHANCEMENT Added SapphireTest->usesDatabase flag to explicitly request building of a test database for a test suite. This is necessitated by r93717, which removed the automatic building of these databases on every run. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93975 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-11-30 01:48:26 +00:00
Sean Harvey
cef45bb95a BUGFIX Fixed newlines for Windows when logging errors in LogErrorFileFormatter (from r93161) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93749 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-11-27 01:26:03 +00:00
Sam Minnee
66e4b42942 ENHANCEMENT: Don't set up the test db if database tests aren't being run. 
From: Sam Minnee <sam@silverstripe.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93717 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-11-27 00:24:56 +00:00
Ingo Schommer
f3c0cbc1ab BUGFIX Setting HTTP status in current controller for Debug::friendlyError() to avoid it being overwritten in HTTPResponse->output() later in the execution chain 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92535 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-11-21 02:31:30 +00:00
Ingo Schommer
143dae483f MINOR: Make pass use a password field, dont require call by reference (merged from r72930) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92259 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-11-19 20:23:19 +00:00
Sam Minnee
4252067f0c MINOR Changed silverstripe.com references to silverstripe.org 
MINOR Fixed broken wiki links (#4672) (from r90886)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90957 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-11-06 03:35:07 +00:00
Andrew Short
79773042be API CHANGE: Renamed conflicting classes to have an "SS_" namespace, and renamed existing "SS" namespace to "SS_". The affected classes are: HTTPRequest, HTTPResponse, Query, Database, SSBacktrace, SSCli, SSDatetime, SSDatetimeTest, SSLog, SSLogTest, SSLogEmailWriter, SSLogErrorEmailFormatter, SSLogErrorFileFormatter, SSLogFileWriter and SSZendLog. 
MINOR: Replaced usage of renamed classes with the new namespaced name.

From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90075 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-26 03:06:31 +00:00
Sam Minnee
599adc97b1 API CHANGE: Added dev/tests/build, which runs everything, meaning that dev/tests/all doesn't need to run PhpSyntaxTes 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90059 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-23 03:06:59 +00:00
Ingo Schommer
e1a47de20e BUGFIX Fixing regression in TranslatableTest due to outdated singleton caching. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89911 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-22 00:30:21 +00:00
Ingo Schommer
11d5ce0274 BUGFIX Moved SINGLETON resetting for test runs from SiteTreeTest/ObjectTest into SapphireTest - there should be no caching between all test invocations to avoid side effects 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89893 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-21 23:09:14 +00:00
Sean Harvey
84c9f8efd0 BUGFIX Removed double up of classes in TestRunner::coverage() (from r88463) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89798 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-21 04:06:29 +00:00
Sean Harvey
1e09bc4907 MINOR Check that the error file exists in Debug (from r82791) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89723 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-21 02:32:55 +00:00
Ingo Schommer
5018dc0ada MINOR Fixed assignment by reference in TestSession->lastPage() (deprecated in PHP 5.3) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89244 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-16 01:21:53 +00:00
Sam Minnee
bc6b3804b6 API CHANGE: Added SapphireTest::logInWithPermission() (from r89012) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89209 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-15 22:40:17 +00:00
Sean Harvey
57ab419736 MINOR Updated class documentation for SSLog to fix inaccurate class name, when it should actually be "SSLogEmailWriter" 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88950 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-14 06:29:05 +00:00
Sam Minnee
cad7d5e859 ENHANCEMENT: Make base tag in 404 page dynamic (from r72282) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88633 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-12 03:23:10 +00:00
Sam Minnee
c347278dda API CHANGE: Added Debug::$friendly_error_header and Debug::$friendly_error_detail for customising the friendly error message. (from r69855) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88632 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-12 03:20:24 +00:00
ajshort
97ac0008b3 ENHANCEMENT: Cached the value for RootURLController::get_homepage_link() between calls. 
From: ajshort <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88504 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-11 00:07:22 +00:00
Andrew Short
d2a1f25d16 BUGFIX #3862: Explicitly defined browsing and viewing actions on CodeViewer. 
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88473 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-10-11 00:06:57 +00:00
Sean Harvey
b77d088d47 Merged in parent::__construct() additions from branches/2.3 - r83580 and r83587 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86676 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-18 03:02:19 +00:00
Ingo Schommer
e7add7a943 MINOR Dont trim strings in Debug::message(), they are useful for indentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86222 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-14 05:41:28 +00:00
Ingo Schommer
a4cd246a72 BUGFIX Return FALSE in SapphireTest->assertDOSEquals() if no valid DataObjectSet is passed in 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86217 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-14 05:16:15 +00:00
Sean Harvey
3386e8223a MINOR Removed unnecessary $bt variable in Debug::errorHandler() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86176 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-13 23:23:02 +00:00
Ingo Schommer
5708f79312 BUGFIX Consistently returning from a Security::permissionFailure() to avoid ambiguous situations when controllers are in ajax mode 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86008 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-10 02:00:42 +00:00
Ingo Schommer
0cf75cfc65 MINOR Unified permission control for i18nTextCollectorTask, TaskRunner, TestRunner, ModelViewer, DevelopmentAdmin, TestViewer, MigrateTranslatableTask 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86005 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-10 01:49:56 +00:00
Ingo Schommer
7a27726d00 MINOR Removed alpha stage ModuleManager into new "modulemanager" module. Was never released, and won't be suitable for 2.4. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86000 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-10 01:34:20 +00:00
Julian Seidenberg
2cf002e333 ENHANCEMENT: added option to truncate (clear) database table before importing a new CSV file with CSVBulkerLoader and ModelAdmin. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85709 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-09-04 00:31:08 +00:00
Ingo Schommer
fec369531c MINOR Added SiteTree::reset() to unset any in-memory caches (see DataObject::reset()). Using reset() in SapphireTest to avoid caches persisting across multiple tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85337 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-27 06:55:32 +00:00
Ingo Schommer
1a7418c18b BUGFIX Disabled PHPUnit backup of global variables, which caused i18n::_t() calls in subsequent test cases to fail because of a cached empty global 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85330 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-27 04:45:58 +00:00
Sean Harvey
87bb1acadb BUGFIX #3713 Escape HTTP request URL properly in DebugView::writeError() using htmlentities() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85136 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-25 03:11:22 +00:00
Sam Minnee
19769e3841 API CHANGE: Added DataObjectSet assertions to SapphireTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85073 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-24 06:14:54 +00:00
Sam Minnee
d34963df8a API CHANGE: Added comparison argument to SSLog::add_writer() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85028 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-24 03:21:12 +00:00
Sam Minnee
5829c86947 Made timing code for test runner more accurate (includes initial db build): 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84970 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-21 03:02:43 +00:00
Sean Harvey
c9af2765b2 MINOR Fixed tabbing in errorHandler() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84838 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 22:58:03 +00:00
Sean Harvey
2cca0b0a7b API CHANGE Added SSLogFileWriter to replace Debug::log_errors_to() and Debug::log_error_if_necessary() - the existing formatting for the Debug deprecation functions is now wrapped into SSLogErrorFileFormatter 
MINOR Moved SSErrorLogTest to SSLogTest
MINOR Documentation updates for SSLog and other bits and pieces



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84828 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 21:55:03 +00:00
Sean Harvey
c4dcf4f2d3 MINOR Changed "Notice" and "Warning" to "User Notice" and "User Warning" if E_USER_NOTICE and E_USER_WARNING respectively 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84822 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 06:20:25 +00:00
Sean Harvey
802d95dbc9 MINOR Fixed incorrect colour for WARN priority logging 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84821 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 06:19:53 +00:00
Sean Harvey
12e54a4a6e MINOR Fixed tabbing in Debug 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84818 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 06:05:01 +00:00
Sean Harvey
1494169201 ENHANCEMENT Debug and DebugView now supports showing E_NOTICE and E_USER_NOTICE level errors, whereas before they were not handled 
ENHANCEMENT Updated SSLogErrorEmailFormatter to support NOTICE priority level logging
MINOR Updated SSBacktrace to ignore Debug::noticeHandler() in the backtrace



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84816 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 06:03:57 +00:00
Sean Harvey
2c703c8a84 MINOR Added NOTICE level priority to SSLog 
MINOR Added @deprecated php tag to deprecated functions in the Debug class
MINOR Class documentation for SSLog and Debug



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84811 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 05:41:58 +00:00
Sean Harvey
e13316d0dc MINOR Documentation updates to SSZendLog 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84805 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 05:16:58 +00:00
Sean Harvey
9e45d960bf MINOR Debug::backtrace() calls now call SSBacktrace::backtrace() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84782 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 04:22:36 +00:00
Sean Harvey
dcfd803480 MINOR Debug::get_rendered_backtrace() calls in CliTestReport, SapphireTestReporter and DebugView now call SSBacktrace::get_rendered_backtrace() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84780 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 04:20:03 +00:00
Sean Harvey
a682ab9c0e API CHANGE Moved Debug::backtrace() to SSBacktrace::backtrace() 
API CHANGE Moved Debug::get_rendered_backtrace() to SSBacktrace::get_rendered_backtrace()
ENHANCEMENT Added SSLog, SSLogEmailWriter and SSLogErrorEmailFormatter for silverstripe message reporting
API CHANGE Debug::send_errors_to() and Debug::send_warnings_to() are deprecated in favour of SSLog. See class documentation for SSLog on configuration of error email notifications
MINOR Added SSLogTest for basic testing of the SSLog and SSLogEmailWriter classes



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84774 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-19 03:55:23 +00:00
Sam Minnee
5f6bee22ba BUGFIX: Added static resetting methods for more reliable test execution. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84147 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-08-11 04:45:54 +00:00
Tom Rix
7115d327d4 MINOR made $prefix to Debug::header() optional 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82789 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-27 21:56:27 +00:00
Tom Rix
0609a8e9cd MINOR added Debug::header() for fun debugging. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82759 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-27 03:52:40 +00:00
Ingo Schommer
1f19dcdfad BUGFIX Fixed singleton() call in TestRunner?, it fails on PHP 5.2.5 with a ReflectionException? as it passes constructor arguments (merged from branches/2.3-nzct) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82065 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-16 23:56:36 +00:00
Ingo Schommer
cca0d327e7 BUGFIX Don't try to fetch contents from non-existent debug.log files in Debug::log() (merged from branches/2.3-nzct) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82059 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-16 23:48:41 +00:00
Ingo Schommer
25544b1f42 BUGFIX Fail silently on shell_exec() in CSSContentParser to avoid unit test failures because of missing optional libraries like tidy (merged from branches/2.3-nzct) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82056 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-16 23:46:24 +00:00
Ingo Schommer
79912f6ba6 MINOR Removed faulty detection of "digraph" binary from ModelViewer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81584 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-10 03:21:48 +00:00
Ingo Schommer
b459d489a3 BUGFIX Calling parent constructors in ModelViewer 
ENHANCEMENT Checking for GraphViz dependency in ModelViewer

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81544 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-10 00:37:04 +00:00
Sam Minnee
7085f1ce65 BUGFIX: Fixed dev/viewcode to see tests. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81429 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-09 03:19:26 +00:00
Ingo Schommer
c389c01f9c MINOR More backwards handling of $this->fixture references in SapphireTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81320 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-08 04:09:10 +00:00
Ingo Schommer
883be66524 MINOR Fixed array/string notation in SapphireTest error messages 
BUGFIX Using get_by_id() in DataObjectTest to grab deleted pages, to avoid error messages for missing fixtures from SapphireTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81313 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-08 02:54:01 +00:00
Ingo Schommer
6c505e5ede MINOR Moving user_error() invocations for missing fixtures from YamlFixture into SapphireTest - we shouldn't error out of a single fixture, as the object in question might be contained in another fixture on the same test 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81310 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-08 02:36:05 +00:00
Ingo Schommer
4c78f0e3e5 MINOR Wording in SapphireTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81307 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-08 01:38:01 +00:00
Ingo Schommer
f3959b038d API CHANGE Deprecated use of SapphireTest->fixture to access YML fixtures, please use gateway methods on SapphireTest instead (e.g. $this->objFromFixture() instead of $this->fixture->objFromFixture()) 
ENHANCEMENT Allowing multiple fixtures to be defined in SapphireTest::$fixture_file through array notation. 
BUGFIX Disabling DataObject validation in YamlFixture->saveIntoDatabase() instead of SapphireTest->setUp()
MINOR Adapted sapphire unit tests to deprecated $this->fixture usage

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81286 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-08 00:06:16 +00:00
Ingo Schommer
54f8ece2e7 BUGFIX Checking for class_exists() when collating testable classes in TestRunner 
ENHANCEMENT Removing space from TestRunner header output listing classnames, to make them easier to copy/paste into a custom test run command (which accepts comma-separated arguments, but has trouble with spaces)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80799 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-02 00:17:29 +00:00
Sam Minnee
f41e2b474c ENHANCEMENT: Improved performance of admin/assets area. 
BUGFIX: Fixed bug in 'sake interactive' error handling.
BUGFIX: Fixed bugs with MSSQL and Windows support.
API CHANGE: Added FormAction::setButtonContent()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80782 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-07-01 22:27:18 +00:00
Ingo Schommer
17c1d412eb ENHANCEMENT Allowing TestRunner? to skip certain tests through the ?SkipTests?=... GET paramete (merged from branches/2.3-nzct) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80646 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-30 22:35:46 +00:00
Ingo Schommer
504980ce4d ENHANCEMENT Allowing test runs per module (top-level folder), e.g. sake dev/tests/module/sapphire 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80645 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-30 22:30:33 +00:00
Sam Minnee
2bbe7dc87d BUGFIX #3991: Added missing link to dev/buildcache in dev/ homepage 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80252 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-28 02:54:01 +00:00
Sam Minnee
19c235a5bf BUGFIX #3433: Fixed test runner PHPUnit detection on an instance with trailing slashes in paths 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80215 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-27 06:29:12 +00:00
Ingo Schommer
f22bd18b5a BUGFIX Return values in TestMailer for send() commands same as Mailer class 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80148 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-26 04:28:47 +00:00
Sam Minnee
bcbe95b825 BUGFIX: Ignore deprecation errors for improved PHP 5.3 support. 
BUGFIX: Fix behaviour of FILE_TO_URL_MAPPING on Windows.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80131 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-26 02:46:14 +00:00
Sam Minnee
d8bb43ee0a MINOR ajshort: Added a space between the list of tests run so they can be broken up into multiple lines. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79569 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-18 09:34:19 +00:00
Sam Minnee
c52f67aae5 MINOR ajshort: Replaced usage of the deprecated split() function with preg_split(). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79568 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-18 09:34:17 +00:00
Sam Minnee
b93f48790e MINOR: Improved logic of SapphireTest's database deletion code. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79540 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-18 05:01:15 +00:00
Sam Minnee
610232f19c MINOR: Fixed newlines and set svn:eol-style to native 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79478 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-17 23:14:40 +00:00
Sean Harvey
6c754d29e9 Merged from branches/2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79438 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-17 11:36:49 +00:00
Sam Minnee
cd173b7c88 ENHANCEMENT: Added some basic diagnostic info to /dev 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79283 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-16 00:25:34 +00:00
Sam Minnee
3951b0ac84 BUGFIX: If a FunctionalTest fails in the middle of a get() or post() call, return an error other than the controller stack failing. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@78413 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-06-04 06:46:30 +00:00
Tom Rix
e1f54bc394 MINOR syntax error in TestRunner.php 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77706 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-25 02:31:35 +00:00
Ingo Schommer
9c10166381 BUGFIX Failing in TestRunner->init() when PHPUnit is not present, not only in specific method invocations. Previously it was missing checks on only() method 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77704 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-25 02:29:05 +00:00
Sean Harvey
cdbc501c93 MINOR Escaped characters in DebugView::writeHeader() debug page title using htmlentities() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77626 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-22 04:29:25 +00:00
Sam Minnee
3e205b632f BUGFIX: Added Versioned::on_db_reset() so that Versioned tests would run properly. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77568 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-21 08:08:01 +00:00
Sean Harvey
2b3889b640 API CHANGE Removed @deprecated 2.3 function Debug::sendLiveErrorsTo(): Please use Debug::send_errors_to() instead 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77392 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-20 07:19:14 +00:00
Sean Harvey
a1b1e337f9 Merged r77259 from sapphire/branches/2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77260 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-19 22:11:33 +00:00
Sam Minnee
392608b0fa ENHANCEMENT: Added db-abstraction for test database creation and removal. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@76345 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-07 03:49:15 +00:00
Sean Harvey
b20b6e0f95 Merged from 2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@76269 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-06 06:36:16 +00:00
Ingo Schommer
e78d6022fe BUGFIX Fixing assets filepath in Debug::friendlyError() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75914 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-05-04 02:17:56 +00:00
Ingo Schommer
b5bd96b07b ENHANCEMENT Running TestRunner tests suites alphabetically through natcasesort() instead of using the (relatively arbitrary) class ordering from ClassInfo::getSubclassesFor() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75793 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-30 23:52:55 +00:00
Sean Harvey
a5e82ddff1 Merged from branches/2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75590 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-29 01:20:24 +00:00
Sean Harvey
13b358a8dd Merged from branches/2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75582 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-29 00:07:39 +00:00
Sean Harvey
56fbe55a47 Merged from branches/2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75580 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-28 23:55:53 +00:00
Sean Harvey
76b5adc979 Merged from branches/2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75579 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-28 23:52:15 +00:00
Ingo Schommer
228b976ce1 ENHANCEMENT Adding SapphireTest::set_up_once() and SapphireTest::tear_down_once() for better test performance with state that just needs to be initialized once per test case (not per test method). Added new SapphireTestSuite to support this through PHPUnit. 
ENHANCEMENT Using set_up_once() in TranslatableTest and TranslatableSearchFormTest for better test run performance

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@74941 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-22 03:22:09 +00:00
Mark Rickerby
0881728d79 trying to see why my commits are coming up under sam's name 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@74091 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-06 00:00:42 +00:00
Sam Minnee
b34b284929 fixing bug in TaskRunner which caused broken links in the task listing 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@74089 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-04-05 23:53:25 +00:00
Ingo Schommer
2e109a27a5 ENHANCEMENT Allowing to run multiple tests comma-separated in TestRunner, e.g. through dev/tests/ObjectTest,DataObjectTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73886 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-31 19:42:08 +00:00
Ingo Schommer
b12a00c391 MINOR phpdoc documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73509 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-22 22:59:14 +00:00
Sam Minnee
a970382924 BUGFIX #3579 bgribaudo: Error in error text rendering 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73490 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-22 08:38:14 +00:00
Sam Minnee
6343aa2140 BUGFIX #3758: Fixed config-form.html for use with short_open_tag = off 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73482 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-22 00:29:18 +00:00
Sam Minnee
d922d2c36a ENHANCMENT: Improvements to 'sake interactive', thanks Hamish Friedlander 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73471 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-21 03:18:07 +00:00
Ingo Schommer
7ad7f8dcf2 ENHANCEMENT Adjusted SearchForm, Debug, ErrorPage, SiteTree to using locales instead of lang codes 
API CHANGE Changed Translatable datamodel to use locales ("en_US") instead of lang values ("en).
API CHANGE Changed Translatable::$default_lang to $default_locale, Translatable::$reading_lang to $reading_locale
API CHANGE Using "locale" instead of "lang" in Translatable::choose_site_lang() to auto-detect language from cookies or GET parameters
API CHANGE Deprecated Translatable::is_default_lang(), set_default_lang(), get_default_lang(), current_lang(), set_reading_lang(), get_reading_lang(), get_by_lang(), get_one_by_lang()
API CHANGE Removed Translatable::get_original() - with the new "translation groups" concept there no longer is an original for a translation
BUGFIX Updated MigrateTranslatableTask to new Locale based datamodel

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73468 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-20 08:47:06 +00:00
Ingo Schommer
ad3d9ae29a BUGFIX Added isDev() and Permission::check() directives to DatabaseAdmin and DevelopmentAdmin 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73251 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-17 22:23:52 +00:00
Sam Minnee
08a5a7c387 Merged from branches/2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72803 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-10 22:08:52 +00:00
Sam Minnee
a581e748d9 ENHANCEMENT: Added dev/tests/cleanupdb action to remove test databases 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72463 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-04 07:31:23 +00:00
Andrew O'Neil
635e2c3df6 Merged from 2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72453 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-03-04 03:44:11 +00:00
Sean Harvey
8989e89b4e ENHANCEMENT Allow setting unique check callback function on the importer class, to be consistency with relation callbacks 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71977 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-02-18 02:37:00 +00:00
Sean Harvey
d471bd4785 BUGFIX Ensure that TestRunner properly unsets the alternate database name (for temp databases) once the tests have finished 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71307 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-02-03 21:17:23 +00:00