Commit Graph

21412 Commits

Author SHA1 Message Date
Sam Minnee
d295888838 MINOR: Improve type testing 2019-04-05 15:11:21 +13:00
Sam Minnee
c9c7c0c825 FIX: Fix PDO cached statement column coercion
NEW: Add PDOStatementHandle class that is now what PDOQuery expects
2019-04-05 15:11:21 +13:00
Sam Minnee
2625cea5e3 MINOR: Add a test that 0 is falser on int, decimal, currency
Validates that https://github.com/silverstripe/silverstripe-framework/issues/3473 has been fixed

The bug was fixed in #8448
2019-04-05 15:11:21 +13:00
Sam Minnee
45e1fcaf30 FIX: Correct type coercion of MySQL 2019-04-05 15:11:21 +13:00
Sam Minnee
adb6e9eb8d FIX: Perform type coercion on PDO-based MySQL and SQLite connections
It turns out that this is needed for decimal values on MySQL and all
values on SQLite
2019-04-05 15:05:42 +13:00
Sam Minnee
4f4153c834 MINOR: Test test to validate that multiple GreaterThan filters in a filterAny work.
Confirms https://github.com/silverstripe/silverstripe-framework/issues/3995 isn’t a bug.
2019-04-05 15:05:42 +13:00
Ingo Schommer
afb3c825c9
Merge pull request #8890 from open-sausages/pulls/4/get-installer-to-self-create-assets-folder
BUG Update installer to create the assets folder if its missing
2019-04-05 14:41:01 +13:00
Robbie Averill
3771841dd5
Merge pull request #8901 from ian-patel/4.2
Fix Undefined variable: result when catch Exception
2019-04-05 11:53:25 +13:00
Guy Marriott
e9fe68c06c
Merge pull request #8900 from creative-commoners/pulls/4.3/test-state-isolation
MemberTest and SecurityTest now set the default authenticator to use
2019-04-05 11:49:14 +13:00
Ian Patel
759968bbe2 Fix Undefined variable: result when catch Exception 2019-04-05 11:33:01 +13:00
Robbie Averill
123d483213 MemberTest and SecurityTest now set the default authenticator to use 2019-04-05 11:26:29 +13:00
Robbie Averill
67d88c824b
Merge pull request #8880 from tractorcow/pulls/4.2/enum-schema-shifting
BUG Resolve issue where schema changes between enum / non-enum types
2019-04-05 11:09:02 +13:00
Guy Marriott
a9d57f5bfb
Merge pull request #8241 from creative-commoners/pulls/4.3/separate-logging
Separate core error logging from standard LoggerInterface
2019-04-05 08:49:09 +13:00
Guy Marriott
a3d929443a
Merge pull request #8898 from sminnee/fix-3819
FIX: Show RightTitle on CheckboxField
2019-04-04 17:23:02 +13:00
Guy Marriott
961096d921
Merge pull request #8897 from rafaeldsousa/add-array-type-validator-to-getenv
Including is_array validation to getEnv method.
2019-04-04 17:20:43 +13:00
Sam Minnee
8a098d637f FIX: Show RightTitle on CheckboxField
RightTitle, if set, will be shown after Title
with a space between them.

Fixes https://github.com/silverstripe/silverstripe-framework/issues/3819
2019-04-04 15:50:19 +13:00
Rafael Marins de Sousa
68337bd8be Including is_array validation to getEnv method. When SS website is deployed to FortRabbit .env file is read as string what causes the website to crash, due to the lack of type check at getEnv method. 2019-04-04 15:41:13 +13:00
Robbie Averill
acf449011b
Merge pull request #8895 from thats4shaw/patch-1
DOCS HistoryViewerField updates
2019-04-02 18:05:37 +13:00
Hayden Shaw
30775aa428
DOCS HistoryViewerField updates
* Add missing rollback operation in scaffolding example
* Update block_id references to id  to allow query to read query to run successfully in conjunction with HistoryViewerField
2019-04-02 16:59:52 +13:00
Robbie Averill
d816989f2e
Merge pull request #8893 from open-sausages/pulls/4/docs-critical-security-fixes
DOCS Limited "critical security fixes" release lines
2019-04-02 13:14:14 +13:00
Robbie Averill
26ff24067b
Merge pull request #8894 from antons-/patch-1
DOCS - Update path
2019-04-02 13:13:10 +13:00
Anton Smith
167881cc38 Update path 2019-04-02 12:46:19 +13:00
Ingo Schommer
af7e055574 DOCS Limited "critical security fixes" release lines
We're adopting CVSS (https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator),
which allows us to classify the impact of security issues
based on industry standard metrics.

While there is still a lot of room for interpretation,
it is more objective than our previous system of "critical/high/medium/low",
with one sentence descriptions on how we interpret that "severity rating".

This effectively changes our process to only apply
security fixes to release lines in "limited support" (currently 3.6 and 3.7)
if they're considered "critical" (CVSS > 9.0).

We've already limited preannounces to CVSS >7.0 in these docs.
2019-04-01 17:08:13 +13:00
Maxime Rainville
c84ad4278f BUG Update installer to create the assets folder if its missing 2019-03-29 17:56:39 +13:00
Andre Kiste
b77771ea09
Merge pull request #8888 from robomc/patch-1
Change case in link
2019-03-29 16:45:39 +13:00
Rob McGrail
7396f57088
Change case in link
Link doesn't resolve on https://docs.silverstripe.org/en/4/upgrading/upgrading_module/ because of the capital letter
2019-03-29 10:42:31 +13:00
Loz Calver
2073ac85c2
Merge pull request #8879 from jonom/fix-has-one-file-scaffold
FIX Allow only one file when scaffolding has_one File relationship
2019-03-27 09:16:50 +00:00
Aaron Carlino
fc6213c293 Merge branch '4.3' into 4 2019-03-27 13:25:57 +13:00
Guy Marriott
0f00154563
Merge pull request #8840 from open-sausages/pulls/4.3/has-extension-injectable
ENHANCEMENT: has_extension() should allow injector overrides
2019-03-27 13:23:30 +13:00
Aaron Carlino
9eac374b13 Use strcasecmp 2019-03-27 12:40:56 +13:00
Jonathon Menz
fae19c16b5 FIX has_one File form scaffolding
Only allow selection of a single file when scaffolding has_one File relationship (fixes #8862)
2019-03-26 09:50:59 -07:00
Damian Mooyman
6dc41e50a0
MINOR Linting fixes 2019-03-26 17:35:58 +13:00
Andre Kiste
f3535972e4 DOC Add more clear instructions on handling upgrade conflicts (#8836)
* Add more clear instructions on handling upgrade conflicts

* More module upgrading info

* Make it make sense

* Tweak sentence
2019-03-26 16:20:53 +13:00
Damian Mooyman
83ec0b69fa
BUG Resolve issue where schema changes between enum / non-enum types 2019-03-26 14:16:05 +13:00
Robbie Averill
2972acd251
Merge pull request #8878 from DorsetDigital/patch-3
Update 02_RSSFeed.md

[ci skip]
2019-03-25 08:57:17 +13:00
DorsetDigital
abe76e9b29
Update 02_RSSFeed.md
Change file name to PageController to match code.
Change example code to use parameter in `Link()` method rather than using concatenation
2019-03-23 13:22:37 +00:00
Guy Marriott
5243ec2179
Merge pull request #8811 from Juanitou/patch-5
Correct typo and commit hash in 4.3.1 changelog
2019-03-23 10:03:18 +13:00
Loz Calver
8483a9644c
Merge pull request #8874 from johannesx75/fix-pdoconnector-generatedid-type-2
Fix PDOConnector GeneratedID return type
2019-03-22 09:09:23 +00:00
Guy Marriott
4f431d5db5
Correct typo and commit hash in 4.3.1 changelog
Co-Authored-By: Juanitou <Juanitou@users.noreply.github.com>
2019-03-22 09:51:38 +01:00
Daniel Hensby
6d4d332448
Merge pull request #8830 from ntd/pr7
Fix #8829: mention get_one does not escape field names
2019-03-21 14:38:34 +00:00
Johannes Hammersen
e1190e33d2 Fix PDOConnector GeneratedID return type 2019-03-21 09:26:14 +01:00
Aaron Carlino
f6a7bddd8d Linting 2019-03-20 15:50:54 +13:00
Aaron Carlino
388baa01b4 Fix linting 2019-03-20 13:19:10 +13:00
Aaron Carlino
aa491d9294 Fix tests 2019-03-20 12:33:00 +13:00
Aaron Carlino
39a29fa2f6 ENHANCEMENT: has_extension() should allow injector overrides 2019-03-20 12:33:00 +13:00
Damian Mooyman
6b450395ce API Allow empty arraylists to be typed (#8866)
* API Allow empty arraylists to be typed

* PHPCBF fixes
2019-03-20 11:46:35 +13:00
Aaron Carlino
0b524464cd Update translations 2019-03-19 16:22:35 +13:00
Aaron Carlino
3421f931a7 Added 4.3.3 changelog 2019-03-19 16:22:35 +13:00
Robbie Averill
0777ab5ee7
Merge pull request #8847 from blueo/pulls/optional-test-teardown
Add option to leave Temp DB when exiting
2019-03-19 15:58:31 +13:00
Robbie Averill
94e5d0a642
Merge pull request #8849 from kinglozzer/middleware-requesthandler-order
FIX: RequestHandler::__construct() should run after middlewares (fixes #8848)
2019-03-19 14:43:22 +13:00