tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity
23,333 Commits 31 Branches 527 Tags
Commit Graph

2348 Commits

Author SHA1 Message Date
Sam Minnée
4ab36ac210
Merge pull request #9717 from robbieaverill/pulls/4.7/improve-stuff 
Update spaces in syntax, single quotes, early returns where possible
 2020-10-02 19:45:05 +13:00
Robbie Averill
7184703a57
Merge pull request #9516 from alessandromarotta/isLockectOut-call-LoginAttempt-getByEmail 
isLockedOut() in Member.php call LoginAttempt::getByEmail but it passes to it the unique_identifier_field instead $this->Email
 2020-10-01 17:43:30 -07:00
Robbie Averill
4d54a2110f Update spaces in syntax, single quotes, early returns where possible 2020-10-01 17:36:14 -07:00
Guy Marriott
478d487f0e
Merge pull request #9707 from robbieaverill/pulls/4.7/exceptions 2020-10-01 17:16:43 -07:00
Daniel Hensby
fe45655a2b
Merge pull request #9698 from sminnee/pulls/symfony4 
Symfony 4 support
 2020-09-30 23:22:51 +01:00
Garion Herman
8ad4c4e024 FIX Fix namespace parsing under PHP 8, tweak readability of parser 
$hadNamespace was ambiguously named, so the original PHP 8 support
update marked it true when it was strictly meant to indicate that a
namespace separator token had been encountered, resulting in bungled
parsing of complex class specs like Class(["arg" => true]).
 2020-09-30 16:16:30 +13:00
Aaron Carlino
2042d1c6b0
MINOR: Allow DevelopmentAdmin to have subclasses (#9702) 2020-09-26 21:21:16 +12:00
Robbie Averill
ae1e17edec Update exception assertions in tests and remove deprecated annotations 2020-09-25 10:06:49 -07:00
Robbie Averill
27bd5d12e3 ENH Replace E_USER_ERROR errors with exceptions 2020-09-24 23:51:21 -07:00
Sam Minnee
9247bc8b79 NEW: Add Symfony 4 support alongside Symfony 3 
- Remove duplicate key in YML file
 - Remove deprecated yaml dump indentation set (the constructor arg works in both ^3 and ^4)

Fixes #9274
 2020-09-21 19:09:08 +12:00
Dan Hensby
ae0ece2b02
Merge pull request #9665 from creative-commoners/pulls/4/php8-fqcn-token 2020-09-18 20:44:22 +01:00
Sam Minnee
0d7c5a9ece NEW Add/remove callbacks on RelationList 
This provides a mechanism for adjusting the behaviour of these
relations when building more complex data models.

For example the following example has a status field incorporates a
Status field into the relationship:

```php
function MyRelation() {
  $rel = $this->getManyManyComponents(‘MyRelation’);
  $rel = $rel->filter(‘Status’, ‘Active’);

  $rel->addCallbacks()->add(function ($relation, $item, $extra) {
    $item->Status = ‘Active’;
    $item->write();
  });
}
```

Introduces a new library dependency: http://github.com/sminnee/callbacklist
 2020-09-18 13:33:42 +12:00
Maxime Rainville
acce4c4ce7 BUG Remove old boostrap 3 CSS class 2020-09-16 11:03:27 +12:00
Loz Calver
bca0f28b62
FIX: Make template parser error on mismatched brackets (fixes #8845) 2020-09-15 16:54:24 +01:00
Loz Calver
bfc3b4b468
FIX: Stop empty comments breaking the template parser (fixes #8742) 2020-09-15 16:54:22 +01:00
Sam Minnee
85252ca05e FIX: Ensure Embed options are always array 
This maintains support for embed 3.0.0.
 2020-09-15 17:40:42 +12:00
Garion Herman
f1c94e6d54 FIX Allow quotes in expected ReflectionExceptions within tests 2020-09-15 17:40:42 +12:00
Garion Herman
44685eceba FIX Support PHP 8 namespace tokens in i18nTextCollector 2020-09-15 17:40:42 +12:00
Garion Herman
bad0662291 FIX Disable libxml_disable_entity_loader() calls in PHP 8 2020-09-15 17:40:42 +12:00
Sam Minnee
b3dd27953b NEW: Allow league/csv ^9 
Hopefully this has better PHP 8 support.
 2020-09-15 17:40:42 +12:00
Sam Minnee
09fb33e657 FIX: Avoid passing non-class to get_parent_class() 
Throws errors in PHP 8
 2020-09-15 17:40:42 +12:00
Sam Minnee
5cb3d07f44 FIX: Avoid pass-literal-by-reference warning in PHP 8 2020-09-15 17:40:42 +12:00
Steve Boyd
ab50e2cc51 Merge branch '4.6' into 4 2020-09-15 13:44:57 +12:00
Steve Boyd
e339549e0d
Merge pull request #9649 from kinglozzer/9648-security-titles 
FIX: Include missing security page titles when CMS not installed (fixes #9648)
 2020-09-15 13:43:59 +12:00
Sam Minnee
2143660c3f FIX: Add class_exists() guards to SapphireTest 
This test helper has a number of hooks to other parts of the
and required many class_exists() guards to operate without them

This has come out of PoC development work as part of:
https://github.com/silverstripe/silverstripe-framework/issues/9679

But can stand-alone as a mergeable PR.
 2020-09-14 13:49:21 +12:00
Steve Boyd
015ea8cfc8 Merge branch '4.6' into 4 2020-09-11 11:54:23 +12:00
Damian Mooyman
ac6f34846e
BUG Resolve issue where TreeMultiSelectField would error loading its value (#9604) 
* BUG Resolve issue with TreeMultiSelectField not retaining value in some situations
E.g. in an elemental form
 2020-09-11 11:52:36 +12:00
Robbie Averill
de61681dec
Merge pull request #9634 from open-sausages/pulls/4/ellipsis 
BUG Use proper ellipsis character in the various summary method.
 2020-09-10 14:48:33 -07:00
Maxime Rainville
8bcfa57342 BUG Make PasswordEncryptor::check more resistent to timing attacks 2020-09-10 22:17:50 +12:00
Maxime Rainville
acdebcdba7 Fix unit test 2020-09-10 17:08:13 +12:00
Steve Boyd
02827a6670 FIX Problem with direct compare in SELECT statement causing incompatibility with SQL Server database 
Co-authored-by: Tomas Bilek
 2020-09-10 14:48:09 +12:00
Jackson Darlow
2753f823ee
DOC Added a tip to docs describing how to set a cookie for less than a day (#9552) 
DOC Added a tip to docs describing how to set a cookie for less than a day
Co-authored-by: Garion Herman <garion@silverstripe.com>
 2020-09-10 12:34:33 +12:00
Steve Boyd
4c3a5441b2 Merge branch '4.6' into 4 2020-09-09 13:58:35 +12:00
Nicolaas
27c1c72912
FIX ModuleManifest::getModuleByPath fix to ensure right module is returned (#9569) 
* FIX: ModuleManifest::getModuleByPath returns the wrong module #9561
Co-authored-by: Nicolaas Thiemen <nt@sunnysideup.co.nz>
 2020-09-09 13:47:36 +12:00
Maxime Rainville
adaf793ddb
BUG Always validate Member credentials against DRAFT stage (#9671) 2020-09-08 11:47:04 +12:00
Sam Minnee
622cf8b914 FIX: Drop parameter names in Injector instantiation to preserve behaviour in PHP 8 
Fixes #9667
 2020-09-07 17:24:00 +12:00
Sam Minnee
e0f3797489 FIX: Remove deprecated & non-functional default argument config 
This throws deprecation errors on PHP 8.

Fixes #9666
 2020-09-07 17:24:00 +12:00
Garion Herman
08010d5933 NEW Support namespace tokens in ClassInfo::parse_class_spec() 
The T_NAME_QUALIFIED and T_NAME_FULLY_QUALIFIED tokens are introduced
in PHP 8, and encapsulate theentire FQCN, replacing the previous
structure of a group of T_STRINGs and T_NS_SEPARATORs.
 2020-09-07 17:23:56 +12:00
Guy Marriott
ff04f97149
Add return type 
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
 2020-09-01 08:43:36 -07:00
Guy Marriott
3575070b9d FIX Removing selected column detail only if having is empty (MySQL "feature") 2020-09-01 16:21:43 +12:00
Guy Marriott
f9fc4f6641 FIX Allow for BC for DB adapters that return an actual boolean when selecting boolean literals in SQL 2020-09-01 16:20:07 +12:00
Guy Marriott
ef0af7ae9c FIX Exists statements can't remove GROUP BY if there's a HAVING clause as it might rely on an aggregate 2020-09-01 16:20:07 +12:00
Guy Marriott
91591373d6 NEW Add exists as a method to the DataQuery API that will generate an SQL "exists" query 
The exists query in SQL allows the query optimiser (engine specific) to execute these queries much faster - often only needing the presence of an index to return "yes it exists".
 2020-09-01 16:20:07 +12:00
Steve Boyd
7474a76d1b
Merge pull request #9657 from creative-commoners/pulls/4/expose-recipe-core-version 
NEW Add recipe-core to default VersionProvider module list
 2020-08-28 10:36:58 +12:00
Jackson Darlow
699913406b
NEW Added a dev view to output the current config from dev/config (#9542) 
* #3236 Added dev/config view

* Refactored use of echo to

* Added config/audit for matching missing property definitions in the current config

* Minor enhancements to dev/config implementation
 2020-08-28 07:19:03 +12:00
Garion Herman
9aa2642d03
Merge pull request #9639 from creative-commoners/pulls/4/embed-performance 
NEW Cache embed shortcodes
 2020-08-27 12:15:24 +12:00
Garion Herman
680adbd10b NEW Add recipe-core to default VersionProvider module list 
Recipe versions are a more useful indicator than the framework module
version, so if installed we want to show the recipe-core version. The
cms module expands upon this to include recipe-cms.
 2020-08-26 14:49:11 +12:00
Mojmir Fendek
7c84171d5b
NEW: Improved task runner UI. (#9540) 
Co-authored-by: Sacha Judd <sjudd@silverstripe.com>
 2020-08-26 11:11:13 +12:00
Dylan Grech
efdd359485 Fixed spelling and changed to shorthand array 2020-08-23 14:31:06 +02:00
Dylan Grech
a380cc7444
Added exception for enumerated array (#9644) 
\SilverStripe\View\ArrayData::__construct() throws error when passed an enumerated array #9644
 2020-08-22 13:48:59 +02:00