Commit Graph

19291 Commits

Author SHA1 Message Date
Christopher Joe
f6b7cf8889 Feature disable current user from removing their admin permission 2017-10-30 12:34:06 +13:00
Daniel Hensby
921bf7df1e Merge pull request #7522 from dhensby/pull/5729
Fixes issue 5188: X-Forwarded Proto
2017-10-27 14:18:15 +01:00
Damian Mooyman
b6ef8d0595 Merge pull request #7519 from open-sausages/pulls/4/no-namespace-thats-a-shamespace
Add missing namespaces to docs
2017-10-27 16:17:45 +13:00
Damian Mooyman
cdfb413395
Code block whitespace / formatting cleanup 2017-10-27 15:38:27 +13:00
Damian Mooyman
2a9d1ff550 Merge pull request #5932 from silverstripe-terraformers/fixes/291-permission-checkbox-fix
Checks if $this->value is iterable
2017-10-27 13:01:59 +13:00
Aaron Carlino
e7274b0ee4 Add namespaces 2017-10-27 12:45:26 +13:00
Oly Su
4d85da179f 291 checks if ->value is iterable 2017-10-27 10:46:20 +13:00
Chris Joe
33be3a0c34 Merge pull request #7508 from open-sausages/pulls/4.0/cleanup-max-field
ENHANCEMENT Ensure DBVarchar scaffolds text field with TextField with appropriate max length
2017-10-27 10:12:48 +13:00
Ian Walls
e0c829f471
Fixes issue 5188: X-Forwarded Proto
Removes X-Forwarded-Protocol in favour of the more standard
X-Forwarded-Proto in the default Vary header config.
2017-10-26 12:20:29 +01:00
Damian Mooyman
324bdad48c
ENHANCEMENT Ensure DBVarchar scaffolds text field with TextField with appropriate max length
Fixes #1413
2017-10-26 16:21:51 +13:00
Chris Joe
f9b9e98279 Merge pull request #7500 from creative-commoners/pulls/view-button-style
Tidy up view record button
2017-10-26 13:55:23 +13:00
Chris Joe
1f576cccf1 Merge pull request #7517 from open-sausages/pulls/4.0/fix-tree-readonly-encoding
BUG Ensure readonly tree dropdown is safely encoded
2017-10-26 13:49:51 +13:00
Damian Mooyman
68c3279fd9
BUG Ensure readonly tree dropdown is safely encoded
Removed legacy entwine dead code
Added soft-deprecation to label field
2017-10-26 13:04:30 +13:00
Damian Mooyman
10894b53a4 Merge pull request #7515 from open-sausages/pulls/4.0/fix-changelog-anchors
Fix changelog anchors
2017-10-26 11:15:39 +13:00
Ingo Schommer
f006ef6354 Merge pull request #7513 from dhensby/pulls/4.0/sake-location-docs
DOCS Update sake location where relevant
2017-10-26 09:09:39 +13:00
Ingo Schommer
8725672eae Fix changelog anchors
See https://raw.githubusercontent.com/silverstripe/silverstripe-docsviewer/f61751b19e5d22dba7e72d2c195b723376dc2b71/tests/docs/en/test.md for correct format.
2017-10-26 08:41:18 +13:00
Daniel Hensby
79a5daa0a9 Merge pull request #7512 from creative-commoners/pulls/4.0/fix-escaped-readonly-treedropdown
FIX Do not escape the readonly values since they get escaped when rendered
2017-10-25 12:18:36 +01:00
Daniel Hensby
92a429b935
DOCS Update sake location where relevant 2017-10-25 11:48:50 +01:00
Robbie Averill
da4989e8f6 FIX Do not escape the readonly values since they get escaped when rendered 2017-10-25 17:36:54 +13:00
Damian Mooyman
29af6dbafd
Merge remote-tracking branch 'origin/4.0' into 4 2017-10-25 16:59:19 +13:00
Damian Mooyman
97948eb41d Added 4.0.0-rc1 changelog 2017-10-25 16:47:04 +13:00
Damian Mooyman
24a1266967 Update translations 2017-10-25 16:18:07 +13:00
Chris Joe
34f6f1b931 Merge pull request #7511 from open-sausages/pulls/4.0/installer-env-write-perms
Warn if env isn't writable
2017-10-25 15:45:14 +13:00
Damian Mooyman
97f9eddf90
Warn if env isn't writable 2017-10-25 15:07:35 +13:00
Chris Joe
2f64bfcd65 Merge pull request #7510 from open-sausages/pulls/4.0/fix-installer-env
BUG Fix env loading in installer
2017-10-25 14:45:24 +13:00
Damian Mooyman
2f82d08460
BUG Fix env loading in installer 2017-10-25 14:06:57 +13:00
Damian Mooyman
f52eecdc7f Merge pull request #7507 from open-sausages/pulls/4.0/changelog
Improve changelog
2017-10-25 12:36:05 +13:00
Damian Mooyman
ebe20bb643
Remove obsolete ToC
Update composer recommendations
2017-10-25 12:04:04 +13:00
Ingo Schommer
d56c756074 Fixed changelog indentation 2017-10-25 07:24:57 +13:00
Ingo Schommer
69f16c605c Consistent anchors in changelog headliens 2017-10-24 22:41:18 +13:00
Ingo Schommer
19d33f4de7 Moved up file migration in changelog 2017-10-24 22:37:04 +13:00
Ingo Schommer
862fcec553 Moved up .env docs in changelog
They're needed much earlier
2017-10-24 22:34:48 +13:00
Ingo Schommer
ff0b648d75 Detail links in changelogs 2017-10-24 22:33:20 +13:00
Ingo Schommer
a08c1f42d9 Deprioritised docs on minor upgrade paths 2017-10-24 22:21:49 +13:00
Ingo Schommer
5027af3926 Consistent 4.0 changelog presentation
- Use "Removed/Changed/Added/Moved" prefixes to make content more scannable
- Removed "change" vs "remove" distinction in subheadings (hard to separate, and not meaningful in practice)
- Linearised messages, less nesting - easier to parse (don't need to remember context from a few lines above)
- Simplified language (e.g. "use" instead of "please use")
- Simplified headline wording (remove repetitive "upgrade code that uses X")
- More anchor links across sections
- More use of diffs to clearly communicate before/after states
- Consistently apply backtick code formatting
- Consistently use "()" to denote methods (easier to read)
- Removed duplicate SQLQuery instructions (and simplified the augmentSQL example)
- Add new composer.json intro
2017-10-24 22:18:46 +13:00
Damian Mooyman
56b49dad34 DOCS Improve high level file documentation (#7501)
* DOCS Improve high level file documentation
Fixes https://github.com/silverstripe/silverstripe-assets/issues/62

* Updates based on feedback
2017-10-24 22:12:28 +13:00
Ingo Schommer
13d2350ad9 More upgrade rules 2017-10-24 21:18:52 +13:00
Damian Mooyman
a4b88c776f Merge pull request #7505 from open-sausages/pulls/4/ch-ch-ch-ch-ch-angesets
Document changesets
2017-10-24 17:05:35 +13:00
Aaron Carlino
4039a2ab61 Remove revert() method reference 2017-10-24 16:13:40 +13:00
Aaron Carlino
47917856c1 Revisions per Damian 2017-10-24 16:08:20 +13:00
Damian Mooyman
e76f01ebfa Merge pull request #7496 from open-sausages/pulls/4/inspect-upgrade-warnings
Upgrading rules for new inspect/warning capabilities
2017-10-24 15:25:34 +13:00
Ingo Schommer
7938b842cc More upgrader rules 2017-10-24 14:26:24 +13:00
Damian Mooyman
ff992de231 Merge pull request #7493 from kinglozzer/require-me-some-isolation
FIX: Use isolated scope when requiring files for module activation
2017-10-24 14:19:37 +13:00
Will Rossiter
ff32f99d1b Tidy up view record button 2017-10-24 14:05:40 +13:00
Damian Mooyman
093e69f6e5 Merge pull request #7506 from NightJar/patch-2
Remove dead code from GridFieldDetailForm
2017-10-24 13:30:26 +13:00
Dylan Wagstaff
7c354525fb Remove dead code from GridFieldDetailForm
There is no action for 'autocomplete', there is no method 'handleAutocomplete', and out of the box there is no extension that applies it.
Manually testing the URL that would take us through such a handler does not give an exception about missing details from the URI (such as a required query string), but instead gives us an exception on there not being a handler for such.
`[Emergency] Uncaught BadMethodCallException: Object->__call(): the method 'handleAutocomplete' does not exist on 'SilverStripe\Forms\GridField\GridFieldDetailForm'`
@ e.g. `http://localhost/admin/pages/edit/EditForm/1/field/ElementalArea/autocomplete`.

Auto complete should be (and is) handled in it's own component code, such as https://github.com/silverstripe/silverstripe-framework/blob/4.0/src/Forms/GridField/GridFieldAddExistingAutocompleter.php#L210
2017-10-24 12:57:08 +13:00
Aaron Carlino
dee0754b5a document changesets 2017-10-24 10:30:37 +13:00
Damian Mooyman
13afd6f0d5 Merge pull request #7502 from open-sausages/pulls/4.0/i-converted-an-apple-to-an-orange
Fix switch to using the Convert class for decoding
2017-10-24 10:25:53 +13:00
Sam Minnee
4bec62ba51 Merge branch '4.0' into 4 2017-10-20 18:45:16 +13:00
Damian Mooyman
b9cb1e69e6 BUG Replace phpdotenv with thread-safe replacement 2017-10-20 18:43:11 +13:00