Ingo Schommer
65209a0ed5
AssetAdmin reset button and chosen.js ( fixes #1640 )
...
See https://github.com/harvesthq/chosen/issues/215
2013-06-13 00:45:59 +02:00
Ingo Schommer
98f8191dff
Fixed Tab floating in CMS ( fixes #1778 )
...
Removed inline-block from header elements which seems
to cause the issues of tabs stacking on top of each other.
Replaced header background to work on multiline scenarios
Added bottom margin to breadcrumbs so they don't look cramped
when tabs are floated below them.
See https://github.com/silverstripe/silverstripe-framework/pull/1863 ,
https://github.com/silverstripe/silverstripe-framework/issues/1943 ,
https://groups.google.com/forum/?fromgroups#!topic/silverstripe-dev/c-W-ZxDlDuA ,
http://open.silverstripe.org/ticket/6882
2013-06-13 00:04:56 +02:00
Damian Mooyman
be986c6524
API Allow $summary_fields to support methods on DBFields
2013-06-13 09:41:24 +12:00
Ingo Schommer
88595e38f9
Merge pull request #2088 from g4b0/cache-comments
...
Inline documentation updated
2013-06-12 08:02:23 -07:00
g4b0
4b7cf5af18
2013-06-12 16:47:07 +02:00
Ingo Schommer
ab9e0286f0
Merge pull request #2051 from kinglozzer/candelete-gridfield-fix
...
Fix: Enable delete button for users with canDelete() but no canEdit() permissions
2013-06-12 02:10:41 -07:00
Ingo Schommer
25ba77d333
Merge pull request #2062 from jthomerson/enhancement_3.1_allow_disabling_prepopulate_version_number_cache
...
ENHANCEMENT: allow disabling of Versioned prepopulate_versionnumber_cache
2013-06-12 01:59:49 -07:00
Ingo Schommer
4df7f5f0f8
Merge pull request #2086 from robert-h-curry/1954-link-editor
...
BUG Fix JS issues in treedropdownfield for link editor
2013-06-12 01:18:30 -07:00
Robert Curry
eaf0fe4b2f
BUG Fix JS issues in treedropdownfield for link editor
2013-06-12 16:59:07 +12:00
Sean Harvey
dfdb274773
Merge pull request #2085 from mateusz/password-autocomplete
...
Add autocomplete=off switch for the password field.
2013-06-11 15:16:18 -07:00
Mateusz Uzdowski
d1482bee15
Add autocomplete=off switch for the password field.
...
Some clients require disabling of the browser password handling
mechanisms. Add a switch to make it possible without hacking the core.
No change to default behaviour.
2013-06-12 09:41:18 +12:00
Ingo Schommer
a643f95796
Merge pull request #2080 from tractorcow/3.1-mediadialog-overwrite-hack
...
BUG Temporarily disable overwrite warning on HtmlEditorField "insert media".
2013-06-11 00:11:39 -07:00
Ingo Schommer
1c150ac3a0
Merge pull request #2044 from jonom/patch-3
...
FIX #527 : Add Thumbnails to 'Choose another file' dialogue
2013-06-10 05:13:08 -07:00
Ingo Schommer
71a5615213
Test $allowed_actions on controllers with template name=action conventions
2013-06-10 12:33:30 +02:00
Damian Mooyman
78bd73d40d
BUG Temporarily disable overwrite warning on HtmlEditorField "insert media" dialogue until this feature properly supports validation error recovery.
2013-06-10 15:35:28 +12:00
Stig Lindqvist
dbc2b62c69
Merge pull request #2054 from chillu/pulls/dataobject-duplicate-hasone
...
BUG Correct relation saving in DataObject->duplicateRelations()
2013-06-07 22:54:36 -07:00
Stig Lindqvist
487a55f9f9
Merge pull request #2052 from chillu/pulls/onchange-tinymce-trigger
...
BUG Trigger TinyMCE onChange more frequently
2013-06-07 22:50:08 -07:00
Stig Lindqvist
2eafd63297
Merge pull request #2077 from halkyon/changepassword_validation_redirection_issue
...
BUG If BackURL set, validation errors send the user to wrong place.
2013-06-07 22:44:13 -07:00
Will Rossiter
6d792adab2
Update documentation static declarations to private
...
Also spelling, grammar and line length clean up.
2013-06-08 15:16:59 +12:00
Sean Harvey
83bff54ec2
BUG If BackURL set, validation errors send the user to wrong place.
...
If there's validation errors in the ChangePasswordForm, the user
is taken to the BackURL because redirectBack() will go there if
it's set.
Instead of this, just redirect back to the "changepassword" action
on the Security controller.
2013-06-08 11:34:58 +12:00
Will Rossiter
31cfcdb08e
Merge pull request #2076 from halkyon/passwordvalidator_translate
...
Allow PasswordValidator to be translated
2013-06-07 16:19:40 -07:00
Sean Harvey
7862ececbd
Allow PasswordValidator to be translated
2013-06-08 10:48:27 +12:00
Ingo Schommer
4ebd5ab740
Merge pull request #2057 from jthomerson/enhancement_3.1_do_not_run_abstract_test_cases
...
ENHANCEMENT: Do not attempt to run abstract test classes
2013-06-07 07:54:05 -07:00
Will Morgan
1c0ae76f8e
Adding passwordless message instead of throwing an exception
2013-06-07 16:52:44 +02:00
Andrew Short
92135acc14
Merge pull request #2063 from g4b0/mysqldatabase-extensible
...
Enhancement: replaced private with protected
2013-06-07 07:51:49 -07:00
Ingo Schommer
c45ae00d01
Merge pull request #2069 from stevie-mayhew/patch-1
...
MINOR: equality check consistency
2013-06-07 07:14:40 -07:00
Ingo Schommer
117b6887c7
Merge pull request #2070 from stevie-mayhew/patch-2
...
MINOR: equality check consistency
2013-06-07 07:14:29 -07:00
Ingo Schommer
7b7d99d3b1
Merge pull request #2071 from tractorcow/3.1-uploadfield-tweaks
...
API Removed user_error UploadField::setConfig
2013-06-07 07:13:41 -07:00
Mike Parkhill
574c11a834
Behat: "Insert image from web" feature
...
Partially fixes https://github.com/silverstripe/silverstripe-cms/issues/628
Modified a bit by Ingo :)
2013-06-07 16:10:21 +02:00
Ingo Schommer
fd6060e7be
Behat: More robust "field should contain" logic
2013-06-07 16:02:29 +02:00
Ingo Schommer
924664527b
Less assumptions in "HTML field contains" step
...
Not using the loose idea of a "field name" in the NamedSelector
sense of the word as "field with id exists".
2013-06-07 15:46:05 +02:00
Ingo Schommer
7dfe5ccbd2
Limit "should see a button" to actually visible elements
2013-06-07 15:45:15 +02:00
Stig Lindqvist
17bca1db86
Behat: Adding context for 'Given I should not see a "xxx" button'
2013-06-07 12:06:01 +02:00
Ingo Schommer
ff5624c57e
BUG Fixed dropdown step definition for "preview" dropdowns
...
Broke after I optimized it to work with a TreeDropdownField
which assumes <li><a> structures that thie "preview" dropdowns
don't have. I also failed at the recursion assignment, causing
infinite loops...
2013-06-07 11:45:09 +02:00
Damian Mooyman
96023079d5
API Removed user_error when setting missing option on UploadField via setConfig. Added documentation to this function as a replacement for the check.
2013-06-07 14:32:30 +12:00
Stevie Mayhew
76f6e0f71e
MINOR: equality check consistency
...
Updated all equality checks to use double equals (==) for consistency.
2013-06-07 12:37:52 +12:00
Stevie Mayhew
6aae3d7d05
MINOR: equality check consistency
...
Updated all equality logic checks to use double == for consistency across the page.
2013-06-07 12:33:57 +12:00
Sean Harvey
59fb88bec7
Merge pull request #2068 from sminnee/cookie-fix
...
Ensure Cookie::get() will immediately return results.
2013-06-06 16:39:52 -07:00
Sam Minnee
a6bd8f8f43
Ensure Cookie::get() will immediately return results.
...
Without this change, a call to Cookie::get() immediately after Cookie::set()
won't return the value provided. This creates some unintuitive edge-cases,
although to date it looks like they have been worked around.
The patch doesn't have a test because our testing framework doesn't deal
with cookies well.
2013-06-07 11:27:15 +12:00
Sean Harvey
c14b7997d6
Merge pull request #2067 from chillu/pulls/sqlquery-zero-limit
...
BUG Accept $limit=0 in SQLQuery->setLimit()
2013-06-06 13:52:37 -07:00
Ingo Schommer
23e51b871b
BUG Accept $limit=0 in SQLQuery->setLimit()
...
SQLQuery->setLimit(0, 99) should result in "SELECT ... LIMIT 0 OFFSET 1".
In fact it does "SELECT ..." without a LIMIT clause at all,
which is unexpected. This is regardless of the $offset value.
2013-06-06 15:27:14 +02:00
Ingo Schommer
4603378e00
Behat: Fixed step notation
2013-06-06 15:26:50 +02:00
g4b0
6618507823
Enhancement: replaced privete with protected in order to have MySQLDatabase class extensible
2013-06-06 09:06:55 +02:00
Ingo Schommer
7791f20f49
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsUiContext.php
2013-06-05 15:17:06 +02:00
Ingo Schommer
d3a4161a94
Behat: Backport improved dropdown step handler
2013-06-05 14:59:01 +02:00
Ingo Schommer
1d01347fd3
Behat: Use explicit fixtures
2013-06-05 14:32:42 +02:00
Ingo Schommer
f8b1c08c67
Behat: Copy fixture identifier to "Name" or "Title" by default
...
This makes fixture setup less verbose, particularly for behat
tests (e.g. with "Given a page 'About Us'")
2013-06-05 14:32:42 +02:00
Ingo Schommer
bb92e494d7
Behat fixture refactoring (shared factory instance)
2013-06-05 14:32:42 +02:00
Ingo Schommer
a9ed6b34cb
Behat: Support for TreeDropdownField
2013-06-05 14:32:42 +02:00
Ingo Schommer
a39adb46db
Behat: New fixture notation in "manage files" tests
2013-06-05 14:32:41 +02:00