Commit Graph

20948 Commits

Author SHA1 Message Date
Loz Calver
441d079647
Merge pull request #8637 from creative-commoners/pulls/4.4/falsy-detail-component
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 18:28:26 +01:00
Loz Calver
213ec240b0
Merge pull request #8635 from creative-commoners/pulls/4.4/redundant-right-group
FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected
2018-11-26 18:28:01 +01:00
Robbie Averill
fa26ead0f6
DOCS Add namespaces to PHP i18n examples, and reference __CLASS__ and self::class as options 2018-11-26 17:15:17 +01:00
Robbie Averill
f22a4b980b FIX getComponentByType can return null - prevent null pointer errors 2018-11-26 16:01:46 +01:00
Robbie Averill
efa427fc45 FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected 2018-11-26 12:42:47 +01:00
Robbie Averill
1f1c344272 Merge branch '4.3' into 4
# Conflicts:
 #	tests/php/Forms/ConfirmedPasswordFieldTest.php
2018-11-26 12:15:17 +01:00
Robbie Averill
41dc9229bf FIX Reverting ExtensionTestState and Extensible extra methods modifications to prevent PHP 5.6 segfault (#8581)
* API Revert addition of Extensible::flush_extra_methods_cache() and change to ExtensionTestState

This reverts the changes from #8465 and #8505 that relate to ExtensionTestState and the
tracking of extra methods between unit tests. The existing test from #8465 testing
overloaded Extensions after extra_methods are populated has been updated to show that you
must re-add the extension to flush the extra_methods cache if you need this behaviour.

* Revert change to InjectorTest::testExtendedExtensions

* Revert "Add failing test to show that overloaded extensions are broken in Extensible"

This reverts commit 55e79ffdfd.

* DOCS Add docs for extending extensions, and upgrade guide note to 4.3 to avoid using PHP config to do so
2018-11-26 12:00:02 +13:00
Jan Alfred Richter
34373dad99
Update 03_Environment_Management.md
Info: You can't use them outside of Injector config (as of 4.2).
2018-11-26 09:17:48 +13:00
Jan Alfred Richter
0353b29652
Referencing env vars in configs
As mentioned here: https://stackoverflow.com/a/53459699/2111274
2018-11-26 08:42:10 +13:00
Guy Marriott
84c8dace7d
Merge pull request #8621 from open-sausages/pulls/4.3/tweak-site-tree-search
FIX Explicity mark nodes when searching
2018-11-23 16:14:46 +13:00
Serge Latyntcev
f526c794fc Minor / Refactor php tests for TreeMultiselectField 2018-11-23 16:03:44 +13:00
Andre Kiste
1d9e40ba26 Use new plus icon (#8619)
* Use new plus icon and refactor

* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level

* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring

* Refactor to fail gracefully on GridFieldPaginator

* Fix merge
2018-11-23 12:40:18 +13:00
Robbie Averill
661d2567fa
Merge pull request #8612 from micmania1/docs/upgrade-docs
DOCS add step to upgrade existing database class references
2018-11-22 07:25:33 +01:00
micmania1
f1710f0bfd DOCS add step to upgrade existing database class references 2018-11-22 12:53:26 +13:00
Serge Latyntcev
9ce6d91b76 FIX / TreeMultiselectField::objectForKey handles list of IDs correctly 2018-11-22 12:11:18 +13:00
Robbie Averill
3b24323263
Merge pull request #8629 from aledbrown/patch-1
renderWith() - Namespace added for Template Loading
2018-11-21 17:37:27 +01:00
Aled Brown
ff1a0dd6fc
renderWith Namespace for Template Loading
Just calling MyCustomTemplate does not work in SS 4.2.X. Adding the full Namespace as a path is now required.
2018-11-21 15:28:12 +00:00
Maxime Rainville
d74af1c17e FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621 2018-11-21 11:43:21 +13:00
Serge Latyntcev
80885fc231 ADD php test TreeMultiselectField::testEmptyChoiceReadonly 2018-11-20 16:45:23 +13:00
Robbie Averill
6d6ce61b8f
Merge pull request #8616 from creative-commoners/pulls/4.3/rolling-out-rollback-docs
DOCS Updating HistoryViewer documentation to specify the rollback mutation instead of copyToStage
2018-11-19 12:01:51 +01:00
Guy Marriott
d19c7f2a2d
DOCS Updating HistoryViewer documentation to specify the rollback mutation instead of copyToStage 2018-11-19 14:08:02 +13:00
Andre Kiste
cc712892a9 NEW Port betterbuttons to framework (#8569)
* MINOR: Add `Previous`, `Next` and `Create New` actions in edit form

If the form is opened via a grid field, the filters will be retained so the previous/next record opened will be correct

* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level

* Fix invalid action when pressing the `New` button in an edit form unless `betterbuttons` module was installed

* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring

* Refactor to fail gracefully on GridFieldPaginator
2018-11-19 11:06:47 +13:00
Guy Marriott
2a0e868260
Merge pull request #8606 from creative-commoners/pulls/4.3/history-viewer-docs
DOCS Add documentation for configuring a HistoryViewerField for custom DataObjects
2018-11-19 09:30:21 +13:00
Robbie Averill
3b1e91eb59 Merge branch '4.2' into 4.3 2018-11-15 13:41:23 +02:00
Robbie Averill
ef0f9dff8a Merge branch '4.1' into 4.2 2018-11-15 13:41:00 +02:00
Robbie Averill
c6e3a398c7 Merge branch '4.0' into 4.1 2018-11-15 13:40:08 +02:00
Robbie Averill
c181a17790
Merge pull request #8610 from kinglozzer/urltoken-redirect-loop
FIX: Redirect loop with multiple confirmation tokens present (fixes #8607)
2018-11-15 13:38:21 +02:00
Loz Calver
b5bae137bd FIX: Redirect loop with multiple confirmation tokens present (fixes #8607) 2018-11-15 10:59:42 +00:00
Robbie Averill
cc5c59e39d
Merge pull request #8608 from christopherdarling/patch-12
DOCS fix link to XHProf article
2018-11-15 11:26:55 +02:00
Andre Kiste
34103f5e8a
Merge pull request #8604 from creative-commoners/pulls/4.3/password-validator-test-fixes
FIX Ensure that tests setting passwords have stubbed configuration
2018-11-15 15:34:21 +13:00
Christopher Darling
c186c8ea68
DOCS fix link to XHProf article 2018-11-14 21:56:57 +00:00
Robbie Averill
71eeaa090e DOCS Add documentation for configuring a HistoryViewerField for custom DataObjects
[ci skip]
2018-11-14 14:08:06 +02:00
Robbie Averill
0e64b6ed3f
Merge pull request #8605 from scott1702/patch-4
Add new core committers
2018-11-14 12:07:40 +02:00
Scott Hutchinson
70897495d6
Add new core committers 2018-11-14 23:06:17 +13:00
Robbie Averill
7d1d6d0f7b FIX Ensure that tests setting passwords have stubbed configuration 2018-11-14 11:54:17 +02:00
Andre Kiste
d1823665e7
Merge pull request #8600 from creative-commoners/pulls/4.3/password-validator-docs
DOCS Update documentation for password validation rule configuration
2018-11-14 12:22:45 +13:00
Andre Kiste
04d1a767e6
Merge pull request #8601 from creative-commoners/pulls/4.3/fix-password-validator-tests
FIX Remove default password validation rules before running unit tests
2018-11-14 11:48:35 +13:00
Robbie Averill
0bb94b018b FIX Remove default password validation rules before running unit tests 2018-11-13 14:09:08 +02:00
Robbie Averill
af8d268cc7 DOCS Update documentation for password validation rule configuration 2018-11-13 10:55:26 +02:00
Andre Kiste
d2cc773720
Merge pull request #8587 from creative-commoners/pulls/4.3/password-requirements
FIX Move password complexity requirements into framework
2018-11-13 18:15:31 +13:00
Serge Latyntcev
15aaf9db9f Fix a code style typo 2018-11-13 10:20:49 +13:00
Thor Chen
bda7653ae3 DOC: Fix outdated information and make enhancements for 2018-11-12 18:24:37 +13:00
Guy Marriott
b2dd22fb50
Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests
NEW Adding a stack more unit tests for logging and some form fields
2018-11-11 10:31:24 +13:00
Robbie Averill
bab84f31dc Remove underscores from variable test class names 2018-11-10 14:55:11 +02:00
Robbie Averill
eba92d77df Rename CheckboxFieldReadonlyTest for future PSR-2 compatibility 2018-11-10 10:04:17 +02:00
Sam Minnee
a8d3b95175 FIX: Make test work with utf8mb4 2018-11-10 12:10:25 +13:00
Sam Minnee
bd5a815909 FIX: Make all enums non-destructive, not just ClassName
This change also renders a portion of DBSchemaManager irrelevant, that
destructively “fixes” old values. This is in keeping with the
non-destructive principle of dev/build, and some suggestions to move
away from enum fields altogether.

Fixes https://github.com/silverstripe/silverstripe-framework/issues/1387
2018-11-10 12:10:25 +13:00
Robbie Averill
a12a5b7168
Merge pull request #8377 from creative-commoners/pulls/4.3/bootstrap-alerts
NEW Use Bootstrap alerts throughout the CMS
2018-11-09 14:27:38 +02:00
Robbie Averill
0f2eebe5d4 NEW Change to variadic calls in ListDecorator and add unit tests 2018-11-09 13:59:14 +02:00
Loz Calver
bbb208e1dd
Merge pull request #8499 from sminnee/fix-1489
FIX: CheckboxSetField can now save into DBMultiEnum
2018-11-09 10:40:55 +01:00