Commit Graph

2217 Commits

Author SHA1 Message Date
Paul Clarke
4cc6cc3151 Fix position of back button on empty preview within campaigns 2016-10-31 12:55:53 +13:00
Paul Clarke
1395ee0c31 Don't hide gridfield content on small list view of tree 2016-10-31 12:21:48 +13:00
Paul Clarke
a5d3dccd37 Fix for preview being under toolbar 2016-10-28 16:53:00 +13:00
Paul Clarke
5df797b705 Toolbar-content to be flexible 2016-10-28 16:53:00 +13:00
Paul Clarke
50f0c1f37c Remove fixed height for batch actions 2016-10-28 16:53:00 +13:00
Paul Clarke
2daca4ebc6 Improve alert text, fix spacing 2016-10-28 16:53:00 +13:00
Paul Clarke
706d2b6458 Add additional space to tree bottom, required for large tree 2016-10-28 16:52:03 +13:00
Paul Clarke
fad8df83cc Remove console.log 2016-10-28 16:52:03 +13:00
Paul Clarke
71a4eb7d22 Hide preview in campaigns, override list styles for mobile 2016-10-28 16:52:03 +13:00
Paul Clarke
4373eb6801 Hide sitetree in smaller screens for setting and pages 2016-10-28 16:51:03 +13:00
Christopher Joe
debb1a947e Add responsive class for Campaign list
Fix back button in preview
Fix add to campaign in pages section
2016-10-28 16:51:03 +13:00
Paul Clarke
5350fcf650 Delete legacy styles in Layout, move rest to CampaignAdmin. Convert to BEM 2016-10-28 16:47:50 +13:00
Paul Clarke
c82c88ebf6 Remove legacy classes 2016-10-28 16:44:54 +13:00
Paul Clarke
5257c92fcd Remove legacy class 2016-10-28 16:44:54 +13:00
Paul Clarke
4ce2bcc360 Add back button style if it has text 2016-10-28 16:44:54 +13:00
Paul Clarke
3fd5a6d4e6 Add left border to preview and bg 2016-10-28 16:44:54 +13:00
Paul Clarke
d761075fd3 Move mock back button 2016-10-28 16:44:54 +13:00
Paul Clarke
0885a3178e Adjust button padding so they all have the same height 2016-10-28 16:44:54 +13:00
Paul Clarke
25783db020 toolbar-north to be 100%, removed from toolbar-content 2016-10-28 16:44:54 +13:00
Paul Clarke
50af94099e Remove some legacy layout styles 2016-10-28 16:39:59 +13:00
Paul Clarke
a95781e66e Search and batch actions to have same selected state 2016-10-28 16:39:59 +13:00
Paul Clarke
96964be39d Sitetree scroll moved so whole area scrolls excluding actions 2016-10-28 16:39:59 +13:00
Paul Clarke
364ab957e6 improve spacing of sitetree for smaller screens 2016-10-28 16:39:59 +13:00
Paul Clarke
6254f186b1 Remove border on left of preview mode 2016-10-28 16:39:59 +13:00
Paul Clarke
27724c0829 Remove set width of toolbar-content as it extends further than 100% 2016-10-28 16:39:59 +13:00
Chris Joe
82119888c1 Validation on server side for React forms (fixes #6205) 2016-10-28 16:13:29 +13:00
Damian Mooyman
d7ed308e17 BUG Fix minor html encoding issue in SecurityAdmin (#6240) 2016-10-28 15:22:21 +13:00
Michael Strong
1df533298d BUG abstract HTMLEditorConfig instantiates (#6244)
https://github.com/silverstripe/silverstripe-framework/blob/master/Forms/HTMLEditor/HTMLEditorConfig.php#L64

On line 64, HTMLEditorConfig tries to create an instance of itself if it doesn't exist. However, HTMLEditorConfig is abstract and this throws an error.

This is caused by admin/_config.php
2016-10-28 15:21:44 +13:00
Damian Mooyman
adfd0456de Merge pull request #6241 from open-sausages/pulls/4.0/fix-pagination-wrapping
BUG Prevent pagination wrapping
2016-10-28 13:44:28 +13:00
Damian Mooyman
42096bb41b
BUG Prevent pagination wrapping
Fixes https://github.com/silverstripe/silverstripe-asset-admin/issues/269
2016-10-27 11:58:19 +13:00
Damian Mooyman
5551040839 API Update listview / treeview to use pjax instead of deferred loading 2016-10-26 14:29:10 +13:00
Damian Mooyman
44b65429f1 Merge pull request #6212 from open-sausages/pulls/4.0/search-bg
Adjustments for filter panel positioning
2016-10-26 14:27:24 +13:00
Christopher Joe
8de2f9dbb4 switched from calc to negative margin 2016-10-26 10:43:51 +13:00
Ingo Schommer
bed547fc86 Merge pull request #6206 from Chibby/master
Prevent undefined index notices
2016-10-26 09:06:35 +13:00
Paul Clarke
4b413d395e Adjustments for filter panel positioning 2016-10-21 14:09:39 +13:00
Damian Mooyman
316ac86036
API Writes to versioned dataobjects always writes to stage even when written on live
API Remove "Archive" actions
API "Delete" actions for pages now archives records
BUG Fix batch actions failing on certain controllers
Fixes #6059
2016-10-21 13:16:32 +13:00
Ingo Schommer
9ca359e5de Merge pull request #6208 from open-sausages/pulls/4.0/tab-spacing
Add spacing to nested tabs
2016-10-21 12:53:35 +13:00
Ingo Schommer
bf02abe688 Merge pull request #6209 from open-sausages/pulls/4.0/button-internal-padding
Remove additional spacing from buttons with no icon
2016-10-21 12:53:19 +13:00
Paul Clarke
833dbbcafe remove additional spacing from buttons with no icon 2016-10-21 11:40:31 +13:00
Paul Clarke
19c1ed9443 add spacing to nested tabs 2016-10-21 11:28:29 +13:00
Damian Mooyman
7cd32b7d72
Remove unnecessary $schemaLink parameter 2016-10-21 11:11:18 +13:00
Martijn
b0566b0cb8 Prevent undefined index notices 2016-10-20 14:04:15 +02:00
Ingo Schommer
aa47845a6c Updated dist files 2016-10-20 22:03:42 +13:00
Ingo Schommer
3a690d8084 Moved promise polyfill into boot logic
It's not specific to one single component
2016-10-20 22:03:42 +13:00
Ingo Schommer
54a4cef863 Consistently use 'value' for FormField schemas
LiteralField (data.content) was inconsistent with HTMLReadonlyField (value),
which made the frontend components harder to handle.

See https://github.com/silverstripe/silverstripe-framework/pull/6172#discussion_r83561757 for contex
2016-10-20 22:03:38 +13:00
Christopher Joe
84c0df3db0 Fix double forward slash link in campaign admin 2016-10-20 21:49:10 +13:00
Ingo Schommer
5b31a40593 Use redux-form instead of custom actions/reducers (fixes #5524)
- Removed custom form reducers in favour of redux-form (updateField(), addForm(), etc)
- Storing 'state' in schema reducer to avoid a separate forms reducer tree (no longer needed for other use cases). This means 'state' is only the "initial state", any form edits will be handled by redux-form internally in the 'reduxForm' reducer namespace
- Removed componentWillUnmount() from <Form> since there's no more reducer state to clean up (removed formReducer.js), and redux-form handles that internally
- Removed isFetching state from <FormBuilder> since there's now a props.submitting coming from redux-form
- Improved passing of "clicked button" (submittingAction), using component state rather than reducer and passing it into action handlers (no need for components to inspect it any other way)
- Hacky duplication of this.submittingAction and this.state.submittingAction to avoid re-render of <FormBuilder> *during* a submission (see https://github.com/erikras/redux-form/issues/1944)
- Inlined handleSubmit() XHR (rather than using a redux action). There's other ways for form consumers to listen to form evens (e.g. onSubmitSuccess passed through <FormBuilder> into reduxForm()).
- Adapting checkbox/radio fields to redux-forms
  Need to send onChange event with values rather than the original event,
  see http://redux-form.com/6.1.1/docs/api/Field.md/#-input-onchange-eventorvalue-function-
- Using reduxForm() within render() causes DOM to get thrown away,
  and has weird side effects like https://github.com/erikras/redux-form/issues/1944.
  See https://github.com/erikras/redux-form/issues/603#issuecomment-176397728
- Refactored <FormBuilderLoader> as a separate container component which connects to redux and redux-form. This keeps the <FormBuilder> component dependency free and easy to test. It'll also be an advantage if we switch to a GraphQL backed component, in which case the async loading routines will look very different from the current <FormBuilderLoader> implementation
- Refactoring out the redux-form dependency from FormBuilder to make it more testable (through baseFormComponent and baseFieldComponent)
- Passing through 'form' to allow custom identifiers (which is important because currently the schema "id" contains the record identifier, making the form identifier non-deterministic - which means you can't use it with the redux-form selector API)
2016-10-20 21:49:06 +13:00
Ingo Schommer
5f81122ad3 Removed misdocumented 'data' prop 2016-10-20 15:33:50 +13:00
Ingo Schommer
1e478a5378 Consistently set 'id' in FormSchema
The URL to request the schema representation is the unique identifier.
We can't default to $request->getURL() since that's different for form submissions.

The schema.schema_url key is redundant, since the identifier is already contained on the top level 'id' key.
Keeping schema_url in a schema itself makes it less portable, particularly once we transition into
generic schemas which are not reliant on a particular record context (that's only contained in the schema_url)

This also fixes the issue of form schemas not refreshing after submit,
e.g. when form fields are added or removed.
2016-10-20 15:33:50 +13:00
Damian Mooyman
3f773c826a Merge pull request #6189 from open-sausages/pulls/4.0/split-pages-toolbar
Split top toolbar for Pages section
2016-10-18 18:44:06 +13:00