Commit Graph

21278 Commits

Author SHA1 Message Date
Robbie Averill
1ac36611a6 Update tests to pass in CWP kitchen sink context 2018-12-02 23:04:34 +00:00
Maxime Rainville
731ef00f7a
Merge pull request #8627 from creative-commoners/pulls/4.3/abstr-action-state
FIX Provide alternatives to session for storing GridField_FormAction state
2018-12-03 11:58:05 +13:00
Robbie Averill
59efddccb2
Merge pull request #8653 from hpeide/patch-3
Update 02_Images.md
2018-12-02 15:15:05 +01:00
Hans Philip Eide
f9cd6d9a15
Update 02_Images.md
If the default is that resampling is off, shouldn't the example be that force_resample is set to true to enable resample?
2018-12-01 13:36:52 +01:00
Robbie Averill
f1170255cb
Merge pull request #8652 from edlinklater/patch-2
FIX incorrect composer module type
2018-11-30 19:55:08 +01:00
Ed Linklater
cc7aa7b68b
FIX incorrect composer module type
Was silverstripe/vendormodule, should be silverstripe-vendormodule
2018-12-01 07:53:21 +13:00
Guy Marriott
c7b5b1efd2
FIX Switching to use Controller::curr as it was using previously 2018-11-30 15:40:45 +13:00
Guy Marriott
32d096d9e5
DOCS Moving interface subscription to the abstract and adding a changelog entry 2018-11-30 15:40:45 +13:00
Guy Marriott
aace1da1f0
DOCS Adding notes on configuring the storage method for GridField_FormActions 2018-11-30 15:40:45 +13:00
Guy Marriott
ddaa22986f
Updating StateStore interface not to define a constructor & fixing GridFieldFilterHeader to add required attributes 2018-11-30 15:40:45 +13:00
Guy Marriott
b4c8f699eb
FIX Provide alternatives to session for storing GridField_FormAction state 2018-11-30 15:40:45 +13:00
Sam Minnee
0c17ffc944 FIX: Manifest should ignore vendor folders within packages contained in vendor
Without this change vendor/silverstripe/framework/vendor/silverstripe/config
will be pick up by the manifest, which is inappropriate.

Although this doesn’t happen often, it can occur if you have run
“composer install” within vendor/silverstripe/framework, which can be
done either accidentally or (in my case) as part of running the
framework tests isolated from the rest of your project (which is closer
to the execution model on Travis)

Note that the presence of the ‘nestedvendor.txt’ file tests that this
works without any explicit changes to the PHP of the tests, since it’s
merely confirming that such a file is *not* picked up.
2018-11-30 13:52:25 +13:00
Serge Latyntcev
4ee63eb4e7 TreeMultiselectFieldTest / make scrutinizer happy 2018-11-29 12:13:56 +13:00
Serge Latyntcev
38f8217f01 TreeMultiselectFieldTest / setUp is protected in PHPUnit5 2018-11-29 09:55:28 +13:00
Aled Brown
5d15d20f0f ModelAdmin Menu Icon Class Documentation Added + Namespace Permissions (#8646) 2018-11-28 18:23:37 +01:00
Loz Calver
3f8551df41
Merge pull request #8462 from sminnee/nondestructive-enum
FIX: Make all enums non-destructive, not just ClassName
2018-11-28 16:42:12 +01:00
Guy Marriott
1b68157e39
Merge pull request #8633 from falnyr/patch-1
Referencing env vars in configs
2018-11-27 09:43:47 +13:00
Loz Calver
441d079647
Merge pull request #8637 from creative-commoners/pulls/4.4/falsy-detail-component
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 18:28:26 +01:00
Loz Calver
213ec240b0
Merge pull request #8635 from creative-commoners/pulls/4.4/redundant-right-group
FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected
2018-11-26 18:28:01 +01:00
Robbie Averill
fa26ead0f6
DOCS Add namespaces to PHP i18n examples, and reference __CLASS__ and self::class as options 2018-11-26 17:15:17 +01:00
Robbie Averill
f22a4b980b FIX getComponentByType can return null - prevent null pointer errors 2018-11-26 16:01:46 +01:00
Robbie Averill
efa427fc45 FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected 2018-11-26 12:42:47 +01:00
Robbie Averill
1f1c344272 Merge branch '4.3' into 4
# Conflicts:
 #	tests/php/Forms/ConfirmedPasswordFieldTest.php
2018-11-26 12:15:17 +01:00
Robbie Averill
41dc9229bf FIX Reverting ExtensionTestState and Extensible extra methods modifications to prevent PHP 5.6 segfault (#8581)
* API Revert addition of Extensible::flush_extra_methods_cache() and change to ExtensionTestState

This reverts the changes from #8465 and #8505 that relate to ExtensionTestState and the
tracking of extra methods between unit tests. The existing test from #8465 testing
overloaded Extensions after extra_methods are populated has been updated to show that you
must re-add the extension to flush the extra_methods cache if you need this behaviour.

* Revert change to InjectorTest::testExtendedExtensions

* Revert "Add failing test to show that overloaded extensions are broken in Extensible"

This reverts commit 55e79ffdfd.

* DOCS Add docs for extending extensions, and upgrade guide note to 4.3 to avoid using PHP config to do so
2018-11-26 12:00:02 +13:00
Jan Alfred Richter
34373dad99
Update 03_Environment_Management.md
Info: You can't use them outside of Injector config (as of 4.2).
2018-11-26 09:17:48 +13:00
Jan Alfred Richter
0353b29652
Referencing env vars in configs
As mentioned here: https://stackoverflow.com/a/53459699/2111274
2018-11-26 08:42:10 +13:00
Guy Marriott
84c8dace7d
Merge pull request #8621 from open-sausages/pulls/4.3/tweak-site-tree-search
FIX Explicity mark nodes when searching
2018-11-23 16:14:46 +13:00
Serge Latyntcev
f526c794fc Minor / Refactor php tests for TreeMultiselectField 2018-11-23 16:03:44 +13:00
Andre Kiste
1d9e40ba26 Use new plus icon (#8619)
* Use new plus icon and refactor

* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level

* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring

* Refactor to fail gracefully on GridFieldPaginator

* Fix merge
2018-11-23 12:40:18 +13:00
Robbie Averill
661d2567fa
Merge pull request #8612 from micmania1/docs/upgrade-docs
DOCS add step to upgrade existing database class references
2018-11-22 07:25:33 +01:00
micmania1
f1710f0bfd DOCS add step to upgrade existing database class references 2018-11-22 12:53:26 +13:00
Serge Latyntcev
9ce6d91b76 FIX / TreeMultiselectField::objectForKey handles list of IDs correctly 2018-11-22 12:11:18 +13:00
Robbie Averill
3b24323263
Merge pull request #8629 from aledbrown/patch-1
renderWith() - Namespace added for Template Loading
2018-11-21 17:37:27 +01:00
Aled Brown
ff1a0dd6fc
renderWith Namespace for Template Loading
Just calling MyCustomTemplate does not work in SS 4.2.X. Adding the full Namespace as a path is now required.
2018-11-21 15:28:12 +00:00
Maxime Rainville
d74af1c17e FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621 2018-11-21 11:43:21 +13:00
Serge Latyntcev
80885fc231 ADD php test TreeMultiselectField::testEmptyChoiceReadonly 2018-11-20 16:45:23 +13:00
Robbie Averill
6d6ce61b8f
Merge pull request #8616 from creative-commoners/pulls/4.3/rolling-out-rollback-docs
DOCS Updating HistoryViewer documentation to specify the rollback mutation instead of copyToStage
2018-11-19 12:01:51 +01:00
Guy Marriott
d19c7f2a2d
DOCS Updating HistoryViewer documentation to specify the rollback mutation instead of copyToStage 2018-11-19 14:08:02 +13:00
Andre Kiste
cc712892a9 NEW Port betterbuttons to framework (#8569)
* MINOR: Add `Previous`, `Next` and `Create New` actions in edit form

If the form is opened via a grid field, the filters will be retained so the previous/next record opened will be correct

* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level

* Fix invalid action when pressing the `New` button in an edit form unless `betterbuttons` module was installed

* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring

* Refactor to fail gracefully on GridFieldPaginator
2018-11-19 11:06:47 +13:00
Guy Marriott
2a0e868260
Merge pull request #8606 from creative-commoners/pulls/4.3/history-viewer-docs
DOCS Add documentation for configuring a HistoryViewerField for custom DataObjects
2018-11-19 09:30:21 +13:00
Robbie Averill
3b1e91eb59 Merge branch '4.2' into 4.3 2018-11-15 13:41:23 +02:00
Robbie Averill
ef0f9dff8a Merge branch '4.1' into 4.2 2018-11-15 13:41:00 +02:00
Robbie Averill
c6e3a398c7 Merge branch '4.0' into 4.1 2018-11-15 13:40:08 +02:00
Robbie Averill
c181a17790
Merge pull request #8610 from kinglozzer/urltoken-redirect-loop
FIX: Redirect loop with multiple confirmation tokens present (fixes #8607)
2018-11-15 13:38:21 +02:00
Loz Calver
b5bae137bd FIX: Redirect loop with multiple confirmation tokens present (fixes #8607) 2018-11-15 10:59:42 +00:00
Robbie Averill
cc5c59e39d
Merge pull request #8608 from christopherdarling/patch-12
DOCS fix link to XHProf article
2018-11-15 11:26:55 +02:00
Andre Kiste
34103f5e8a
Merge pull request #8604 from creative-commoners/pulls/4.3/password-validator-test-fixes
FIX Ensure that tests setting passwords have stubbed configuration
2018-11-15 15:34:21 +13:00
Christopher Darling
c186c8ea68
DOCS fix link to XHProf article 2018-11-14 21:56:57 +00:00
Robbie Averill
71eeaa090e DOCS Add documentation for configuring a HistoryViewerField for custom DataObjects
[ci skip]
2018-11-14 14:08:06 +02:00
Robbie Averill
0e64b6ed3f
Merge pull request #8605 from scott1702/patch-4
Add new core committers
2018-11-14 12:07:40 +02:00