Commit Graph

1684 Commits

Author SHA1 Message Date
Ingo Schommer
447ec71471 MINOR better error reporting for broken redirector & virtual pages (from r97185) (from r98155)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102622 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:27:30 +00:00
Ingo Schommer
99be47c479 MINOR if the $fieldname to DOS->sort has a direction in it, split it out, and pass it. (from r96482) (from r98140)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:25 +00:00
Ingo Schommer
864a15db8e MINOR redirector link tracking is more intelligent (from r96461) (from r98139)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:11 +00:00
Ingo Schommer
9b650a4e6c MINOR remove sort direction when running canSortBy. Also added test coverage for this. (from r96428) (from r98138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:50 +00:00
Ingo Schommer
83ccc4f6d9 BUGFIX: Don't make ManifestBuilder choke on empty files. (from r96058) (from r98133)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:37 +00:00
Ingo Schommer
5044de817e BUGFIX: removing search&replace victim, using unpopulated cache. Reverted to AllChildren, which calls the cache itself. (from r98111)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:27 +00:00
Ingo Schommer
21299ba686 ENHANCEMENT Allow user theme selection through SiteConfig, falling back to SSViewer::set_theme() as a default if there are none selected
MINOR Unit tests for SSViewer::current_theme() and SiteConfig::getAvailableThemes() (from r98110)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:12 +00:00
Ingo Schommer
1e20e55c68 MINOR don't HTML-format queries from showqueries if this is an AJAX request. (from r95855) (from r98097)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:24 +00:00
Ingo Schommer
453faed88a API CHANGE: Refactored test for whether a SQLQuery can be sorted by a particular column into SQLQuery::canSortBy($fieldName) (from r95850) (from r98096)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:12 +00:00
Ingo Schommer
da778dd2a9 BUGFIX: Make TableListField rely on SQLQuery for its count-generation.
BUGFIX: Make SQLQuery return an appropriate count if a HAVING clause is used. (from r95814) (from r98094)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:45 +00:00
Ingo Schommer
2ae6f896e3 Add some nice date formats (from r95772) (from r98093)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:26 +00:00
Ingo Schommer
753a8804ac ENHANCEMENT ManifestBuilder::get_manifest_info() now uses ManifestBuilder::get_themes() instead of doing it's own retrieval of available themes
MINOR Added ManifestBuilderTest::testThemeRetrieval() to test ManifestBuilder::get_themes() (from r98091)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102583 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:02:52 +00:00
Ingo Schommer
72bb124951 MINOR: Edit-case checking of data in ViewableData::$failover for better error message. (from r95560) (from r98090)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:02:18 +00:00
Ingo Schommer
0ee0244a01 MINOR added direct links to items in the backlinks report (from r88277) (from r98085)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:00:41 +00:00
Ingo Schommer
7bd479156b MINOR Changed MySQLDatabase::now() block comment to be more useful (from r98059)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:25 +00:00
Ingo Schommer
a5dde231b6 API CHANGE Decimal now allows setting a default value properly
MINOR Unit tests for Decimal field type default value through new test class DecimalTest (from r98056)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102571 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:13 +00:00
Ingo Schommer
529ed1dd1d MINOR: niced the way MultiEnums call requireField to give alternative adapter access (from r98043)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:50:15 +00:00
Ingo Schommer
a2055d1d67 MINOR: use ENUM hack for dealing with SET legacy values (from r98042)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:49:58 +00:00
Ingo Schommer
92a25a3e68 FEATURE: added support for MySQL data type SET used in MultiEnum FEATURE: added datetime helper functions (from r98041)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:49:40 +00:00
Ingo Schommer
25ad651966 APICHANGE: rename the class "Cache" to "SS_Cache" (ref ticket: #4997) (from r97996)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:48:06 +00:00
Ingo Schommer
98de6165ea MINOR: groupby works for SQLite too (from r97985)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:51 +00:00
Ingo Schommer
1997485ba3 BUGFIX #5009: Removed inappropriate field-detection change on multienums with no default (from r97980)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:27 +00:00
Ingo Schommer
9e9dcb1b96 MINOR: Better error message on bad Enum default (from r97979)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:45:53 +00:00
Ingo Schommer
37e9c9e569 BUGFIX: remove the possibility that Director::isDev() could be recursively called when putting isDev=1 in $_GET, addressed in ticket #4978 (http://open.silverstripe.org/ticket/4978) (from r97926)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:45:00 +00:00
Ingo Schommer
6c0efa68de BUGFIX Allowing translations of VirtualPage by not copying over original Locale property (see #5000) (from r97912)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:44:23 +00:00
Ingo Schommer
48bd1ffa24 BUGFIX If a Group doesn't have any specific TRANSLATE_<locale> edit rights, but has general CMS access (CMS_ACCESS_CMSMain, CMS_ACCESS_LeftAndMain, ADMIN), then assign TRANSLATE_ALL permissions as a default. Necessary to avoid locking out CMS editors from their default language (see #4940 and 4941) (from r97911)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:44:03 +00:00
Ingo Schommer
6fb2a2a2e0 MINOR Removed debug code (from r97910)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:43:44 +00:00
Ingo Schommer
ee4174c0e2 Added values for new permission code 'VIEW_DRAFT_CONTENT' test (from r97898)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:43:29 +00:00
Ingo Schommer
9a04ca62d2 Added test for new permission code. (from r97897)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:42:50 +00:00
Ingo Schommer
22fde45409 ENHANCEMENT: 2.4 tickets (#4670) new permission code to view draft w/o CMS access (from r97896)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:34:28 +00:00
Ingo Schommer
54d166c4ce ENHANCEMENT: 2.4 tickets (#4670), new permission code to view draft stage w/o CMS access (from r97895)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:33:49 +00:00
Ingo Schommer
930b051182 BUGFIX Checking that URL controller in HTTPRequest->match() is a subclass of Controller, not RequestHandler (which would include nested controllers like Form or FormField subclasses that shouldn't be accessible on their own toplevel URL namespace) (from r97881)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:30:43 +00:00
Ingo Schommer
d43c990e56 BUGFIX Using i18n::get_locale() in ContentController->ContentLocale() to ensure the correct locale can be used in templates withouth Translatable enabled (broken in r97207, thanks DesignCity)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:05:45 +00:00
Ingo Schommer
279031cc3a MINOR fix call to undefined method when a virtual page picks up the wrong object. (from r97875)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:44:25 +00:00
Ingo Schommer
731269988e MINOR PHP notice error (from r97838)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:43:52 +00:00
Ingo Schommer
68fb898c6d API CHANGE: Added cancelSchemaUpdate() and doesSchemaNeedUpdating() to the Database class (from r97827)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:43:10 +00:00
Ingo Schommer
d62b3303f0 API CHANGE Fixed i18n _t() calls without namespaces in template includes: They now default to setting the include filename as namespace, rather than the including template (#4915, #3400 - thanks Henk_Poley, jwalsoe, walec51) (from r97797)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102534 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:39:15 +00:00
Ingo Schommer
29ea7e0b98 BUGFIX Use BASE_PATH and BASE_URL instead of data from $_SERVER.
API CHANGE: Determine default BASE_PATH/BASE_URL from the __FILE__ content, so that the script that initiated the Sapphire process doesn't matter.  This means that index.php doesn't need to manipulate those variables. (from r97731)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:15:04 +00:00
Ingo Schommer
40899c3bfb BUGFIX: Don't rely on the current working directory for any file access; use BASE_PATH. (from r97728)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:14:36 +00:00
Ingo Schommer
efa09e60a5 MINOR: replaced proprietary update query with one that is ANSI compliant in doPublish() (from r97705)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:11:58 +00:00
Ingo Schommer
891de73b31 MINOR Fixed undefined variable in SiteTree::can_edit_multiple() (broken in r83442)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102516 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:46:40 +00:00
Ingo Schommer
fa8c4b128c BUGFIX: Fixed potential data corruption issue when you are changing the class of a SiteTree subclass between two subclasses that share a fieldname. (from r97594)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:30:07 +00:00
Ingo Schommer
69543bb575 BUGFIX #4929: Fixed Object::add_static_vars() for uninherited static.s (from r97586)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102510 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:00:25 +00:00
Ingo Schommer
1417722d9e API CHANGE #4929: Add $class argument to DataObjectDecorator::extraStatics() (from r97582)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102508 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:58:35 +00:00
Ingo Schommer
b70c2df842 MINOR Using SiteTree::get_by_link() in SiteTree->requireDefaultRecords() (see #4590) (from r97484)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102499 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:54 +00:00
Ingo Schommer
f331e2e1a6 BUGFIX: Was using custom_database_fields in Aggregate, not database_fields, and so aggregates for the common fields (LastEdited, Created, ClassName) would fail (from r97414)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102489 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:10:21 +00:00
Ingo Schommer
2969a7ee44 FEATURE: Add partial caching support to SSViewer. (from r97391)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102488 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:09:54 +00:00
Ingo Schommer
4e850f6011 FEATURE: Add aggregate calculation to DataObject, allowing (cached) calculation of Max, Min, Count, Avg, etc (from r97390)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102448 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:04:34 +00:00
Ingo Schommer
1039cfade4 FEATURE Allowing translation of SiteConfig (including toplevel permission groups)
BUGFIX Fixed SiteConfig->canView()/canEdit() to respect empty CanViewType/CanEditType assignments. (from r97370)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102445 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:02:31 +00:00
Ingo Schommer
40466ccb02 BUG FIX: The 5.1 replacement array_fill_keys function now made available to the cron jobs (from r97300)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102441 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:00:40 +00:00