Sam Minnee
212765ae5c
MINOR: Made extract() call a little tighter.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 23:04:43 +00:00
Ingo Schommer
e54a2e75e6
BUGFIX Fixed many_many relations querying in RestfulServer
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81346 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 08:28:17 +00:00
Ingo Schommer
c389c01f9c
MINOR More backwards handling of $this->fixture references in SapphireTest
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81320 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 04:09:10 +00:00
Ingo Schommer
b8736bd5b2
BUGFIX Fixed SiteTreeTest to work with new fixture handling: objFromFixture() can no longer be used to determine if an item has been deleted, as it will throw a warning
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81319 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 04:06:23 +00:00
Ingo Schommer
883be66524
MINOR Fixed array/string notation in SapphireTest error messages
...
BUGFIX Using get_by_id() in DataObjectTest to grab deleted pages, to avoid error messages for missing fixtures from SapphireTest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81313 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 02:54:01 +00:00
Ingo Schommer
6c505e5ede
MINOR Moving user_error() invocations for missing fixtures from YamlFixture into SapphireTest - we shouldn't error out of a single fixture, as the object in question might be contained in another fixture on the same test
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81310 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 02:36:05 +00:00
Ingo Schommer
4c78f0e3e5
MINOR Wording in SapphireTest
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81307 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 01:38:01 +00:00
Ingo Schommer
f3959b038d
API CHANGE Deprecated use of SapphireTest->fixture to access YML fixtures, please use gateway methods on SapphireTest instead (e.g. $this->objFromFixture() instead of $this->fixture->objFromFixture())
...
ENHANCEMENT Allowing multiple fixtures to be defined in SapphireTest::$fixture_file through array notation.
BUGFIX Disabling DataObject validation in YamlFixture->saveIntoDatabase() instead of SapphireTest->setUp()
MINOR Adapted sapphire unit tests to deprecated $this->fixture usage
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81286 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 00:06:16 +00:00
Sam Minnee
2000087dd6
BUGFIX: Fixed application of parameterised extensions with Object::add_extension()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81173 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-07 01:28:47 +00:00
Ingo Schommer
cf302011b8
BUGFIX Fixed Form->handleField() to first look for fieldByName() before falling back to dataFieldByName(). This was necessary for tabs and formfields having the same name, e.g. "Members" in the SecurityAdmin class. We have to ensure to return the data field instead of the (non-datafield) tab.
...
MINOR Added documentation about URL handling to Form
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81130 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 22:06:42 +00:00
Ingo Schommer
4a531820cd
BUGFIX Accepting dot-notation in TabSet->fieldByName()
...
BUGFIX Using fieldByName() instead of dataFieldByName() in Form->handleField() to allow rendering of nested tabs through a URL
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81128 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 21:53:50 +00:00
Ingo Schommer
fcc6948e79
BUGFIX Setting brokenOnConstruct to FALSE in CompositeField::__construct() - it skips a constructor, hence breaking request handling (and therefore direct field access through /Form/Field/MyCompositeField/FieldHolder
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81127 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 21:48:12 +00:00
Sam Minnee
7f77bc4733
BUGFIX: Removed double-call to augmentSQL in DataObject::get
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80961 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-03 03:45:11 +00:00
Sam Minnee
2b61c12adc
BUGFIX #4325 : Fixed publishing of empty values by fixing DataObject::forceChange()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80934 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-03 01:21:48 +00:00
Sam Minnee
57bb3c09d7
BUGFIX: Fixed Versioned::publish() when the class name is bad, for example after a module has been removed.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80933 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-03 01:21:13 +00:00
Sean Harvey
1b1809f1a2
Merged from branches/2.3
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80873 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-02 07:18:18 +00:00
Ingo Schommer
54f8ece2e7
BUGFIX Checking for class_exists() when collating testable classes in TestRunner
...
ENHANCEMENT Removing space from TestRunner header output listing classnames, to make them easier to copy/paste into a custom test run command (which accepts comma-separated arguments, but has trouble with spaces)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80799 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-02 00:17:29 +00:00
Sam Minnee
f41e2b474c
ENHANCEMENT: Improved performance of admin/assets area.
...
BUGFIX: Fixed bug in 'sake interactive' error handling.
BUGFIX: Fixed bugs with MSSQL and Windows support.
API CHANGE: Added FormAction::setButtonContent()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-01 22:27:18 +00:00
Ingo Schommer
aaef41a122
MINOR renamed case sensitive SSDatetimeTest for filename to match classname
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80666 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-01 00:36:57 +00:00
Sam Minnee
0924d723b6
BUGFIX #3937 : Fixed substr_count in HTTPRequest to be mbstring compatible
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80655 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-30 23:21:50 +00:00
Sam Minnee
9fdf9e1dc8
BUGFIX #3892 : Removed reference to non-existent blockquote module in front-end tiymce.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80651 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-30 22:55:53 +00:00
Ingo Schommer
17c1d412eb
ENHANCEMENT Allowing TestRunner? to skip certain tests through the ?SkipTests?=... GET paramete (merged from branches/2.3-nzct)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80646 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-30 22:35:46 +00:00
Ingo Schommer
504980ce4d
ENHANCEMENT Allowing test runs per module (top-level folder), e.g. sake dev/tests/module/sapphire
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80645 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-30 22:30:33 +00:00
Ingo Schommer
8ae9db13c0
ENHANCEMENT Added ClassInfo::classes_for_folder()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80641 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-30 22:08:59 +00:00
Rainer Spittel
ca4ec1af03
ENHANCEMENT: enabled saveInto to use the setter method when available instead of passing through the form field values directly to the money class.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80521 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-30 03:16:28 +00:00
Sean Harvey
14e77970c8
MINOR Added test for the inverse for DataObjectDecoratorTest::testOneToManyAssociationWithDecorator()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80352 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-29 05:14:06 +00:00
Sean Harvey
628a0b7b88
ENHANCEMENT Don't give an error if ContentController::childrenOf() can't find the parent page, since this error isn't that useful
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80341 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-29 04:53:15 +00:00
Sam Minnee
2bbe7dc87d
BUGFIX #3991 : Added missing link to dev/buildcache in dev/ homepage
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80252 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-28 02:54:01 +00:00
Sam Minnee
7f5838ce3d
BUGFIX: MemberAuthenticator::authenticate() returns a member object or false, in keeping with the current docs.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80250 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-28 02:48:33 +00:00
Sam Minnee
73cfe3ab84
API CHANGE: Added increase_time_limit_to(), which respects safe_mode.
...
API CHANGE: Added no-arg option to increase_memory_limit_to()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80241 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-28 02:36:46 +00:00
Sam Minnee
66b25f1e62
BUGFIX: Fixed CSRF warning in image form after selecting a folder.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80237 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-28 01:17:20 +00:00
Sam Minnee
273ec1b240
ENHANCEMENT: Don't look for i18n lang files in hidden directories
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80236 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-28 01:16:56 +00:00
Sam Minnee
43abccf15d
MINOR: Bugfix to previous commit.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80233 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 13:36:01 +00:00
Sam Minnee
96250e0136
ENHANCEMENT: Added MySQLDatabase::set_connection_charset() so that utf8 data can be stored properly in the MySQL database.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80231 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 13:26:31 +00:00
Sam Minnee
56199e45e7
BUGFIX #3900 : Fix Director::forceWWW()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80230 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 13:08:23 +00:00
Sam Minnee
038d1ecec2
ENHANCEMENT #4041 : Improved performance of SQLQuery::renameTable()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80229 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 13:00:51 +00:00
Sam Minnee
7ae9a9e352
BUGFIX #2391 : Removed pagination header when there are no records.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80228 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 12:29:47 +00:00
Sam Minnee
e2dcc48d48
ENHANCEMENT ajshort: Allow a HTTPResponse to be encapsulated in a HTTPResponse_Exception, which can be later caught by the request handler.
...
MINOR ajshort: Updated RequestHandler->httpError() to interrupt the execution flow by throwing an exception.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80226 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 08:48:44 +00:00
Sam Minnee
c0c72e4c53
BUGFIX ajshort: Ensure that CSRF security token settings are passed from parent controllers/forms into child forms.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80225 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 08:48:42 +00:00
Sam Minnee
86ccd8cb96
API CHANGE: Removed DB::getNextID(), which was deprecated some time ago
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80224 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 08:36:10 +00:00
Sam Minnee
2926b34e50
API CHANGE: Removed unused and unnecessary PDODatabase. For mssql and postgres support, see the relevant modules.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80223 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 08:30:17 +00:00
Sam Minnee
ef82fe2859
MINOR #3776 : Fixed documentation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80222 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 07:42:31 +00:00
Sam Minnee
9069d5ae46
MINOR #3399 : Removed last references to DefaultFieldHolder.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80220 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 07:00:01 +00:00
Sam Minnee
f882f55492
BUGFIX #3732 : Fixed validation of SilverStripeNavigator HTML
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80219 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 06:41:19 +00:00
Sam Minnee
19c235a5bf
BUGFIX #3433 : Fixed test runner PHPUnit detection on an instance with trailing slashes in paths
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80215 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 06:29:12 +00:00
Sam Minnee
f6c8f6bd54
BUGFIX #4239 : Check that project folder exists and throw a more helpful warning.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 06:03:30 +00:00
Sam Minnee
6bcabcbe46
BUGFIX #4306 simon_w: Fixed ConfirmedPasswordField::setValue()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80192 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 04:00:10 +00:00
Sam Minnee
547a9b700d
BUGFIX #4303 : Fixed File::CMSThumbnail() HTML
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80184 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 03:30:47 +00:00
Ingo Schommer
f22bd18b5a
BUGFIX Return values in TestMailer for send() commands same as Mailer class
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80148 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-26 04:28:47 +00:00
Ingo Schommer
da1f065cf7
BUGFIX Removing quotes from test data in RestfulServiceTest, it gives different results depending on magic_quotes_gpc setting on PHP configuration
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80132 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-26 03:14:22 +00:00