Marcus Nyeholt
428cbe4b03
FIX issue with Injector::create not passing args
...
If creating an object using Injector::create() and constructor arguments
are passed through, in some cases where the object being created had a yml
configuration set for it, the passed in constructor arguments weren't being
passed through to the instantiation of the object.
2013-02-15 10:24:47 +11:00
Ingo Schommer
f4068371fc
Merge pull request #1159 from chillu/pulls/datetimefield-field-setters
...
DatetimeField->setDateField()/setTimeField()
2013-02-14 11:31:31 -08:00
Julian Seidenberg
f931b8d326
API Data corruption on Versioned due to lazy loading
...
Lazy loading no longer loads fields from the versions table when querying. This could lead to incorrect data being displayed if the data on the object and the version it pointed to did not match.
API methods to allow setting of the context of the query that generated the DataObject on that object (used by the lazy loading mechanism to correctly query the Stage, Live, or Versions tables)
See https://github.com/silverstripe/sapphire/pull/1178 for context.
2013-02-14 14:18:10 +01:00
Simon Welsh
be8482aa73
Merge pull request #1173 from ajshort/include-object-argument
...
BUG: Pass named include argument as objects.
2013-02-13 23:44:29 -08:00
ajshort
d3629be344
BUG: Pass named include argument as objects.
...
This means you can pass objects such as lists as named parameters, not
just strings.
2013-02-14 18:31:40 +11:00
Zauberfisch
54237d5b10
NEW Return $this on setters in DataObject
2013-02-13 18:18:37 +01:00
ajshort
ff19f3b11a
BUG: Fixed the injection of named services.
2013-02-13 23:06:15 +11:00
Ingo Schommer
923ad8861f
Layout regression in "add pages"
...
Unrelated fields affected by changes to CMS tooltips. See 1ca3883a76
.
2013-02-13 10:15:06 +01:00
Sean Harvey
15a156955b
Merge pull request #1172 from robert-h-curry/preview-pane-refresh
...
Force preview window to refresh on every save
2013-02-12 15:09:19 -08:00
Sean Harvey
b25b6d4769
Merge pull request #1182 from chillu/pulls/showtemplate-admin-ss3
...
API Require ADMIN for ?showtemplate=1 (3.0)
2013-02-12 15:07:34 -08:00
Sean Harvey
9337902fdd
Merge pull request #1181 from chillu/pulls/showtemplate-admin
...
API Require ADMIN for ?showtemplate=1 (2.4)
2013-02-12 15:07:13 -08:00
Ingo Schommer
d969e29d00
API Require ADMIN for ?showtemplate=1
2013-02-12 23:26:04 +01:00
Ingo Schommer
45c68d6821
API Require ADMIN for ?showtemplate=1
2013-02-12 23:21:13 +01:00
Ingo Schommer
b44720179c
Merge pull request #1180 from mateusz/css-combining-media
...
API Add possibility to combine media-targeting stylesheets.
2013-02-12 14:13:45 -08:00
Mateusz Uzdowski
53feb3a5ae
API Add possibility to combine media-targeting stylesheets.
2013-02-13 11:04:05 +13:00
Sean Harvey
02d58b1015
Merge pull request #1177 from mateusz/session-set-form-message
...
BUG Adjust Session::setFormMessage to fit with underlying API.
2013-02-11 15:14:12 -08:00
Mateusz Uzdowski
d52d5f71c5
BUG Adjust Session::setFormMessage to fit with underlying API.
2013-02-12 11:00:36 +13:00
uniun
8ea805e60b
Long drop area title overlaps upload icon
2013-02-11 15:13:42 +02:00
ajshort
a4096ecc70
Add a self method to the SSViewer scope.
...
This returns the current object, and resets the scope.
2013-02-11 17:53:14 +11:00
Robert Curry
7ff8d35be0
Force preview window to refresh on every save
2013-02-08 12:04:18 +13:00
Ingo Schommer
14a56c18e9
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
control/Director.php
2013-02-07 21:45:16 +01:00
Jeremy Bridson
2e77e87ed3
BUGFIX: fix for broken layout in insert media dialog - Trac #8232
2013-02-07 21:43:34 +01:00
Ingo Schommer
8b50e32f65
Merge pull request #1170 from g4b0/docs-scheduled-tasks
...
Fixed error in documentation
2013-02-07 11:14:47 -08:00
g4b0
f2a9a2657e
Fixed error in documentation
2013-02-07 16:49:52 +01:00
ajshort
5e6813c02a
Use the injector for creating tasks.
2013-02-08 00:32:16 +11:00
Ingo Schommer
1a43ad5ed3
Removed widths on DatetimeField children
...
Makes it more flexible in regards to field widths,
e.g. DMY fields vs. a single input field. Also allows
to extend with additional fields more easily, e.g.
a drop down through the "timedropdownfield" module.
2013-02-07 11:41:20 +01:00
Ingo Schommer
048f6b19fe
Removed DatetimeField->setDescription() proxying
...
We shouldn't pass it to the child fields since it ends
up showing the description three times in the default
"inline" mode. If the description is required as a hover/focus effect,
it can be set individually on the fields.
2013-02-07 11:41:20 +01:00
Ingo Schommer
121fb662e6
Merge pull request #1137 from jonom/patch-2
...
API: Use HTMLText as default for RSS Description
2013-02-07 02:15:23 -08:00
Ingo Schommer
2b05951d41
Merge pull request #1160 from uniun/patch-3
...
Incorrect Contant-Type header for RSS feeds
2013-02-07 02:14:09 -08:00
Ingo Schommer
79eacb2439
FIX Group->canEdit() correct non-admin checks ( fixes #8250 )
...
Due to changed return value of DataObject::get(),
the (negated) check always returned false.
This wasn't noticed in 3.0 because Group->canEdit() is rarely
enforced, but does become noticeable in 3.1 where GridField
checks those object-level permissions.
Thanks to @purplespider for reporting!
2013-02-07 09:19:57 +01:00
Sean Harvey
3a97b622d1
Merge pull request #1165 from robert-h-curry/has_extension-deprecation-fix
...
Fix deprecated use of has_extension
2013-02-06 17:33:44 -08:00
Robert Curry
cc1a5824f2
Fix deprecated use of has_extension
2013-02-07 14:30:46 +13:00
Ingo Schommer
a1beda14d1
Removed explicit pass-by-ref in DataExtension->validate()
...
Same fix as be97535b
for 3.1. Makes the method signature
more consistent with other DataExtension methods,
and comply with its subclass implementation in
Hierarchy->validate(). See accbd7f1e2
for more comments.
2013-02-06 19:00:23 +01:00
Ingo Schommer
b31dbc0b5f
Merge pull request #1163 from schwarz-computer-systeme/3.0
...
Update admin/javascript/lang/de_DE.js
2013-02-06 01:37:23 -08:00
senglmann
bb223bb35f
Update admin/javascript/lang/de_DE.js
...
fixed typo in translation
2013-02-06 10:13:49 +01:00
Ingo Schommer
d289016bc3
DataObject on*() callbacks now consistently invoke on subclasses as well
...
Before this was only possible for some specific ones, like onBeforeWrite.
This excludes any callbacks with augment*() or update*() naming,
since these are assumed to be on extension only, with a corresponding
base method available on the class itself (e.g. "updateCMSFields()"
vs "getCMSFields()").
2013-02-05 23:28:09 +01:00
Ingo Schommer
18c9a95996
API Removed 'BadLoginURL' session var from MemberLoginForm
...
It was never set in core, and is generally undocumented,
hence just unnecessarily increases the security surface
of this sensitive class.
2013-02-05 22:49:06 +01:00
Will Rossiter
1db0156832
Merge pull request #1162 from dhensby/patch-1
...
NEW Add Varchar::getSize()
2013-02-05 12:19:07 -08:00
Daniel Hensby
f0621cdd91
FEATURE: Added ability to query size of Varchar
...
This allows a developer to programatically access the size of the DB Varchar field. This allows us to be a bit more DRY and to define the size in one place and limit TextFields to the same value
2013-02-05 18:41:11 +00:00
Ingo Schommer
083b6b2164
NEW Upload->replaceFile setting
2013-02-05 19:28:24 +01:00
uniun
e249799e9a
Incorrect Contant-Type header for RSS feeds
...
It should be application/rss+xml but not text/xml.
2013-02-05 18:11:28 +02:00
Ingo Schommer
b350ded87c
Fixed DatetimeField formatting (single row, smaller field)
...
Also removed the arbitrary right-floating of fields within a fieldgroup
2013-02-05 12:01:32 +01:00
Ingo Schommer
6c22545639
DatetimeField->setDateField()/setTimeField()
...
Useful e.g. to override the time field with the
"silverstripe/timefield" dropdown
2013-02-05 11:03:19 +01:00
Ingo Schommer
1acb416a7f
NEW Don't load CMS preview iframe if not visible ( fixes #8247 )
2013-02-05 10:23:48 +01:00
Ingo Schommer
3931945e62
Merge pull request #1158 from halkyon/deleteaction
...
Trigger delete confirmation popup when deleting a GridFieldDetailForm re...
2013-02-05 00:10:21 -08:00
Sean Harvey
d320247627
Trigger delete confirmation popup when deleting a GridFieldDetailForm record
2013-02-05 13:14:03 +13:00
Sean Harvey
ba825cec28
Remove whitespace from LeftAndMain_Menu
2013-02-05 12:30:14 +13:00
Sean Harvey
632e0e898d
Simplify sentence on shortcodes
2013-02-05 10:43:01 +13:00
Ingo Schommer
fe740515b4
Loading "OR" in admin/assets for Chrome ( fixes #8245 )
2013-02-04 22:00:12 +01:00
Ingo Schommer
56d8eb96f0
Merge pull request #1157 from mateusz/shortcode-docs
...
Move the shortcode docs to documentation, add examples.
2013-02-04 12:43:58 -08:00