Commit Graph

4087 Commits

Author SHA1 Message Date
Ingo Schommer
16c93b1284 MINOR Made Upload::load() error more useful (from r100499)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:04:20 +00:00
Ingo Schommer
ecb6c8cb3f BUGFIX: replacing calls to deprecated Upload functions - using validator instead (related to r100057) (from r100496)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:03:46 +00:00
Ingo Schommer
1e5944c690 API CHANGE Removed deprecated File::loadUploaded(), please use Upload directly instead! (from r100495)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105580 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:58:39 +00:00
Ingo Schommer
56ba78b2a5 API CHANGE Removed deprecated function RootURLController::get_homepage_urlsegment(), please use RootURLController::get_homepage_link() instead! (from r100493)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:58:22 +00:00
Ingo Schommer
046dd623be API CHANGE Removed deprecated function SiteTree::get_by_url(), please use SiteTree::get_by_link() instead! (from r100492)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:57:46 +00:00
Ingo Schommer
93d405c4a3 MINOR Fixed tabbing in DataObjectSet (from r100491)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105577 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:56:02 +00:00
Ingo Schommer
a06e2af9ef API CHANGE Removed deprecated methods DataObjectSet::filter_map() and DataObjectSet::map_multiple() - please use map() instead! (from r100490)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:55:47 +00:00
Ingo Schommer
7e8a2c10c9 MINOR Changed places of Object::extInstance() to Object::getExtensionInstance() and added a notice if extInstance is used in future (from r100487)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:55:30 +00:00
Ingo Schommer
45d8433d57 MINOR Pushed @deprecated 2.3 items out to 2.5 since they're still in use for now (from r100486)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105574 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:54:48 +00:00
Ingo Schommer
584e8a5ee6 MINOR Changed @deprecated note for Director::redirectBack to 2.5 as it's still widely used (from r100483)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:54:29 +00:00
Ingo Schommer
731720d7be BUGFIX #5012 BasicAuth should check if there's already a current member logged in before asking for a login/password (from r100466)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:54:14 +00:00
Ingo Schommer
dd7e7f813d MINOR Fixed regression of Convert::json2obj() not working when json_decode() is being used (from r100461)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105571 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:53:58 +00:00
Ingo Schommer
d5e48d55dc ENHANCEMENT #4599 DataObjectSet now uses more array functions instead of performing equivalent tasks - thanks simon_w! (from r100453)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:53:43 +00:00
Ingo Schommer
d74e3c43fe BUGFIX GD::setQuality() persistence issue because the GD instance is re-created instead of being cloned - thanks Tjofras! (from r100438)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:53:12 +00:00
Ingo Schommer
f7c34fc73c MINOR phpDoc bits for Convert Services_JSON functions (from r100424)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:52:56 +00:00
Ingo Schommer
30b2a950fe ENHANCEMENT Convert JSON functions now use the Services_JSON library where appropriate instead of custom code, and if json_decode() or json_encode() are available these are used
MINOR Added unit tests for Convert JSON functions (from r100423)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:52:38 +00:00
Ingo Schommer
a5608657cc MINOR Use "email" instead of username for validation of admin account during install (from r100418)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105566 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:52:01 +00:00
Ingo Schommer
f298275295 MINOR: Blocking unnecessary revisions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105565 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:51:43 +00:00
Ingo Schommer
28f80b8da5 BUGFIX #5121 Fixed cache flushing for FieldSet when removing fields - thanks paradigmincarnate! (from r100417)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:51:35 +00:00
Ingo Schommer
65b3bec774 BUGFIX #5136 Ensure $coverage argument to TestRunner::runTests() has a strict check before running coverage tests, as sometimes an SS_HTTPRequest object can be passed into this argument (from r100415)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:51:11 +00:00
Ingo Schommer
23e7a9a22d MINOR Geoip class no longer extends Object, as it's not necessary (from r100409)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105562 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:50:56 +00:00
Ingo Schommer
00d19cc3d1 BUGFIX: FormAction input tag attributes were being doubly-escaped. (from r100407)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:50:37 +00:00
Ingo Schommer
ffa1267516 BUGFIX: Fix mismatch with $all_locales and $common_locales (#5096) (from r100406)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:50:19 +00:00
Ingo Schommer
252be427f7 ENHANCEMENT #5072 RSSFeed_Entry::rssField() now respects custom getters on the data class (from r100400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105559 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:49:55 +00:00
Ingo Schommer
8f8a3b2f6e BUGFIX YamlFixture::writeDataObject() - some databases need special allowance to edit the primary key column - do so by using DB::getConn()->allowPrimaryKeyEditing() (from r100393)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105558 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:49:22 +00:00
Ingo Schommer
cf5afb4018 MINOR Updated installer to use "CMS / Framework" instead of just "CMS"
MINOR Updated copyright year to current year (from r100387)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:45:51 +00:00
Ingo Schommer
95c4befb4a BUGFIX: Sam's fix for "Unknown column Group.SubsiteID" with new subsites (from r100375)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:45:27 +00:00
Ingo Schommer
08fb51c584 BUGFIX: use localized prefix to compare group codes rather than hard coded english string. MINOR: updated lang file (from r100370)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:45:11 +00:00
Ingo Schommer
5db5bbf9df BUGFIX: PHP 5.1 requires an array rather than a string for call_user_func() (from r100367)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:44:54 +00:00
Ingo Schommer
e5eff98e15 BUGFIX: Show Language dropdown in English (#5098) (from r100359)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:44:31 +00:00
Ingo Schommer
179641d972 MINOR correct order of OBW (from r100323)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:43:28 +00:00
Ingo Schommer
ba4ad49422 BUGFIX: Fix TestRunner coverage pattern to work as documented (Fixes QA scripts too) (from r100116)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:43:11 +00:00
Ingo Schommer
75b98970e4 API CHANGE #5107 Upload now uses Upload_Validator to separate the validation rules from the File loading done in the Upload class (from r100057)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:42:52 +00:00
Ingo Schommer
d8478a8f59 BUGFIX SQL Error is a member is not part of any groups (from r100053)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:56 +00:00
Ingo Schommer
3bd114256b MINOR added Rfc2822 method to SS_Datetime. Fixed bug where dates in DataObject would not set times. (from r100032)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:37 +00:00
Ingo Schommer
052f71f4b3 MINOR LastEdited/Created dates are now mockable via SS_Datetime (from r100008)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:11 +00:00
Ingo Schommer
3a19dc08a3 ENHANCEMENT you can now do coverage tests of single/multiple tests, or entire modules (from r99954)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:22:44 +00:00
Ingo Schommer
cd66429be7 MINOR: Blocking unnecessary revisions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105543 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:22:19 +00:00
Ingo Schommer
384995217a BUGFIX: Fix #2138, allow modification of existing images
via Image panel, and keep proportions when changing size
in text input boxes. (from r99952)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:22:08 +00:00
Ingo Schommer
1eb7959896 ENHANCEMENT #4787 Widget now respects updateCMSFields on extension classes so additional fields can be add (or existing ones removed) (from r99929)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105541 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:19:04 +00:00
Ingo Schommer
f86c05ba08 MINOR Reinstated UploadTest (from r99862)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:18:49 +00:00
Ingo Schommer
b632c8ff88 BUGFIX: Fix #5097, Translatable uses augmentValidURLSegment to check that URLSegment is valid (from r99850)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:18:25 +00:00
Ingo Schommer
0ab57094a0 API CHANGE: SiteTree::validURLSegment extendable (#5907)
Uses $this->extend('augmentValidURLSegment')
so that (for instance) Translatable can hook this. (from r99849)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:16:54 +00:00
Ingo Schommer
097eb6b649 Revert "FEATURE: Use tidied HTML in DataDifferencer"
This reverts commit a0d2f7b3e289d12dedcdbd02ae52eec3e6718340. (from r99848)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:15:54 +00:00
Ingo Schommer
593a87b2f2 ENHANCEMENT #4043 Allow setting the from address for debug information in SS_LogEmailWriter - thanks Hamish! (from r99845)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105536 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:15:26 +00:00
Ingo Schommer
4d2cc5dbe8 ENHANCEMENT #5024 Installer now checks that the user has entered a username and password correctly for the default admin, an additional button for re-checking requirements is now found at the bottom of the admin configuration section
ENHANCEMENT Error messages for database AND admin configuration are now in the same place at the top of the installer (from r99841)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105535 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:14:47 +00:00
Ingo Schommer
b3409a2ea3 MINOR Reverted r99522 as this will cause problems if File records are deleted when the resampled images are linked to in the content fields (from r99823)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:06:35 +00:00
Ingo Schommer
290284db09 MINOR Reverted r105528 (Group->CMSTreeClasses() was already defined)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105532 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:06:16 +00:00
Ingo Schommer
c193d27f31 BUGFIX: Handle filename deduping when uploading of double-barrelled extensions and files ending in numbers better. (from r99818)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:04:55 +00:00
Ingo Schommer
d00d876efe BUGFIX: Fixed the code for the unused file list, although the feature is still disabled. (from r99816)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:03:56 +00:00