tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
4,545 Commits 31 Branches 527 Tags 162 MiB
38f9e74fba
Commit Graph

848 Commits

Author SHA1 Message Date
Sam Minnee
e92a2da304 BUGFIX: $val is now cast as an int to prevent strings always returning true (YES) (from r109168) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112820 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:21:45 +00:00
Sam Minnee
a7d0b685ec BUGFIX: Validator::requiredField() should check the required field submitted value is an array before check strlen(). Some fields submitted as an array, e.g. MoneyField (from r109155) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112816 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:20:38 +00:00
Sam Minnee
b8ee6f6af5 BUGFIX Added specific border case for array form data in RequiredFields::php() (from r108811) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112767 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:51:18 +00:00
Sam Minnee
8ced8772aa BUGFIX: Fixed validation to accept arrays (FileField case) (from r108792) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112766 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:50:59 +00:00
Sam Minnee
4b1f71d67b BUGFIX NumericField javascript does not accept negatives, make use of isNaN built-in javascript function instead of custom regex (from r108633) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112760 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:47:43 +00:00
Sam Minnee
c0e2017cfc BUGFIX Validator/RequiredFields should not regard "0" as an empty value (from r108512) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112756 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:43:38 +00:00
Sam Minnee
43c0e432ed BUGFIX CurrencyField doesn't accept negative value (#5769, thanks simon_w) (from r108422) 
BUGFIX: Take note of output format when building Location header for RestfulServer (from r108427)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112744 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:32:18 +00:00
Sam Minnee
ce06d13fd6 MINOR Cross-referencing some documentation (from r108375) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112721 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:50:48 +00:00
Sam Minnee
b90e3a680c BUGFIX: the autoselection on linking sidebar for downloads did not work properly: the item would not be selected when the user clicked a link in the editor. Only numeric IDs were permitted, but the TreeDropdownField now supports other columns as IDs too, so enabled that for autoselection. 
BUGFIX: asset search would fail - typo in request var and the sql query had unnecessarily escaped quotes (from r108351)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112720 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:50:30 +00:00
Sam Minnee
ea50868156 BUGFIX Added a clearing div after the date and time fields, not the best way of doing it but the only way as the overflow css trick for clearing fields doesn't work with the time dropdown (from r107811) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112698 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:26:13 +00:00
Sam Minnee
30efd55852 ENHANCEMENT Added class to time icon in TimeField so it can be styled (from r107810) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112697 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:25:59 +00:00
Sam Minnee
c5f4926d4d BUGFIX Fixed DateField->validate() with keyed, but empty array values 
MINOR Fixed DateField/TimeField validation message translation (wrong sprintf() nesting) (from r107789)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112696 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:25:41 +00:00
Sam Minnee
61012967cf MINOR Fixed TimeField validation _t() entity name (from r107787) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112695 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:25:17 +00:00
Sam Minnee
171fdd6050 BUGFIX Using actual date format settings in DateField/TimeField->validate() messages (from r107786) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112694 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:23:40 +00:00
Sam Minnee
40bc9ced5d BUGFIX Limit 'showcalendar' javascript option to DateField instances (rather than applying to all available) (from r107785) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112693 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:22:56 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:55:22 +00:00
Ingo Schommer
e07d56096d BUGFIX Allowing DatetimeField->saveInto() to save a partial array notation with missing 'time' value (from r107441) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112599 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:51:21 +00:00
Ingo Schommer
52bd0cc4bb API CHANGE Using FieldHolder() instead of Field() for subfields in DatetimeField->FieldHolder(), in order to get configuraton settings for javascript DateField (from r107439) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112598 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:49:06 +00:00
Ingo Schommer
d67c43ad7d ENHANCEMENT Using jQuery UI datepicker in DateField and DatetimeField instead of outdated DHTML calendar.js (fixes #5397) 
ENHANCEMENT Abstracted optional DateField->setConfig('showcalendar') logic to DateField_View_JQuery (from r107438)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112597 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:48:39 +00:00
Ingo Schommer
80eab2a24c BUGFIX: Reverted 107414, wrong patch (from r107417) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112589 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:43:47 +00:00
Ingo Schommer
3b500bb137 BUGFIX: TableListField headings i18n translation (ticket #5742) (from r107414) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112576 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:26:45 +00:00
Ingo Schommer
6351b16ab9 BUGFIX Added Locale hidden field to HTMLEditorField->LinkForm() in order to show correct context in "page on the site" dropdown (fixes #5743) (from r107390) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112573 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:25:51 +00:00
Ingo Schommer
47762cdf5b ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:23:02 +00:00
Ingo Schommer
efebfe5993 ENHANCEMENT: added setDisabled() to set DropdownField::$disabled (from r107086) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112546 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:08:09 +00:00
Ingo Schommer
a848a182a7 API CHANGE Deprecated AutocompleteTextField, use third-party solutions (from r107054) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112545 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:07:54 +00:00
Ingo Schommer
a1f9efc414 BUGFIX Stricter checking that a relation exists on ComplexTableField::saveComplexTableField() (from r106755) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112536 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:03:54 +00:00
Ingo Schommer
ceb27c4a41 BUGFIX Fixed ImageField->EditFileForm() to list subclasses of Image in tree dropdown (fixes #5708, thanks keeny) (from r106671) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112533 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:02:17 +00:00
Ingo Schommer
4d665ce268 BUGFIX Prevent DateField->performReadonlyTransformation() from segfaulting on PHP 5.2 due to broken __toString() casting (fixes #5713, thanks charden) (from r106666) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112532 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:01:58 +00:00
Ingo Schommer
48cea784f6 MINOR: Provide a default message for FIELDISREQUIRED (from r106568) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112531 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:01:42 +00:00
Ingo Schommer
2d2ca13e45 ENHANCEMENT: added setRows() and setColumns() to customize the size of the textarea field outside of the controller (from r106118) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112518 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:56:36 +00:00
Ingo Schommer
db460ed57f MINOR Better error handling in Form::__construct() (fixes #5649) (from r105912) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112511 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:54:02 +00:00
Ingo Schommer
ca02b91673 BUGFIX: TableListField_Item::SelectOptionClasses() can not use it parent protected variable. (from r105876) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112506 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:52:05 +00:00
Ingo Schommer
8a2576ee3e BUGFIX: rollback r105858 which introducesa bug (from r105875) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112505 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:51:48 +00:00
Ingo Schommer
91700a3dac BUGFIX: updated select options classes to work with the dataobjectset returned by selectoptions rather than the array previously (from r105872) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112504 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:51:33 +00:00
Ingo Schommer
092a3c1c26 BUGFIX: TableListField_Item::SelectOptionClasses() can use it parent protected variable. (from r105858) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112503 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:51:04 +00:00
Ingo Schommer
4c2ff4bd0a APICHANGE: refactored methods in session to use coding conventions (from r105756) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112502 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:50:43 +00:00
Ingo Schommer
12fa850986 ENHANCEMENT: Preserve sort options in pagination links in TableListField (from r105275) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112475 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:29:44 +00:00
Ingo Schommer
68fcd8c94f MINOR Reverted r105264, breaks CompositeFieldTest, FieldSetTest, TranslatableTest (from r105274) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112474 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:28:12 +00:00
Ingo Schommer
bcbe9c254d ENHANCEMENT Allowing batch checkbox selection of TableListField rows with TableListField->Markable and TableListField->addSelectOptions() (from r105266) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112473 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:27:59 +00:00
Ingo Schommer
de0bf3f7cd BUGFIX: addFieldToTab segfaulting under PHP 5.2 (from r105264) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112445 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:29:18 +00:00
Ingo Schommer
93cd3ae55d BUGFIX: force dateformat to en_NZ if showcalendar is enabled as calendar is compatibile with en_NZ only (from r105225) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112444 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:29:02 +00:00
Ingo Schommer
a191019e7a MINOR Documentation (from r104404) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112345 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 00:04:14 +00:00
Ingo Schommer
c969e04731 MINOR Removed unnecessary $timeformat parameter from TimeField::__construct, and getting the default from Zend_Locale_Format in the same way that DateField behaves (unreleased API, so no api change). 
MINOR Automatically choosing $locale in TimeField::__construct, to be consistent with DateField (from r103975)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112328 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-14 23:53:13 +00:00
Ingo Schommer
d2c096119c BUGFIX Fixed double pragma after referer redirection on forms with Form->httpSubmission() (fixes #5509, thanks ktauber) (from r103936) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112325 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-14 23:51:55 +00:00
Sam Minnee
077a119cfb MINOR Database quoting in TreeDropdownField (fixes #5484) (from r103515) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112146 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 03:56:48 +00:00
Sam Minnee
da671c628d BUGFIX Fixed CurrencyField->jsValidation() regex escaping (fixes #5462, thanks mobiusnz) (from r103451) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112143 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 03:53:52 +00:00
Sam Minnee
a2f6487fa3 BUGFIX DateField with setConfig('dmyfields') now validates TRUE for empty values (fixes #5458) (from r103450) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112140 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 03:52:36 +00:00
Sam Minnee
961d4ce298 BUGFIX: added optional separator for http_build_query in HTTP:setGetVar(). this fixes sorting columns in ModelAdmin (ticket #5325). (from r103012) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112071 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:48:24 +00:00
Sam Minnee
19f4c1ef89 BUGFIX #5320 ManyManyComplexTableField::getQuery() now uses T-SQL compatible syntax CASE WHEN instead of IF THEN which works in multiple databases as well (from r102436) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112066 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:42:01 +00:00
Sam Minnee
3ac1580aae BUGFIX: Explicitly specify the many_many's join table name in the join's ON match statement in ManyManyComplexTableField (from r101608) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112008 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:51:33 +00:00