Sam Minnee
32783ef0e8
MINOR Make dev/build not constantly show a changed index because of whitespace between VersionID and Version in the index spec (from r110205)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112837 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:29:25 +00:00
Sam Minnee
065155eb5d
MINOR Removed removeDuplicates() call on linked pages DataObjectSet in MigrateSiteTreeLinkingTask which is no longer required, as the duplicate results were fixed in DataObject directly (from r110200)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112836 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:28:37 +00:00
Sam Minnee
2f159ce93e
BUGFIX MigrateSiteTreeLinkingTask now takes a direct map when querying the page tracked links instead of looping through the direct result set. This fixes SQL Server failing when MARS (Multiple Active Result Sets) is disabled (from r110197)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112835 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:28:13 +00:00
Sam Minnee
6e8bf5617a
MINOR: only call next() in iterator validation on initialisation or after reset NOT if current value is invalid (from r110190)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:27:51 +00:00
Sam Minnee
12dd5b08e8
BUGFIX Fixed missing "Save" action input label on ComplexTableField popup form (from r110165)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:27:35 +00:00
Sam Minnee
3f90b70db2
BUGFIX: force the test to wait until indexing completes. Do not use stop words ('me') (from r110130)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:27:18 +00:00
Sam Minnee
274387f0f4
BUGFIX: BasicAuthTests fail when Member's unique_identifier_field is anything except the default of Email (from r109834)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112831 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:26:49 +00:00
Sam Minnee
2c7d88aade
MINOR: repair installer for sqlite (from r109787)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:26:27 +00:00
Sam Minnee
29ca5ff9a7
BUGFIX: disable basic auth for the restful controller test (from r109714)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112829 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:26:09 +00:00
Sam Minnee
0154fbae0f
BUGFIX: makeRelative would return "false" for the root path, empty string is expected - fix that
...
BUGFIX: change the check in forceSSL to work on Windows - it sets the $_SERVER['https'] to off, instead of null (from r109712)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:50 +00:00
Sam Minnee
ac33763d05
BUGFIX: getItem didn't consider the PostgreSQL SQL syntax. Columns with Capital letters must be quoted. Added quotes to the where clause in getItem. I didn't added quotes to the baseTable because it causes PostgreSQL errors (tables can not be double quoted, just single quoted). (from r109591)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112827 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:32 +00:00
Sam Minnee
458f3b1197
MINOR: neatly quote identifiers (from r109405)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112826 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:19 +00:00
Sam Minnee
46a38e972f
MINOR: return a fail instead of an error (from r109382)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112825 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:03 +00:00
Sam Minnee
102375954a
MINOR Remove whitespace if Surname field set on Member, but not FirstName (from r109334)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:24:43 +00:00
Sam Minnee
38f9e74fba
MINOR Tests for Member::getName() and Member::setName() (from r109333)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112823 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:24:04 +00:00
Sam Minnee
00ddc0ff83
MINOR: trim space off end of firstname if surname is not set. #5925 (from r109330)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112822 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:23:44 +00:00
Sam Minnee
99fde26091
MINOR CSSContentParser::__construct() now gives a better error if the content could not be parsed. This will mostly happen if tidy isn't present. (from r109274)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:23:00 +00:00
Sam Minnee
e92a2da304
BUGFIX: $val is now cast as an int to prevent strings always returning true (YES) (from r109168)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:45 +00:00
Sam Minnee
f929d2ee6d
MINOR phpDoc updates for SS_LogFileWriter and SS_LogEmailWriter (from r109165)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:32 +00:00
Sam Minnee
11907212fc
Revert "BUGFIX: sort order of widgets is now fixed."
...
This reverts commit 1e7781ba2b8ac30333a20d9a1b0bcb9b4ba5b0b0. (from r109163)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112818 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:10 +00:00
Sam Minnee
496e9bcef6
API CHANGE #5873 DataObjectSet::shift() now performs a proper shift instead of unshift (wrong). Please use DataObjectSet::unshift($item) if unshifting was intended!
...
API CHANGE Added DataObjectSet::pop()
MINOR Unit tests for DataObjectSet::shift(), DataObjectSet::unshift() and DataObjectSet::pop() (from r109156)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:56 +00:00
Sam Minnee
a7d0b685ec
BUGFIX: Validator::requiredField() should check the required field submitted value is an array before check strlen(). Some fields submitted as an array, e.g. MoneyField (from r109155)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:38 +00:00
Sam Minnee
fcc20b5e1a
BUGFIX Fixed ContentNegotiator to handle HTML and XHTML base tags properly when converting, regression from r108413 (from r108421)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112815 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:07 +00:00
Sam Minnee
a588ae305c
BUGFIX #5855 SSViewer::get_base_tag() should produce a properly closed base tag for XHTML (thanks smorris!) (from r108413)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:06:25 +00:00
Sam Minnee
53b974053a
MINOR: Blocking unnecessary revisions
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112789 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:59:02 +00:00
Sam Minnee
ea1157f5b2
MINOR Doc update for Director::forceSSL() (from r109152)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112788 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:52 +00:00
Sam Minnee
97be4d2ca6
BUGFIX: Remove () that was breaking coverage report (from r109128)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112787 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:40 +00:00
Sam Minnee
634a3afeff
MINOR: Applied patch from walec51 for <% control %> on empty set ( #5579 ) Also added unit tests by ischommer (from r109127)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112785 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:23 +00:00
Sam Minnee
0bcb61f261
BUGFIX: sort order of widgets is now fixed. (from r109106)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112784 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:39 +00:00
Sam Minnee
f20e83eeaf
MINOR: Fix links etc, and remove www. from SS urls (from r109105)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112783 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:25 +00:00
Sam Minnee
cda6638281
ENHANCEMENT: Added -v / --verbose option to dev/tests/*, to make it output every single test name before it starts that test. (from r109104)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:02 +00:00
Sam Minnee
cf6907931b
API CHANGE Member::set_session_regenerate_id() can now be used to disable Member::session_regenerate_id() which can break setting session cookies across all subdomains of a site (from r109103)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112781 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:55:33 +00:00
Sam Minnee
f8ec13a1ab
BUGFIX: Themed permissionFailure messages (from r109102)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112780 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:55:20 +00:00
Sam Minnee
215cbb6b36
ENHANCEMENT Session::set_cookie_path() and Session::set_cookie_domain() are now possible. This is useful for sharing cookies across all subdomains, for example. (from r109101)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112779 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:55:02 +00:00
Sam Minnee
bf935d5a5e
MINOR: Clear out the test database in between each salad scenario. (from r109100)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112778 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:45 +00:00
Sam Minnee
0d6cb295c4
Added dev/tests/emptydb to clear out test session databases. (from r109099)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112777 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:31 +00:00
Sam Minnee
829d532b6a
BUGFIX Group::getCMSFields() should use Tab instances with a fixed name instead of translated one, leaving the translation for the tab title instead (from r109083)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112776 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:16 +00:00
Sam Minnee
d6fdc57db7
BUGFIX SiteTree decorated canView() checks not being passed through to SiteTree::canView() (from r109082)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112775 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:02 +00:00
Sam Minnee
adfab98adb
BUGFIX StringField::setNullifyEmpty() should assign the given value boolean, not evaluate whether it's true or not (from r109081)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:53:46 +00:00
Sam Minnee
e6976a8458
BUGFIX Count() call on a non-object in File::BackLinkTrackingCount() (from r109079)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112773 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:53:21 +00:00
Sam Minnee
db8035e1a1
MINOR Added tests for File::getURL() and File::getAbsoluteURL() (from r109066)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112772 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:52:57 +00:00
Sam Minnee
f99e6059b1
BUGFIX Fixed File::getAbsoluteURL() absolute generation (from r109063)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112771 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:52:36 +00:00
Sam Minnee
46f1994da4
BUGFIX File::getAbsoluteURL() should return a URL, not a filesystem path (from r109062)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112770 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:52:21 +00:00
Sam Minnee
58d6cbf81a
MINOR: remove SQL table alias keyword AS (from r108961)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112769 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:53 +00:00
Sam Minnee
7f3f167748
ENHANCEMENT: make RestfulService support PUT method. (from r108942)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112768 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:33 +00:00
Sam Minnee
b8ee6f6af5
BUGFIX Added specific border case for array form data in RequiredFields::php() (from r108811)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112767 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:18 +00:00
Sam Minnee
8ced8772aa
BUGFIX: Fixed validation to accept arrays (FileField case) (from r108792)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112766 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:59 +00:00
Sam Minnee
43f4500cd6
MINOR Fixed tests not working on the web side as redirection to https would occur (from r108666)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112765 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:37 +00:00
Sam Minnee
83e31e1f8a
MINOR Fixed DirectorTest to restore it's REQUEST_URI state to the original one after each test method is run (from r108665)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112764 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:15 +00:00
Sam Minnee
d295d682c5
ENHANCEMENT #3828 500 server error page is created by default on dev/build (from r108644)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112763 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:49:53 +00:00