Commit Graph

22344 Commits

Author SHA1 Message Date
Garion Herman
f1c94e6d54 FIX Allow quotes in expected ReflectionExceptions within tests 2020-09-15 17:40:42 +12:00
Garion Herman
44685eceba FIX Support PHP 8 namespace tokens in i18nTextCollector 2020-09-15 17:40:42 +12:00
Garion Herman
bad0662291 FIX Disable libxml_disable_entity_loader() calls in PHP 8 2020-09-15 17:40:42 +12:00
Sam Minnee
fb9e6e51a6 FIX: Switch to sminnee fork of phpunit 5.7
This provides 5.7.28 with fixes for PHP 8 support.
2020-09-15 17:40:42 +12:00
Sam Minnee
57bdef3b2e FIX: Fix test mistakenly labelling content as name arguments in data provider 2020-09-15 17:40:42 +12:00
Sam Minnee
b3dd27953b NEW: Allow league/csv ^9
Hopefully this has better PHP 8 support.
2020-09-15 17:40:42 +12:00
Sam Minnee
09fb33e657 FIX: Avoid passing non-class to get_parent_class()
Throws errors in PHP 8
2020-09-15 17:40:42 +12:00
Sam Minnee
5cb3d07f44 FIX: Avoid pass-literal-by-reference warning in PHP 8 2020-09-15 17:40:42 +12:00
Steve Boyd
ab50e2cc51 Merge branch '4.6' into 4 2020-09-15 13:44:57 +12:00
Steve Boyd
e339549e0d
Merge pull request #9649 from kinglozzer/9648-security-titles
FIX: Include missing security page titles when CMS not installed (fixes #9648)
2020-09-15 13:43:59 +12:00
Guy Marriott
05e3417249
Merge pull request #9686 from sminnee/pulls/9679-guard-sapphiretest 2020-09-14 17:22:30 -07:00
Guy Marriott
a80f66f11c
Merge pull request #9689 from RuthAdele/patch-2
Update 02_Pagination.md
2020-09-14 16:44:34 -07:00
RuthAdele
bd2f017557
Update 02_Pagination.md
Adding commonly used $FirstItem and $LastItem to the Template Variables list.
2020-09-14 21:26:33 +09:30
Sam Minnee
2143660c3f FIX: Add class_exists() guards to SapphireTest
This test helper has a number of hooks to other parts of the
and required many class_exists() guards to operate without them

This has come out of PoC development work as part of:
https://github.com/silverstripe/silverstripe-framework/issues/9679

But can stand-alone as a mergeable PR.
2020-09-14 13:49:21 +12:00
cloph
13725d2f92
DOC HistoryViewer: explain "magic names" (#9670)
DOC HistoryViewer: explain "magic names"
GraphQL scaffolding uses names consisting of the first part of the namespace and the classname, but to inject it to the HistoryViewer field you need to use the database table name.
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2020-09-12 12:56:23 +12:00
Steve Boyd
015ea8cfc8 Merge branch '4.6' into 4 2020-09-11 11:54:23 +12:00
Damian Mooyman
ac6f34846e
BUG Resolve issue where TreeMultiSelectField would error loading its value (#9604)
* BUG Resolve issue with TreeMultiSelectField not retaining value in some situations
E.g. in an elemental form
2020-09-11 11:52:36 +12:00
Robbie Averill
de61681dec
Merge pull request #9634 from open-sausages/pulls/4/ellipsis
BUG Use proper ellipsis character in the various summary method.
2020-09-10 14:48:33 -07:00
Mojmir Fendek
2c1cb79156 DOCS: Example of partial cache expiry setting. 2020-09-11 08:58:44 +12:00
Daniel Hensby
b592d2105c
Merge pull request #9681 from open-sausages/pulls/4/better-hash-compare-function
BUG Make PasswordEncryptor::check more resistent to timing attacks
2020-09-10 18:23:22 +01:00
Maxime Rainville
8bcfa57342 BUG Make PasswordEncryptor::check more resistent to timing attacks 2020-09-10 22:17:50 +12:00
Maxime Rainville
acdebcdba7 Fix unit test 2020-09-10 17:08:13 +12:00
Ingo Schommer
089098ffdb
Merge pull request #9676 from creative-commoners/pulls/4/docs-preannouncement-mailing-list-denounce
DOC Clarify the security pre-announcement mailing list usage
2020-09-10 16:51:49 +12:00
Steve Boyd
1a602608ce
Merge pull request #9675 from creative-commoners/pulls/4/docs-partial-template-cache-in-a-loop
DOC Fix Partial Template Cache documentation header
2020-09-10 16:32:50 +12:00
Serge Latyntsev
b13453c88d
Merge pull request #9678 from creative-commoners/pulls/4.6/compare-select
FIX Problem with direct compare in SELECT statement causing incompatibility with SQL Server database
2020-09-10 16:29:21 +12:00
Steve Boyd
02827a6670 FIX Problem with direct compare in SELECT statement causing incompatibility with SQL Server database
Co-authored-by: Tomas Bilek
2020-09-10 14:48:09 +12:00
Serge Latyntcev
a5c1a86dcb DOC Clarify the security pre-announcement mailing list usage 2020-09-10 13:57:27 +12:00
Serge Latyntcev
d9c0b079d1 DOC Fix Partial Template Cache documentation header 2020-09-10 12:58:16 +12:00
Jackson Darlow
2753f823ee
DOC Added a tip to docs describing how to set a cookie for less than a day (#9552)
DOC Added a tip to docs describing how to set a cookie for less than a day
Co-authored-by: Garion Herman <garion@silverstripe.com>
2020-09-10 12:34:33 +12:00
Steve Boyd
589631df00
Merge pull request #9280 from open-sausages/pulls/4/doc-breadcrumb
DOC Update breadcrumb template in theme rather than app.
2020-09-10 09:48:23 +12:00
Garion Herman
c072f7343a
DOCS Add triage resources, document stale PR definition (#9660)
* DOCS Add triage resources, document stale PR definition
Co-authored-by: Steve Boyd <steve@silverstripe.com>
Co-authored-by: Serge Latyntcev <serge.latyntcev@silverstripe.com>
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-09-09 18:06:02 +12:00
Steve Boyd
4c3a5441b2 Merge branch '4.6' into 4 2020-09-09 13:58:35 +12:00
Nicolaas
27c1c72912
FIX ModuleManifest::getModuleByPath fix to ensure right module is returned (#9569)
* FIX: ModuleManifest::getModuleByPath returns the wrong module #9561
Co-authored-by: Nicolaas Thiemen <nt@sunnysideup.co.nz>
2020-09-09 13:47:36 +12:00
Maxime Rainville
adaf793ddb
BUG Always validate Member credentials against DRAFT stage (#9671) 2020-09-08 11:47:04 +12:00
Steve Boyd
1a0c80ccdb
Merge pull request #9669 from creative-commoners/pulls/4/docs-template-partial-cache
DOC Update Partial Template Cache documentation
2020-09-08 11:14:03 +12:00
Daniel Hensby
85242b1efe
Merge pull request #9650 from dylangrech92/patch-1
Added exception for enumerated array (#9644)
2020-09-07 10:57:36 +01:00
Sam Minnee
622cf8b914 FIX: Drop parameter names in Injector instantiation to preserve behaviour in PHP 8
Fixes #9667
2020-09-07 17:24:00 +12:00
Sam Minnee
e0f3797489 FIX: Remove deprecated & non-functional default argument config
This throws deprecation errors on PHP 8.

Fixes #9666
2020-09-07 17:24:00 +12:00
Garion Herman
08010d5933 NEW Support namespace tokens in ClassInfo::parse_class_spec()
The T_NAME_QUALIFIED and T_NAME_FULLY_QUALIFIED tokens are introduced
in PHP 8, and encapsulate theentire FQCN, replacing the previous
structure of a group of T_STRINGs and T_NS_SEPARATORs.
2020-09-07 17:23:56 +12:00
Sam Minnee
af40eee3ad TEST Add nightly (aka PHP 8) to build matrix 2020-09-07 17:13:02 +12:00
Serge Latyntcev
e632ee3e52 DOC Update Partial Template Cache documentation
- create a new documentation section explaining the "cached" block
 - clean up the Performance documentation section,
   moving explanations about "cached" block away,
   adding new warnings and recommendations
2020-09-07 13:45:08 +12:00
Maxime Rainville
4ee7102761 DOC Update breadcrumb template in theme rather than app. 2020-09-02 13:23:24 +12:00
Robbie Averill
1eb66e2258
Merge pull request #8915 from creative-commoners/pulls/4.4/helping-performance-exist
NEW DataQuery::exists now generates EXISTS SQL statements
2020-09-01 13:09:02 -07:00
Guy Marriott
ff04f97149
Add return type
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-09-01 08:43:36 -07:00
Guy Marriott
3575070b9d FIX Removing selected column detail only if having is empty (MySQL "feature") 2020-09-01 16:21:43 +12:00
Guy Marriott
f9fc4f6641 FIX Allow for BC for DB adapters that return an actual boolean when selecting boolean literals in SQL 2020-09-01 16:20:07 +12:00
Guy Marriott
ef0af7ae9c FIX Exists statements can't remove GROUP BY if there's a HAVING clause as it might rely on an aggregate 2020-09-01 16:20:07 +12:00
Guy Marriott
91591373d6 NEW Add exists as a method to the DataQuery API that will generate an SQL "exists" query
The exists query in SQL allows the query optimiser (engine specific) to execute these queries much faster - often only needing the presence of an index to return "yes it exists".
2020-09-01 16:20:07 +12:00
Garion Herman
6b78428fbb
Merge pull request #9651 from open-sausages/pulls/4/test-mysql-connection-collation
ENH Test coverage for MySQL connection collation
2020-08-30 22:44:28 +12:00
Serge Latyntcev
f57d5cc807 ENH Test coverage for MySQL connection collation 2020-08-30 13:21:38 +12:00