Sam Minnee
29515b2e01
BUGFIX Removing overloaded TableField->sourceItems() method, which enables features of the underlying TableListField implementation, such as pagination and source item caching ( fixed #5965 , thanks martijn) (from r111492)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:56:23 +00:00
Sam Minnee
cdb04f79de
BUGFIX Fixed quoting and GROUP BY statement in ManyManyComplexTableField->getQuery() for Postgres compatibility (from r111202)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112900 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:48:57 +00:00
Sam Minnee
31d442f5da
BUGFIX Respecting field specific locale settings in DatetimeField and DateField when validating and saving values ( fixes #5931 , thanks Tjofras) (from r110889)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112864 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:01:03 +00:00
Sam Minnee
2d82ae6217
BUGFIX Enforcing canEdit() checks in ComplexTableField_Popup - making form readonly if the current user can't edit (from r110857)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:00:45 +00:00
Sam Minnee
2c60a67e09
BUGFIX Case insensitive DateField value navigation ( fixes #5990 , thanks gw0( (from r110838)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112851 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:40:21 +00:00
Sam Minnee
3c6512ab1a
MINOR Check in TableListField->HighlightClasses() ( fixes #5993 , thanks lx) (from r110837)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:36:39 +00:00
Sam Minnee
9d4d7301a2
BUGFIX Passing $name in MoneyField->FieldCurrency() ( fixes #5982 , thanks andersw) (from r110835)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112848 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:34:31 +00:00
Sam Minnee
61bb2fe4a4
BUGFIX Removing "typography" class from HTMLEditorField container (should just apply to the contained <iframe>) ( fixes #5949 ) (from r110809)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112847 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:33:28 +00:00
Sam Minnee
1b95077fed
BUGFIX Allowing $extraClass on CheckboxField FieldHolder ( fixes #5939 , thanks mobiusnz) (from r110808)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112846 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:33:08 +00:00
Sam Minnee
6fa348a2cb
BUGFIX Fixed boundary PHP notice case in RequiredFields::php() where a field name may not be defined in the $data array when a Form is submitted (from r110463)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:31:30 +00:00
Sam Minnee
12dd5b08e8
BUGFIX Fixed missing "Save" action input label on ComplexTableField popup form (from r110165)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:27:35 +00:00
Sam Minnee
e92a2da304
BUGFIX: $val is now cast as an int to prevent strings always returning true (YES) (from r109168)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:45 +00:00
Sam Minnee
a7d0b685ec
BUGFIX: Validator::requiredField() should check the required field submitted value is an array before check strlen(). Some fields submitted as an array, e.g. MoneyField (from r109155)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:38 +00:00
Sam Minnee
b8ee6f6af5
BUGFIX Added specific border case for array form data in RequiredFields::php() (from r108811)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112767 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:18 +00:00
Sam Minnee
8ced8772aa
BUGFIX: Fixed validation to accept arrays (FileField case) (from r108792)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112766 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:59 +00:00
Sam Minnee
4b1f71d67b
BUGFIX NumericField javascript does not accept negatives, make use of isNaN built-in javascript function instead of custom regex (from r108633)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112760 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:47:43 +00:00
Sam Minnee
c0e2017cfc
BUGFIX Validator/RequiredFields should not regard "0" as an empty value (from r108512)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112756 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:43:38 +00:00
Sam Minnee
43c0e432ed
BUGFIX CurrencyField doesn't accept negative value ( #5769 , thanks simon_w) (from r108422)
...
BUGFIX: Take note of output format when building Location header for RestfulServer (from r108427)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112744 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:32:18 +00:00
Sam Minnee
ce06d13fd6
MINOR Cross-referencing some documentation (from r108375)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112721 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:50:48 +00:00
Sam Minnee
b90e3a680c
BUGFIX: the autoselection on linking sidebar for downloads did not work properly: the item would not be selected when the user clicked a link in the editor. Only numeric IDs were permitted, but the TreeDropdownField now supports other columns as IDs too, so enabled that for autoselection.
...
BUGFIX: asset search would fail - typo in request var and the sql query had unnecessarily escaped quotes (from r108351)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112720 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:50:30 +00:00
Sam Minnee
ea50868156
BUGFIX Added a clearing div after the date and time fields, not the best way of doing it but the only way as the overflow css trick for clearing fields doesn't work with the time dropdown (from r107811)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112698 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:26:13 +00:00
Sam Minnee
30efd55852
ENHANCEMENT Added class to time icon in TimeField so it can be styled (from r107810)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112697 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:59 +00:00
Sam Minnee
c5f4926d4d
BUGFIX Fixed DateField->validate() with keyed, but empty array values
...
MINOR Fixed DateField/TimeField validation message translation (wrong sprintf() nesting) (from r107789)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112696 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:41 +00:00
Sam Minnee
61012967cf
MINOR Fixed TimeField validation _t() entity name (from r107787)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:17 +00:00
Sam Minnee
171fdd6050
BUGFIX Using actual date format settings in DateField/TimeField->validate() messages (from r107786)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:23:40 +00:00
Sam Minnee
40bc9ced5d
BUGFIX Limit 'showcalendar' javascript option to DateField instances (rather than applying to all available) (from r107785)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112693 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:22:56 +00:00
Ingo Schommer
a0dd4ff8f0
MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:55:22 +00:00
Ingo Schommer
e07d56096d
BUGFIX Allowing DatetimeField->saveInto() to save a partial array notation with missing 'time' value (from r107441)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:21 +00:00
Ingo Schommer
52bd0cc4bb
API CHANGE Using FieldHolder() instead of Field() for subfields in DatetimeField->FieldHolder(), in order to get configuraton settings for javascript DateField (from r107439)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:49:06 +00:00
Ingo Schommer
d67c43ad7d
ENHANCEMENT Using jQuery UI datepicker in DateField and DatetimeField instead of outdated DHTML calendar.js ( fixes #5397 )
...
ENHANCEMENT Abstracted optional DateField->setConfig('showcalendar') logic to DateField_View_JQuery (from r107438)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:48:39 +00:00
Ingo Schommer
80eab2a24c
BUGFIX: Reverted 107414, wrong patch (from r107417)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:43:47 +00:00
Ingo Schommer
3b500bb137
BUGFIX: TableListField headings i18n translation (ticket #5742 ) (from r107414)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:45 +00:00
Ingo Schommer
6351b16ab9
BUGFIX Added Locale hidden field to HTMLEditorField->LinkForm() in order to show correct context in "page on the site" dropdown ( fixes #5743 ) (from r107390)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:25:51 +00:00
Ingo Schommer
47762cdf5b
ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:02 +00:00
Ingo Schommer
efebfe5993
ENHANCEMENT: added setDisabled() to set DropdownField::$disabled (from r107086)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:08:09 +00:00
Ingo Schommer
a848a182a7
API CHANGE Deprecated AutocompleteTextField, use third-party solutions (from r107054)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:54 +00:00
Ingo Schommer
a1f9efc414
BUGFIX Stricter checking that a relation exists on ComplexTableField::saveComplexTableField() (from r106755)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112536 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:03:54 +00:00
Ingo Schommer
ceb27c4a41
BUGFIX Fixed ImageField->EditFileForm() to list subclasses of Image in tree dropdown ( fixes #5708 , thanks keeny) (from r106671)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:02:17 +00:00
Ingo Schommer
4d665ce268
BUGFIX Prevent DateField->performReadonlyTransformation() from segfaulting on PHP 5.2 due to broken __toString() casting ( fixes #5713 , thanks charden) (from r106666)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112532 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:58 +00:00
Ingo Schommer
48cea784f6
MINOR: Provide a default message for FIELDISREQUIRED (from r106568)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:42 +00:00
Ingo Schommer
2d2ca13e45
ENHANCEMENT: added setRows() and setColumns() to customize the size of the textarea field outside of the controller (from r106118)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112518 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:36 +00:00
Ingo Schommer
db460ed57f
MINOR Better error handling in Form::__construct() ( fixes #5649 ) (from r105912)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112511 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:02 +00:00
Ingo Schommer
ca02b91673
BUGFIX: TableListField_Item::SelectOptionClasses() can not use it parent protected variable. (from r105876)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112506 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:52:05 +00:00
Ingo Schommer
8a2576ee3e
BUGFIX: rollback r105858 which introducesa bug (from r105875)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:48 +00:00
Ingo Schommer
91700a3dac
BUGFIX: updated select options classes to work with the dataobjectset returned by selectoptions rather than the array previously (from r105872)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:33 +00:00
Ingo Schommer
092a3c1c26
BUGFIX: TableListField_Item::SelectOptionClasses() can use it parent protected variable. (from r105858)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112503 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:04 +00:00
Ingo Schommer
4c2ff4bd0a
APICHANGE: refactored methods in session to use coding conventions (from r105756)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:50:43 +00:00
Ingo Schommer
12fa850986
ENHANCEMENT: Preserve sort options in pagination links in TableListField (from r105275)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112475 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:29:44 +00:00
Ingo Schommer
68fcd8c94f
MINOR Reverted r105264, breaks CompositeFieldTest, FieldSetTest, TranslatableTest (from r105274)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112474 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:28:12 +00:00
Ingo Schommer
bcbe9c254d
ENHANCEMENT Allowing batch checkbox selection of TableListField rows with TableListField->Markable and TableListField->addSelectOptions() (from r105266)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112473 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:27:59 +00:00