Commit Graph

21297 Commits

Author SHA1 Message Date
Guy Marriott
cc1fdf603b
Resolve incorrect empty string assertion in tests 2019-04-17 13:29:54 +12:00
Robbie Averill
2c207b636a
Merge pull request #8932 from eeerlend/patch-1
Added missing Permission class to example
2019-04-17 12:38:12 +12:00
Erlend Mongstad
80b097eb68
Added missing Permission class to example
Following the example will give the following error;

```[Emergency] Uncaught Error: Class {my namespace}\Permission not found```

Added the missing class
2019-04-17 02:36:13 +02:00
Robbie Averill
45edc816ba
Merge pull request #8928 from DorsetDigital/patch-4
Update 03_Disable_Anchor_Links.md
2019-04-17 09:34:06 +12:00
Robbie Averill
6b07b2c47c Update docs/en/02_Developer_Guides/01_Templates/How_Tos/03_Disable_Anchor_Links.md
Fix code styling

Co-Authored-By: DorsetDigital <DorsetDigital@users.noreply.github.com>
2019-04-16 22:32:55 +01:00
DorsetDigital
321ef827b8
Update 03_Disable_Anchor_Links.md
Update example code for disabling anchors on a per-instance basis.  The previous code was unclear and statically called a non-static method on SSViewer  (presumably this was SS3 code)
2019-04-16 21:22:27 +01:00
Sam Minnée
6a2762662b MINOR: Change “Choose Page” to “Search or choose Page” (#8766)
* MINOR: Change “Choose Page” to “Search or choose Page”

Based on discussions with James Ford, it wasn’t clear that you could
search.

* Use new translation key
2019-04-16 16:06:37 +12:00
Guy Marriott
9d6b5048a6 FIX Table aliases are retained on base tables in queries built using SQLConditionalExpression (#8918)
* Adding failing test for base table aliases using SQLSelect

* FIX Retain table aliases applied to the base table on queries

* FIX Move the trimmed alias outside of the condition so we can use it within the condition
2019-04-16 15:40:09 +12:00
Guy Marriott
7fd6e14423
Adding comment about the === 't' condition for supporting postgres 2019-04-16 12:10:13 +12:00
Robbie Averill
be9f0120ad
Merge pull request #8922 from lhalaa/pulls/dbtext-multibyte
FIX Replace substr with mb_substr to get the correct position
2019-04-15 23:14:06 +12:00
Robbie Averill
b17526edbf
Merge pull request #8923 from christopherdarling/patch-13
DOCS composer autoload examples should be psr-4
2019-04-15 18:04:04 +12:00
Christopher Darling
fcef36b7fa
DOCS composer autoload examples should be psr-4
currently 'psr4'
2019-04-15 06:55:01 +01:00
Guy Marriott
a48beac845
FIX Calculate threshold condition with SQL rather than PHP
This is a performance fix. Modern SQL engines can avoid counting a whole result set (potentially thousands of records) when you are only interested if the count exceeds a threshold.
2019-04-15 16:48:44 +12:00
Sheila Bañez
63360f8048 BUG Replace substr with mb_substr to get the correct position 2019-04-15 16:38:52 +12:00
Guy Marriott
b1339f0d72 NEW Update FieldList::replaceField API to match removeByName (#8876)
* API Update FieldList::replaceField API to match removeByName

This specifically adds the parameter that `removeByName` has but `replaceField` does not. This parameter is set to `true` by default rather than inheriting the same default as `removeByField`. This is because the existing funtionality of `replaceField` was the same as if this parameter was set to `true`. This should be updated in SS5 to match the `removeByField` API.

* Add dataFieldOnly to CompositeField
2019-04-15 16:22:54 +12:00
Ralph Slooten
66c372ce28 Include baseURL with relative setGetVar() links (#8834)
* Return baseURL with setGetVar

* Adjust testSetGetVar tests for base url
2019-04-15 14:50:46 +12:00
Robbie Averill
2c971eea83 Merge branch '4.3' into 4 2019-04-11 11:37:47 +12:00
Robbie Averill
f2f28586d9 Merge branch '4.2' into 4.3 2019-04-11 11:37:34 +12:00
Robbie Averill
116ea12783 Merge branch '4.1' into 4.2 2019-04-11 11:37:22 +12:00
Robbie Averill
f4a6115ee6 Merge branch '4.0' into 4.1 2019-04-11 11:36:40 +12:00
Robbie Averill
8a06682e31 Merge branch '4.3' into 4
# Conflicts:
 #	src/ORM/Connect/DBSchemaManager.php
2019-04-11 11:24:17 +12:00
Robbie Averill
55cbacca86 Merge branch '4.2' into 4.3
# Conflicts:
 #	src/Forms/GridField/GridFieldLevelup.php
 #	src/includes/constants.php
2019-04-11 11:21:42 +12:00
Robbie Averill
b90061fdd3 Update translations 2019-04-11 11:16:00 +12:00
Loz Calver
9d3337b7af
Merge pull request #8914 from open-sausages/pulls/4/docs-publishall
DOCS Limitations of publishall
2019-04-10 09:21:03 +01:00
Ingo Schommer
fcdc146996 DOCS Limitations of publishall
Fixes https://github.com/silverstripe/silverstripe-cms/issues/2406
2019-04-10 10:42:49 +12:00
Robbie Averill
f50fdd72dd
Merge pull request #8913 from altwohill/patch-1
Fix formatting
2019-04-10 08:24:49 +12:00
Al
9a43952385
Fix formatting
Last code block was not closed
2019-04-10 08:22:51 +12:00
Robbie Averill
761d4d877e
Merge pull request #8905 from sminnee/fix-3519
FIX: Better error message when GridFieldLevelup passed bad record details
2019-04-09 09:01:33 +12:00
Robbie Averill
9bb6ab9977
Merge pull request #8907 from open-sausages/pulls/docs/upgrading-guide-issues
DOCS Upgrading guide known issues and self-update
2019-04-09 09:00:41 +12:00
Ingo Schommer
d04ef04999 DOCS Upgrading guide known issues and self-update 2019-04-09 08:24:15 +12:00
Sam Minnee
f12fa62ad6 FIX: Better error message when GridFieldLevelup passed bad record details
Fixes https://github.com/silverstripe/silverstripe-framework/issues/3519
2019-04-08 18:09:51 +12:00
Guy Marriott
0f4bd1606a
Merge pull request #8903 from kinglozzer/enum-empty-defaults
FIX: prevent unnecessary field alterations for enums with empty defaults
2019-04-06 09:48:57 +13:00
Loz Calver
594af77134 FIX: prevent unnecessary field alterations for enums with empty defaults 2019-04-05 16:17:41 +01:00
Loz Calver
0b5f5e3bcb
Merge pull request #8590 from sminnee/zero-is-false
Ensure that decimal DB values are fetched as floats
2019-04-05 09:41:41 +01:00
Robbie Averill
8b4b54f264
PHPCS linting error on indentation 2019-04-05 16:29:24 +13:00
Sam Minnee
d295888838 MINOR: Improve type testing 2019-04-05 15:11:21 +13:00
Sam Minnee
c9c7c0c825 FIX: Fix PDO cached statement column coercion
NEW: Add PDOStatementHandle class that is now what PDOQuery expects
2019-04-05 15:11:21 +13:00
Sam Minnee
2625cea5e3 MINOR: Add a test that 0 is falser on int, decimal, currency
Validates that https://github.com/silverstripe/silverstripe-framework/issues/3473 has been fixed

The bug was fixed in #8448
2019-04-05 15:11:21 +13:00
Sam Minnee
45e1fcaf30 FIX: Correct type coercion of MySQL 2019-04-05 15:11:21 +13:00
Sam Minnee
adb6e9eb8d FIX: Perform type coercion on PDO-based MySQL and SQLite connections
It turns out that this is needed for decimal values on MySQL and all
values on SQLite
2019-04-05 15:05:42 +13:00
Sam Minnee
4f4153c834 MINOR: Test test to validate that multiple GreaterThan filters in a filterAny work.
Confirms https://github.com/silverstripe/silverstripe-framework/issues/3995 isn’t a bug.
2019-04-05 15:05:42 +13:00
Ingo Schommer
afb3c825c9
Merge pull request #8890 from open-sausages/pulls/4/get-installer-to-self-create-assets-folder
BUG Update installer to create the assets folder if its missing
2019-04-05 14:41:01 +13:00
Robbie Averill
3771841dd5
Merge pull request #8901 from ian-patel/4.2
Fix Undefined variable: result when catch Exception
2019-04-05 11:53:25 +13:00
Guy Marriott
e9fe68c06c
Merge pull request #8900 from creative-commoners/pulls/4.3/test-state-isolation
MemberTest and SecurityTest now set the default authenticator to use
2019-04-05 11:49:14 +13:00
Ian Patel
759968bbe2 Fix Undefined variable: result when catch Exception 2019-04-05 11:33:01 +13:00
Robbie Averill
123d483213 MemberTest and SecurityTest now set the default authenticator to use 2019-04-05 11:26:29 +13:00
Robbie Averill
67d88c824b
Merge pull request #8880 from tractorcow/pulls/4.2/enum-schema-shifting
BUG Resolve issue where schema changes between enum / non-enum types
2019-04-05 11:09:02 +13:00
Guy Marriott
a9d57f5bfb
Merge pull request #8241 from creative-commoners/pulls/4.3/separate-logging
Separate core error logging from standard LoggerInterface
2019-04-05 08:49:09 +13:00
Guy Marriott
a3d929443a
Merge pull request #8898 from sminnee/fix-3819
FIX: Show RightTitle on CheckboxField
2019-04-04 17:23:02 +13:00
Guy Marriott
961096d921
Merge pull request #8897 from rafaeldsousa/add-array-type-validator-to-getenv
Including is_array validation to getEnv method.
2019-04-04 17:20:43 +13:00