Commit Graph

819 Commits

Author SHA1 Message Date
Ingo Schommer
2d2ca13e45 ENHANCEMENT: added setRows() and setColumns() to customize the size of the textarea field outside of the controller (from r106118)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112518 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:36 +00:00
Ingo Schommer
db460ed57f MINOR Better error handling in Form::__construct() (fixes #5649) (from r105912)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112511 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:02 +00:00
Ingo Schommer
ca02b91673 BUGFIX: TableListField_Item::SelectOptionClasses() can not use it parent protected variable. (from r105876)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112506 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:52:05 +00:00
Ingo Schommer
8a2576ee3e BUGFIX: rollback r105858 which introducesa bug (from r105875)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:48 +00:00
Ingo Schommer
91700a3dac BUGFIX: updated select options classes to work with the dataobjectset returned by selectoptions rather than the array previously (from r105872)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:33 +00:00
Ingo Schommer
092a3c1c26 BUGFIX: TableListField_Item::SelectOptionClasses() can use it parent protected variable. (from r105858)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112503 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:04 +00:00
Ingo Schommer
4c2ff4bd0a APICHANGE: refactored methods in session to use coding conventions (from r105756)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:50:43 +00:00
Ingo Schommer
12fa850986 ENHANCEMENT: Preserve sort options in pagination links in TableListField (from r105275)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112475 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:29:44 +00:00
Ingo Schommer
68fcd8c94f MINOR Reverted r105264, breaks CompositeFieldTest, FieldSetTest, TranslatableTest (from r105274)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112474 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:28:12 +00:00
Ingo Schommer
bcbe9c254d ENHANCEMENT Allowing batch checkbox selection of TableListField rows with TableListField->Markable and TableListField->addSelectOptions() (from r105266)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112473 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:27:59 +00:00
Ingo Schommer
de0bf3f7cd BUGFIX: addFieldToTab segfaulting under PHP 5.2 (from r105264)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112445 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:29:18 +00:00
Ingo Schommer
93cd3ae55d BUGFIX: force dateformat to en_NZ if showcalendar is enabled as calendar is compatibile with en_NZ only (from r105225)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:29:02 +00:00
Ingo Schommer
a191019e7a MINOR Documentation (from r104404)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112345 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 00:04:14 +00:00
Ingo Schommer
c969e04731 MINOR Removed unnecessary $timeformat parameter from TimeField::__construct, and getting the default from Zend_Locale_Format in the same way that DateField behaves (unreleased API, so no api change).
MINOR Automatically choosing $locale in TimeField::__construct, to be consistent with DateField (from r103975)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112328 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:53:13 +00:00
Ingo Schommer
d2c096119c BUGFIX Fixed double pragma after referer redirection on forms with Form->httpSubmission() (fixes #5509, thanks ktauber) (from r103936)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112325 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:51:55 +00:00
Sam Minnee
077a119cfb MINOR Database quoting in TreeDropdownField (fixes #5484) (from r103515)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112146 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:56:48 +00:00
Sam Minnee
da671c628d BUGFIX Fixed CurrencyField->jsValidation() regex escaping (fixes #5462, thanks mobiusnz) (from r103451)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112143 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:53:52 +00:00
Sam Minnee
a2f6487fa3 BUGFIX DateField with setConfig('dmyfields') now validates TRUE for empty values (fixes #5458) (from r103450)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112140 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:52:36 +00:00
Sam Minnee
961d4ce298 BUGFIX: added optional separator for http_build_query in HTTP:setGetVar(). this fixes sorting columns in ModelAdmin (ticket #5325). (from r103012)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112071 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:48:24 +00:00
Sam Minnee
19f4c1ef89 BUGFIX #5320 ManyManyComplexTableField::getQuery() now uses T-SQL compatible syntax CASE WHEN instead of IF THEN which works in multiple databases as well (from r102436)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112066 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:42:01 +00:00
Sam Minnee
3ac1580aae BUGFIX: Explicitly specify the many_many's join table name in the join's ON match statement in ManyManyComplexTableField (from r101608)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112008 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:51:33 +00:00
Sam Minnee
e09cc66e94 BUGFIX: Fixed issues with broekn link tracking (from r101138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111960 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:42:25 +00:00
Sam Minnee
a96cb319d3 BUGFIX Fixed TableListField->print() - was unsetting $cachedSourceItems instead of null'ing it, which breaks later access to the property (from r101080)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111583 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:44:58 +00:00
Sam Minnee
5b6fa898d5 BUGFIX: column and table names now quoted properly (from r100998)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:39 +00:00
Sam Minnee
c54cce8673 BUGFIX Disable javascript date validation via DateField->jsValidation() if locale is not 'en_NZ" (which is the only format it validates for). (from r100986)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111558 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:13 +00:00
Sam Minnee
5f0fcc58ec BUGFIX HTMLEditorField->saveInto() can now find images with urlencoded information for resample (e.g. spaces in filenames) (from r100985)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:00 +00:00
Sam Minnee
30037f269c MINOR Updated r100966 to include spaces on ternary operator for readability and coding conventions (from r100975)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:34 +00:00
Sam Minnee
67db4ce22a FEATURE: MoneyField currency dropdown can be made from an associate array like array('NZD'=>'New Zealand Dollor', 'USD'=>"United States Dollor') as well (from r100966)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:09 +00:00
Sam Minnee
29623a639d MINOR: Correction on email address validator, and a unit test for EmailField php validation (from r100950)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:26:12 +00:00
Sam Minnee
ae66792c33 MINOR Added jQuery requirement to TreeDropdownField (see #5139) (from r100946)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:25:17 +00:00
Sam Minnee
e55102ef29 MINOR Using jquery.live instead of livequery on ImageFormAction.js (from r100886)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111534 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:14:55 +00:00
Andreas Piening
4d7429a393 BUGFIX: Added single quote as a valid local-part of an email address as per RFC5322. Other symbols still excluded although in the spec (from r100825)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-03 01:07:18 +00:00
Andreas Piening
983fb1fc09 BUGFIX #5157 strftime() %F format parameter does not work on Windows - use %Y-%m-%d instead (from r100795)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108762 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-02 01:00:44 +00:00
Ingo Schommer
af0f93c109 MINOR Removed <input name="MAX_FILE_SIZE"> from FileField and SimpleImageField, as it's a meaningless clientside setting thats not respected by any browser, nor part of any HTML spec (see http://bugs.php.net/bug.php?id=40387)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105913 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-30 22:36:24 +00:00
Ingo Schommer
1d80d77270 MINOR Fixed regression from r100774 (from r100775)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105650 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 05:01:46 +00:00
Ingo Schommer
e78dc5273d ENHANCEMENT Allowing custom popup requirements in ComplexTableField without subclassing through $requirementsForPopupCallback
MINOR Added getParentController() to TableListField_ItemRequest and ComplexTableField_Popup
MINOR Extending ComplexTableField_ItemRequest from TableListField_ItemRequest to avoid redundant code (from r100774)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105649 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 05:00:25 +00:00
Ingo Schommer
c81a788ba7 ENHANCEMENT Added 'updateImageForm', 'updateFlashForm', 'updateLinkForm' hooks to HtmlEditorField (the imageform hook was necessary to make the 'pixlr' module work) (see #3938) (from r100753)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105642 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:56:02 +00:00
Ingo Schommer
c8ac8a274d BUGFIX #5099 FileIFrameField fails when using it with a locale different to the default (from r100747)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105634 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:26:47 +00:00
Ingo Schommer
4e87fb5713 BUGFIX get TreeMultiselectField working with an array of items, rather than a relation. (from r100525)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:14:51 +00:00
Ingo Schommer
5a38c65156 API CHANGE TreeDropdownField no longer requires your object to have the Hierarchy extension (from r100512)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:13:05 +00:00
Ingo Schommer
9d9c0b31e9 BUGFIX: wrong constructor function name (from r100508)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:12:06 +00:00
Ingo Schommer
ecb6c8cb3f BUGFIX: replacing calls to deprecated Upload functions - using validator instead (related to r100057) (from r100496)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:03:46 +00:00
Ingo Schommer
45d8433d57 MINOR Pushed @deprecated 2.3 items out to 2.5 since they're still in use for now (from r100486)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105574 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:54:48 +00:00
Ingo Schommer
28f80b8da5 BUGFIX #5121 Fixed cache flushing for FieldSet when removing fields - thanks paradigmincarnate! (from r100417)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:51:35 +00:00
Ingo Schommer
00d19cc3d1 BUGFIX: FormAction input tag attributes were being doubly-escaped. (from r100407)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:50:37 +00:00
Ingo Schommer
e6dac14e9a BUGFIX #5087: Show default values in CTF 'add' popups. (from r99777)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 02:59:14 +00:00
Ingo Schommer
6460d09570 MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 00:11:41 +00:00
Ingo Schommer
fed0d1fe4b BUGFIX Fixed variable existence checks in setValue() in FormField::__construct() by checking for !== NULL (changed from isset($value) to $value in r99360) (from r99394)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102862 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:40:04 +00:00
Ingo Schommer
568f0d34bc BUGFIX Fixed MoneyField constructor - parent (FormField) constructor calls setValue() already, which needs to happen *after* setting certain field instances (from r99391)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102861 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:39:51 +00:00
Ingo Schommer
498c075ece ENHANCEMENT Allow locale/dateformat specific reordering of day, month, year input fields in DateField (from r99361)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102860 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:39:36 +00:00