tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
2,597 Commits 31 Branches 527 Tags 162 MiB
2cb4b43320
Commit Graph

574 Commits

Author SHA1 Message Date
Sean Harvey
859bbb2eaa Reverted r74899 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74900 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Sean Harvey
b6d6dfb76b BUGFIX If validator doesn't exist on Form, don't attempt to call setForm() on it or you'll get a non-object error 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74899 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Will Rossiter
3ff0fc139f FEATURE: hooks into form field to allow custom error messages. Note does not currently apply to the behaviour / js. Just the PHP validation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74739 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Ingo Schommer
fe5e722313 BUGFIX Fixing CurrencyField serverside and javascript validation to accept numbers with leading or trailing spaces 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74725 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Ingo Schommer
c0a7241812 BUGFIX Fixing NumericField serverside validation to accept numbers with leading or trailing spaces by using trim() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74721 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Ingo Schommer
6a51018f50 BUGFIX Fixed NumericField javascript validation to not fail on numbers with trailing or leading whitespace 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74657 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
786b777e0e FEATURE: make PasswordField and ConfirmedPasswordField able to either readonly or disabled. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74538 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
12e2c9cda1 FEATURE: make PasswordField and ConfirmedPasswordField able to either readonly or disabled. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74503 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
f5117782ee Undoing changeset committed in r74490 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74501 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
15c4b90132 git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74490 467b73ca-7a2a-4603-9d3b-597d59a354a9 2011-02-02 14:27:14 +13:00
Normann Lou
2889ab115a BUGFIX: add more condition before $this->form is used as Caller since $this->form can still not be set yet in a certain circumstance. 
ENHANCEMENT: add the ability that a SimpleImageField could be disabled.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74489 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Will Rossiter
a7cd85b06a BUGFIX: fixed typos in ResetFormAction 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74477 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Will Rossiter
d7aead3f71 MINOR: refactored dulicate code in ResetFormField, who knew we had a reset form field... 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74462 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
cfbda47e25 fix the bug in Mingle (SC #234):Users reporting a parse error when trying to open grants. also HD(1571). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74416 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Hamish Friedlander
8a38580159 MINOR: Add disabled class to InlineFormAction, adjust Folder to use InlineFormAction rather than LiteralField for "Delete unused thumbnails" button. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74168 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Will Rossiter
09bd69cdd4 MINOR: added full stop to required labels for consistency 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73596 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Normann Lou
3973a6a47e ENHANCEMENT: more robust conditional check before we go to foreach loop, more robust conditional checking before we call a FormField function where we are not sure the caller is a FormField object. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73435 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Sam Minnee
8dc652aaa8 BUGFIX: Updated i18n javascript system so that the i18n javascript needs to be explicitly included, so that it doesn't poke its nose in where it's not wanted. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@72563 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:09 +13:00
Ingo Schommer
dd6ff797e2 MINOR Merged from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@72384 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:08 +13:00
Will Rossiter
a2ffe586a1 BUGFIX: escaped filename before querying with it - #ajoneil 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@72190 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:07 +13:00
Ingo Schommer
b515a2f2d7 BUGFIX Removed unused ComplexTableField->unpagedSourceItems - was already commented out in r70956, and doesn't seem to be used across parent- or subclasses. Added ticket #3484 to re-enable popup pagination, which was broken and disabled due to the deprecation of $unpagedSourceItems (see r53830) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71348 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:06 +13:00
Will Rossiter
479f8c0fa3 MINOR: added user friendly labels - should really be _t compatible I guess 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71345 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:06 +13:00
Sam Minnee
ce28dccdec BUGFIX #3442: Fix pagination in HasManyComplexTable, HasOneComplexTableField, ManyManyComplexTable 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71018 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Normann Lou
2939e33554 ENHANCEMENT: Ticket 2756: Newsletter performance problem, run out of memory. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70956 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Sean Harvey
66ce174441 MINOR Code formatting fix in DateField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70953 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Sean Harvey
f5b22dadff MINOR Code formatting fixes in CheckboxSetField 
MINOR Added phpDoc comments for documentation that needs to be written explaining the different source data that can be used with CheckboxSetField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70843 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:04 +13:00
Normann Lou
c9df0ee039 BUGFIX: 
1. TableListField? exportfunality random bug. 
2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70747 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
b114900053 BUGFIX: 1. TableListField exportfunality random bug. 2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70743 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
b9145ab995 BUGFIX: 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70741 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
85abd8664b Undoing change committed in r 70734 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70740 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
d7f67183c6 git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70734 467b73ca-7a2a-4603-9d3b-597d59a354a9 2011-02-02 14:27:03 +13:00
Normann Lou
f71025aa40 BUGFIX: $_POST[$this->Name] in TableField::SubmittedFieldSet are not always set 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70695 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Sean Harvey
7f9e91d2b5 MINOR Changed $title parameter to HtmlEditorField constructor to null to be consistent with TextareaField and so title is derived based on the name of the field if no title is given. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70647 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Sean Harvey
c6275611ee BUGFIX Defined jsValidation() and validate() so that inherited validation from DateField doesn't break PopupDateTimeField - this still needs fixing, and PopupDateTimeField shouldn't inherit from CalendarDateField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70609 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Sean Harvey
6eec6006a5 MINOR Code formatting fix in FormField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70608 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Will Rossiter
59da2e1887 MINOR: ticket 1846. Changed Action to title case 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70598 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:01 +13:00
Saophalkun Ponlu
5ddb00dfa3 BUGFIX: when the total number of rows is 0 the pagination says 1 to 0 of 0 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70565 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:01 +13:00
Sean Harvey
87772a9713 BUGFIX Hidden field needs to exist for DateField_Disabled in order for validation to pass correctly 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70545 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:01 +13:00
Sean Harvey
68898849ad MINOR Update ResetFormAction to make use of createTag() method instead of patching together strings to make the form input 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70269 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:00 +13:00
Sean Harvey
9c4552efa3 MINOR Fixed undefined variable error in TableListField->generateExportFileData() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70257 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:00 +13:00
Normann Lou
d3a5bcbb7f APICHANGE: we move the filedata generation part of export() function to a new function generateExportFileData, so that, a child class could reuse the function when overload export function 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70150 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:59 +13:00
Sean Harvey
b839d2c2c1 BUGFIX Removed for attribute on FieldGroup->FieldHolder() since there's no ID of any input fields to match the label to. 
BUGFIX Changed the FieldHolder method to use explicit functionality instead of statically calling FormField::FieldHolder()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70127 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:58 +13:00
Sean Harvey
504c515ee6 MINOR Code formatting fixes in HtmlEditorField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70059 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:58 +13:00
Sean Harvey
44f2caf60b BUGFIX Fixed FileField->getFolderName() - it was not returning $this->folderName, instead it was returning an undefined variable in error 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69975 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:57 +13:00
Saophalkun Ponlu
9278f0ffe5 BUGFIX: error when creating a form 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69973 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:57 +13:00
Sean Harvey
f9c25b2465 MINOR Removed "edit image" button since the image editor has been removed 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69939 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:56 +13:00
Sam Minnee
ec5448008c ENHANCEMENT #3313 gigtech: Added ComplexTableField::setAddTitle() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69924 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:56 +13:00
Ingo Schommer
23ed38765c ENHANCEMENT Moved i18n::get_existing_content_languages() to correct namespace in Translatable::get_existing_content_languages(). 
BUGFIX Using SQL DISTINCT in get_existing_content_languages()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69891 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Sean Harvey
8c88519d9f BUGFIX Fixed use of undefined constant error, and undefined variable error in TableField stopping CMS user from adding records to a TableField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69870 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Sean Harvey
d0831b37b6 MINOR Moved form session error set up from Form constructor to method so it can be used again if need be 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69843 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00