Commit Graph

21285 Commits

Author SHA1 Message Date
Guy Marriott
a48beac845
FIX Calculate threshold condition with SQL rather than PHP
This is a performance fix. Modern SQL engines can avoid counting a whole result set (potentially thousands of records) when you are only interested if the count exceeds a threshold.
2019-04-15 16:48:44 +12:00
Sheila Bañez
63360f8048 BUG Replace substr with mb_substr to get the correct position 2019-04-15 16:38:52 +12:00
Guy Marriott
b1339f0d72 NEW Update FieldList::replaceField API to match removeByName (#8876)
* API Update FieldList::replaceField API to match removeByName

This specifically adds the parameter that `removeByName` has but `replaceField` does not. This parameter is set to `true` by default rather than inheriting the same default as `removeByField`. This is because the existing funtionality of `replaceField` was the same as if this parameter was set to `true`. This should be updated in SS5 to match the `removeByField` API.

* Add dataFieldOnly to CompositeField
2019-04-15 16:22:54 +12:00
Ralph Slooten
66c372ce28 Include baseURL with relative setGetVar() links (#8834)
* Return baseURL with setGetVar

* Adjust testSetGetVar tests for base url
2019-04-15 14:50:46 +12:00
Robbie Averill
2c971eea83 Merge branch '4.3' into 4 2019-04-11 11:37:47 +12:00
Robbie Averill
f2f28586d9 Merge branch '4.2' into 4.3 2019-04-11 11:37:34 +12:00
Robbie Averill
116ea12783 Merge branch '4.1' into 4.2 2019-04-11 11:37:22 +12:00
Robbie Averill
f4a6115ee6 Merge branch '4.0' into 4.1 2019-04-11 11:36:40 +12:00
Robbie Averill
8a06682e31 Merge branch '4.3' into 4
# Conflicts:
 #	src/ORM/Connect/DBSchemaManager.php
2019-04-11 11:24:17 +12:00
Robbie Averill
55cbacca86 Merge branch '4.2' into 4.3
# Conflicts:
 #	src/Forms/GridField/GridFieldLevelup.php
 #	src/includes/constants.php
2019-04-11 11:21:42 +12:00
Robbie Averill
b90061fdd3 Update translations 2019-04-11 11:16:00 +12:00
Loz Calver
9d3337b7af
Merge pull request #8914 from open-sausages/pulls/4/docs-publishall
DOCS Limitations of publishall
2019-04-10 09:21:03 +01:00
Ingo Schommer
fcdc146996 DOCS Limitations of publishall
Fixes https://github.com/silverstripe/silverstripe-cms/issues/2406
2019-04-10 10:42:49 +12:00
Robbie Averill
f50fdd72dd
Merge pull request #8913 from altwohill/patch-1
Fix formatting
2019-04-10 08:24:49 +12:00
Al
9a43952385
Fix formatting
Last code block was not closed
2019-04-10 08:22:51 +12:00
Robbie Averill
761d4d877e
Merge pull request #8905 from sminnee/fix-3519
FIX: Better error message when GridFieldLevelup passed bad record details
2019-04-09 09:01:33 +12:00
Robbie Averill
9bb6ab9977
Merge pull request #8907 from open-sausages/pulls/docs/upgrading-guide-issues
DOCS Upgrading guide known issues and self-update
2019-04-09 09:00:41 +12:00
Ingo Schommer
d04ef04999 DOCS Upgrading guide known issues and self-update 2019-04-09 08:24:15 +12:00
Sam Minnee
f12fa62ad6 FIX: Better error message when GridFieldLevelup passed bad record details
Fixes https://github.com/silverstripe/silverstripe-framework/issues/3519
2019-04-08 18:09:51 +12:00
Guy Marriott
0f4bd1606a
Merge pull request #8903 from kinglozzer/enum-empty-defaults
FIX: prevent unnecessary field alterations for enums with empty defaults
2019-04-06 09:48:57 +13:00
Loz Calver
594af77134 FIX: prevent unnecessary field alterations for enums with empty defaults 2019-04-05 16:17:41 +01:00
Loz Calver
0b5f5e3bcb
Merge pull request #8590 from sminnee/zero-is-false
Ensure that decimal DB values are fetched as floats
2019-04-05 09:41:41 +01:00
Robbie Averill
8b4b54f264
PHPCS linting error on indentation 2019-04-05 16:29:24 +13:00
Sam Minnee
d295888838 MINOR: Improve type testing 2019-04-05 15:11:21 +13:00
Sam Minnee
c9c7c0c825 FIX: Fix PDO cached statement column coercion
NEW: Add PDOStatementHandle class that is now what PDOQuery expects
2019-04-05 15:11:21 +13:00
Sam Minnee
2625cea5e3 MINOR: Add a test that 0 is falser on int, decimal, currency
Validates that https://github.com/silverstripe/silverstripe-framework/issues/3473 has been fixed

The bug was fixed in #8448
2019-04-05 15:11:21 +13:00
Sam Minnee
45e1fcaf30 FIX: Correct type coercion of MySQL 2019-04-05 15:11:21 +13:00
Sam Minnee
adb6e9eb8d FIX: Perform type coercion on PDO-based MySQL and SQLite connections
It turns out that this is needed for decimal values on MySQL and all
values on SQLite
2019-04-05 15:05:42 +13:00
Sam Minnee
4f4153c834 MINOR: Test test to validate that multiple GreaterThan filters in a filterAny work.
Confirms https://github.com/silverstripe/silverstripe-framework/issues/3995 isn’t a bug.
2019-04-05 15:05:42 +13:00
Ingo Schommer
afb3c825c9
Merge pull request #8890 from open-sausages/pulls/4/get-installer-to-self-create-assets-folder
BUG Update installer to create the assets folder if its missing
2019-04-05 14:41:01 +13:00
Robbie Averill
3771841dd5
Merge pull request #8901 from ian-patel/4.2
Fix Undefined variable: result when catch Exception
2019-04-05 11:53:25 +13:00
Guy Marriott
e9fe68c06c
Merge pull request #8900 from creative-commoners/pulls/4.3/test-state-isolation
MemberTest and SecurityTest now set the default authenticator to use
2019-04-05 11:49:14 +13:00
Ian Patel
759968bbe2 Fix Undefined variable: result when catch Exception 2019-04-05 11:33:01 +13:00
Robbie Averill
123d483213 MemberTest and SecurityTest now set the default authenticator to use 2019-04-05 11:26:29 +13:00
Robbie Averill
67d88c824b
Merge pull request #8880 from tractorcow/pulls/4.2/enum-schema-shifting
BUG Resolve issue where schema changes between enum / non-enum types
2019-04-05 11:09:02 +13:00
Guy Marriott
a9d57f5bfb
Merge pull request #8241 from creative-commoners/pulls/4.3/separate-logging
Separate core error logging from standard LoggerInterface
2019-04-05 08:49:09 +13:00
Guy Marriott
a3d929443a
Merge pull request #8898 from sminnee/fix-3819
FIX: Show RightTitle on CheckboxField
2019-04-04 17:23:02 +13:00
Guy Marriott
961096d921
Merge pull request #8897 from rafaeldsousa/add-array-type-validator-to-getenv
Including is_array validation to getEnv method.
2019-04-04 17:20:43 +13:00
Sam Minnee
8a098d637f FIX: Show RightTitle on CheckboxField
RightTitle, if set, will be shown after Title
with a space between them.

Fixes https://github.com/silverstripe/silverstripe-framework/issues/3819
2019-04-04 15:50:19 +13:00
Rafael Marins de Sousa
68337bd8be Including is_array validation to getEnv method. When SS website is deployed to FortRabbit .env file is read as string what causes the website to crash, due to the lack of type check at getEnv method. 2019-04-04 15:41:13 +13:00
Robbie Averill
acf449011b
Merge pull request #8895 from thats4shaw/patch-1
DOCS HistoryViewerField updates
2019-04-02 18:05:37 +13:00
Hayden Shaw
30775aa428
DOCS HistoryViewerField updates
* Add missing rollback operation in scaffolding example
* Update block_id references to id  to allow query to read query to run successfully in conjunction with HistoryViewerField
2019-04-02 16:59:52 +13:00
Robbie Averill
d816989f2e
Merge pull request #8893 from open-sausages/pulls/4/docs-critical-security-fixes
DOCS Limited "critical security fixes" release lines
2019-04-02 13:14:14 +13:00
Robbie Averill
26ff24067b
Merge pull request #8894 from antons-/patch-1
DOCS - Update path
2019-04-02 13:13:10 +13:00
Anton Smith
167881cc38 Update path 2019-04-02 12:46:19 +13:00
Ingo Schommer
af7e055574 DOCS Limited "critical security fixes" release lines
We're adopting CVSS (https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator),
which allows us to classify the impact of security issues
based on industry standard metrics.

While there is still a lot of room for interpretation,
it is more objective than our previous system of "critical/high/medium/low",
with one sentence descriptions on how we interpret that "severity rating".

This effectively changes our process to only apply
security fixes to release lines in "limited support" (currently 3.6 and 3.7)
if they're considered "critical" (CVSS > 9.0).

We've already limited preannounces to CVSS >7.0 in these docs.
2019-04-01 17:08:13 +13:00
Maxime Rainville
c84ad4278f BUG Update installer to create the assets folder if its missing 2019-03-29 17:56:39 +13:00
Andre Kiste
b77771ea09
Merge pull request #8888 from robomc/patch-1
Change case in link
2019-03-29 16:45:39 +13:00
Rob McGrail
7396f57088
Change case in link
Link doesn't resolve on https://docs.silverstripe.org/en/4/upgrading/upgrading_module/ because of the capital letter
2019-03-29 10:42:31 +13:00
Loz Calver
2073ac85c2
Merge pull request #8879 from jonom/fix-has-one-file-scaffold
FIX Allow only one file when scaffolding has_one File relationship
2019-03-27 09:16:50 +00:00