Commit Graph

12663 Commits

Author SHA1 Message Date
Will Rossiter
11a809798b Merge pull request #2788 from MarcusDalgren/session-cookie-fix
Fix Session::set_cookie_domain
2014-01-17 12:20:55 -08:00
Marcus Dalgren
9934230ad8 Fix Session::set_cookie_domain 2014-01-17 15:27:51 +01:00
Mateusz U
027022ef67 Merge pull request #2785 from halkyon/cmsmenu_test_fix
Fixing failing tests because ?locale= is appended to the end of the URL.
2014-01-16 17:50:40 -08:00
Sean Harvey
9d11f6f2f5 Fixing failing tests because ?locale= is appended to the end of the URL.
Switching from assertEquals to assertContains to be more flexible when
extensions like Translatable add query vars at the end of the links.
2014-01-17 13:48:46 +13:00
madmatt
e0b4e6125c MINOR: Added behat test to cover changes made in e69e65c. 2014-01-15 16:20:19 +13:00
madmatt
e69e65c1e3 BUGFIX: Fix JS for PermissionCheckboxsetField in SecurityAdmin 2014-01-15 15:51:35 +13:00
Will Rossiter
9b5a9afe2b Merge pull request #2773 from Zauberfisch/patch-1
Removed $MetaTitle from docs(closes #2761)
2014-01-13 21:19:45 -08:00
Daniel Black
fb12d1ee37 Update install.php5
Defaulting to MySQL here is really dumb. There is an explicit type as an argument so falling back to mysql could result in "I couldn't write to path ....db" despite the real error that the include of the sqlite3/code/SQLiteDatabaseConfigurationHelper.php failed for some reason.

Other uses of getDatabaseConfigurationHelper also need a similar error handler.
2014-01-14 13:07:09 +11:00
Zauberfisch
0e95f7f2a6 Removed $MetaTitle from docs(closes #2761) 2014-01-13 19:00:41 +00:00
Joe Harvey
405426799b Issue #2766 - Moves logic to return ReadonlyField versions of MoneyFields child fields to performReadonlyTransformation() method and reverts changes to MoneyField::setReadonly() as per Wilr’s (https://github.com/wilr) request 2014-01-13 08:35:40 +00:00
Will Rossiter
e302793bda Merge pull request #2770 from madmatt/pulls/updatetreenodes-notice
BUG: Remove possibility of E_NOTICE in updatetreenodes().
2014-01-12 21:57:32 -08:00
madmatt
77c35e7bde BUGFIX: Remove possibility of E_NOTICE in updatetreenodes(). 2014-01-13 17:47:33 +13:00
Will Rossiter
0b22ca6c59 FIX: Ignore current instance when checking for duplicate records (Fixes #1927) 2014-01-12 20:54:55 +13:00
Will Rossiter
a50996a010 NEW: Add support for push operator on ArrayList (Fixes #1539) 2014-01-12 18:55:40 +13:00
Will Rossiter
c61f6540fb BUG Add support for X-Forwarded-Proto checking SSL (Fixes #1416)
De-facto standard for identifying the originating protocol of an HTTP request through a reverse proxy or load balancer.

http://www.geekisp.com/faq/6_65_en.html
2014-01-12 18:05:09 +13:00
Will Rossiter
e7266535c5 FIX: Allow empty checkboxes through setValue(null) (#1392) 2014-01-12 17:28:09 +13:00
Will Rossiter
13bd4e96b1 Correct PHPDoc for Member::currentUser. (Fixes #2750) 2014-01-12 16:08:31 +13:00
Will Rossiter
4ea62b44f9 FIX: Ensure GridFieldDetailForm has the current record validator.
Currently the validator is only set through
ModelAdmin and not through GridField
directly. This will set the validator based on the
record unless a custom validator has been
provided.

http://www.silverstripe.org/data-model-questions/show/34650?start=8#post331958
2014-01-12 16:08:31 +13:00
Simon Welsh
5e3420a640 FIX: Use the correct classname to check for a repair
This re-enables correcting the case of tables, mostly used after an import from MySQL running on Windows.

Fixes #2713
2014-01-12 07:15:17 +13:00
Will Rossiter
40814fc3c4 FIX: Ensure GridFieldDetailForm has the current record validator.
Currently the validator is only set through
ModelAdmin and not through GridField
directly. This will set the validator based on the
record unless a custom validator has been
provided.

http://www.silverstripe.org/data-model-questions/show/34650?start=8#post331958
2014-01-11 16:01:52 +13:00
Will Rossiter
f433b5000f FIX: Resolve issue when selected value is zero. (#2530)
$this->value is stored as string internally. In
the special case that the option value is 0, the
type comparison fails to resolve 0 == '0',
see http://www.php.net/manual/en/types.comparisons.php.
2014-01-11 13:25:40 +13:00
Will Rossiter
dd801bdb0b Merge pull request #2242 from torleif/3.0
FIX postgres can filter on non text fields
2014-01-10 15:19:12 -08:00
Joe Harvey
611d571b65 BUG corrects MoneyField::setReadonly() method in order to return ReadonlyField instances of its child fields
Issue #2766 - This causes our cloned MoneyField to actually contain two ReadonlyFields for currency and amount.
2014-01-10 15:38:06 +00:00
Will Rossiter
6fae1e6392 Merge pull request #2763 from jedateach/validationresult-chaining
API: ValidationResult functions chain-able.
2014-01-08 19:47:33 -08:00
Jeremy Shipman
62694b0a8b NEW: Made ValidationResult functions chain-able.
Added unit tests for CombiningResults
2014-01-09 16:32:27 +13:00
Mateusz U
c84d9ee00c Merge pull request #2760 from madmatt/pulls/securityadmin-js
BUGFIX: Fix SecurityAdmin checkboxes not being properly unchecked
2014-01-08 16:13:57 -08:00
Will Rossiter
516277a6ad Merge pull request #2757 from jedateach/confirmedpasswordfield-fix
FIX: ConfirmedPasswordField setName failed to set names of child fields.
2014-01-08 12:33:02 -08:00
Matt Peel
aec29bf8c8 Properly fix SecurityAdmin Groups javascript checkbox toggling. 2014-01-09 08:47:41 +13:00
Sriram Venkatesh
efa309c977 Corrects Broken Link 2014-01-09 08:20:34 +13:00
Matt Peel
ee1cfa2393 BUGFIX: Fix SecurityAdmin checkboxes not being properly unchecked 2014-01-08 14:55:23 +13:00
Simon Welsh
ac1658b500 Merge pull request #2758 from edlinklater/patch-1
MINOR fix typo in link
2014-01-07 10:59:49 -08:00
Ed Linklater
264fbcbff6 MINOR fix typo in link 2014-01-08 03:14:20 +13:00
Jeremy Shipman
8d8f3abace FIX: ConfirmedPasswordField setName failed to set names of child fields.
FIX: ConfirmedPasswordField relied on POST variables. These should instead come from setValue().
Added all important tests for validating the field: valid if passwords match, invalid if passwords differ.
2014-01-07 17:17:55 +13:00
Matt Peel
0eaae90bdb Update theHtmlFieldShouldContain step to include negation.
This allows steps to be declared as either “should contain” or “should not
contain”.
2014-01-06 17:22:40 +13:00
madmatt
2b00036d9d Allow GridFields without titles to be found. 2014-01-06 10:20:44 +13:00
colymba
02bceca9b4 FIX UploadField validation error and styles
UploadField now return the validator's error message instead of 403. Plus nicer layout for error messages.
2014-01-04 22:30:35 +02:00
Will Rossiter
98c01a34f6 Merge pull request #2752 from nedmas/patch-1
FIX: Documentation for Silverstripe Test
2014-01-02 13:04:53 -08:00
Tom Densham
a04c79872f FIX: Documentation for Silverstripe Test
Change the access level of the `static $fixture_file` property in the example code.
2014-01-02 11:38:43 +00:00
Martijn
180bae826a formHtmlContent() uses missing FormEncType() call
it needs to call $this->getEncType() instead..
2014-01-02 10:44:00 +01:00
Will Rossiter
1c6bea9bb5 Merge pull request #2745 from guttmann/patch-1
Fix error in code block for ModelAdmin documentation
2013-12-23 12:44:25 -08:00
James Goodman
9c9e5c0656 Fix error in code block for ModelAdmin example 2013-12-24 07:59:05 +13:00
Will Rossiter
88c59ef0a7 Fix icon being stretched in ModelAdmins 2013-12-23 20:21:05 +13:00
Will Rossiter
3f6db0ddae Fix section icon in cms header 2013-12-21 17:23:07 +13:00
Will Rossiter
3e2cf27b38 Add ability for a panel link to link externally. 2013-12-21 16:59:09 +13:00
Will Rossiter
770e23f8e1 Merge pull request #2270 from ARNHOE/3.1-updatedfieldgroup
BUG Updated fieldgroup class and example code
2013-12-20 19:14:21 -08:00
Will Rossiter
57e65075e9 Dialog icon size
The dialog close icon was one 1px higher then the dialog close hover icon causing a little bit of movement when hovering.
2013-12-21 16:11:06 +13:00
Will Rossiter
1f125730e4 Merge pull request #2281 from mandrew/fixed_collapsed
Fixing expanding/collapse CMS menu targeting wrong element
2013-12-20 18:51:55 -08:00
Will Rossiter
8b9f8cfd6f Merge pull request #2742 from ss23/patch-1
Make CacheTest sleep properly
2013-12-20 18:47:06 -08:00
Hendrik Schaper
c563caec05 GroupedList: Enable grouping by a function result. 2013-12-21 15:15:55 +13:00
Stephen Shkardoon
40163edba7 Make CacheTest sleep properly
This way it will always sleep for the right amount of time (or longer)
2013-12-21 15:05:51 +13:00