Guy Sartorelli
a92baeaf6f
FIX Allow double dots in path when not attempting directory traversal ( #11219 )
2024-05-06 13:15:26 +12:00
Loz Calver
a53301f673
FIX: OutOfBoundsException when recipe-core isn't installed ( fixes #11197 )
2024-04-15 16:59:59 +01:00
Steve Boyd
a18fb1bcb7
MNT Ensure composer/semver installed or skip test
2024-03-04 12:52:17 +13:00
Guy Sartorelli
4f3282bf2a
Merge pull request #11157 from lekoala/patch-46
...
FIX use composer runtime api
2024-02-28 09:16:25 +13:00
Thomas Portelange
59177dd315
Delete tests/php/Core/Manifest/fixtures/VersionProviderTest directory
2024-02-27 10:42:25 +01:00
Thomas Portelange
a06ce0493a
use VersionParser instead of comparator
2024-02-26 11:44:11 +01:00
Thomas Portelange
80e197fe4f
make error message more readable
2024-02-26 10:21:23 +01:00
Thomas Portelange
a1d1e977c5
use composer/semver
2024-02-26 10:13:34 +01:00
Thomas Portelange
2b64e98afc
Update VersionProviderTest.php
2024-02-26 09:48:15 +01:00
Guy Sartorelli
7f71695335
NEW Wire up symfony/validator ( #11123 )
2024-02-02 13:15:32 +13:00
Nick
e456de11b0
Fix clobbering of the upload size validation ( #10059 )
...
* Fix clobbering of the upload size validation
When the validation is set here like this, it overrides validation which has already been setup with a simple '*' rule for the size based on PHP.
If you've defined in the sites yml config something like
SilverStripe\Assets\Upload_Validator:
default_max_file_size:
'[image]': '2m'
'*' : '1m'
then it will not be respected.
If you review SilverStripe\Assets\Upload_Validator and check the getAllowedMaxFileSize method, you'll see the sizing will be populated (if it hasn't been done before).
You can see it fail by;
- Setup a new SilverStripe site.
- Set your PHP to allow max post / max upload size of 10mb.
- Add the above config to your sites yml file and flush.
- In the CMS you'll be able to upload a 5MB file, when you shouldn't.
* Test that FileField will use size validation if defined
Couple of tests which prove a fix so the FileField and others will use the default_max_file_size setting
* Fix variable name in last commit
This is what happens when you refactor in the github window.
Fix the variable names. This will get squashed once merged.
* Updates the pr - white space and non deprecated method for byte conversion
Remove extra white space to appease the CS. Use the non deprecated method for memstring2bytes
* White space fixes for the phpcs
White space fixes for the phpcs
* Ensure that "memstring2bytes" can handle if an empty or value with no number is passed in
* DEP Bump assets constraint to ensure that change is also pulled in
---------
Co-authored-by: Guy Sartorelli <guy.sartorelli@silverstripe.com>
2024-01-08 15:49:41 +13:00
Sabina Talipova
56511c8618
MNT Remove TODO comments
2023-10-30 13:21:09 +13:00
Thomas Portelange
359cb1427a
BUG include silverstripe core files into roots
2023-08-02 10:00:33 +12:00
Steve Boyd
ef3b91417a
FIX Get ApcuCacheFactory and MemcachedCacheFactory working again
2023-05-17 10:18:28 +12:00
Steve Boyd
63c2460f72
Merge branch '4' into 5.0
2023-03-30 13:20:03 +13:00
Steve Boyd
41bb35f3f3
FIX Reduce array method calls
2023-03-22 11:06:23 +13:00
Guy Sartorelli
046befc4ba
ENH Improve deprecation logging
2023-03-06 13:25:44 +13:00
Guy Sartorelli
128b327c6d
API Add method to check if env var is set
2023-03-06 11:49:22 +13:00
Guy Sartorelli
7c20ade548
DEP Replace thirdparty simpletest with symfony domcrawler
2023-02-02 13:31:45 +13:00
Steve Boyd
77301408d8
MNT Remove legacy upgrader config
2023-01-20 17:05:41 +13:00
Steve Boyd
c1a773310d
ENH PHP 8.2 support
2022-12-21 14:44:47 +13:00
Sabina Talipova
53c0147f11
API Remove deprecated code ( #10594 )
2022-12-08 10:44:47 +13:00
Steve Boyd
b5533e4680
API Stop using deprecated API
2022-11-28 19:16:31 +13:00
Sabina Talipova
a52c7795c7
Merge branch '4' into 5
2022-11-22 11:41:53 +13:00
Steve Boyd
137ebcebec
API Stop using deprecated API
2022-11-15 18:20:54 +13:00
Steve Boyd
6e9d3ab632
Merge branch '4' into 5
2022-10-21 12:00:39 +13:00
Steve Boyd
59b980edd7
Merge branch '4.11' into 4
2022-10-21 11:46:39 +13:00
Steve Boyd
e3a6cad8a8
FIX Allow passing objects to InjectionCreator::create()
...
Co-authored-by: Nate Devereux <nate@daveclark.co.nz>
2022-10-19 18:04:48 +13:00
Guy Sartorelli
5e16b29699
Merge branch '4' into 5
2022-09-29 09:43:31 +13:00
Guy Sartorelli
421864d111
Merge branch '4.11' into 4
2022-09-29 09:41:06 +13:00
Guy Sartorelli
4a598ded51
FIX Allow removing named extensions in yaml config
2022-09-27 13:15:28 +13:00
Steve Boyd
c9bc01473c
API Update caching to use symfony 6
2022-09-07 16:08:54 +12:00
Guy Sartorelli
3284c06703
API Remove PHPUnit 5.7 compatability hacks
2022-08-12 10:52:56 +12:00
Guy Sartorelli
1253ab82af
Merge pull request #10415 from kinglozzer/10413-php81-enums
...
NEW: Add support for autoloading PHP 8.1 enums
2022-07-27 11:38:51 +12:00
Loz Calver
d3f104382d
NEW: Add support for autoloading PHP 8.1 enums
2022-07-22 15:59:55 +01:00
Steve Boyd
4d662d2dea
Merge branch '4.11' into 4
2022-06-28 17:42:07 +12:00
Steve Boyd
98b985fb91
Merge branch '4.10' into 4.11
2022-06-28 17:41:49 +12:00
Steve Boyd
b5abc38455
CVE-2021-41559 Disable xml entities
2022-06-28 17:04:34 +12:00
Paweł Suwiński
1c85d151a6
NEW Add factory_method configuration to Injector
...
use callable as well as creator
2022-06-09 13:57:47 +12:00
Steve Boyd
6a779d07d0
ENH Allow multiple backtick variables in a single value
2022-05-12 17:12:14 +12:00
Steve Boyd
511b3bb060
ENH PHP 8.1 compatibility
2022-04-14 13:12:59 +12:00
Steve Boyd
f488f38f7d
NEW Get the version for an individual module
2022-03-08 13:48:43 +13:00
Lukas
552cf5944d
MNT Fix various typos with codespell ( #10177 )
2021-12-13 21:05:33 +13:00
Maxime Rainville
e0197191b8
Rename "Ignore CI Configs" to "Ignored CI Config"
2021-11-22 11:02:27 +13:00
Maxime Rainville
7c3fddfc8a
Anwser Peer review feedback
2021-11-18 23:16:03 +13:00
Maxime Rainville
cbc4593ab4
ENH Don't index test from PHPUNit 5.7 module wdon using PHPUnit 9.5
2021-11-18 21:45:53 +13:00
Maxime Rainville
640a7e3eea
ENH Improve ManifestFileFinder so it can ignore test based on the testing library
2021-11-18 21:45:53 +13:00
Maxime Rainville
2922370d81
API Add Module::getCILibrary function
2021-11-18 21:45:53 +13:00
Steve Boyd
081537d014
MNT Adjust a couple of unit tests to run from recipe-kitchen-sink
2021-11-16 12:55:00 +13:00
Steve Boyd
cd076542f4
API Upgrade SapphireTest to work with phpunit 9 ( #10028 )
2021-10-27 15:39:47 +13:00
