There are also a few general corrections to PHPDocs that I noticed along
the way (e.g. adding `|null` when the method is returning a null value.
There are some cases where either the return type or the whole PHPDoc
was duplicated from the parent class - in those cases I've simply
removed the duplication.
* ENH Create Requirements::customScriptWithAttributes
* MNT PHP Lint failures corrected
* ENH Refactored attribute handling to avoid API changes, auto lowercase, strong typing
* FIX Updated default value handling for type in customScriptWithAttributes
* DOC Removed white space
* MNT PHP Lint Failures Corrected
* Update src/View/Requirements_Backend.php
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
* Update src/View/Requirements_Backend.php
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
* Update tests/php/View/RequirementsTest.php
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
* FIX Removed extra closing brace in customScriptWithAttributes
* Update src/View/Requirements_Backend.php
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
* Update src/View/Requirements.php
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
* MNT Fixed left over content definition and created tests for uniquenessIDs
* MNT Fixed PHP Lint Error
* MNT Fix PHP Lint Error
* FIX Remove attribute when calling customScript with the same uniquenessID
---------
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
NOTE: There will be additional related PRs required for at least
silverstripe/cms and silverstripe/admin.
Co-authored-by: Guy Sartorelli <guy.sartorelli@silverstripe.com>
SSViewer iterates on Iterators that it receives twice: first to get the
total number of items, then to actually render each item.
This necessitates a rewind. In order to make more use of generators,
which are not rewindable, I’d like to remove the need for a rewind.
I’ve done this by caching the content of the iterator as an array
within SSViewer_Scope.
Although this means a bit of memory usage, there are no cases in which
code will get to this point without iterating on all items, which would
use the memory anyway. It would only create onerous impacts in cases
where you are iterating on very long iterators, which would mean you’re
rendering a very large page anyway, and probably have other performance
issues.
