tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
4,617 Commits 31 Branches 527 Tags 162 MiB
25af09b0f6
Commit Graph

1270 Commits

Author SHA1 Message Date
Sam Minnee
ffba082738 BUGFIX Fixed column names that were not quoted that broke PostgreSQL (from r110944) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112869 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:06:15 +00:00
Sam Minnee
4c0afd2564 BUGFIX Fixed double quotes around column names in Versioned::augmentDatabase() (from r110914) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112867 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:03:19 +00:00
Sam Minnee
0b2ed12c63 BUGFIX: delete orphaned records from versioned tables when updating. #5936 (from r110901) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112866 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:01:51 +00:00
Sam Minnee
995f1f4157 BUGFIX: ensure that pages can only be requested from staging and live (from r110759) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112845 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:32:39 +00:00
Sam Minnee
9d72145ee1 MINOR Warning about install.php existing for root site tree node as well (SiteConfig form) (from r110440) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112841 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:31:07 +00:00
Sam Minnee
d0c9fe908a MINOR: added missing closing tag (from r110243) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112839 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:29:55 +00:00
Sam Minnee
32783ef0e8 MINOR Make dev/build not constantly show a changed index because of whitespace between VersionID and Version in the index spec (from r110205) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112837 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:29:25 +00:00
Sam Minnee
6e8bf5617a MINOR: only call next() in iterator validation on initialisation or after reset NOT if current value is invalid (from r110190) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112834 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:27:51 +00:00
Sam Minnee
ac33763d05 BUGFIX: getItem didn't consider the PostgreSQL SQL syntax. Columns with Capital letters must be quoted. Added quotes to the where clause in getItem. I didn't added quotes to the baseTable because it causes PostgreSQL errors (tables can not be double quoted, just single quoted). (from r109591) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112827 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:25:32 +00:00
Sam Minnee
458f3b1197 MINOR: neatly quote identifiers (from r109405) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112826 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:25:19 +00:00
Sam Minnee
496e9bcef6 API CHANGE #5873 DataObjectSet::shift() now performs a proper shift instead of unshift (wrong). Please use DataObjectSet::unshift($item) if unshifting was intended! 
API CHANGE Added DataObjectSet::pop()
MINOR Unit tests for DataObjectSet::shift(), DataObjectSet::unshift() and DataObjectSet::pop() (from r109156)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112817 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:20:56 +00:00
Sam Minnee
d6fdc57db7 BUGFIX SiteTree decorated canView() checks not being passed through to SiteTree::canView() (from r109082) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112775 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:54:02 +00:00
Sam Minnee
adfab98adb BUGFIX StringField::setNullifyEmpty() should assign the given value boolean, not evaluate whether it's true or not (from r109081) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112774 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:53:46 +00:00
Sam Minnee
58d6cbf81a MINOR: remove SQL table alias keyword AS (from r108961) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112769 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:51:53 +00:00
Sam Minnee
d295d682c5 ENHANCEMENT #3828 500 server error page is created by default on dev/build (from r108644) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112763 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:49:53 +00:00
Sam Minnee
9a036a6fad MINOR: allow $icon to be overridden on ErrorPages. PATCH via martljn (#5875). (from r108640) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112761 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:48:04 +00:00
Sam Minnee
4aa299c4f2 MINOR Making "todo" tab title translatable (from r108441) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112751 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:37:07 +00:00
Sam Minnee
684e76e36b ENHANCEMENT Added argument to SQLQuery->leftJoin()/innerJoin() (#5802, thanks stojg) (from r108418) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112732 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:58:43 +00:00
Sam Minnee
e5a07227c2 ENHANCEMENT: Full-text search with double quotes returns too many results. ticket #5733. Thanks ktauber. 
Using htmlentities($keywords,ENT_NOQUOTES) instead of proposed solution (from r108417)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112731 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:58:23 +00:00
Sam Minnee
ca7edd5ca5 BUGFIX Undefined variable when calling DataObject::many_many_extraFields() and relation name couldn't be found for the component (from r108400) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112726 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:53:59 +00:00
Sam Minnee
2058ee31ee BUGFIX: DataObjects without the Versioned decorator cannot have a "Version" field. ticket #5775. Thanks ajshort (from r108399) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112725 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:53:19 +00:00
Sam Minnee
bcdf352a71 ENHANCEMENT: Show a warning inside the the CMS if you've neglected to delete install.php (from r108024) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112707 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:40:18 +00:00
Sam Minnee
ad68943003 BUGFIX dev/build always reporting index change because of a whitespace in the index column names (from r107831) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112700 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:27:12 +00:00
Ingo Schommer
b64015e2cf BUGFIX Remove dummy entry created by Versioned if record is first written to Live stage (fixes #5596, thanks muzdowski) (from r107537) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112603 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:53:14 +00:00
Ingo Schommer
cfe9b518a5 MINOR: Fixed Documentation (from r107430) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112594 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:46:54 +00:00
Ingo Schommer
556e753fee ENHANCEMENT: Added documentation and changed static names (from r107429) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112593 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:46:32 +00:00
Ingo Schommer
2f4fe2ff35 ENHANCEMENT: Added static to set regeneration of default pages (ticket #5633) (from r107426) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112591 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:44:57 +00:00
Ingo Schommer
bd6e51c87f BUGFIX: Only highlight strings more than 2 characters long. #4949 (from r107423) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112590 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:44:24 +00:00
Ingo Schommer
f63751893b BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957) 
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest) (from r107415)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112588 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:43:30 +00:00
Ingo Schommer
8f8de04aaf MINOR Documentation in DataObjectSet (from r107400) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112575 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:26:27 +00:00
Ingo Schommer
2d127753ed MINOR Documentation in File and Folder class (from r107265) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112553 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:12:39 +00:00
Ingo Schommer
ad20ddf24b MINOR: updated generator tag URL (from r107214) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112552 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:10:04 +00:00
Ingo Schommer
6bf8fad460 MINOR: force exclusive connection (from r107175) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112551 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:09:49 +00:00
Ingo Schommer
997a86b7e0 MINOR: return false rather than error out in case SS_Query:: is not a resource (from r107030) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112544 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:07:39 +00:00
Ingo Schommer
a0424ccd3e MINOR: mysql_fetch_row() expects resource, this will fatal if query was e.g. UPDATE when iterating a result because MySQLQuery::nextRecord() is used by Iterator::valid() and MySQLQuery:: is bool in this case (from r106938) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112543 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:07:22 +00:00
Ingo Schommer
35a3d79e87 BUGFIX Re-enabling theme in ErrorPage->doPublish() (it's usually disabled in the publication context through LeftAndMain->init()) 
MINOR Reverted r88633, it breaks <base> tag in static HTML for ErrorPage->doPublish() (from r106777)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112537 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:04:10 +00:00
Ingo Schommer
0acb21d219 ENHANCEMENT Calling Image->deleteFormattedImages() in Image->onBeforeWrite() (#5423) (from r106705) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112535 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:03:37 +00:00
Ingo Schommer
333a5b487b MINOR: Correct typo in comments (from r106313) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112530 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:01:24 +00:00
Ingo Schommer
e36247c1ed ENHANCEMENT: added prefix and suffix support to ContextSummary (from r106200) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112526 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:59:46 +00:00
Ingo Schommer
497e557632 BUGFIX: if running in cli do not output html tags when rebuilding the db (from r106154) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112522 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:58:21 +00:00
Ingo Schommer
723731a574 BUGFIX: Replaced Versioned's unique index definition with an array syntax. (from r106120) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112520 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:57:46 +00:00
Ingo Schommer
2aed7be053 BUGFIX: Fixed SiteTree::IsModifiedOnStage() for an edge-case that was identified when deleteFromStage() stopped manipulating the current record. (from r106082) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112516 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:56:05 +00:00
Ingo Schommer
c7b47d8a8b BUGFIX: Don't let deleteFromStage() kill the ID of the original record. (from r106080) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112515 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:55:45 +00:00
Ingo Schommer
03c3d59ba0 BUGFIX: Add a unique index to SiteTree_versions.RecordID+Version. Fix saving methods to support this. (from r106079) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112514 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:55:15 +00:00
Ingo Schommer
ee0d4c5197 BUGFIX: Throw an exception if you try an delete an unsaved or already-deleted record (from r106078) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112513 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:54:34 +00:00
Ingo Schommer
2943c75156 MINOR Using ASSETS_DIR and THEMES_DIR constant in Image, ManifestBuilder, Requirements, File (fixes #5619) (from r105282) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112493 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:37:41 +00:00
Ingo Schommer
59883d7770 MINOR: increased height of the todo text field in the cms (from r105139) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112441 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:26:44 +00:00
Ingo Schommer
8d07a8eccc MINOT Translation in SiteTree (#5603, thanks Pike) (from r105057) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112439 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:24:43 +00:00
Ingo Schommer
0b3ff09e7e MINOR Checking for headers_sent() before setting cookies in Versioned::choose_site_stage() to avoid problems with URL parameters like showqueries=1 and ContentController calling choose_site_stage() (fixes #5557) (from r105027) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112435 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:22:25 +00:00
Ingo Schommer
a213ce7839 MINOR Allowing translation of "save" button in SiteConfig->getCMSActions() (from r104978) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112418 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 01:19:24 +00:00