Robbie Averill
24d6527845
Merge branch '4.3' into 4
2018-11-09 11:39:27 +02:00
Robbie Averill
358cef0cdf
Merge pull request #8514 from wilr/pulls/lookup-injector
...
FIX use Injector for FormField::castedCopy
2018-11-07 19:20:36 +02:00
Robbie Averill
64c2938c96
Merge branch '4.3' into 4
2018-11-06 11:05:22 +01:00
Aaron Carlino
0ba275cb40
Merge branch '4.2' into 4.3
2018-11-06 15:09:01 +13:00
Luke Edwards
97180c2612
Fix readonly grid state always being truthy ( #8562 )
2018-11-02 14:28:47 +13:00
Luke Edwards
8866e7674a
BUG: Fix duplicate plugins on HTML editor fields ( #8559 )
...
* BUG: Fix duplicate plugins on HTML editor fields
* Add new test
2018-11-02 12:26:53 +13:00
Luke Edwards
c7b8b80e8b
Persist GridField readonly state, add view button ( #8535 )
...
* Persist GridField readonly state, add view button
* Minor clarity fixes
2018-11-01 11:12:52 +13:00
Andre Kiste
511c368e8c
Merge pull request #8521 from open-sausages/pulls/4.3/searching-for-legacy
...
Add config to force legacy filter header globally
2018-10-29 14:57:21 +13:00
Robbie Averill
b02a6fa02d
FIX Replace usage of Convert JSON methods with json_encode
2018-10-28 21:15:29 +00:00
Luke Edwards
3284bf48d6
Fix search filtering relations and clear filters ( #8477 )
2018-10-26 14:43:56 +13:00
Luke Edwards
d879148bff
Add config to force legacy filter header globally
2018-10-26 14:28:15 +13:00
Will Rossiter
66a404ad1a
FIX use Injector for FormField::castedCopy
...
Allows LookupField to be replaced with user specificed classes.
2018-10-24 12:13:14 +13:00
Maxime Rainville
af46381dca
MINOR Correct implementation of single lookup field when valueToLabel returns null
2018-10-23 11:54:26 +13:00
bergice
a6a1743997
BUG: Fix ENTER
not triggering form save button as GridField
s used submit
type buttons
2018-10-18 12:37:24 +13:00
Aaron Carlino
57756f38cb
Revert bd6c4fd
2018-10-17 14:54:03 +13:00
Robbie Averill
7215637673
Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield
...
API Add a new GridFieldLazyLoader component
2018-10-11 13:43:10 +02:00
Loz Calver
dca2d47127
Merge pull request #8357 from creative-commoners/pulls/4.3/fix-i18n
...
FIX Text collector translations now compile without errors
2018-10-11 13:16:23 +02:00
Maxime Rainville
250d925810
MINOR Update CompositeField::__construct to call setChildren #8460
2018-10-11 15:25:34 +13:00
Maxime Rainville
98afbfe9b4
Implement Peer review feedback #8460
2018-10-11 14:56:06 +13:00
Maxime Rainville
ef439f9306
MINOR Correct GridField_DataManipulator PHPDOC to not assume DataList
...
Tweak GridField_DataManipulator to not assume only DataList will be
provided. Use the SS_List Interface instead. (#8460 )
2018-10-11 12:06:21 +13:00
Maxime Rainville
2e2ca5a4a7
Make sure LazyLoader still woks after a readonly transofrmation ( #8460 )
2018-10-11 11:56:39 +13:00
Robbie Averill
bd6c4fdda0
Merge pull request #8440 from creative-commoners/pulls/4.3/its-indestruc-tab-le
...
NEW TabSet react component is no longer structural
2018-10-09 22:05:53 +02:00
Robbie Averill
d1281a571a
FIX Escape HTML in PHPDoc to fix API docs from rendering incorrectly
2018-10-09 10:46:45 +02:00
Maxime Rainville
fdb53311ba
Fix linting issue.
2018-10-09 17:32:42 +13:00
Maxime Rainville
bfb6518176
Tweak the logic to empty lazy list.
2018-10-09 17:32:42 +13:00
Maxime Rainville
d2a51471e9
Don't lazy load tab that are not in a TabSet.
2018-10-09 17:32:42 +13:00
Maxime Rainville
5276b6cbb1
API Add FieldList::getContainerField
2018-10-09 17:32:42 +13:00
Maxime Rainville
bdb53979aa
API Create a new GridFieldLazyLoader GridField component
2018-10-09 17:32:42 +13:00
Sam Minnee
e5d3b28a4d
FIX: Don’t break validation on selects without a source.
...
Fixes cases where there are no valid values or an empty-string
value is manually added rather than using setEmptyString()
Fixes #4849
Fixes #7159
2018-10-06 11:53:17 +13:00
Robbie Averill
ee24413c30
Merge branch '4.2' into 4
2018-10-03 15:28:05 +02:00
Robbie Averill
d74fed554a
Merge pull request #8427 from sminnee/fix-1397
...
FIX: Append any fields that don’t match name in insertBefore/insertAfter
2018-10-03 13:22:23 +02:00
Robbie Averill
6a5fb4999c
Merge pull request #8416 from lekoala/patch-14
...
raw2att accepts array, but sprintf doesn't
2018-10-03 13:21:43 +02:00
Raissa North
90afb2037a
NEW TabSet react component is no longer structural
2018-10-03 16:36:17 +13:00
Robbie Averill
cb2b9498fb
API Deprecate updateSearchContextCallback and updateSearchFormCallback
2018-10-03 13:47:40 +13:00
Luke Edwards
bf60a699a5
Add extension points for ModelAdmin search API
2018-10-03 13:47:40 +13:00
Robbie Averill
c8e7672ede
Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict
...
FIX Avoid having search fields with the same names as form elements
2018-10-02 13:43:59 +02:00
Sam Minnee
71dad5f685
FIX: Append any fields that don’t match name in insertBefore/insertAfter
...
Previous behaviour was to return false, which has been described as
a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397
where the issue was identified.
2018-10-02 10:39:48 +13:00
Maxime Rainville
755907d117
Merge pull request #8409 from open-sausages/pulls/4/treedropdown-caching
...
MINOR Add caching to the TreeDropdownField tree action
2018-10-01 13:56:21 +13:00
Guy Marriott
c503dbd634
Prefixing search filters for the React search form context
2018-10-01 13:38:32 +13:00
Maxime Rainville
13c89d0ed0
Add a comment and only apply caching if using the standard NumChildrenMethod
2018-10-01 11:29:51 +13:00
Robbie Averill
f842ee2eec
Update deprecation PHPDocs to be PSR-5 compliant
...
See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated
2018-09-28 10:49:14 +02:00
Thomas Portelange
fdd5acff5d
raw2att accepts array, but sprintf doesn't
...
it's not very likely to happen (it did in my case :-) ) but if the value is an array, sprintf will fail (because raw2att accepts array, but sprintf doesn't). i suggest to json encode any array data to ensure it's safely included in the html. Or we should throw proper exceptions to make sure invalid values do not result in a php error.
2018-09-27 12:12:59 +02:00
Guy Marriott
c54e7317d2
FIX Avoid having search fields with the same names as form elements
2018-09-27 17:39:50 +12:00
Thomas Portelange
f103648f8c
value can be something else than a string
...
if the value is not a string (an array for instance), sprintf will fail
2018-09-26 11:35:40 +02:00
Maxime Rainville
77339b7e75
MINOR Add caching to the TreeDropdownField tree action
2018-09-26 17:24:06 +12:00
Robbie Averill
0276f6c089
FIX Revert semver break in adding GridField type hint to method signature
2018-09-24 13:39:33 +02:00
Andre Kiste
e8fd49b394
Merge pull request #8381 from open-sausages/pulls/4.2/sort-out-your-field
...
BUG Changes being detected on TreeMulti as values not sorted
2018-09-21 16:38:56 +12:00
Luke Edwards
4ac4cdc91b
Merge pull request #8348 from caffeineinc/bugfix/3357
...
BUG Add GridField Readonly Transformation (#3357 )
2018-09-21 14:54:37 +12:00
Luke Edwards
3fc49dd4ce
Lint fixes and allow a few other components by default
2018-09-20 13:32:52 +12:00
Luke Edwards
db63f55fbb
BUG Changes being detected on TreeMulti as values not sorted
2018-09-18 13:24:55 +12:00