Ingo Schommer
1b1b1a1d78
MINOR Re-enabled calls to updateCMSFields() accidentally disabled in r67294
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67295 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Ingo Schommer
3b50d5de00
ENHANCEMENT Added SITETREE_GRANT_ACCESS permission code to SiteTree to control editability of the "Access" tab (incl. unit tests)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67294 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Sam Minnee
ba0c2380e9
BUGFIX: dev/build should function even when new classes are referenced in _config.php
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67271 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Josh Kosmala
d839201092
BUGFIX: Filter on the baseclassid in Hierachy, not the class id, in case the class doesnt have a table (aoneil)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67268 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Sam Minnee
e802eaa1d9
ENHANCEMENT: Make it easier to create pageless subclasses of Page_Controller
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67242 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Ingo Schommer
958ad1c4e0
MINOR Merged r66794 from trunk (related to #3192 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67213 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Andrew O'Neil
c305bf3e1e
BUGFIX: Fixed incorrect permission checking when the current member isn't being used
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67199 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Andrew O'Neil
2132e8e301
Merged r67152 from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67194 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Ingo Schommer
4469283166
BUGFIX Checking for "$this instanceof VirtualPage" instead of "$this->class == 'VirtualPage' to support subclassing in VirtualPage->onBeforeWrite()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67150 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Ingo Schommer
933ade1692
BUGFIX Checking for existence of $this->record in VirtualPage_Controller->init()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67140 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Andrew O'Neil
a037a24148
BUGFIX: Fix publishing of error pages
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67137 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Sean Harvey
88d7a32017
BUGFIX Put the order of save and publish buttons back to normal (so save and publish are next to eachother)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67078 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
b1846439a7
MINOR removed debug code
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67075 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
78406d7c1f
ENHANCEMENT Moving "save" and "delete" cms actions from CMSMain->EditForm() into SiteTree->getCMSActions() to make them decoratable (e.g. disallow delete action) and easier to cover with unit tests. Leaving fallback "save" and "delete" actions in CMSMain in case no actions are defined (necessary e.g. for Group class in SecurityAdmin)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Sam Minnee
7671dc644b
BUGFIX: Fixed Enum::scaffoldSearchForm() to always include an (All) option
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67045 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Sam Minnee
c7a4afee52
BUGFIX: Fixing tests
...
ENHANCEMENT: Add <%-- --%> comments
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66946 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
3d5600c597
MINOR merged from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66944 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Ingo Schommer
3673a604c6
MINOR merged r66670 from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66942 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sam Minnee
7cce6782bc
BUGFIX #3115 ajshort: Fixed backslashes in temp folder location in manifest builder
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66918 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sam Minnee
1aeaed7fc4
Better checking of tabstrip stuff
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66889 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sam Minnee
331a427796
BUGFIX: Better generation of PastMember cookie when you have stale login info
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66888 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sean Harvey
4a145c4e1b
MINOR Code formatting conventions in HTTPRequest->param()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Ingo Schommer
322fa2a547
BUGFIX Returning a boolean instead of Permission IDs in specific SiteTree->canEdit() case
...
BUGFIX Passing through $member param from SiteTree->canPublish() to SiteTree->canEdit()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66740 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Will Rossiter
18178c3e79
BUGFIX: fixed typo in filesystem
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Ingo Schommer
524a003d24
MINOR merged r66672 from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Ingo Schommer
93dd7600df
ENHANCEMENT Renamed tab "Meta-data" to "Metadata" for better readability (see #3142 )
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66654 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sam Minnee
be6e67a20f
DataObject::relObject() throws an exception rather than an error so that it can be caught
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66645 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sean Harvey
7874d09771
MINOR Removed redundant code
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66640 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sean Harvey
0d450e6c3a
BUGFIX Fixed flaw logic checking for $member variable, since it's always set the alternative for choosing Member::currentUser() would never work.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66638 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sean Harvey
a2d5a9ac75
MINOR Code formatting of !isset($member) on SiteTree->canAddChildren() for consistency with other can*() methods
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66637 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sean Harvey
8089d7b14c
MINOR Renamed to correct updateCMSActions() in php comment
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sean Harvey
640c50149d
BUGFIX Fixed SiteTree->getCMSActions() so it returns a FieldSet, instead of a DataObjectSet. This makes it consistent with DataObject->getCMSActions() as well as SiteTree->getCMSFields()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66635 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sean Harvey
4713842790
BUGFIX Fixed SiteTree->getCMSActions() not extending properly because it was passing an array to the extend() 2nd argument, which expected a FieldSet object
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66632 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sean Harvey
53cef6b435
BUGFIX Fixed incorrect class name in user_error message for deprecated function HTTP::sendFileToBrowser()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66629 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sam Minnee
b877ddb546
Added support to DataObject::relObject() for looking at $casting to get information about the relation - good for dynamic relations
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Will Rossiter
07e9aaa547
MINOR: added setter function to write_js_on_body() so I can override the settings
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66426 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Normann Lou
92e7071412
APICHANG: if a DataObject has getCMSActions, its model admin should be able to add them.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66392 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Sam Minnee
9d1be81b41
Merge pre-2.3-oct08 into 2.3 (via trunk)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66353 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Sam Minnee
2606f99fb4
ENHANCEMENT: Added comments in rendered templates to indicate the source .ss files, on dev sites only:
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66343 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Ingo Schommer
a9bc9c6845
BUGFIX Fixed ForeignKey->scaffoldFormField() usage of model class instead of relation class to generate dropdown list
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66313 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:35 +13:00
Sean Harvey
76f15e47bf
MINOR Removed old references from workflow in SiteTree and VirtualPage (AssignedToID and RequestedByID were old properites of a workflow page type)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66311 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:35 +13:00
Ingo Schommer
647c25ca14
MINOR Added isset($_SERVER['HTTP_HOST']) checks to Director->isDev() and Director->isTest() - these environment variables are not available in CLI mode, and show up as PHP notices in a default cli-script/sake execution
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66302 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:35 +13:00
Sam Minnee
b40dbbb2f0
BUGFIX: Merged from trunk; fix DataObject::hasDatabaseFields()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66269 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Sam Minnee
0eac163b11
API CHANGE: Deprecated Controller::PastVisitor(), it generates a lot of unused cookies
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66268 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Sam Minnee
03c88ba020
Return an HTTPResponse consistently from controllers
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66267 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Sam Minnee
6d5db643ab
API CHANGE: Improve encapsulation of cookies in Director::test()
...
BUGFIX: Fix test/cookie conflict in ErrorPage rendering
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66266 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Sam Minnee
4f84e92dbf
Fixed RequirementsTest
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66265 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Andrew O'Neil
d76611f380
#2771 : Fix SQLQuery::filtersOnID() (wakeless)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66225 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Andrew O'Neil
4c81b8c3a5
BUGFIX #2714 - Cookie::set doesn't operate correctly with expiryDays 0 (wakeless)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66196 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Andrew O'Neil
e3298047c3
#2635 - More informative errors in DataObject (simon_w)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66192 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00