Ingo Schommer
5260738148
MINOR Avoid reinitialising tabs (see #7258 )
2012-06-15 01:19:19 +02:00
Ingo Schommer
980686ab75
MINOR Limiting console.log() output to explicit enabling through window.debug to avoid failing IE
2012-06-15 01:19:19 +02:00
Hamish Friedlander
21e7ec61f4
ENHANCEMENT: In dev mode, include some basic leak detection functions in the admin panel
2012-06-15 01:19:19 +02:00
Hamish Friedlander
b86a787521
BUGFIX: Use new jQuery.Entwine event capturing, onadd and onremove features to plug some memory leaks
2012-06-15 01:19:15 +02:00
Paul Meyrick
882b4267cb
BUGFIX: Ticket #5578 SiteTree->CanCreateTopLevel() doesn't change dragged tree nodes or ParentID changes
2012-06-14 17:17:27 +12:00
Ingo Schommer
e23a7585a7
MINOR Using new jQuery.changetracker.destroy method in LeftAndMain.EditForm.js
2012-06-13 23:16:13 +02:00
Ingo Schommer
0b6d45356e
MINOR Added destroy() method to jQuery.changetracker plugin
2012-06-13 23:16:09 +02:00
Andrew Short
d9c7bb8eb9
ENHANCEMENT: Implemented help text for form fields.
...
The title attribute is extracted from form fields and displayed inline
below the field.
2012-06-13 13:19:12 +02:00
Andrew Short
513737097b
MINOR: Fixed tab border being shown when tabs were hidden.
2012-06-13 13:46:00 +10:00
Ingo Schommer
ce3d48e310
MINOR Supressed dependencies of tree logic on SiteTree elements (not properly isolated to work well with Folder objects)
2012-06-13 00:51:53 +02:00
Ingo Schommer
896d198890
BUGFIX Correct DOM structure on updating tree nodes from edit forms, adding badge classes to force strike-through styling on deleted nodes (see #7410 )
2012-06-12 19:16:34 +02:00
Ingo Schommer
2637969bcd
API CHANGE Renamed JS event from 'reloadeditform' on 'aftersubmitform', 'beforesave' to 'beforesubmitform'. Listening to bubbled event on container to avoid binding to forms which are removed before the event is triggered.
2012-06-12 17:13:36 +02:00
Andrew Short
34eb1b39dd
BUGFIX: Fixed incorrect variables breaking form submission.
2012-06-11 23:31:02 +10:00
Ingo Schommer
d4baf2d19d
BUGFIX Stability improvements on CMS layout logic
...
- Changed application order
- Fixed layout trigger after preview toggle
- Replaced button row dimension approximation with double application of jQuery.layout() - once before sizing the action panel height to set correct width on container, then again for the height
2012-06-06 21:05:36 +02:00
Ingo Schommer
415a680802
BUGFIX CMS Breadcrumbs and tabs as inline blocks which can span multiple lines, rather than being cropped off ( fixes #6882 )
2012-06-06 21:05:33 +02:00
Ingo Schommer
12f2e1e176
Merge branch 'pjax-multiple'
2012-06-05 14:01:18 +02:00
Ingo Schommer
f794e98d7e
BUGFIX Moved localised JS messages in correct module ( fixes #7393 )
2012-06-04 11:52:31 +02:00
Ingo Schommer
69d3497497
MINOR Fixed node deselection when changing areas (e.g. "pages" to "edit page")
2012-06-04 11:05:05 +02:00
Ingo Schommer
c18c29f464
BUGFIX Updating tree state (after adding/renaming nodes, changing parent). Deselecting nodes when switching to edit view ( fixes #7389 , #7336 , #7309 )
2012-06-03 18:48:47 +02:00
Ingo Schommer
460148c12a
MINOR Debug messages for tracking down JS layout sequence issues (disabled by default)
2012-06-02 12:31:55 +02:00
Ingo Schommer
5a93ee77f8
MINOR Fixed tab selection state
2012-05-30 16:36:26 +02:00
Ingo Schommer
0eac6ea5c3
MINOR Apply loading indicators to all forms, not just .cms-edit-form (which means it includes the "pages list view"). Move to correct place in LeftAndMain.js (not specific to '.cms-content')
2012-05-30 16:36:25 +02:00
Ingo Schommer
19bfd01a60
ENHANCEMENT Declare a single DOM element with multiple Pjax fragments. Unified ajax response handling in CMS, followup from submitForm() refactoring. Removed replacement of arbitrary CSS selectors through Pjax, relies on a fragment now (to keep logic consistent).
2012-05-30 16:36:23 +02:00
Ingo Schommer
75e51de9ed
API CHANGE Moved submitForm() from $('.cms-content') to $('.cms-container'), unifying ajax response handling between panel loading and form submission
2012-05-30 15:07:14 +02:00
Ingo Schommer
5178954311
UNFINISHED Processing multiple PJAX responses on CMS JavaScript, introducing data-pjax-fragment attribute to identify reloadable template parts
2012-05-30 15:07:13 +02:00
Ingo Schommer
5b03f49245
BUGFIX Respecting server-overrides on X-Pjax responses during ajax redirects. Fixes GridFieldDetailForm redirect after delete, e.g. in ModelAdmin. Partially reverts 8b4b896
. Closes pull request #488
2012-05-29 11:34:47 +02:00
Sean Harvey
ecf847b61c
ENHANCEMENT Re-instate pinging every 5 minutes in the CMS as a measure
...
to keep sessions alive. Moved Security/ping to admin/security/ping
2012-05-23 17:15:17 +12:00
Mateusz Uzdowski
8d469b66c8
BUGFIX: add missing onunmatches
2012-05-23 16:24:15 +12:00
Sean Harvey
0d4f7a04dc
BUGFIX Fixing incorrect arguments to submitForm() in
...
LeftAndMain.AddForm.js
2012-05-22 15:37:31 +12:00
Sean Harvey
ce7a96b116
BUGFIX Fixed missing comma in LeftAndMain.AddForm
2012-05-22 14:57:30 +12:00
Mateusz Uzdowski
78b7836d04
BUGFIX: add missing onunmatch
2012-05-22 14:49:57 +12:00
Mateusz Uzdowski
ac2567761b
BUGFIX: add missing selectors and namespace qualifiers
2012-05-22 11:29:06 +12:00
Ingo Schommer
7c589f07dc
MINOR Don't invoke layout() in onmatch() for cms-preview, as it causes a gap above the menu/logo div for some reason. It's also unnecessary processing, since the preview is always hidden by default, and layout() will be triggered through redraw() when required (e.g. preview panel expansion)
2012-05-18 20:07:06 +02:00
Ingo Schommer
d23e8ec14c
BUGFIX Fixed cms menu expansion logic when shown alongside preview panel, retain cookie preference
2012-05-18 20:07:06 +02:00
Mateusz Uzdowski
8b4b896578
BUGFIX: add capability of redirecting form actions.
...
Form actions assume that they are reloading the form afterwards. But
this is not always the case - for example "delete" action will redirect
back to the panel, so we need to be able to set the X-Pjax headers
accordingly.
2012-05-18 17:36:06 +12:00
Mateusz Uzdowski
97e00a35dd
BUGFIX: add missing onunmatches causing exceptions in entwine
2012-05-18 14:27:09 +12:00
Mateusz Uzdowski
6e436b54f4
BUGFIX: change namespace for the tree so all matchers are executed
...
.cms-tree.multiple matcher would not execute, because .cms-tree from
another file is overriding it (and the element is marked as resolved by
entwine). We need to move it to a separate namespace.
2012-05-18 12:27:30 +12:00
Mateusz Uzdowski
37399f88db
BUGFIX: add missing _super calls to all matchers and unmatchers
...
Otherwise some matchers might not be triggered as expected.
2012-05-18 12:27:30 +12:00
Mateusz Uzdowski
3d0876c8f5
BUGFIX: put all CMS JS code into 'ss' namespace.
...
Conflicts:
admin/javascript/LeftAndMain.js
javascript/GridField.js
2012-05-18 12:27:30 +12:00
Ingo Schommer
d57ede8f44
MINOR Fixed query param concatenation in LeftAndMain.js
2012-05-15 21:28:55 +02:00
Ingo Schommer
d42ea5a9d6
BUGFIX Encoding multibyte characters in custom X-Status HTTP headers used in CMS (headers don't allow multibyte data)
2012-05-14 15:13:49 +02:00
Andrew Short
304c3cd5d3
ENHANCEMENT: Fields can be excluded from change tracking using a ".no-change-track" class.
2012-05-12 18:49:56 +10:00
Ingo Schommer
ffbcf634bb
Merge pull request #420 from chillu/sapphire
...
---
See http://open.silverstripe.org/ticket/7261
2012-05-11 13:42:47 +02:00
Mateusz Uzdowski
905115b4db
BUGFIX: Update the batch action select state also on load (os7304)
...
This approach should cover more situations than the previous one. It
will owrk regardless of the initial state in the HTML (which can be
loaded from deferred cache).
2012-05-11 16:21:00 +12:00
Mateusz Uzdowski
b28a625f0b
BUGFIX: clean up Chosen classess, so the cached panel can be rebuilt (os7304)
...
There is no way to clean up attached Chosen instance in a nice way -
there is no destroy, nor remove on the library.
Also, we can't use the onunmatch on this entwine - it only triggers after the cache snapshot
has been taken. This is because the cache function is on different
namespace.
2012-05-11 16:17:44 +12:00
Ingo Schommer
8b4afc01a7
Merge pull request #426 from halkyon/jquery_upgrade
...
MINOR Upgrade jQuery dependency to 1.7.2
2012-05-10 02:49:41 -07:00
Ingo Schommer
2753744f9e
ENHANCEMENT Moving X-Status message handling in CMS from global ajaxError to ajaxComplete handler, to allow success messages being passed this way as well.
2012-05-10 10:44:21 +02:00
Sean Harvey
1e8a89db8f
MINOR Upgrade jQuery dependency to 1.7.2
2012-05-10 16:21:11 +12:00
Ingo Schommer
11f4756225
ENHANCEMENT Auto-hiding tab bar in CMS forms if only a single tab is available (to save screen space and reduce UI clutter) (see #7261 )
2012-05-09 17:19:20 +02:00
Ryan O'Hara
abb5719d33
ENHANCEMENT: Style change to buttons for preview states. Removed open in new window (TRAC-7214)
2012-05-04 13:53:33 +12:00
Ryan O'Hara
92484581e3
ENHANCEMENT: Add disabled state to preview buttons and add watermark for the current state being viewed (TRAC:7214)
2012-05-04 13:53:33 +12:00
Ingo Schommer
e29bb3c390
ENHANCEMENT Allow opt-out of autofocus in CMS editor form, to avoid browser "auto scrolling" to bring the focused element into view ( fixes #7242 )
2012-05-02 18:27:45 +02:00
Ingo Schommer
ca789ef5ff
BUGFIX Disable form submits through "enter" key in CMS, as they might trigger unwanted actions by the browser choosing the default button
2012-05-01 23:40:21 +02:00
Ingo Schommer
4c2352f908
MINOR Don't trigger on click on construction of view-model toggles, as it bubbles up to the panel, where it causes a toggle action which overrides any previous user choices stored in cookies ( fixes #7210 )
2012-05-01 14:10:09 +02:00
Ingo Schommer
feab46e075
MINOR Marking ModelAdmin tools filters panel as expanded by default (related to #7210 )
2012-05-01 14:08:55 +02:00
Ingo Schommer
b428fa1548
MINOR Reverting panel collapse changes for filters (see pull requests #383 and #385 )
2012-05-01 13:01:00 +02:00
Sean Harvey
3cd4b33121
Merge pull request #385 from adrexia/7210-close-filter-panel-default
...
BUGFIX: Fix logic error
2012-04-30 20:26:41 -07:00
Naomi Guyer
16fae77241
BUGFIX: Fix logic error
2012-05-01 15:23:11 +12:00
Sean Harvey
befc80676d
Merge pull request #383 from adrexia/7210-close-filter-panel-default
...
ENHANCEMENT: Close filter panel(Track#7210)
2012-04-30 18:44:08 -07:00
Naomi Guyer
af5bd4d750
ENHANCEMENT: Close filter panel(Track#7210)
...
Make the filter panel closed every time unless explicitly opened. This
commit is dependent on a commit to the CMS that adds a class to the
template.
2012-05-01 11:12:47 +12:00
Ingo Schommer
85a331cc11
BUGFIX Choose first "action" button on submission of CMS forms via enter key, to avoid a form field button being autoselected ( fixes #7151 )
2012-04-30 17:13:39 +02:00
Ingo Schommer
3ee4459476
MERGE tabs url abs
2012-04-18 16:54:57 +02:00
Ingo Schommer
473d3a66b8
MINOR Fixed controller contexts in LeftAndMain->SiteTreeAsUL() - needs different context for edit links and determining "current page" (not applicable for CMSPagesController)
2012-04-17 22:33:30 +02:00
Ingo Schommer
35d4cd3da8
MINOR PJAX support for .cms-panel-link
2012-04-17 22:28:36 +02:00
Ingo Schommer
84b0a7d96c
MINOR Renamed .ss-tabset to .cms-tabset in cms templates to distinguish entwine selectors and add extra functionality (cookies, re-selecting tab, panel loading)
2012-04-17 17:40:37 +02:00
Ingo Schommer
d6eb1b6fff
ENHANCEMENT Added .cms-panel-deferred for lazy loading of CMS panels (for performance reasons)
2012-04-17 17:19:03 +02:00
Ingo Schommer
37777615cf
MINOR Ignore aborted ajax requests in CMS notifications
2012-04-17 17:12:15 +02:00
Ingo Schommer
0ef5d0b84f
MINOR Moved tree filtering in LeftAndMain from SiteTreeAsUL() into getSiteTreeFor() to allow filtering the initial tree (via GET parameters), rather than just through getsubtree()
2012-04-17 16:07:22 +02:00
Ingo Schommer
6bee103d14
MINOR Removed hardcoded children entries from CMS Menu (and record setting logic), as the related controllers have been merged to be accessible under the same top-level menu
2012-04-17 11:03:09 +02:00
Simon Welsh
3a6341a251
API-CHANGE sapphire folder can now be renamed.
2012-04-15 10:50:19 +12:00
Ingo Schommer
e2df1f4c5f
MINOR Removed $('.cms-content').loadForm(), its very similar to loadPanel() - accepts callbacks, but that's not specific to forms. Listen to 'afterstatechange' rather than 'loadform' events
2012-04-12 23:53:14 +02:00
Ingo Schommer
5cfbac63a2
MINOR Fixed PJAX panel loading when .cms-content is a split panel with tree and form view (regression caused by 452a507cc9
)
2012-04-12 12:29:20 +02:00
Mateusz Uzdowski
452a507cc9
BUGFIX: remove form auto-detection from the generic JS state handler.
...
Forms take care of PJAX state on their own in the submit and load functions (os-7126)
2012-04-12 11:31:28 +12:00
Ingo Schommer
ac45e5b9c0
Merge branch 'integration'
...
Conflicts:
admin/css/ie8.css
admin/css/screen.css
admin/scss/_style.scss
dev/install/config-form.html
dev/install/install.css
dev/install/php5-required.html
2012-04-11 16:31:12 +02:00
Ingo Schommer
a64715beeb
BUGFIX Calling tinyMCE.init() in sync with entwine rules to avoid uncached loading interfereing with call order ( fixes #6877 )
2012-04-10 21:41:00 +02:00
Ingo Schommer
3390ea390f
MINOR Updating tree nodes on each state change, rather than just listening to form reloads
2012-04-10 12:28:10 +02:00
Ingo Schommer
15e16f13e1
MINOR Retaining correct PJAX selector on (fake) redirects after form submissions
2012-04-10 12:27:40 +02:00
Julian Seidenberg
1e0b843353
ENHANCEMENT: refactoring code for making a link an ajax/history link. Removing the selector that targets .crumb and only applying the selector that turns links with cms-panel-link into ajax enabled links. Adding the cms-panel-link to those links that already have the crumb class.
2012-04-10 18:16:27 +12:00
Ingo Schommer
cf304044b8
Merge branch 'master' into integration
2012-04-10 00:39:29 +02:00
Ingo Schommer
1742b4b742
BUGFIX Fixed loading/saving regressions due to new PJAX logic introduced in e01b0aa3d0
2012-04-10 00:37:14 +02:00
Ingo Schommer
8c5e56fe31
Merge branch 'master' into integration
...
Conflicts:
admin/css/screen.css
dev/install/php5-required.html
2012-04-09 21:10:08 +02:00
Ingo Schommer
aebbb10c9f
MINOR Skip processing in CMS on empty ajax responses, as they're usually a pseudo redirect (via X-ControllerURL)
2012-04-05 23:00:22 +02:00
Sam Minnee
e01b0aa3d0
ENHANCEMENT PjaxResponseNegotiator for more structured partial ajax refreshes, applied in CMS and GridField. Also fixes issues with history.pushState() and pseudo-redirects on form submissions (e.g. from page/add to page/edit/show/<new-record-id>)
2012-04-05 23:00:22 +02:00
Ingo Schommer
72985b6f42
MINOR Artificially triggering onsubmit event on CMS form buttons rather than calling submitForm() method, in order to give forms like .cms-add-form the option to overload its behaviour
2012-04-05 23:00:22 +02:00
Ingo Schommer
f97804bbe2
MINOR Fixed specificity of .add-form behaviour
2012-04-05 23:00:22 +02:00
Ingo Schommer
ac6f9e9987
MINOR Normalize trailing slashes in X-ControllerURL handling to avoid double requests caused by SS_HTTPRequest modifying the original URL (removing trailing slash etc)
2012-04-04 16:47:14 +02:00
Ingo Schommer
c2b741642e
MINOR Moved X-ControllerURL handling into global ajax response handlers to avoid code duplication
2012-04-04 16:47:13 +02:00
Normann Lou
f1e0951483
ENHANCEMENT: allow each dialog pop to have their own extra class.
2012-04-03 12:50:13 +12:00
Sean Harvey
f8a6db8d31
MINOR Temporarily reverted X-ControllerURL push state, as the header doesn't get set
...
correctly in LeftAndMain::handleRequest() correctly. This fixes saving
pages until X-ControllerURL has been corrected.
2012-04-03 11:29:44 +12:00
Sean Harvey
a2979f0551
BUGFIX Ensure that origLayoutClasses is always an array when considered
...
empty, as join() will be called later and causes a JS error on an empty
string.
2012-04-02 14:29:02 +12:00
Ingo Schommer
6c91aa0ec5
BUGFIX Force referer via "BackURL" POST data in CMS to work around IE problems with sending the base URL as the referer instead of the actual one ( #7002 )
2012-03-30 16:51:43 +02:00
Ingo Schommer
1091c7b944
BUGFIX Don't replace pushState() if emulated, as it will re-load the new URL via ajax, effectively duplicating every request in IE ( #7002 )
2012-03-30 16:51:43 +02:00
Ingo Schommer
83adffd7cd
MINOR Fixed var names in LeftAndMain.js
2012-03-30 16:51:42 +02:00
Ingo Schommer
3f4aba5545
MINOR Avoid breaking IE on CMS ajax responses which don't contain CSS class names (splitting on NULL) ( #7002 )
2012-03-30 16:51:42 +02:00
Ingo Schommer
c518a19ec2
BUGFIX Replaced logic for checking external URLs in CMS Menu with more stable jQuery Mobile codebase (fixes problems on IE not loading menu entries via ajax) ( #7002 )
2012-03-30 16:51:42 +02:00
Ingo Schommer
efc30fd39e
MINOR Removed setRightTitle() special case (and too specific styling) from Group->getCMSFields(), implemented title attribute for chosen.js drop downs instead (to be styled with more friendly title popovers)
2012-03-27 17:07:50 +02:00
Normann Lou
7a27832297
BUGFIX fix the field generated by choser with 0 width in an iFrame popup
2012-03-27 17:06:58 +02:00
Normann Lou
4c1cb59116
MINOR: fix the bug that ModelAdmin search filter doesn't work when arriving from another section of the CMS.
2012-03-27 15:37:32 +02:00
Sam Minnee
f5f655bd7a
BUGFIX: Show a correct growl message when ajax returns a JS error rather than HTTP error.
2012-03-24 16:35:18 +13:00
Will Rossiter
06dd79f34c
MINOR: remove console.log
2012-03-24 14:22:29 +13:00