Commit Graph

1513 Commits

Author SHA1 Message Date
Sean Harvey
ff4c82039d MINOR Class documentation for GridFieldDeleteAction 2012-03-23 10:50:17 +13:00
Sean Harvey
4da42f2baf MINOR Revert folderName change to UploadField (already exists on
FileField parent)
2012-03-23 09:22:54 +13:00
Ingo Schommer
0ad6fe7ec1 Merge pull request #250 from sminnee/form-head-request-throws-500
Return 404 rather than 500 on bad actions in requesthandler
2012-03-22 12:45:12 -07:00
Sean Harvey
b5d4234dfd MINOR Correct DropdownField class documentation to include a proper
example using DataList and non-deprecated way of setting the empty value
and string
2012-03-20 15:47:22 +13:00
Sean Harvey
f85f30ac61 BUGFIX DropdownField with SS_Map as the source should use empty string
as the value, and the empty string text as the title, not the other way
around.
2012-03-20 15:34:10 +13:00
Sam Minnee
1d5065f4a7 BUGFIX: Removed reference to non-existence function Form::handleAction(). 2012-03-19 13:10:51 +13:00
Ingo Schommer
161a5ca209 Merge pull request #249 from sminnee/form-head-request-throws-500
BUGFIX: Prevent 500 error when a HEAD request is sent to its action URL.
2012-03-18 15:54:25 -07:00
Sam Minnee
067204d003 BUGFIX: Prevent 500 error when a HEAD request is sent to its action URL. 2012-03-19 09:26:20 +13:00
Simon Welsh
b9ab70a249 BUGFIX Don't try setting the value attribute on DropdownField or its subclasses. 2012-03-17 21:16:25 +13:00
Ingo Schommer
22dc7fd2d8 MINOR Warning about imminent TableField deprecation 2012-03-15 22:31:55 +01:00
Sean Harvey
5ce1dc1822 ENHANCEMENT Allow setting folderName to Upload in UploadField using
setFolderName()
2012-03-14 15:53:04 +13:00
Sean Harvey
54507d7a8f MINOR Fixed coding style in CreditCardField::Field() 2012-03-13 09:47:30 +13:00
Ingo Schommer
2d151b8cfa API CHANGE Deprecated TableListField and ComplexTableField, use GridField instead 2012-03-12 17:26:42 +01:00
Ingo Schommer
b246522c24 MINOR Various fixes to get TableListField and ComplexTableField baseline operational (although usage of GridField is encouraged) 2012-03-12 17:26:40 +01:00
Ingo Schommer
95f1800d80 BUGFIX Resolve local images correctly even with absolute URLs in HTMLEditorConfig_Toolbar, fixed display of remote images (don't try to format the thumbnail, which only works on local images) (fixes #6952) 2012-03-12 16:31:48 +01:00
Ingo Schommer
4fc3aaf939 Revert "ENHANCEMENT Using 'autoresize' TinyMCE plugin in HTMLEditorField default config, in order to save space when no content is entered into the field" - causes artificial loading delay, and doesn't detect height correctly due to floated images in paragraphs. These paragraphs can't be clearfix'ed because they'd become contenteditable (resizeable) elements in IE because of this.
This reverts commit 69a8659a3d.
2012-03-12 16:03:13 +01:00
Andrew O'Neil
199dd648da BUGFIX: Fix errors submitting a credit card field 2012-03-12 10:26:41 +01:00
Ingo Schommer
960e3428b6 MINOR Avoid wrapping GridField row buttons into multiple lines 2012-03-12 10:23:59 +01:00
Ingo Schommer
0d69126152 MINOR Fixed GridField conditional 2012-03-12 09:59:29 +01:00
Ingo Schommer
2ec9de1e59 MINOR Updated GridFieldDetailForm naming 2012-03-12 09:55:33 +01:00
Sam Minnee
7de5bf55e0 API CHANGE: Updated throwExceptionOnBadDataType setter to be standard setThrowExceptionOnBadDataType(), added getThrowExceptionOnBadDataType(). 2012-03-10 14:44:12 +13:00
Sam Minnée
aa83c114a6 Merge pull request #220 from oddnoc/6817-findOrMakeTab
BUGFIX #6817: FieldList.php: findOrMakeTab () fails for nested TabSets
2012-03-09 15:24:28 -08:00
Sam Minnée
603a984ad4 Merge pull request #236 from silverstripe-big-o/pull/SSF-25
SSF-25: ModelAdmin
2012-03-09 15:23:20 -08:00
Ingo Schommer
e6be56e3b4 API CHANGE Removed FormResponse class, use custom HTTP status codes to communicate state on text/html responses, or use text/json for more structured data responses 2012-03-09 23:27:39 +01:00
Ingo Schommer
fa6142cba5 API CHANGE Removed deprecated TableListField->ajax_refresh() 2012-03-09 23:17:05 +01:00
Ingo Schommer
1ba5e79e3b MINOR Re-fetching relationship in ListboxField->saveInto() when dealing with new records, to avoid errors on RelationList without foreign keys (fixes #6925) 2012-03-09 22:32:12 +01:00
Fred Condo
594448499b BUGFIX: Don't try to set the title if it hasn't been set for us.
This enables the new code to pass the existing tests.
2012-03-09 11:14:06 -08:00
Fred Condo
595a6dc333 BUGFIX #6817: FieldList.php: findOrMakeTab () fails for nested TabSets
- Implements recommended solution from bug report.
- Calculates last index only once instead of at each loop iteration.
- There was no existing test for this method, so if someone can implement a test, that would be great.
2012-03-09 10:44:47 -08:00
Ingo Schommer
4e1c8bdb32 Merge branch 'fieldlist-fortemplate' of https://github.com/sminnee/sapphire
Conflicts:
	forms/FieldList.php
2012-03-09 17:03:02 +01:00
Ingo Schommer
1f01e1135d API CHANGE Removing ScaffoldingComplexTableField, using GridField instead to edit relationships through FormScaffolder and DataObject->scaffoldFormFields() 2012-03-09 15:16:01 +01:00
Sam Minnee
d04fe07fa6 BUGFIX: Renamed UploadField::$config to UploadField::$ufConfig to avoid conflicts with the config API. 2012-03-09 19:37:43 +13:00
Sam Minnee
1f7263e55e ENHANCEMENT: Updated default many-many grid field to show "add existing" and "add new" side by side. 2012-03-09 17:54:39 +13:00
Sam Minnee
818c341c57 API CHANGE: Created GridFieldAddNewButton, replacing the one that was previously hardcoded in GridFieldToolbarHeader 2012-03-09 17:52:26 +13:00
Sam Minnee
12618e2027 API CHANGE: Added targetFragment argument to GridFieldAddExistingAutocompleter, so that its location can be changed. Updated CSS and HTML to allow for this. 2012-03-09 17:52:26 +13:00
Sam Minnee
d795a55bdb API CHANGE: Removed 'add new' button from GridFieldToolbarHeader, instead opting to include two HTML fragments: toolbar-header-left and toolbar-header-right. 2012-03-09 17:52:26 +13:00
Sam Minnee
92a3535455 API CHANGE: Added targetFragment argument to GridFieldExportButton to control button placement. Moved search fields to 2nd argument. 2012-03-09 17:52:26 +13:00
Sam Minnee
adbcf61c56 MINOR: Minor fixes after new SS_List interfaces cleanup 2012-03-09 17:50:32 +13:00
Stig Lindqvist
6d380cd546 BUGFIX GridFieldPaginator did not work correctly after SS_Limitable was introduced 2012-03-09 17:07:42 +13:00
Stig Lindqvist
b6803f6141 MINOR Check that component getActions returns an array before using it 2012-03-09 17:07:42 +13:00
Sam Minnee
426f16764c ENHANCEMENT: GridFieldComponents will now use SS_Filterable, SS_Sortable, and SS_Limitable to determine which features are applicable to the List provided, and either throw an error, or silently disable the feature.
API CHANGE: Added throwExceptionOnBadDataType() to GridFilterFilter, GridFieldPaginator, and GridFieldSortableHeader.
2012-03-09 17:07:41 +13:00
Sam Minnee
a55e06f6b5 API CHANGE: Introduce SS_Limitable class for adding to SS_Lists that have limit capability.
API CHANGE: Deprecated SS_List::getRange() in favour of SS_Limitable::limit().
API CHANGE: Introduce SS_Limitable::limit($limit, $offset = 0) as the only modern way of specifying limits; deprecate all others.
2012-03-09 17:07:40 +13:00
Sam Minnee
3d54668896 MINOR: Added explicit 'public' keyword on functions. 2012-03-09 15:42:31 +13:00
Sam Minnee
ba93028b01 API CHANGE: Added Form::VisibleFields() and FieldList::VisibleFields(), which list everything except hidden fields, to assist with the creation of custom form layouts. 2012-03-09 15:41:42 +13:00
Sam Minnee
a071456837 Merge branch 'master' of github.com:silverstripe/sapphire
Conflicts:
	tests/forms/gridfield/GridFieldDetailFormTest.php
	tests/forms/gridfield/GridFieldPopupFormsTest.yml
2012-03-09 14:37:32 +13:00
Stig Lindqvist
09d6fa7bb3 API CHANGE Renamed GridFieldDefaultColumns to GridFieldDataColumns #6921 2012-03-09 14:07:40 +13:00
Stig Lindqvist
6d0b0d6788 API CHANGE Removing GridFieldDeleteAction and moved functionality into GridFieldRemoveButton #6921 2012-03-09 13:55:49 +13:00
Stig Lindqvist
8b82dae06c API CHANGE: Renaming of gridfield components #6921 2012-03-09 12:54:02 +13:00
Sean Harvey
c59c717d78 API CHANGE Removed CustomRequiredFields, please use custom validation instead
BUGFIX Ensure validators still used in ModelAdmin forms
2012-03-09 12:45:18 +13:00
Sean Harvey
7eddf4298f Merge remote-tracking branch 'upstream/master' 2012-03-09 12:21:46 +13:00
Sean Harvey
9f3344b355 API CHANGE Removed built-in behaviour.js client-side form validation.
This is no longer supported. Please use custom client-side validation instead. (see 3.0.0 changelog
for more information)
2012-03-09 12:19:57 +13:00
Ingo Schommer
66f22441e5 MINOR Checking for existence of $searchFields in GridFieldRelationAdd 2012-03-08 23:56:46 +01:00
Stig Lindqvist
8b2213d56c MINOR Added per-record canView, canDelete, canCreate and canEdit checks on gridfield and gridfield components #6890 2012-03-09 10:58:01 +13:00
Sean Harvey
f86e53bad8 API CHANGE Removed Validator::showError(), Validator::getError() and
Validator::getCombinedError(). Use Validator::getErrors() instead
2012-03-09 10:31:00 +13:00
Sam Minnee
ed0e06c0f6 BUGFIX: Fix a couple of rebasing-related bugs in GridField. 2012-03-09 10:27:57 +13:00
Sam Minnee
7ea151789b MINOR: Formatted code a little better, at Stig's request. 2012-03-09 10:04:25 +13:00
Sam Minnee
5800db0239 API CHANGE: Allow for the creation of custom GridField fragments. (#6911) 2012-03-09 10:03:53 +13:00
Sam Minnee
c80e86f430 BUGFIX: Fix GridField::Field() 2012-03-09 09:58:57 +13:00
Ingo Schommer
e4a6dd5850 Merge branch 'integration'
Conflicts:
	forms/gridfield/GridField.php
2012-03-08 20:25:21 +01:00
Ingo Schommer
ae17e97d75 MINOR Made GridFieldPopupForms work outside of the CMS again (was assuming existence of Breadcrumbs) 2012-03-08 19:53:19 +01:00
Ingo Schommer
b321b9b995 MINOR Don't show GridField pagination when no records are found, and ensure the "no results" message is laid out correctly 2012-03-08 18:22:30 +01:00
Ingo Schommer
2ec40f888a MINOR Stop using deprecated FormField->getTabIndex() 2012-03-08 18:22:27 +01:00
Ingo Schommer
ac20bfaf99 MINOR Renamed GridFieldAction_Edit to GridFieldEditAction, GridFieldAction_Delete to GridFieldDeleteAction, to make it clearer that there's no parent class/concept called "GridFieldAction". There's only the GridFieldActionProvider interface, as well as the GridField_FormAction (which is a related, but different kettle of fish). 2012-03-08 18:22:25 +01:00
Ingo Schommer
3e700d729f MINOR Renaming GridField_Action to GridField_FormAction, to better distinguish it from GridFieldActionProvider and GridFieldAction_Edit. The two are conceptually related, but not through inheritance, as the original naming suggested. 2012-03-08 15:22:00 +01:00
Normann Lou
d35d7507ff FEATURE SSF-25 : enable to remove component from a GridFieldConfig. 2012-03-08 20:29:18 +13:00
Normann Lou
fd828fc4cb ENHANCEMENT SSF-53 : change the icon class for "Link Existing" button to 'chain--plus' 2012-03-08 14:55:53 +13:00
Andrew O'Neil
38db2c1744 BUGFIX: Fix state of gridfield pagination 2012-03-08 14:11:25 +13:00
Normann Lou
0ede949b74 MINOR SSF-53 : typo correction 'unlick' => 'unlink' 2012-03-08 12:28:35 +13:00
Normann Lou
7331a06cb1 ENHANCEMENT SSF-53 : add gridfield-button-unlink to unlink button that removes a member from a group 2012-03-08 11:05:57 +13:00
Julian Seidenberg
a59637c77c MINOR: SSF-30 tweaking comment 2012-03-08 10:08:43 +13:00
Sam Minnee
1fd8d19e28 API CHANGE: FormAction::FieldHolder() now returns just the Field(), so that a FieldList::forTemplate() returns a sensible result for an action list. 2012-03-08 10:02:57 +13:00
Sam Minnee
e4dbf8065b API CHANGE: Added FieldList::forTemplate(), so that by default a FieldList will be rendered in its template as a concatenation of FieldHolder values.
API CHANGE: Removed unnecessary HiddenFieldList class.
2012-03-08 10:00:54 +13:00
Ingo Schommer
391ffde4f3 API CHANGE Deprecated FormField->getTabIndex()/setTabIndex(), use getAttribute()/setAttribute() instead. Removed FormField->getTabIndexHTML() 2012-03-07 17:46:10 +01:00
Ingo Schommer
3b9c9399dc MINOR Using base LeftAndMain_EditForm template in GridFieldPopupForms regardless of template overrides on the "root" cms controller 2012-03-07 17:17:44 +01:00
Ingo Schommer
feca8390d7 API CHANGE Deprecated HasManyComplexTableField and ManyManyComplexTableField, use GridField with GridFieldConfig_RelationEditor instead 2012-03-07 13:32:42 +01:00
Ingo Schommer
55a0fb18e4 API CHANGE Deprecated FormField->describe(), use setDescription() instead. Actually use the description in form fields other than FormAction. 2012-03-07 13:32:42 +01:00
Ingo Schommer
69a8659a3d ENHANCEMENT Using 'autoresize' TinyMCE plugin in HTMLEditorField default config, in order to save space when no content is entered into the field 2012-03-07 13:32:42 +01:00
Normann Lou
1facb509a4 ENHANCEMENT SSF-53 : Change the Labels for "Save" and "Delete" button for an "adding new form" of GridField to "Create" and "Cancel", apply different logic for Cancel 2012-03-07 18:32:27 +13:00
Julian Seidenberg
febcff734c BUGFIX: SSF-30 redirect action that sends an edit form back to the root of assets after making a change like changing the parentID of a file, or deleting it. Basically, any action that makes the existing URL reference obsolete. 2012-03-07 17:17:32 +13:00
Julian Seidenberg
676bcbe8c0 BUGFIX: SSF-30 adding check for null record in the GridFieldPopupForms request handler 2012-03-07 16:43:12 +13:00
Julian Seidenberg
5967a1c135 API-CHANGE: SSF-30 adding a method to control a parameter passed to Hierarchy->getChildrenAsUL() from TreeDropdownField. The parameter is useful for controlling whether the returned UL contains child nodes, or just folders. 2012-03-07 16:43:12 +13:00
Normann Lou
4794195b25 MINOR SSF-53 : change the export button's icon name as per design 2012-03-07 15:28:00 +13:00
Andrew O'Neil
a28485316f BUGFIX: Fix pagination when there are no records 2012-03-07 14:48:08 +13:00
Andrew O'Neil
c81bb3b4d3 MINOR: Change -10/+10 buttons to First and Last 2012-03-07 14:48:08 +13:00
Ingo Schommer
829c7682e3 BUGFIX Support for multilevel nested GridFieldPopupForm (in CMS only), fixed breadcrumb linkage 2012-03-07 01:23:41 +01:00
Ingo Schommer
b43bdf3781 BUGFIX Allowing to save ListboxField and CheckboxSetField into custom relations (which don't return TRUE for has_many() or many_many()) 2012-03-07 01:23:41 +01:00
Andrew O'Neil
58309cb2ec MINOR: Tests for add and edit forms of GridField 2012-03-07 10:48:09 +13:00
Ingo Schommer
8efaf75375 MINOR jQuery UI icons for GridField buttons (with spriting), added new icon to GridFieldRelationDelete to dustinguish it visually from GridFieldAction_Delete 2012-03-06 21:38:34 +01:00
Ingo Schommer
1c344db339 MINOR More consistent overloading in GridField_Action, using standard getAttributes() method rather than custom template placeholders, removing setButtonIcon() and setButtonLabel() as those features already exist in the base implementation 2012-03-06 21:38:34 +01:00
Ingo Schommer
0b4228231c MINOR Integrating GridFieldSearch.js in GridField.js (and using entwine for it) 2012-03-06 21:38:34 +01:00
Ingo Schommer
dc83ace928 BUGFIX Fixed CSV exporting on GridFieldExporter (was calling action via ajax, which doesn't allow HTTP download responses) 2012-03-06 15:50:07 +01:00
Ingo Schommer
dca1b0df1c MINOR GridField docs 2012-03-06 12:39:13 +01:00
Julian Seidenberg
17016273d5 MINOR: SSF-106 documentation 2012-03-06 15:01:17 +13:00
Ingo Schommer
4253950b4c MINOR Fixed handleRequest() usage in GridFieldPopupForms 2012-03-06 01:23:34 +01:00
Ingo Schommer
1201f6c8bb BUGFIX Saving records in ListboxField->saveInto() and PermissionCheckboxSetField->saveInto() so we have a database ID to relate to (was previously customised in MemberTableField->saveComplexTableField(), which is now deprecated) 2012-03-06 01:23:34 +01:00
Julian Seidenberg
e0bd5d1070 ENHANCEMENT: SSF-106 adding a "no items found" message when returning an empty grid field 2012-03-06 12:36:59 +13:00
Julian Seidenberg
a715785a42 ENHANCEMENT: SSF-106 adding the ability to turn off and on the "add new" button on the GridFieldTitle 2012-03-06 11:19:46 +13:00
Hamish Friedlander
763e644145 BUGFIX: Dont need (and cant call) iteratorProperties calls as workaround any more 2012-03-06 10:18:26 +13:00
Hamish Friedlander
28bb83552a API-CHANGE: moving iterator support from ViewableData to SSViewer. New set of unit tests for iterator support functions. 2012-03-06 09:31:55 +13:00
Ingo Schommer
e2c21cce8e MINOR "New <record title>" breadcrumb for GridFieldPopupForm 2012-03-05 18:21:08 +01:00
Ingo Schommer
8da89c6f7c MINOR Generic .cms-help-toggle implementation to replace MemberDatetimeOptionsetField.js (which also didn't work when loaded via Ajax, and needed a rewrite to jQuery.entwine anyway) 2012-03-05 17:41:50 +01:00