Commit Graph

3339 Commits

Author SHA1 Message Date
Andrew O'Neil
f02e8803b1 ENHANCEMENT: Only run a single query per class for Hierarchy::numChildren()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89999 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-22 22:18:02 +00:00
Andrew O'Neil
96736eea50 APICHANGE: Add extra classes to WidgetHolder (#3855, patch from jshipman)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89988 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-22 21:21:12 +00:00
Sean Harvey
09ed10e1b1 MINOR SiteConfig::requireDefaultRecords() shouldn't show a database alteration message if there's already a record
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89975 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-22 07:01:37 +00:00
Sean Harvey
3e6c6fbed1 MINOR Fixed incorrect URLSegment field in MigrateSiteTreeLinkingTaskTest.yml
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89954 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-22 03:38:19 +00:00
Ingo Schommer
e1a47de20e BUGFIX Fixing regression in TranslatableTest due to outdated singleton caching.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89911 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-22 00:30:21 +00:00
Ingo Schommer
11d5ce0274 BUGFIX Moved SINGLETON resetting for test runs from SiteTreeTest/ObjectTest into SapphireTest - there should be no caching between all test invocations to avoid side effects
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89893 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 23:09:14 +00:00
Ingo Schommer
5ad33a014a BUGFIX Reset $_SINGLETONS cache in SiteTreeTest::tear_down() to avoid stale Translatable information. This broke SiteTreePermissionTest and SiteTreeTest when running in parallel with Translatable enabled.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89881 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 22:08:35 +00:00
Ingo Schommer
0fc7d4d656 BUGFIX Added setup/teardown methods to SiteTreeBacklinksTest to make it work with Translatable enabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 19:49:13 +00:00
Sean Harvey
d3130e6dfe API CHANGE Fixed change in r89716 to be more semantic with FileIFrameField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89841 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 05:54:12 +00:00
Sean Harvey
574f7b6a1e NOTFORMERGE Blocked revisions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 05:13:22 +00:00
Sean Harvey
afade29469 MINOR Fixed incorrect function call case for DB::getConn() in SearchForm::getResult() (from r88464)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89799 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 04:07:58 +00:00
Sean Harvey
84c9f8efd0 BUGFIX Removed double up of classes in TestRunner::coverage() (from r88463)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89798 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 04:06:29 +00:00
Sean Harvey
7f7e3a0ba3 API CHANGE: TableListField customQuery and customCsvQuery won't automatically include ID, ClassName, and RecordClassName fields (from r87354)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:36:33 +00:00
Sean Harvey
ae89c56d7a MINOR Calendar displays underneath the time input field in IE, added padding to move the calendar out of the way (from r82988)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:34:54 +00:00
Sean Harvey
b85af0194e ENHANCEMENT Filesystem::sync() now accepts a folderID argument, meaning you can specifically target a folder and it's children to sychronise, instead of everything (from r82840)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:33:55 +00:00
Sean Harvey
1e09bc4907 MINOR Check that the error file exists in Debug (from r82791)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:32:55 +00:00
Sean Harvey
d1af532bf4 MINOR Destroy the child object in Folder::syncChildren() after destroying it's internal records and components (from r82790)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89722 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:32:11 +00:00
Sean Harvey
6b0a508502 BUGFIX Folder::syncChildren() now uses far less memory - we do this by destroying the child object memory after use (from r82780)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89719 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:30:48 +00:00
Sean Harvey
87a8af00c5 BUGFIX Fixed array to string conversion error in Date::setValue() (from r82749)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89718 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:30:07 +00:00
Sean Harvey
65501a6ff2 ENHANCEMENT Filesystem::sync() will now return the number of added and deleted files and folders instead of null (from r82616, 82617 and 82724)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89717 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:29:20 +00:00
Sean Harvey
2cc2f41b45 BUGFIX: disabling user ability to upload images into the CMS from their local computer (from r82573)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:26:01 +00:00
Sean Harvey
25e7f4413b BUGFIX Ensure that FileIFrameField gets the proper class, this could be a subclass of File instead
MINOR Make use of dataClass() in FileIFrameField instead of calling the same has_one() method in multiple places
(from r82175)



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89715 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:23:14 +00:00
Sean Harvey
325f4b6b6f BUGFIX Ensure that before creating default 404 error page, we don't have one already that exists with a record ID (from r81991)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89714 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:22:15 +00:00
Sean Harvey
8bd78f77d8 MINOR Supress session warnings in session_regenerate_id() for a win32 environment (from r81984)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89712 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:21:05 +00:00
Sean Harvey
0b7d187817 MINOR Fixed non-object errors in VirtualPage? if source not found (from r81983)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:19:40 +00:00
Sean Harvey
b117becef5 API CHANGE: Change the way that Database::requireField() gets field type information from the underlying database driver. (from r82793)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89708 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:15:29 +00:00
Sam Minnee
b07e4e5181 MINOR: Fixed column escaping for PostgreSQL support.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89517 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-19 22:28:35 +00:00
Sam Minnee
d2918f40ed BUGFIX: Hard code the migration task to use Content instead of the no-longer-used FieldName. This should probably be improved to iterate over all HTMLText fields on the model.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89460 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-19 05:29:46 +00:00
Sam Minnee
7b8bdca931 MINOR: Made security fixture set-up tigher in tests and other bugfixes.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89458 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-19 05:28:59 +00:00
Sam Minnee
ed1e677c1f MINOR: Removed tests for link rewriting operations that are no longer necessary. Link rewriting isn't needed because we use shortcodes now.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89455 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-19 05:19:34 +00:00
Sam Minnee
9289de1319 BUGFIX: Removed SiteTree::rewriteLink() method that is no longer necessary due to the use of shortcodes.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-19 04:19:41 +00:00
Sean Harvey
e343391bfe MINOR Fixed invalid argument foreach() on CheckboxSetField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89342 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-17 23:33:13 +00:00
Ingo Schommer
baf98e81d6 BUGFIX Respecting SiteTree->canDelete() in SiteTree->getCMSActions()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89338 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-17 05:11:23 +00:00
Ingo Schommer
6478062ceb BUGFIX Removed 'name' attribute from HeaderField markup - its invalid HTML to put in <h*> elements (#4623)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89333 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-17 00:01:55 +00:00
Ingo Schommer
5018dc0ada MINOR Fixed assignment by reference in TestSession->lastPage() (deprecated in PHP 5.3)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89244 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-16 01:21:53 +00:00
Ingo Schommer
613dbf55d0 BUGFIX Fixed SiteTree->validURLSegment() to perform a DataObject::get_one() instead of raw SQL, in order for decorated filtering (e.g. by the subsites module) to apply correctly.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89236 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-16 00:31:39 +00:00
Sam Minnee
f792d16c01 MINOR: Ensure that tests work by giving the test executor admin rights (from r89124)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89217 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:41:55 +00:00
Sam Minnee
16189a4697 MINOR: Fixed WebserverRoutingTest by ensuring that it's not using an out-of-date manifest file. (from r89123)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89216 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:41:32 +00:00
Sam Minnee
675e841c6e BUGFIX: Detect a brokenh link on an incompletely specified redirector page. (from r89043)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89215 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:41:14 +00:00
Sam Minnee
07aefc8138 MINOR: Removed canPublish quirks from SiteTreeBacklinksTest (from r89027)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89214 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:41:08 +00:00
Sam Minnee
e6428ef1d9 BUGFIX: Fixed link generation in CTF default action (from r89026)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89213 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:41:01 +00:00
Sam Minnee
3da29fb08d MINOR show the permission/role inheritance chain on a group (from r89024)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:40:52 +00:00
Sam Minnee
c1fb483890 MINOR: Removed debugging statement (from r89019)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89211 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:40:45 +00:00
Sam Minnee
508d8d1215 MINOR: Added tests for many_many_extraFields (from r89013)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89210 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:40:38 +00:00
Sam Minnee
bc6b3804b6 API CHANGE: Added SapphireTest::logInWithPermission() (from r89012)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89209 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:40:17 +00:00
Sam Minnee
aaeaf6ccb2 BUGFIX: Fixed image link rewriting and added a test. (from r89011)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89208 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:40:06 +00:00
Sam Minnee
e23023b8a9 ENHANCMENT improved reporting around broken links/files (from r88993)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89207 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:39:26 +00:00
Sam Minnee
dfd45fb7fd BUGFIX: Fixed diabled image references for edit and delete links in CTF (from r88967)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89206 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:39:19 +00:00
Sam Minnee
dbe0cd925e API CHANGE: Don't automatically set a default action on complex table fiels. It leads to too many accidental clicks when trying to click a non-default action. Still allow for people to explicitly select a default action. (from r88961)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89205 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:39:13 +00:00
Sam Minnee
96e449225e BUGFIX: If a CTF without a show action is made readonly, don't add the show action back. (from r88960)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89204 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:39:07 +00:00