Will Rossiter
09bd69cdd4
MINOR: added full stop to required labels for consistency
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:11 +13:00
Normann Lou
3973a6a47e
ENHANCEMENT: more robust conditional check before we go to foreach loop, more robust conditional checking before we call a FormField function where we are not sure the caller is a FormField object.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73435 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:11 +13:00
Sam Minnee
8dc652aaa8
BUGFIX: Updated i18n javascript system so that the i18n javascript needs to be explicitly included, so that it doesn't poke its nose in where it's not wanted.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@72563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:09 +13:00
Ingo Schommer
dd6ff797e2
MINOR Merged from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@72384 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:08 +13:00
Will Rossiter
a2ffe586a1
BUGFIX: escaped filename before querying with it - #ajoneil
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@72190 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:07 +13:00
Ingo Schommer
b515a2f2d7
BUGFIX Removed unused ComplexTableField->unpagedSourceItems - was already commented out in r70956, and doesn't seem to be used across parent- or subclasses. Added ticket #3484 to re-enable popup pagination, which was broken and disabled due to the deprecation of $unpagedSourceItems (see r53830)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71348 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:06 +13:00
Will Rossiter
479f8c0fa3
MINOR: added user friendly labels - should really be _t compatible I guess
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71345 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:06 +13:00
Sam Minnee
ce28dccdec
BUGFIX #3442 : Fix pagination in HasManyComplexTable, HasOneComplexTableField, ManyManyComplexTable
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71018 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:05 +13:00
Normann Lou
2939e33554
ENHANCEMENT: Ticket 2756: Newsletter performance problem, run out of memory.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70956 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:05 +13:00
Sean Harvey
66ce174441
MINOR Code formatting fix in DateField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:05 +13:00
Sean Harvey
f5b22dadff
MINOR Code formatting fixes in CheckboxSetField
...
MINOR Added phpDoc comments for documentation that needs to be written explaining the different source data that can be used with CheckboxSetField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70843 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:04 +13:00
Normann Lou
c9df0ee039
BUGFIX:
...
1. TableListField? exportfunality random bug.
2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70747 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
b114900053
BUGFIX: 1. TableListField exportfunality random bug. 2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70743 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
b9145ab995
BUGFIX:
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70741 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
85abd8664b
Undoing change committed in r 70734
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70740 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
d7f67183c6
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70734 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
f71025aa40
BUGFIX: $_POST[$this->Name] in TableField::SubmittedFieldSet are not always set
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:02 +13:00
Sean Harvey
7f9e91d2b5
MINOR Changed $title parameter to HtmlEditorField constructor to null to be consistent with TextareaField and so title is derived based on the name of the field if no title is given.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70647 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:02 +13:00
Sean Harvey
c6275611ee
BUGFIX Defined jsValidation() and validate() so that inherited validation from DateField doesn't break PopupDateTimeField - this still needs fixing, and PopupDateTimeField shouldn't inherit from CalendarDateField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70609 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:02 +13:00
Sean Harvey
6eec6006a5
MINOR Code formatting fix in FormField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:02 +13:00
Will Rossiter
59da2e1887
MINOR: ticket 1846. Changed Action to title case
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Saophalkun Ponlu
5ddb00dfa3
BUGFIX: when the total number of rows is 0 the pagination says 1 to 0 of 0
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70565 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Sean Harvey
87772a9713
BUGFIX Hidden field needs to exist for DateField_Disabled in order for validation to pass correctly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Sean Harvey
68898849ad
MINOR Update ResetFormAction to make use of createTag() method instead of patching together strings to make the form input
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70269 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Sean Harvey
9c4552efa3
MINOR Fixed undefined variable error in TableListField->generateExportFileData()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70257 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Normann Lou
d3a5bcbb7f
APICHANGE: we move the filedata generation part of export() function to a new function generateExportFileData, so that, a child class could reuse the function when overload export function
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70150 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Sean Harvey
b839d2c2c1
BUGFIX Removed for attribute on FieldGroup->FieldHolder() since there's no ID of any input fields to match the label to.
...
BUGFIX Changed the FieldHolder method to use explicit functionality instead of statically calling FormField::FieldHolder()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70127 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
504c515ee6
MINOR Code formatting fixes in HtmlEditorField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70059 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
44f2caf60b
BUGFIX Fixed FileField->getFolderName() - it was not returning $this->folderName, instead it was returning an undefined variable in error
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69975 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Saophalkun Ponlu
9278f0ffe5
BUGFIX: error when creating a form
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69973 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Sean Harvey
f9c25b2465
MINOR Removed "edit image" button since the image editor has been removed
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00
Sam Minnee
ec5448008c
ENHANCEMENT #3313 gigtech: Added ComplexTableField::setAddTitle()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69924 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00
Ingo Schommer
23ed38765c
ENHANCEMENT Moved i18n::get_existing_content_languages() to correct namespace in Translatable::get_existing_content_languages().
...
BUGFIX Using SQL DISTINCT in get_existing_content_languages()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69891 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:55 +13:00
Sean Harvey
8c88519d9f
BUGFIX Fixed use of undefined constant error, and undefined variable error in TableField stopping CMS user from adding records to a TableField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69870 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:55 +13:00
Sean Harvey
d0831b37b6
MINOR Moved form session error set up from Form constructor to method so it can be used again if need be
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69843 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:55 +13:00
Sean Harvey
eecda158c3
ENHANCEMENT Caption support for the HtmlEditorField in the SS CMS. Ticket #2937
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:55 +13:00
Sean Harvey
2d7237d65f
BUGFIX If TreeDropdownField source object is "Folder", don't show "File" tree items unless the marking filter function is explicitly set. This fixes the bug where files were appearing for selecting a folder in the thumbnailstrip field in CMS
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69803 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:54 +13:00
Sam Minnee
6ff158cee4
Better error messages when HasManyComplexTableField can't configure itself properly.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:54 +13:00
Sam Minnee
4f32e1873b
BUGFIX #3248 : Fixed TreeDropdownField when using non-ID key field
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69696 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:54 +13:00
Sam Minnee
5f9120e99e
BUGFIX #3188 : Fixed default HeaderField name to be non-conflicting with other fields, for backward compat
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:54 +13:00
Ingo Schommer
c3074cae5d
BUGFIX Don't include Validator.js if Validator->javascriptValidationHandler is set to 'none' (in Validator::__construct()).
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69689 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:54 +13:00
Ingo Schommer
adfc2131dd
API CHANGE Enforcing usage of a Validator instance in Forms if its not explicitly passed to the Form constructor. By default a new RequiredField instance is used without any fields marked as required. This was necessary because some FormField implementations rely on their validate() method, sometimes as a wrongly placed processing hook, but mostly for security reasons. One example are file extension checks in FileField subclasses.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69688 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:54 +13:00
Sean Harvey
5bde2dbe93
BUGFIX CountryDropdownField now allows for title to be optional, which uses the name of the field if not set. This makes it consistent with DropdownField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69378 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:53 +13:00
Sean Harvey
1213a073a0
BUGFIX Added check before foreach() to fix potential HMCTF bugs
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69377 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:53 +13:00
Sam Minnee
1a9180abaa
ENHANCEMENT: Update ForeignKey and Primary key default fields to use SQLMap for their dropdown source for better performance.
...
API CHANGE: Add keyField and titleField arguments to SQLMap
BUGFIX: Get DrodpownField::$emptyString working when used with a SQLMap source
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69360 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:52 +13:00
Sam Minnee
c0fc790e32
Simplified implementation of FieldSet::makeReadonlyField()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69350 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:52 +13:00
Sam Minnee
d64297e9ee
Simplified implementation of FieldSet::makeReadonlyField()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69349 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:52 +13:00
Sean Harvey
c5ab033cdd
ENHANCEMENT Added renameField() to FieldSet
...
MINOR Added test for FieldSet->renameField() to test method behaviour
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69244 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:52 +13:00
Ingo Schommer
22a9f3ab91
MINOR logical bug in FormScaffolder
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69206 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:51 +13:00
Ingo Schommer
c5bb7b76a2
BUGFIX Making "Main" tab in FormScaffolder translatable
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69203 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:51 +13:00
Ingo Schommer
522c34b6da
MINOR Making CTF save button translatable
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68758 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:50 +13:00
Sam Minnee
caa4ddf3fd
ENHANCEMENT: Allow HtmlEditorField on front-end forms
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68701 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:49 +13:00
Sam Minnee
bb7027484e
Made CalendarDataField JS more self-suffficient
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:49 +13:00
Sean Harvey
f93b782e94
BUGFIX Fixed HasManyComplexTableField/ManyManyComplexTableField issue with source items which broke from changes in r66080. Thanks hamish!
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:49 +13:00
Ingo Schommer
042a4f0fac
BUGFIX Allowing FormAction instances to be readonly by setting disabled="disabled". Adding CSS class "disabled".
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68194 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:48 +13:00
Andrew O'Neil
bc1235be3f
BUGFIX: #3204 - Broken link tracking is broken (ajshort)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:46 +13:00
Hayden Smith
17a55042ca
BUGFIX: Fixed a check for CSV field formatting.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:46 +13:00
Hayden Smith
884ad43916
BUGFIX: Fixed an aliasing problem when saving popup items, and a bug with when associating a new record with the parent ID associated with the field.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67580 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:46 +13:00
Sean Harvey
c96d891c2c
MINOR Removed whitespace after ?> end PHP tag
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:45 +13:00
Sean Harvey
33960f1af3
ENHANCEMENT Allow setting of the legend value in the Form template by use of Form->setLegend('my legend')
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67422 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Hayden Smith
eb80145291
BUGFIX: $allowHTML argument was not passed to DatalessField::__construct
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67363 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:44 +13:00
Ingo Schommer
8331d52b60
ENHANCEMENT Added CompositeField->makeFieldReadonly() (straight copy from FieldSet) incl. unit tests
...
ENHANCEMENT Supporting object parameter in FieldSet->makeFieldReadonly()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67292 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:43 +13:00
Sam Minnee
3a619d8dbb
Add TableListField::setFieldList()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67169 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Ingo Schommer
0ad968090a
ENHANCEMENT Allowing usage of extraClass() in TreeDropdownField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67138 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:40 +13:00
Andrew O'Neil
025d2b2498
BUGFIX: Don't make blank dates show 1/1/1970
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66891 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:39 +13:00
Sam Minnee
edc29eddef
BUGFIX: Fixed notice-level errors in PhoneNumberField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66707 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Ingo Schommer
29c2757841
ENHANCEMENT Fixed default level in HeaderField - was duplicating defaults already present in two other places (see r66639)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66646 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sam Minnee
5f189c42da
Set default level for HeaderField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66639 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:38 +13:00
Sean Harvey
087cba096e
MINOR Code formatting cleanup on CheckboxSetField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Sean Harvey
ca2c814cd9
ENHANCEMENT Allow CheckboxSetField to use extra classes as other FormField classes do. Also dded test for this behaviour in CheckboxSetFieldTest.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66625 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:37 +13:00
Ingo Schommer
916df369d8
BUGFIX Consistenly returning cloned instances for all FormField classes when calling performReadonlyTransformation() or performDisabledTransformation(). Making sure that these instances are actually flagged as readyonly/disabled. Addd unit tests to dynamically instanciate most FormField classes to check for this behaviour. Originally, this bugfix was necessary to avoid changed FormField state when recursively calling replaceField() on FieldSet->dataFields() in Translatable->updateCMSFields()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Ingo Schommer
4cc3ace3b8
ENHANCEMENT Added ConfirmedPasswordField->setShowOnClickTitle()
...
MINOR Documentation for ConfirmedPasswordField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66333 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Ingo Schommer
03277b5349
BUGFIX Include jquery_improvements.js whenever jquery.js is required, so jQuery.noConflict() is set. This is required to ensure $() behaves in the prototypey way (alias for document.getElementByID()) rather than jQuery style (document.getElementsBySelector())
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66332 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Sean Harvey
29899c4396
BUGFIX Fixed HasManyComplexTableField, and subclass fields HasOneComplexTableField and ManyManyComplexTableField saving bug because javascript wasn't being included properly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66306 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:35 +13:00
Sam Minnee
f15cfaccf4
BUGFIX: Fixed recursion bug with FieldSet::fieldPosition
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66305 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:35 +13:00
Sean Harvey
c20e69d563
MINOR Code formatting in FormField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66270 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Sam Minnee
adb03a1d88
BUGFIX: Removed unnecessary and bug-causing Behaviour.apply() call.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66251 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:34 +13:00
Ingo Schommer
63866493e7
MINOR Removed debug code in AjaxUniqueTextField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66093 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:33 +13:00
Will Rossiter
a92d2120a1
Merged pre-2.3-oct08 into branches/2.3 (via trunk)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66084 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:33 +13:00
Sean Harvey
7318977194
Merged in image search capabilities from trunk version - r65820, r65823
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:31 +13:00
Sean Harvey
1458d5b973
BUGFIX Fixed deletion of RedirectorPage
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65769 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-13 01:43:38 +00:00
Sam Minnee
b39d3811ff
Refactored tabstrip.js to use livequery for loading
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65717 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-12 22:28:07 +00:00
Sam Minnee
73a075a491
FEATURE #594 : Added javascript-on-demand support
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65688 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-12 04:31:33 +00:00
Ingo Schommer
5df97fba10
ENHANCEMENT Added CompositeField->fieldPosition()
...
ENHANCEMENT Supporting recursion into nested sets in FieldSet->insertAfter()/TabSet->insertAfter()/CompositeField->insertAfter()
API CHANGE Deprecated CompositeField->insertBeforeRecursive(), use CompositeField->insertBefore()
ENHANCEMENT Renamed CompositeField->beforeInsert() to CompositeField->onBeforeInsert() to avoid confusion with insertBefore()
ENHANCEMENT Added CompositeFieldTest
ENHANCEMENT Added unit tests for FieldSet->insertBefore()/insertAfter()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-11 02:35:54 +00:00
Sam Minnee
58dbe416ee
Merged from branches/2.2
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65523 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-10 03:51:35 +00:00
Ingo Schommer
fdeaececb1
BUGFIX Respecting $dontEscape in FormAction
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65335 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 23:21:50 +00:00
Ingo Schommer
c172e823ea
BUGFIX Using empty title in TreeDropdownField->Field() if the related DataObject cannot be found
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65293 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 15:58:46 +00:00
Sean Harvey
d145c50cc2
ENHANCEMENT Folder name can now be used for uploading files. Ticket #3026 - Thanks simon_w!
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65266 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 03:56:22 +00:00
Sam Minnee
020a92eda8
BUGFIX #2992 : Fixed T_PAAMAYIM_NEKUDOTAYIM error in RequestHandler
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65250 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 01:59:27 +00:00
Ingo Schommer
61a856503e
BUGFIX Calling parent constructor in ComplexTableField_ItemRequest, was confusing RequestHandler
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-04 13:52:03 +00:00
Sean Harvey
dc8876223e
MINOR Code formatting on HtmlEditorField functions
...
MINOR phpDoc of HtmlEditorField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65205 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-04 04:12:54 +00:00
Ingo Schommer
c539687eb2
MINOR Fixed PHP Notices in TreeMultiSelectField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65145 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 13:47:40 +00:00
Sean Harvey
99589e626f
BUGFIX Fix potential PHP notice opening a ComplexTableField popup
...
MINOR Code formatting in ComplexTableField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65127 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 02:33:08 +00:00
Sean Harvey
e9f65ed8e1
BUGFIX Fixed wrong case of class names for ImageIFrameField causing errors
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64976 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-31 02:09:04 +00:00
Sam Minnee
cd699e3d89
API CHANGE #2857 - Renamed RequestHandlingData to RequestHandler
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 22:03:21 +00:00
Normann Lou
132f4ae5ca
CurrencyField::jsValidation() needs to register its validateCurrency function mulitiple times with different FormID for working in a popup of ComplexTableField where FormID is changed.
...
In general all Form Fields should imply with this rule if a page contain mulitiple forms, but this is not under our current developing cycle, since our form fields validation is changing to use jQuery.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64896 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 01:02:57 +00:00
Ingo Schommer
41075078fd
BUGFIX Fixed title-handling in FormAction, regression from r64410
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64879 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-29 16:12:23 +00:00
Sean Harvey
c013b02dc8
MINOR Code formatting in TextareaField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64871 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-29 03:13:38 +00:00
Sam Minnee
f5e636ac43
Changed default # of rows on HTMLEditorField from 15 to 30
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-29 02:39:09 +00:00
Sean Harvey
68326a5eac
BUGFIX Avoid ajax evaluator errors by checking if $resizedImage actually exists before calling relativePath() on it
...
MINOR Code formatting cleanup
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-28 23:20:14 +00:00