Ingo Schommer
100048da33
API PSR-11 compliance ( fixes #6594 ) ( #6931 )
...
Note that our usage of `$asSingleton` in `get()` is fine. Quote from the PSR:
> Two successive calls to get with the same identifier SHOULD return the same value. However, depending on the implementor design and/or user configuration, different values might be returned, so user SHOULD NOT rely on getting the same value on 2 successive calls.
2017-05-19 13:45:07 +12:00
Daniel Hensby
db3e3d51fd
Merge pull request #6928 from open-sausages/pulls/4.0/form-action-handler-regression
...
Process actions on Form subclasses
2017-05-18 12:09:28 +01:00
Ingo Schommer
adbf9d9f71
Process actions on Form subclasses
...
Regression introduced through https://github.com/silverstripe/silverstripe-framework/issues/6362 .
Quote from the RFC:
```
Thus the order of action precedence becomes
action callback
action on the Form
action on the FormRequestHandler
action on any parent controller (if given)
```
2017-05-18 22:47:39 +12:00
Daniel Hensby
3495c0826e
Cleanup SapphireTest and time related tests ( #6898 )
...
* Test databases now include timestamp for easier debugging
* Use classname::class instead of string literal classnames
* Remove DataObject::get_one() from SapphireTest
* More fixes to ICU DB inconsitency for time formatting
* Correctly restore PHPUnits error handler
2017-05-18 22:01:55 +12:00
Damian Mooyman
8ed675d29b
Merge pull request #4542 from patricknelson/issue-4417-validator-remove-validation-master
...
FIX for #4417 : Ensuring ->removeValidation() is defined on instances of Validator. Setup new API for enabling/disabling validation. Documentation and better type handling.
2017-05-18 09:27:48 +12:00
Damian Mooyman
ef3f088b0d
Merge pull request #6925 from nfauchelle/patch-2
...
Fix a typo in comment
2017-05-17 22:47:42 +12:00
Nick
dddf88278c
Fix a typo in comment
...
Typo
2017-05-17 22:09:07 +12:00
Loz Calver
471166c15e
Merge pull request #6169 from open-sausages/pulls/4.0/duplicate-manymany-option
...
API Duplication of many_many relationships now defaults to many_many only
2017-05-17 09:31:09 +01:00
Damian Mooyman
79796083d1
Merge pull request #6924 from open-sausages/pulls/4.0/where-art-thou-file-2
...
Fix TreeDowndropField copying
2017-05-17 17:16:39 +12:00
Christopher Joe
0534a5ec0c
Fix TreeDowndropField copying
2017-05-17 16:52:21 +12:00
Chris Joe
4c1a4eb474
Merge pull request #6920 from open-sausages/pulls/4.0/fix-artifacts-path
...
BUG Fix artifacts index.html download path
2017-05-17 12:04:17 +12:00
Damian Mooyman
dfc86effe5
Merge pull request #6915 from open-sausages/pulls/4.0/where-art-thou-file
...
TreeDropdownField API for root option
2017-05-17 11:16:19 +12:00
Christopher Joe
287ad35f0d
Fix change API to hasEmptyDefault() to be inline with SingleSelectField
2017-05-17 10:13:54 +12:00
Christopher Joe
3927e7e248
Fix added cache key for TreeDropdownField cache
2017-05-17 10:13:54 +12:00
Christopher Joe
6869e450a0
Enhancement added customisable emptyTitle and a showRootOption property in TreeDropdownField
2017-05-17 10:13:54 +12:00
Patrick Nelson
5fa3c85280
FIX for #4417 : Ensuring ->removeValidation() is defined on instances of Validator. Setup new API for enabling/disabling validation. Documentation and better type handling.
2017-05-16 12:58:00 +01:00
Damian Mooyman
f5f6fdce12
API Duplication of many_many relationships now defaults to many_many only
...
Fixes https://github.com/silverstripe/silverstripe-cms/issues/1453
2017-05-16 23:26:39 +12:00
Damian Mooyman
41a268c69f
Merge pull request #6921 from ColmMcBarron/patch-1
...
Update YAML format to use namespace
2017-05-16 23:09:08 +12:00
Colm McBarron
8666d4abb2
Update YAML format to use namespace
2017-05-16 11:49:39 +01:00
Chris Joe
8871210d74
Merge pull request #6916 from open-sausages/pulls/4.0/fqn-services
...
API Rename services to match FQN of interface / classes
2017-05-16 15:42:33 +12:00
Damian Mooyman
7a7e8e5f94
BUG Fix artifacts index.html download path
2017-05-16 14:54:10 +12:00
Damian Mooyman
259f957ce8
API Rename services to match FQN of interface / classes
2017-05-16 14:15:49 +12:00
Chris Joe
961395ba25
Merge pull request #6919 from open-sausages/pulls/4.0/177-editor-form-tabindex
...
Pass autofocus flag to front-end
2017-05-16 13:08:48 +12:00
Damian Mooyman
9da1a6ef5a
Merge pull request #6907 from open-sausages/pulls/4.0/save-it-width
...
Fix update ss template FormActions
2017-05-16 13:02:21 +12:00
Saophalkun Ponlu
1ec7c4e523
Fix lint error
2017-05-16 11:53:23 +12:00
Saophalkun Ponlu
a975b88661
Pass autofocus flag to front-end
2017-05-16 11:53:23 +12:00
Damian Mooyman
7a8dfd2785
Add lint-clean and cleanup code linting
2017-05-16 05:01:51 +12:00
Christopher Joe
6939841e47
Fix update ss template FormActions to be closer to React's implementation
2017-05-15 10:44:58 +12:00
Damian Mooyman
3da1587289
Merge pull request #6913 from nfauchelle/patch-1
...
Correct a typo when css/js file doesn't exist
2017-05-15 09:15:36 +12:00
Nick
eb0da138aa
Correct a typo when css/js file doesn't exist
...
Typo
2017-05-14 07:37:14 +12:00
Daniel Hensby
e741af9127
Merge branch 'pull/6905'
2017-05-12 12:21:02 +01:00
Ralph Slooten
43a122cc36
Fix for meta closing tags
...
Prevent html errors when FormField::create_tag('meta') is called from $MetaTags() so
```
<meta name="generator" content="SilverStripe - http://silverstripe.org "></meta>
```
becomes
```
<meta name="generator" content="SilverStripe - http://silverstripe.org " />
```
Add all void elements to list
2017-05-12 08:49:15 +12:00
Daniel Hensby
fac2bab785
Merge pull request #6901 from mikenz/patch-12
...
BUGFIX: Prevent infinite loop
2017-05-11 12:00:28 +01:00
Daniel Hensby
dcf23ac0e0
Merge pull request #6786 from mikenz/patch-10
...
Support booleans in SilverStripe\View\Parsers\Diff::getHTMLChunks
2017-05-11 11:58:31 +01:00
Daniel Hensby
a65ae8353a
Merge pull request #6879 from mikenz/patch-11
...
MINOR: Fix mismatched brackets
2017-05-11 11:57:46 +01:00
Damian Mooyman
0b70b008b3
API Implement InheritedPermission calculator ( #6877 )
...
* API Implement InheritedPermission calculator
* API Rename RootPermissions to DefaultPermissionChecker
API Refactor inherited permission fields into InheritedPermissionExtension
API Introduce PermissionChecker interface
2017-05-11 21:07:27 +12:00
Mike Cochrane
9d77537061
Support booleans in SilverStripe\View\Parsers\Diff::getHTMLChunks
...
Convert booleans to strings ("true", "false") so they can be diff'd for display.
2017-05-11 15:58:17 +12:00
Mike Cochrane
efd1a32a5d
MINOR: Fix brackets
2017-05-11 15:55:06 +12:00
Mike Cochrane
4373bdb991
BUGFIX: Prevent infinite loop
...
Prevent infinite loop when a < is present without a matching >
2017-05-11 15:52:35 +12:00
Ingo Schommer
36214343f0
Merge pull request #6902 from open-sausages/pulls/4/remove-jsmin
...
Pulls/4/remove jsmin
2017-05-11 11:54:14 +12:00
Aaron Carlino
11a5918810
Deprecate minifier API
2017-05-11 11:52:31 +12:00
Aaron Carlino
5b46461879
Remove JSMinifier implementation
2017-05-11 10:40:00 +12:00
Aaron Carlino
7fa47e234f
New API for minified files using injectable service
2017-05-11 10:14:16 +12:00
Christopher Joe
17ddfab877
Fix Test form factories use the new interface
2017-05-11 09:57:55 +12:00
Christopher Joe
edcb220e4a
Enhancement add EmailLink form factory server-side
2017-05-11 09:57:55 +12:00
Christopher Joe
c58dc97d39
Fix optional $id param because of how methodSchema passes a parameter
2017-05-11 09:57:55 +12:00
Christopher Joe
2ee0d99806
Enhancement switch FormFactories to use RequestHandler instead of Controller
2017-05-11 09:57:55 +12:00
Christopher Joe
403f4db14d
Fix change titles to return schema values in schema
...
Enhancement Add EditorExternalLink call for toolbar
2017-05-11 09:57:55 +12:00
Aaron Carlino
4dea6cb0d5
Remove JSMin library
2017-05-10 15:01:30 +12:00
Aaron Carlino
4af71b9ed7
Pulls/4/remove reliance on admin dir ( #6876 )
...
* Stop relying on external constants
* Revise getTinyMCEPath method to throw exception when no path can be computed
* Throw exception on no gzip, better admin module check
2017-05-10 13:18:44 +12:00
