Commit Graph

3425 Commits

Author SHA1 Message Date
Ingo Schommer
1f19dcdfad BUGFIX Fixed singleton() call in TestRunner?, it fails on PHP 5.2.5 with a ReflectionException? as it passes constructor arguments (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82065 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:56:36 +00:00
Ingo Schommer
4499420ff2 BUGFIX Fixed PhpSyntaxTest? parsing of return value - some PHP versions seem to return a string rather than an error code (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82063 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:55:46 +00:00
Ingo Schommer
485eca829b BUGFIX Removed tabindex settings on DMYDateField, they were messing up the tab order in day/month/year fields (merged from branches/2.3-nzct)
BUGFIX Removed "numeric" class on day/month/year fields in DMYField, the auto-magic NumericField? javascript resetting thats triggered onkeyup() is just a bit too much for its own good (merged from branches/2.3-nzct)
BUGFIX Removed hiddenfield dependency on DMYDateField, save into three distinct input fields and validate accordingly. All underlying logic already works with this notation. (merged from branches/2.3-nzct)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82062 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:54:25 +00:00
Ingo Schommer
11b30e8db9 MINOR Moved NumericField? javascript logic from CalendarDateField?.js into new NumericField?.js. Removed unused DMYCalendarDateField javascript logic, the field behaves just fine with standard input fields and no auto-focus magic on the input fields. (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:52:35 +00:00
Ingo Schommer
8a20d5c1ad ENHANCEMENT Added TableField?->autoRelationSetting to allow for automatic saving into relationships (similiar to ComplexTableField? implementation) (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82060 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:49:32 +00:00
Ingo Schommer
cca0d327e7 BUGFIX Don't try to fetch contents from non-existent debug.log files in Debug::log() (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82059 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:48:41 +00:00
Ingo Schommer
f233d00072 BUGFIX Fixed missing iteration check in DataObject?->getChangedFields() (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82058 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:47:50 +00:00
Ingo Schommer
49ee0cc1bc BUGFIX Only set response header in XMLDataFormatter->convertDataObject() if a response is defined (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82057 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:47:12 +00:00
Ingo Schommer
25544b1f42 BUGFIX Fail silently on shell_exec() in CSSContentParser to avoid unit test failures because of missing optional libraries like tidy (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82056 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:46:24 +00:00
Ingo Schommer
f512347e33 BUGFIX Making sure RequirementsTest? has combine_files activated (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82055 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:45:23 +00:00
Ingo Schommer
53d4925ac0 BUGFIX: removed redundant curl_exec calls from 'request' (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82054 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:43:23 +00:00
Sean Harvey
82a68dd3bd MINOR Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81997 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 03:44:15 +00:00
Ingo Schommer
faed7b0c14 MINOR Making version number in RestfulService dynamic (see #4383)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-14 20:55:42 +00:00
Ingo Schommer
c1f0dda466 BUGFIX Deleted duplicate call to curl_exec() in RestfulService (merge error from r69704)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81822 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-14 20:51:58 +00:00
Tom Rix
61ed3df367 MINOR fixed relative URL resolver in Director::test()
MINOR improved documentation in static-main.php

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81749 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-14 01:21:04 +00:00
Tom Rix
48f200961e MINOR smarter static-main.php, now detects automatically if you are using domain based cacheing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81713 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-13 20:38:37 +00:00
Tom Rix
a81f387945 MINOR smarter static-main.php, now detects automatically if you are using domain based cacheing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81712 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-13 20:28:31 +00:00
Sam Minnee
3a4518c804 BUGFIX: Fix static application for translatable
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81693 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-13 05:25:04 +00:00
Tom Rix
d04c967558 ENHANCEMENT STaticPublisher can now play nice with Subsites, you just need to set FilesystemPublisher::domain_based_caching to true. You also need to change your .htaccess to point all requests to sapphire/static-main.php, rather than main.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81684 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-13 04:42:48 +00:00
Tom Rix
39309b1e9a ENHANCEMENT allow Director::test() to cope with absolute URIs
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81680 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-13 04:15:40 +00:00
Sam Minnee
6a52153b9f BUGFIX #4285: Fixed application of decorators when add_extension not used.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81676 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-13 03:56:26 +00:00
Ingo Schommer
79912f6ba6 MINOR Removed faulty detection of "digraph" binary from ModelViewer
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81584 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-10 03:21:48 +00:00
Ingo Schommer
b459d489a3 BUGFIX Calling parent constructors in ModelViewer
ENHANCEMENT Checking for GraphViz dependency in ModelViewer

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-10 00:37:04 +00:00
Sam Minnee
a738dc2027 BUGFIX: returns duplicated number of the same sentences (from r78773, r78778)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81472 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 06:14:04 +00:00
Sam Minnee
f515ed7898 BUGFIX Calling doRestoreToStage() on orphans which don't have a stage record before unpublishing them in RemoveOrphanedPagesTask
MINOR Added "unselect all" and better permission checks to RemoveOrphanedPagesTask (from r78478)
MINOR Fixed visibility of RemoveOrphanedPagesTask->getOrphanedPages() (from r78486)
ENHANCEMENT Allow rebasing of orphans in a subfolder for RemoveOrphanedPagesTask (from r78494)
MINOR set_time_limit for RemoveOrphanedPagesTask (from r78495)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81471 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 06:13:33 +00:00
Sam Minnee
f88fb435e3 FEATURE Added RemoveOrphanedPagesTask (from r78473)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 06:11:55 +00:00
Sam Minnee
3614e7b1ee BUGFIX In Versioned->augmentDatabase(), only create AuthorID, PublisherID and WasPublished columns on the root table, to avoid redundant information on sub tables. Limit writing in Versioned->augmentWrite() accordingly. This caused problems with the publication status not being reflected in the "Versions" report as the "WasPublished" attribute on the subtable was set to 0, while the root table was 1. (from r78358)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81469 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 06:00:07 +00:00
Sam Minnee
51e6ce6727 MINOR Passing through DB->dontRequireField() to Database->dontRequireField() (from r78357)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81468 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 05:55:56 +00:00
Sam Minnee
ff254355e7 BUGFIX Fixed Hierarchy->markChildren() to only mark nodes as unexpanded if they actually have children. This avoids UI glitches with "plus"-icons beside unexpandable nodes, and prevents batch actions and TreeNode->open() to trigger ajaxExpansion on nodes without children (from r78339)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 05:55:34 +00:00
Sam Minnee
c280542b9b BUGFIX Only trigger BackLinkTracking updates in SiteTree->onBeforeWrite() if the URLSegment is an actual change (type 2), not only a type change. This messed up batch publications, are previously published pages were marked as changed in subsequent write calls to the same object. (from r78337)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81466 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 05:55:17 +00:00
Sam Minnee
ceb0afeb78 ENHANCEMENT Passing $minNodeCount through Hierarchy->getChildrenAsUL() and Hierarchy->markPartialTree() (from r78305)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 05:53:40 +00:00
Sam Minnee
c0aca8ff87 Updated en_US strings
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81431 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 03:21:37 +00:00
Sam Minnee
d38c79f584 ENHANCEMENT: If you are logged in and Security::permissionFailure() is called, just return a 403
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81430 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 03:20:32 +00:00
Sam Minnee
7085f1ce65 BUGFIX: Fixed dev/viewcode to see tests.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81429 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 03:19:26 +00:00
Sam Minnee
5a9ca7d682 BUGFIX: More fixes to i18n text collection with escaping of quotes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 02:37:01 +00:00
Sam Minnee
8ee9373807 ENHANCEMENT: Allow string concatenation in default text in _t() calls
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81409 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-09 01:02:43 +00:00
Sam Minnee
e1fa960775 MINOR: Replaced mysql_escape_string() with mysql_real_escape_string()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81382 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 23:05:01 +00:00
Sam Minnee
212765ae5c MINOR: Made extract() call a little tighter.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 23:04:43 +00:00
Ingo Schommer
e54a2e75e6 BUGFIX Fixed many_many relations querying in RestfulServer
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81346 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 08:28:17 +00:00
Ingo Schommer
c389c01f9c MINOR More backwards handling of $this->fixture references in SapphireTest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81320 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 04:09:10 +00:00
Ingo Schommer
b8736bd5b2 BUGFIX Fixed SiteTreeTest to work with new fixture handling: objFromFixture() can no longer be used to determine if an item has been deleted, as it will throw a warning
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81319 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 04:06:23 +00:00
Ingo Schommer
883be66524 MINOR Fixed array/string notation in SapphireTest error messages
BUGFIX Using get_by_id() in DataObjectTest to grab deleted pages, to avoid error messages for missing fixtures from SapphireTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81313 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 02:54:01 +00:00
Ingo Schommer
6c505e5ede MINOR Moving user_error() invocations for missing fixtures from YamlFixture into SapphireTest - we shouldn't error out of a single fixture, as the object in question might be contained in another fixture on the same test
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81310 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 02:36:05 +00:00
Ingo Schommer
4c78f0e3e5 MINOR Wording in SapphireTest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81307 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 01:38:01 +00:00
Ingo Schommer
f3959b038d API CHANGE Deprecated use of SapphireTest->fixture to access YML fixtures, please use gateway methods on SapphireTest instead (e.g. $this->objFromFixture() instead of $this->fixture->objFromFixture())
ENHANCEMENT Allowing multiple fixtures to be defined in SapphireTest::$fixture_file through array notation. 
BUGFIX Disabling DataObject validation in YamlFixture->saveIntoDatabase() instead of SapphireTest->setUp()
MINOR Adapted sapphire unit tests to deprecated $this->fixture usage

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81286 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 00:06:16 +00:00
Sam Minnee
2000087dd6 BUGFIX: Fixed application of parameterised extensions with Object::add_extension()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81173 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-07 01:28:47 +00:00
Ingo Schommer
cf302011b8 BUGFIX Fixed Form->handleField() to first look for fieldByName() before falling back to dataFieldByName(). This was necessary for tabs and formfields having the same name, e.g. "Members" in the SecurityAdmin class. We have to ensure to return the data field instead of the (non-datafield) tab.
MINOR Added documentation about URL handling to Form

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81130 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 22:06:42 +00:00
Ingo Schommer
4a531820cd BUGFIX Accepting dot-notation in TabSet->fieldByName()
BUGFIX Using fieldByName() instead of dataFieldByName() in Form->handleField() to allow rendering of nested tabs through a URL

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81128 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 21:53:50 +00:00
Ingo Schommer
fcc6948e79 BUGFIX Setting brokenOnConstruct to FALSE in CompositeField::__construct() - it skips a constructor, hence breaking request handling (and therefore direct field access through /Form/Field/MyCompositeField/FieldHolder
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81127 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 21:48:12 +00:00
Sam Minnee
7f77bc4733 BUGFIX: Removed double-call to augmentSQL in DataObject::get
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80961 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-03 03:45:11 +00:00