Sam Minnée
34287895ef
Merge pull request #2099 from chillu/pulls/insert-media-tweaks
...
Various "Insert Media" dialog tweaks
2013-06-18 21:32:00 -07:00
Sam Minnée
8bf4d417c6
Merge pull request #2094 from chillu/pulls/dialog-sizing
...
Min/max constraints for CMS dialog
2013-06-18 14:56:41 -07:00
Ingo Schommer
8865bae8e3
Hide titlebar in "Insert Media" when updating images
...
It doesn't make sense to show it there, since the "delete"
action has no effect, the "edit" button only collapses (useless),
and the thumbnail duplicates.
2013-06-15 10:13:44 +02:00
Ingo Schommer
ec684a2e5c
Show edit form in "Update Media" by default
...
Was showing collapsed UploadField row before which doesn't make a whole lot of sense.
2013-06-15 10:13:44 +02:00
Ingo Schommer
23c0084193
Add new files in "Insert Media" at start of the list
...
Makes the change more obvious without requiring to scroll
to action origin (upload button) out of view
2013-06-15 10:13:44 +02:00
Ingo Schommer
a9bf7dfcce
Fixed HtmlEditorField.js editor instanciation
...
Wasn't parsing data-editor attrs correctly.
Using proper instances of the underlying editor now,
instead of relying on "active editor" states which get
wonky once they lose focus (e.g. when opening a dialog).
2013-06-14 11:46:07 +02:00
Ingo Schommer
9f600ada2c
Min/max constraints for CMS dialog
2013-06-13 20:03:16 +02:00
Ingo Schommer
385f364018
TinyMCE "Insert Media" screen, update button triggers navigation ( fixes #742 )
2013-06-13 09:29:55 +02:00
Robert Curry
36f0fd7a58
Force TreeDropdown to remember selected title.
2013-06-13 11:36:08 +12:00
Robert Curry
eaf0fe4b2f
BUG Fix JS issues in treedropdownfield for link editor
2013-06-12 16:59:07 +12:00
Ingo Schommer
d2eef63b7d
BUG Trigger TinyMCE onChange more frequently
...
Periodically check for inline changes when focused,
since TinyMCE's onChange only fires on certain actions
like inserting a new paragraph, as opposed to any user input.
This also works around an issue where the "save" button
wouldn't trigger if the click is the cause of a "blur" event
after an (undetected) inline change. This "blur" causes onChange
to trigger, which will change the button markup to show "alternative" styles,
effectively cancelling the original click event.
2013-06-03 13:32:43 +02:00
Damian Mooyman
7f057ce343
API UploadField functions on new records
...
Fixed regression from 1e5d40474d
(UploadField::canPreviewFolder).
Merged in pull request #2009 - (6018bdd631
).
Merged pull request #1259 (34bfc862ee
).
2013-05-27 15:22:59 +12:00
Ingo Schommer
6f2ba3fcac
Merge pull request #2009 from sminnee/uploadfield-choose-new-file
...
NEW 'Choose another file' button on upload field AAS-917
2013-05-25 01:55:26 -07:00
Julian Seidenberg
22c7bbfcd4
NEW UploadField displays a warning before overwriting files (only relevant if config.yml: Upload:replaceFile = true).
2013-05-25 19:07:06 +12:00
jean
6018bdd631
NEW 'Choose another file' button on upload field AAS-917
2013-05-25 18:38:02 +12:00
Naomi Guyer
8aa8674e78
BUG: Treedropdowns broken inside togglecomposite fields ( fixes #1945 )
...
* Removed positioning javascript from treedropdownfield
* Set parent to be relatively positioned and overflow to visible
2013-05-23 14:41:08 +12:00
Ingo Schommer
214515f232
Merge pull request #1936 from mikg0/patch-1
...
Fix file link recognition in HtmlEditorField.js
2013-05-22 07:43:11 -07:00
Sean Harvey
9f532fe976
BUG GridField action onclick assuming URL without "?" character
...
Sometimes GridState URL will have a query string already appended,
e.g. "?local=en_GB", but the GridField javascript assumes there won't
be.
The result would be an action URL like:
"/my/url?locale=en_US?RelatedPage=123" which is obviously invalid.
The fix is to check that "?" exists in the GridState URL and use
"&" instead to connect the URLs if that's the case.
2013-05-15 15:49:23 +12:00
mikg0
fb5fc62604
Fix file link recognition in HtmlEditorField.js
...
The new file_link format ([file_link,id=\d+]) uses a comma which was not reflected in the regex.
2013-05-13 15:04:52 +03:00
Mateusz Uzdowski
fdb4a1d871
BUG Enable dropdown so alignment on images can be updated.
2013-05-13 10:08:03 +12:00
Will Rossiter
94d6b1ccff
FIX: Disable autocomplete on ConfirmedPasswordField instances.
2013-05-10 20:32:59 +12:00
Ingo Schommer
a1216b5e32
Merge pull request #1250 from wilr/gridfield-action-fixes
...
FIX: Do not blindly pass input values to GridField_FormAction URL's
2013-05-08 04:20:40 -07:00
Ingo Schommer
16c7235942
DateField.js event selector regression ( fixes #1528 )
...
See 19a8545076
2013-04-11 10:19:00 +02:00
Ingo Schommer
9856fcef21
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
javascript/DateField.js
model/DataQuery.php
model/Versioned.php
tests/forms/RequirementsTest.php
tests/model/DataObjectLazyLoadingTest.php
view/Requirements.php
2013-04-09 14:45:35 +02:00
Sam Minnée
39a4aabcdc
Merge pull request #778 from patbolo/bugfix/7853
...
FIX 7853
2013-04-08 16:08:23 -07:00
Ingo Schommer
3768c247b4
Reset TreeDropdownField search field after defocus
...
Was unsetting original selection even if no new one was made.
2013-04-08 19:42:17 +12:00
Ingo Schommer
5119d9aa72
FIX Only allow one concurrent ajax in TreeDropdownField
...
Prevents situations where a previous action might finish out of line
and override later choices, such as first expanding the (full) tree panel,
then limiting the tree through searching.
2013-04-08 19:42:17 +12:00
Ingo Schommer
da87614d8f
FIX Skip autofocus on TreeDropdownField
...
To avoid (visually) unsetting the selected value if the drop down
is the first form field on the page (see LeftAndMain.EditForm.js)
2013-04-08 19:42:17 +12:00
Ingo Schommer
c08ab18c03
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
.travis.yml
admin/javascript/LeftAndMain.AddForm.js
docs/en/reference/requirements.md
2013-04-02 02:00:50 +02:00
Naomi Guyer
19a8545076
BUG: update deprecated 'live' jquery to 'on'
...
'live' has been deprecated since jquery v 1.7.0, and has been removed
in the latest 2 versions of jquery
2013-03-27 15:09:49 +13:00
Ingo Schommer
0a283eacb8
FIX Unset internal metadata on TreeDropdownField setValue()
...
Otherwise the hidden field value and metadata will get out of sync.
Most commonly used together with setTitle('') as well.
2013-03-25 23:39:37 +01:00
Ingo Schommer
8bedf485d6
Don't fail TinyMCE cleanup if no current instance is set
...
Bug has been observed in IE8
2013-03-20 14:46:28 +01:00
Ingo Schommer
e0e481fc46
Removed stray code from HTMLEditorField.js
2013-03-15 12:01:45 +01:00
Wernervanrun
fade5cce51
Update javascript/HtmlEditorField.js
...
we only want this .ss-uploadfield-files - else we get all ss-uploadfield-files wich include the ones not related to #tinymce insertmedia
2013-03-07 20:33:02 +01:00
Will Rossiter
1853fc864a
FIX: Do not blindly pass input values to GridField_FormAction URL's
...
The length of input fields can very quickly exceed the max URI length resulting in 414 errors when printing or exporting results.
To access the input values for a specific GridField action, encapsulate this in your own Entwine instance.
2013-03-05 10:30:39 +13:00
Ingo Schommer
a86e4ee00c
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
tests/injector/InjectorTest.php
tests/travis/before_script
2013-02-18 14:15:42 +01:00
ARNHOE
823b2acda3
Update javascript/lang/nl_NL.js
2013-02-18 12:09:38 +01:00
Sean Harvey
d320247627
Trigger delete confirmation popup when deleting a GridFieldDetailForm record
2013-02-05 13:14:03 +13:00
Ingo Schommer
fe740515b4
Loading "OR" in admin/assets for Chrome ( fixes #8245 )
2013-02-04 22:00:12 +01:00
Sean Harvey
6a1fe05191
Merge pull request #1151 from silverstripe-rebelalliance/bug/image_reedit_attr
...
FIX Assiging width to caption instead of container
2013-01-31 13:23:36 -08:00
Hamish Friedlander
aa3eb98de2
FIX Assiging width to caption instead of container
2013-02-01 10:17:56 +13:00
Ingo Schommer
dc75d9a5b4
Merge pull request #1149 from silverstripe-rebelalliance/bug/image_reedit_attr
...
FIX A couple of bugs integrating the SilverStripe media panel with TinyMCE
2013-01-31 15:24:51 +01:00
Hamish Friedlander
6f937745b0
FIX Not being able to remove, add or edit the caption on an image properly
2013-01-31 16:35:48 +13:00
Ingo Schommer
0b44d8fbfb
Merge pull request #1145 from silverstripe-rebelalliance/bug/image_reedit_attr
...
FIX Not calling updateFromNode on re-opening an image
2013-01-30 14:52:50 +01:00
Hamish Friedlander
9f822d1e3c
FIX Not calling updateFromNode on re-opening an image
...
Inside mediaform updateFromEditor we called $(this).updateFromNode, but this wasnt
pointing to anything useful after a refactor, which resulted in the fields not
being filled in with current data when editing an already-inserted image
2013-01-30 17:15:01 +13:00
Mateusz Uzdowski
6c78bf9be9
BUG Flush editors on form submission (os#8222)
...
Otherwise some non-textual changes such as moving images and resizing
them could be missed when saving.
This is because TinyMCE does not treat the image move/resize as an
undolevel and does not register this via regular "onChange" event.
2013-01-30 11:54:29 +13:00
Ingo Schommer
c11b3918fc
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
admin/css/screen.css
admin/scss/_style.scss
core/PaginatedList.php
email/Mailer.php
2013-01-21 11:14:57 +01:00
Kirk Mayo
d12ae82f70
Bug fix for open/8181 which stops the HTML source editor window saving/publishing
2013-01-21 08:26:19 +01:00
uniun
e9ba54dec7
Impossible to unselect TreeDropdownField
...
It was impossible to unselect TreeDropdownField.
'!' operator should not be used at all and identical comparison (===) was too "strict" (self.getValue() returns string but $(node).data('id') returns number).
2013-01-15 11:29:35 +02:00
Ingo Schommer
f30277c3cf
Split out getLinkAttributes() in .htmleditor JavaScript for more flexibility
...
Saves us from overwriting the whole insertLink() method just
to add another option.
2013-01-14 16:54:58 +01:00