Sam Minnee
a96cb319d3
BUGFIX Fixed TableListField->print() - was unsetting $cachedSourceItems instead of null'ing it, which breaks later access to the property (from r101080)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111583 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:44:58 +00:00
Sam Minnee
a729b86df8
BUGFIX #5199 Duplicate file uploads have odd numbering attached to end of file (from r101068)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:44:14 +00:00
Sam Minnee
81ce1e358d
BUGFIX Fixed Upload and checking for size with files that don't have any extension (from r101061)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111580 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:44:03 +00:00
Sam Minnee
37629a9c89
MINOR Improved wording of SQLite installer (from r101057)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:43:44 +00:00
Sam Minnee
2582608b34
MINOR No need for a ternary for in_array check in Upload::isValidExtension() (from r101055)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111577 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:43:28 +00:00
Sam Minnee
555762299d
ENHANCEMENT Allowing SQLite selection in installer
...
ENHANCEMENT Moved all Javascript containedin install.php and config-form.html to install.js, and using jQuery to simplify logic
ENHANCEMENT Allow installer to attach custom form fields based on the install driver (as defined in _register_database.php) (from r101054)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:43:12 +00:00
Sam Minnee
0dcf75f965
MINOR Update function doc for Upload::isValidExtension() (from r101053)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:42:54 +00:00
Sam Minnee
f9c888438d
MINOR phpDoc change for Upload (from r101052)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111574 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:42:39 +00:00
Sam Minnee
40091e6c4e
BUGFIX Allow files with no extensions by setting File::$allowed_extensions with an empty string (from r101051)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:42:25 +00:00
Sam Minnee
2ea0e3e331
BUGFIX #5188 Upload and Folder don't handle the duplicate naming of files that have no extension (from r101050)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:42:13 +00:00
Sam Minnee
9f2ca79c67
BUGFIX Cookies set to a value other than NULL (effectively unsetting the cookie) will now use the httpOnly parameter by default for better XSS protection (from r101045) (from r101046)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:40:50 +00:00
Sam Minnee
ce173efce3
API CHANGE: Made MySQL fulltext search optional, activated with MySQLFulltextSearchable::enable() (from r101044)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:32:48 +00:00
Sam Minnee
ec067ab08a
API CHANGE: Pass the full extension string as the 2nd argument to DataObjectDecorator::extraStatics() (from r101043)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:32:30 +00:00
Sam Minnee
9817eb5c60
BUGFIX: Fix static caching file lookup to match file generation. (from r101034)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:32:13 +00:00
Sam Minnee
848faf2a6b
MINOR tests can now require default records on classes (from r101025)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111566 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:31:58 +00:00
Sam Minnee
47df057e63
BUGFIX Image should pass through the title to Image_Cached so that Image::getTag() can produce a more useful alt attribute instead of just the filename (from r101003) (from r101005)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111565 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:56 +00:00
Sam Minnee
5b6fa898d5
BUGFIX: column and table names now quoted properly (from r100998)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:39 +00:00
Sam Minnee
2154e0585d
MINOR Removed unused variable in SiteTree::MetaTags() (from r100992)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:26 +00:00
Sam Minnee
0abbef5fa3
MINOR UploadTest now cleans up after itself when it creates a custom folder relative to assets (from r100991)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111562 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:14 +00:00
Sam Minnee
7f147f9fab
MINOR Added tests for Upload_Validator/UploadTest_Validator for allowed extensions validation (from r100990)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:58 +00:00
Sam Minnee
cb435df6af
ENHANCEMENT If no arguments specified for cli-script.php/sake, then provide a friendly message to the user on where to get help (from r100989)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:40 +00:00
Sam Minnee
390d9b45dd
MINOR Updated required version to 5.1 in php5-required template (from r100988)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111559 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:26 +00:00
Sam Minnee
c54cce8673
BUGFIX Disable javascript date validation via DateField->jsValidation() if locale is not 'en_NZ" (which is the only format it validates for). (from r100986)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111558 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:13 +00:00
Sam Minnee
5f0fcc58ec
BUGFIX HTMLEditorField->saveInto() can now find images with urlencoded information for resample (e.g. spaces in filenames) (from r100985)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:00 +00:00
Sam Minnee
2e66aff365
BUGFIX: Fixed file-write testing issues in requirements combined file generation (from r100982)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:28:48 +00:00
Sam Minnee
32038ab3ce
BUGFIX: Remove cache for Hierarchy::AllChildren() and Hierarchy::AllChildrenIncludingDeleted(), since they increase memory usage unnecessarily. (from r100980)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:28:32 +00:00
Sam Minnee
dd44a010cf
BUGFIX: Don't make CMS loading slow if the combined javascript files can't be written. (from r100979)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:28:02 +00:00
Sam Minnee
387d34f625
MINOR Removed whitespace from "Development servers" textarea for installer (from r100978)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:44 +00:00
Sam Minnee
30037f269c
MINOR Updated r100966 to include spaces on ternary operator for readability and coding conventions (from r100975)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:34 +00:00
Sam Minnee
059866556a
MINOR Renamed SiteTree->getEditFormFields() to getCMSFields() (including new decorator hook for 'updateCMSFields'). Renamed SiteTree->getEditFormActions() to getCMSActions() (including new decorator hook for 'updateCMSActions'). Old API was never released (from r100967)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:23 +00:00
Sam Minnee
67db4ce22a
FEATURE: MoneyField currency dropdown can be made from an associate array like array('NZD'=>'New Zealand Dollor', 'USD'=>"United States Dollor') as well (from r100966)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:09 +00:00
Sam Minnee
11b1367c8c
MINOR Fixed "disabled" styling for database options in config-form.html (showed all as green when "use _ss_environment" was ticked (from r100965)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:26:54 +00:00
Sam Minnee
29623a639d
MINOR: Correction on email address validator, and a unit test for EmailField php validation (from r100950)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:26:12 +00:00
Sam Minnee
ae66792c33
MINOR Added jQuery requirement to TreeDropdownField (see #5139 ) (from r100946)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:25:17 +00:00
Sam Minnee
7285bbe140
ENHANCEMENT Added help text for "locale" setting in installer
...
MINOR Changed <div> hierarchy in config-form.html to allow right-aligned help texts which horizontically align with their respective field sets on the left. (from r100940)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:24:33 +00:00
Sam Minnee
94d98b18ac
ENHANCEMENT Redirecting to translated page when original is requested with a 'locale' GET parameter (e.g. 'about-us/?locale=de_DE' will redirect to 'ueber-uns' with a 301 HTTP response). Implemented in ContentController->handleRequest(). (see #5001 ) (from r100937)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:24:01 +00:00
Sam Minnee
37bc333882
BUGFIX SiteTree::getSiteConfig() should always fall back to using a default if an alternate config wasn't found (from r100932)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:59 +00:00
Sam Minnee
e41c7eeede
BUGFIX Allow DatabaseAdmin to run dev/build in live mode when not Security::is_database_ready(), and avoid broken login due to broken db queries (selecting unknown columns before dev/build) (see #4957 ) (from r100924)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111543 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:45 +00:00
Sam Minnee
ee81852097
MINOR Fixed phpDoc argument in ViewableData::hasValue() (from r100922)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:32 +00:00
Sam Minnee
2e49064341
BUGFIX DataObject::hasValue() is now compatible with parent ViewableData::hasValue() (this also fixes E_STRICT standards in PHP) (from r100921)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111541 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:06 +00:00
Sam Minnee
ddce6c2210
BUGFIX RequestHandler::handleRequest is now compatible with Controller::handleRequest in that SS_HTTPRequest is the type hint for the $request parameter (from r100919)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:20:49 +00:00
Sam Minnee
614a8091f3
ENHANCEMENT Added DatabaseAdapterRegistry::unregister() to remove a database from the registry (from r100908)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:17:01 +00:00
Sam Minnee
aa7d2449d9
BUGFIX Produce XHTML compliant URLs in HTTP::setGetVar() by default (regression from r98373, see #5101 ) (from r100904)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:16:47 +00:00
Sam Minnee
726adb6205
ENHANCEMENT Added _register_database.php to sapphire which sets the SS provided databases for DatabaseAdapterRegistry (from r100902)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:16:29 +00:00
Sam Minnee
1c6e0c3102
MINOR Changed the way DatabaseAdapterRegistry accepts databases (from r100898)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111536 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:16:16 +00:00
Sam Minnee
a9ab6321bc
BUGFIX #5138 : DataObjectSet::removeDuplicates() removes objects of different classes with the same ID (from r100896)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111535 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:15:33 +00:00
Sam Minnee
e55102ef29
MINOR Using jquery.live instead of livequery on ImageFormAction.js (from r100886)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111534 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:14:55 +00:00
Julian Seidenberg
6c541940e4
MINOR: updated comments on new methods that duplicate relations to be compatible with PHPDoc
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-17 02:27:44 +00:00
Julian Seidenberg
c32a6e34a0
BUGFIX: fix to #110845 to allow parsing of the DataObject file in PHP 5.2 and below.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-16 05:53:16 +00:00
Julian Seidenberg
ed666b71b7
ENHANCEMENT: DataObject and SiteTree duplicate now duplicate relations (except for has_many relations, as the object at the other end of such a relation has an existing relation to the original object and that should not be modified by the duplication)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-16 03:40:34 +00:00